summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-03-11PPTX import: save SmartArt markup into InteropGrabBagGrzegorz Araminowicz
it will allow to preserve SmartArt when saving PPTX files Change-Id: I9bb66c59d202b4ce426864599014d042d4aa04b0 Reviewed-on: https://gerrit.libreoffice.org/68916 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-11weld SvxMenuConfigPage/SvxToolbarConfigPageCaolán McNamara
Change-Id: I166ac6c0be8461ea38db711796d1e14fc5b78998 Reviewed-on: https://gerrit.libreoffice.org/68889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11loplugin:constantparamNoel Grandin
Change-Id: Ibe167c208844b4cdd10df80ae804b1e5bfa6aa13 Reviewed-on: https://gerrit.libreoffice.org/68998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unusedfieldsNoel Grandin
Change-Id: Ifb2c9a2d1d7dcc0ed3e8458c1a13933ccababd4c Reviewed-on: https://gerrit.libreoffice.org/68939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I1fcde14b66ce80157cbebe7f3ec8c5ced1e13143 Reviewed-on: https://gerrit.libreoffice.org/68937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-08set empty text for GtkMenuButtons which will later have textCaolán McNamara
Change-Id: Ib08cca8faf2822e5a62f745c4213cf0ca2cc09d7 Reviewed-on: https://gerrit.libreoffice.org/68923 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-08sd: replace long lists of components with services.rdbMichael Stahl
CppunitTest_sd_import_tests actually fails with services.rdb and CppunitTest_sd_misc_tests crashes :( Change-Id: If11b658b139d85a2563768a11dd6979b721f3a92 Reviewed-on: https://gerrit.libreoffice.org/68918 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07tdf#42949 Fix IWYU warnings in include/basic/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9dd7984affc4343f148c66077feaac19176adf51 Reviewed-on: https://gerrit.libreoffice.org/68769 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07tdf#42949 Fix IWYU warnings in sd/source/ui/[a-c]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I75bb860272e23ebc04912295b0ce4f2c8fe540b7 Reviewed-on: https://gerrit.libreoffice.org/68604 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07build: support disabling popplerAshod Nakashian
This adds --enable-poppler configure option. Poppler can be enabled/disabled by setting this parameter to yes or no. Change-Id: I42ba2d27de7b5014d28523394310616d20073b71 Reviewed-on: https://gerrit.libreoffice.org/68602 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/68842 Tested-by: Jenkins
2019-03-07log nice exception messages whereever possibleNoel Grandin
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06hookup MenuButton::SetDropDown to GtkMenuButton draw-indicatorCaolán McNamara
Change-Id: I556d61256bed8f607eed5a9c6e0ed3fcfd63af2c Reviewed-on: https://gerrit.libreoffice.org/68802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-06sync sdraw and simpress ui files with swriter ui filesandreas kainz
Change-Id: I321233437b573d254ca63aaf7274b54334ec066a Reviewed-on: https://gerrit.libreoffice.org/68786 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06loplugin:unnecessaryparen improve member expressionNoel Grandin
Change-Id: I304621018cb1e2a47e478e86df4229bcf2176741 Reviewed-on: https://gerrit.libreoffice.org/68757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05Use indexed getToken()Matteo Casalin
Change-Id: I76b565d24a27eda62383df757f97d197c3b276a8 Reviewed-on: https://gerrit.libreoffice.org/67646 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-05Add missing DoCloseAurimas Fišeras
Change-Id: Ia051ba960102e53a4dc6cb6b3444ea923a351c3d Signed-off-by: Aurimas Fišeras <aurimas@members.fsf.org> Reviewed-on: https://gerrit.libreoffice.org/68619 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05Remove redundant assignmentMike Kaganski
Change-Id: Ie1ccac4748ae949367448d2977590c0483926a71 Reviewed-on: https://gerrit.libreoffice.org/68728 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-05Check svg URLs before exportingSamuel Mehrbrodt
Change-Id: I3b86b6b82318b0d201c3d7db516664520eb47bed Reviewed-on: https://gerrit.libreoffice.org/68668 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-04tdf#120774: remove 7-year-old workaround of now non-existent bugKatarina Behrens
Fix of tdf#41996 is a workaround of kde4-specific condition and has been since disabled on OS X (as tdf#51023). kde5 comes with a new implementation of DnD and slide sorter in Impress now exhibits exactly the same symptoms as on OS X in tdf#51023 Since kde4 is unsupported and remaining platforms (gtk[23], Win) never had issues with DnD in slide sorter, kill the workaround with fire (= disable it globally) Change-Id: Ib9482dd5371ce73cdb86c3e5bbc5e46af65b9905 Reviewed-on: https://gerrit.libreoffice.org/68674 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-04tdf#44223: Export the audio of effects and transitions.Mark Hung
This will allow to round trip the test case for the slide transition and the animation effect audio. Change-Id: Iac524e6bbcdb0a29491cfeba63121c845685fd11 Reviewed-on: https://gerrit.libreoffice.org/68540 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-03-04Avoid storing potentially negative and unused value in sal_uInt16 varStephan Bergmann
At least during CppunitTest_sd_misc_tests, when bReplace is true the value initially calculated for nSdPageEnd (and later overwritten) was -1, so caused a warning with Clang's implicit-signed-integer-truncation. Change-Id: I69be2649e431590fc79808908470c9c2e3cf3c74 Reviewed-on: https://gerrit.libreoffice.org/68663 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-04Fix typo: KATAGANA -> KATAKANATakeshi Abe
No functional change offered, but this reduces some amount of confusion. Japanese word "Katakana" ("kata" + "kana") does not undergo Rendaku [1] while "Hiragana" ("hira" + "kana") does. [1] https://en.wikipedia.org/wiki/Rendaku Change-Id: I07824147d72397c312a0774eca1fdcc7549abc59 Reviewed-on: https://gerrit.libreoffice.org/68661 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-04simplify UNO getTypes methodsNoel Grandin
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-01tdf#123763 move back break command to graphic context menu for vectorgraphicsandreas kainz
Change-Id: I8af6a0197dc83117d936a7fcf8b794e6d853256a Reviewed-on: https://gerrit.libreoffice.org/68518 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-28Fix typoAndrea Gelmini
Change-Id: I1474d167cb9cb388f36f9d960f2f27f4d55415d2 Reviewed-on: https://gerrit.libreoffice.org/68514 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-28use the xmlTextWriterPtr typedef consistentlyNoel Grandin
this is the single biggest chunk of stuff my upcoming paramtypedef loplugin will warn about, so do it separately Change-Id: I412e69e76406d6d947101885d4cd92c65e021508 Reviewed-on: https://gerrit.libreoffice.org/68486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-28oox smartart, picture strip: fix too wide child shapesMiklos Vajna
Once the constraints determine the size, the aspect ratio may shrink one dimension to achieve the requested ratio. Implement the case where a >1 ratio shrinks the width, so the container of the image-text shape pair has correct aspect ratio. Change-Id: I7bac764c031e80bac532c4f97ebd5b5096401096 Reviewed-on: https://gerrit.libreoffice.org/68510 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-28remove some unused definesNoel Grandin
Change-Id: I5304e85cd3fd2edc48147f1297caa57417a3d038 Reviewed-on: https://gerrit.libreoffice.org/68496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-28Fix typoAndrea Gelmini
Change-Id: I8dc9d97b384a2686f7513499e3ee5819a1b05fe8 Reviewed-on: https://gerrit.libreoffice.org/68482 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-02-27oox smartart, picture strip: fix lack of margin in text shapesMiklos Vajna
Shape text has two kind of spacing inside the shape's bounding box: the shape-level margin and the paragraph-level one. Only the second was handled in the tx algorithm so far, add support for the first. The margins taken from constraints were way large by default: the only explanation I found for that is that SmartArt layout sometimes calculates in MMs, sometimes in Points, and the ratio between the two is exactly the Impress / PowerPoint margin. So assume that indeed that unit difference is the reason for the smaller in-PowerPoint margin values and do the same on our side. Change-Id: I6f1e54301e2e9b33a7e721be34244d968cccf42d Reviewed-on: https://gerrit.libreoffice.org/68453 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-27tdf#123557 PPTX: Export timenode condition targets.Mark Hung
Refactor the code and reuse WriteAnimationTarget to export the target element for the condition element in stCondLst and endCondLst. Add testTdf123557 to make sure import-export-import works. As SdOOXMLExportTest2::testTdf90627 no longer produce corupt pptx that has endCondLst without Cond element, make the xpath more specific about what is testing. Update schema because drawooo:enhanced-path incluced in the test case. Change-Id: If5d64f5c23aa2652cfa72471f9f7886c7dd956eb Reviewed-on: https://gerrit.libreoffice.org/68211 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-27loplugin:unnecessaryoverride look for more patternsNoel Grandin
like bool Foo::bar() { b = Super::bar(); return b; } Change-Id: I5e4c8005a3da7d7487c9039c35dcbb1d17e65bd7 Reviewed-on: https://gerrit.libreoffice.org/68418 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27m_bShowAllShapes in SdPageObjsTLV is deadNoel Grandin
since commit c4a91f1409fc21d92f207718f29377c2862e381f Date: Mon Feb 11 17:32:44 2019 +0000 weld SdInsertPagesObjsDlg Change-Id: I9644c492d02e930592fd568c15f2f87d12f4f038 Reviewed-on: https://gerrit.libreoffice.org/68386 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-26oox smartart, picture strip: fix lack of spacing around the picture listMiklos Vajna
The snake algorithm in PowerPoint seem to interpret spacing as follows: if you have N elements, then there should be the requested amount of spacing between the elements, and also double amount of spacing around the actual list of elements. With this, the SmartArt and the title shape in the bugdoc no longer overlaps. Change-Id: I5d6885b434bfaff9de9aac595a298a5346524e19 Reviewed-on: https://gerrit.libreoffice.org/68397 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-26these are modal dialogsCaolán McNamara
Change-Id: I28fe2ba99c4a17cab781d95ef9da8b2774667baa Reviewed-on: https://gerrit.libreoffice.org/68383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-26oox smartart, picture strip: fix too many columns with aspect ratio requestMiklos Vajna
The bugdoc has 3 items in the picture strip and PowerPoint laid this out as a single column with 3 rows (as a snake algorithm). We used to put the first two items to the first row and the third item to the second row. Improve out layout by taking into account what aspect ratio the child algorithms request: this way it's obvious that we should use a single column in case we have a large enough aspect ratio and few enough items. (PowerPoint also uses multiple columns without the aspect ratio request.) Change-Id: I9f1158c04c665fc6a2c85e4ac3a1ed363b1c75fb Reviewed-on: https://gerrit.libreoffice.org/68370 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-26tdf#88969 restart interactive sequence.Mark Hung
This patch allows the whole interactive sequence to restart automatically when it's done. User don't need to insert multiple pause toggle command to a media object just for toggling the media multiple times. Change-Id: I000a55f580917327ae438ea8e79e62f63275cce7 Reviewed-on: https://gerrit.libreoffice.org/68283 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-25Fix build when !HAVE_FEATURE_AVMEDIATor Lillqvist
Change-Id: I17fa4d503d197b9b7c7405281001ea92714494a9
2019-02-25Build the sdui library for non-DESKTOP, tooTor Lillqvist
In order to get the Impress-specific dialogs in the (new, Online-based) iOS and Android apps, too. Change-Id: I7400326bafc1b8a0470b5ed0fb631ae984b7b795
2019-02-25Make SdAbstractDialogFactory::Create() do its job also on non-DESKTOPTor Lillqvist
Change-Id: Ife76336dbdeaadf08f631e3542be73a8568f5368
2019-02-25We want the function pointer here, but not call it yetTor Lillqvist
We will call it just a few lines later. Change-Id: I967ff4eec2cfb1dcc7e8b02f32232be65b6366db
2019-02-25loplugin:unusedmethodsNoel Grandin
Change-Id: I085394e0f4b780dc5b376d5ac0e9d761434e3ead Reviewed-on: https://gerrit.libreoffice.org/68301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-25set m_bLinkableSelected before calling handlerCaolán McNamara
Change-Id: I82bbd43e135490f97e2b7c78e48a01d573b0702a Reviewed-on: https://gerrit.libreoffice.org/68295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-25sd: fix preset class for media call effects.Mark Hung
Change-Id: I2a2a72a3a19beb9911fa694e983945480029ae0d Reviewed-on: https://gerrit.libreoffice.org/68276 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-24Temp icons for the redactedexport commandsMuhammet Kara
Just put some links for now for the icons, and replace the two buttons on the redaction toolbar with the new redactedexporttoolbox Change-Id: Ic1df62d56c965869135ceca97bbeb87efd3aaa0d Reviewed-on: https://gerrit.libreoffice.org/68281 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-11 13:50:37 +0000