summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2020-09-09improve loplugin:unusedvarsglobalNoel Grandin
to find any global variable, was checking the wrong property of VarDecl Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-07tdf#136474 wait until mouse grab is dropped to trigger selection callbackCaolán McNamara
Change-Id: I495b90b9661c32ad3ec71c2a2455d1576fb8f918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-06sd: add additional asserts for testAnnotationsImportExportTomaž Vajngerl
Change-Id: I45824c4023c56b466560638a1fe5206bddaf74be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102092 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-06store annotation subtype in PDFGraphicAnnotation, enum for subtypeTomaž Vajngerl
Change-Id: Ib804f497a6c8f609e4899f9ebcef4c1096f44ce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102090 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-05LOK: allow slide switching in mobile even if it is same slidePranam Lashkari
problem: In the mobile view taping on the selected slide preview would open the wizard but when some object is selected on the slide wizard would open for that object this patch helps us to set the Page as selection and as result mobile wizard opens for the slide even when some object on slide is selected Change-Id: I99cbece8b18ec8766956157c0231e5a0f600d993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101869 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-09-04tdf#118148 Extended tips for simpress/ and sdraw/Olivier Hallot
Change-Id: I7472b2aaa60d554fd9b2d4c9212917661228d929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102061 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-04TabPage no longer needs to inherit from VclBuilderContainerCaolán McNamara
Change-Id: Iaab26ade1109daf732e58a2f3741cc43243e374c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102023 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-03blind fix for tdf129346 test intermittent failureCaolán McNamara
Change-Id: Ib3bc0ce0bdeee01c3c752d935e195f677b6f6d4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02move Edit into toolkit only headersCaolán McNamara
Change-Id: If51bf7143116721e8f16272cf8aff797651d5ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02SetCallHandlersOnInputDisabled unneeded if AlwaysDisableInput not usedCaolán McNamara
and don't need to use that if we use FixedText instead of Edit Change-Id: I162bf829a62a2c7cf8a975c99509607095712e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101851 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02annotation label doesn't need to be an Edit, FixedText is enoughCaolán McNamara
similar to: commit a2d97135411d566b0b1f3d47af7912c8412cee7f Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Aug 18 10:23:27 2020 +0100 annotation label doesn't need to be a MultiLine edit, FixedText is enough Change-Id: I5035ecc2d5d03f7aaeb794006a0cb305bb89a219 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101850 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02loplugin:unusedmethodsNoel Grandin
Change-Id: I523a42b721056f17a04870229834b0f2db00ff39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-01Fix typoAndrea Gelmini
Change-Id: I03dc9ad3ad496524efbbb2f1a48f76fb95d1bfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101781 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I4733e6609ee99bef49c2771c83b450ee89d955b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101804 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id5aa544f169a13b52ebd126a71a7e5b8cc9e4ffa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101803 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I89200406a2422173a96caa5fd74b66211cced557 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101784 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typoAndrea Gelmini
Change-Id: If76dc19adc13548afc0ee5b521321ca439da638d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101782 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01notebookbar: keep align items togetherSzymon Kłos
Change-Id: I24fe425b6b578dc80487464c3206c52ecac8aab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100079 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101521 Tested-by: Jenkins
2020-08-31Fix typos in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I9ba795bf188a9fe11d83516d6895888f880747c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101706 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-31add physics based exit animation effect preset Fall and fade outSarper Akdemir
Adding a new animation effect preset in the Exciting sub category of Exit category called Fall and fade out, which makes the shape fall with a bounciness of 0.6 and fade out. Change-Id: Id9fe29f98f276cdb9748f0eb787e03f68314097a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101660 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-31tdf#136276: fix physics animations faulty duplicationSarper Akdemir
Change-Id: Id147eb129e6e0ee65ecd16139e183790b3f9976c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101658 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-31add two physics based emphasis animation effects presetsSarper Akdemir
Adding two physics based emphasis animation effects presets called Shoot right/left and return. Change-Id: I38ea22a4347c83b7065476b9f673a900566b045f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101657 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-31sd signature line: move menu item to the insert menuMiklos Vajna
Improves consistency with Writer and Calc. Change-Id: I290cbbef508dd3f3390efe6c9a933b488b9c1049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101695 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-29sd: add some comments for findReplace.py UI TestTomaž Vajngerl
Change-Id: I0c424cd254592bd04125ce8ec58ea38ddfc7659f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101636 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-29sd: test Replace and ReplaceAll using LOKitTomaž Vajngerl
Change-Id: I68a612d3fb277970870818d290096b2824f31057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101635 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-29sd: Make search bound to a view - to allow independent searchingTomaž Vajngerl
Before if two windows are open, the search is not independent because Outline class is not independent for a view (because of FuSearch which remembers the view from when the it was created and then an instance is stored in the DocShell). This creates a SearchContext class stored on a View, which stores the actual View bound FuSearch instance, fix us the calls. Also move the VectorGraphicSearchContext back into Outline::Impl, because it doesn't need to be bound to the view anymore. Change-Id: I6a5ce71efafa378845eee4ac9574e2e4301138d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101224 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-29Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I255b7a0873170d956c914d76fd363e358f807d7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101596 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-29Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I173e4887af5cbe3c660412d8463a5a82ee2c5724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101591 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-29Assign aPageRange only once, after the loopStephan Bergmann
c82b891dc9370d4bf72bc07752884603df7d05ac "selecting multiple slides and using 'print...' doesn't set selection as range" had reinstated the lost assignment, but it should suffice to assign the final aBuf value once after the loop. (The guarding if (bool(pPageSelection) && pPageSelection->size() > 1) ensures that the loop body is executed at all (at least twice even), so it can not be the case that the assignment is now done but was not done in the past, if the loop body had not been executed at all.) Change-Id: I54ab430b3f74a7ae3d559b9b47e7c15487e11b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101579 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-08-28Change OUStringLiteral from char[] to char16_t[]Stephan Bergmann
This is a prerequisite for making conversion from OUStringLiteral to OUString more efficient at least for C++20 (by replacing its internals with a constexpr- generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount, conditionally for C++20 for now). For a configure-wise bare-bones build on Linux, size reported by `du -bs instdir` grew by 118792 bytes from 1155636636 to 1155755428. In most places just a u"..." string literal prefix had to be added. In some places char const a[] = "..."; variables have been changed to char16_t, and a few places required even further changes to code (which prompted the addition of include/o3tl/string_view.hxx helper function o3tl::equalsIgnoreAsciiCase and the additional OUString::createFromAscii overload). For all uses of macros expanding to string literals, the relevant uses have been rewritten as u"" MACRO instead of changing the macro definitions. It should be possible to change at least some of those macro definitions (and drop the u"" from their call sites) in follow-up commits. Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-27remove some unused includes and update pchesCaolán McNamara
Change-Id: I786548bef39fa711aabcff32b592b3fdc4a6f9fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26[API CHANGE] Drop OSL_THIS_FUNC, directly use C++11 __func__Stephan Bergmann
It had been documented as "the macro OSL_THIS_FUNC is intended to be an office internal macro for now", so take the liberty of removing it, even if technically that can be considered an incompatible API change. Change-Id: I7580a932e1da54845934378a650e894f3f3a9062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101406 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-24tdf#136067 left align GtkMenuButtons contentsCaolán McNamara
most already are, align the rest too and have for gtk "fill" the label widget Change-Id: I6f75c5c6ebaad0d2e3301854882aeaf3eab8580b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24restore translatable="no"Caolán McNamara
Change-Id: I42b46c0cada25703e8e9600533a220252796457e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#118148 Extended tips from HC2/shared/Olivier Hallot
These extended tips are extracted from <ahelp> in Help files Only for ui files, where dialogs/widget pair could be determined. Other forms of <ahelp hid=".."> such as .uno:.. and *HID* ... will be addressed elswhere. Change#1 Removed extended tips from GtkMenu of svx/.../acceptrejectchangesdialog.ui Change#2 Some empty ET's slipped in cui/macroselectdialog.ui Change-Id: Ic8dc62734143f621fcd3c4156fc004f585630277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#134174 Fix the rotation of bitmap filled custom shapes.Gülşah Köse
During import we were rotating only custom shape. Not its bitmap. Custom shape and its bitmap rotated with same rotation value in that commit. Change-Id: I02d19c820670df7b4d1622836156c6bf8ed1c154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101255 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-23Fix typo in codeAndrea Gelmini
Change-Id: I00f81e25cd1f5a6ba71c8137486069368846f9f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101213 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-23Fix typo in codeAndrea Gelmini
Change-Id: I762b2cfa3aafed4f68743c58c0b3eff556efe846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101214 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21tdf#118148 All extended tips for shared/optionenOlivier Hallot
Extended tips extracted from <ahelp> in all remaining shared/optionen help pages Change-Id: Id35ce9d51ebf0f7fbe1b399ccabbf85a2c145f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99825 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-08-21rhbz#1870501 crash on reexport of odgCaolán McNamara
where SdrObjects in a list have no navigation position set a regression from 450cd772aa734cfcb989c8cedd3c0a454db74a34 Fix fdo#64512 Handle xml:id correctly on multi-image draw:frames this just reverts that and adds the test case that crashed Change-Id: I1a49dab9578699c42fe845e8ec42de40159dec3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-20make physics based animation effects importable-exportableSarper Akdemir
Makes physics based animation effects importable and exportable on content.xml. Uses one new xml token animatePhysics. Also adds a new animation preset called Physics Basic that is available under Emphasis animation effect category. Change-Id: I38b0511f973668655cff78becebe3f1e628d9083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100247 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-19Fix typosAndrea Gelmini
Change-Id: Ibe3cd52117f7f47e1806bde76114cb1644d78763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100969 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-19vcl, sd: various small cleanupsMiklos Vajna
Change-Id: Ic7ad2e044cc1807b105bcad2daf978224b96f298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100956 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-18loplugin:unusedvarsglobalNoel Grandin
tackle some read-only vars. Mark some of them const to make it obvious they are not really used, and to make the constantparam plugin see more data. Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18new loplugin:unusedvarsglobalNoel Grandin
I copied and modified the unusedfields plugin to find unused variables. Change-Id: I18ed6daa202da70a2e564e4fe4760aed7ce070ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18annotation label doesn't need to be a MultiLine edit, FixedText is enoughCaolán McNamara
Change-Id: Ib5db02be9d29f0ba21bf4295be8cf81be2cb409b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100905 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17move vector graphic search to View, so it works in multiple viewsTomaž Vajngerl
VectorGraphicSearch was instantiated for the Outline, which is the same for every view. The problem with this is that when we have multiple views, the search would interfere with each other, which is especially distracting in online when multiple users connect to the same document and try searching. This adds VectorGraphicSearchContext class, that is added to the View, which makes the search view dependent and multiple instances of VectorGraphicSearch are created, each one for its own view. Change-Id: Ia0f34647b30b35f4ddb84d33353990d635756905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100837 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17Remove redundant Invalidate()Michael Meeks
Probable merge error in CWS impressfunctions dc5479dcc39. Change-Id: Ifa8dc9dbeeecf2dd6da44909060b72a20a7042a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100783 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-08-17inline some use-once typedefsNoel Grandin
Change-Id: I683175c1e788a2a4cfec9504dc8dc3ebfee7c5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-15remove constructor with plain Bitmap from Graphic, use BitmapExTomaž Vajngerl
Change-Id: Ie429a10a8f54c6779d437ee4bc75a5ea0c427848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100727 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-27 14:10:04 +0000