summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-08-24fdo#73151 Make better use of the sidebarSamuel Mehrbrodt
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery) Changes: * Show the sidebar by default in Writer & Impress * Remove the Gallery floating window (Gallery now always opens in the sidebar) * Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer (since they have an icon in the sidebar and the sidebar is shown by default now) * When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151 Change-Id: I3a0461d1472711da7121801000af294b432fccb1 Reviewed-on: https://gerrit.libreoffice.org/11077 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-21These "newly added" record types are publicly documented nowadaysTor Lillqvist
Use symbolic names from the MS-PPT RecordType documentation, http://msdn.microsoft.com/en-us/library/dd945336(v=office.12).aspx Change-Id: I1deecfc69dd3360ef982f144d5ff5348a2953280
2014-08-19Resolves: fdo#82355 crash on loading pptCaolán McNamara
regression probably triggered by... commit 2e3c45afc6c5ea74f1f8b4a7dce806e537870546 Date: Fri Mar 4 07:38:16 2011 -0800 Remove usage of deprecated List container. but that just stopped at the first NULL by chance Change-Id: I767e3bc3130d99cedceb4172857d1741c677b19b
2014-08-19Make Draw use paper size when printing - fdo#63905Eilidh McAdam
Previously, Draw/Impress use the default size from the printer. Now Draw uses the paper size (specified in page formatting). Impress still uses the old method - not sure if this is correct but printing handouts etc probably complicate print/paper size. Change-Id: If90bae4ac59cd95dd50fcd8deb25fd900756193e Reviewed-on: https://gerrit.libreoffice.org/9866 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-08-19Fix Insert 3D Model file dialog's "All supported formats" filterZolnai Tamás
It seems on some system the file dialog does not like spaces between the formats. Change-Id: Ifa69f4f210061209f7f0aa9223417d06b06b577a
2014-08-19error C2296: '<<' : illegal, left operand has type 'const char [28]'Miklos Vajna
Change-Id: Ibc25771002bd8ac9b4a2aca9f3c2965b8da9014e
2014-08-18Consistency around XColorItem in svx/sdshcitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I7ecf827a0713efaecb4b0eb49f9f8c06f8c59091
2014-08-18Partial revert of d4cf8c2518c77631f91db8564bf3a506f0ab8e70Stephan Bergmann
"Generally better to have DLLPUBLIC class with some DLLPRIVATE members." MSVC over-eagerly also treats the SdStyleSheetPoolBase template specialization as dllexport and fails to generate code for the ImplInheritanceHelper4() ctor because the SfxStyleSheetPool base class has no default ctor. Change-Id: I656c898ebd3d4ca58785084c5aeed4fa670cb7e0
2014-08-18Consistency around SdrOnOffItem in svx/sdtcfitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18Generally better to have DLLPUBLIC class with some DLLPRIVATE membersStephan Bergmann
...in the same vein as 80a1a2599e04142683d2286d0e32d0e13fb45de3. Change-Id: I330665957aec2c9b98c7aff7fa7f25525e4cdf7d
2014-08-18ErrorBox->MessageDialogCaolán McNamara
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18Consistency around SdrMetricItem in svx/sdsxyitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3734cb14b6ed8f556af85b234968682a55ac8a4c
2014-08-18SD_TOOLBOX is never defined outside toolbox2_tmpl.srcThomas Arnhold
Change-Id: Ie6d05762baae87794e9320a6b123ef326289e4c1
2014-08-18STRING -> StringThomas Arnhold
Change-Id: I084d99fdd1a34842178b59c17ab108750f7bd11d
2014-08-17check TRG_HasMasterPage before TRG_GetMasterPageCaolán McNamara
bff + valgrind Change-Id: Ie08ddfe06dc0850cf44955cc9f9079b3856b19e3
2014-08-17remove executable bitsThomas Arnhold
Change-Id: Iec785ae538de81325812b1e6fe33115789b39770
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on. Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as return value in case of failure and in the related tests. Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-13warning C4189 local variable initialized but not referencedMichael Stahl
Change-Id: I6047e0fc10bb6de0009da40855a97df89904cb0c
2014-08-13warning C4245 signed/unsigned mismatchMichael Stahl
Turns out that mnVisiblePageCount is actually never read. Change-Id: I6bded733bb551525a6143976ad4c4447a5a56773
2014-08-13update_pchThomas Arnhold
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13Ignore exception when service ScannerManager is unavailableTomaž Vajngerl
Exception from an unavailable service ScannerManager propagated to the top. This caused that presentations in android crashed (DrawViewShell wasn't initialized). Change-Id: I485d0cdad05e4d2d6096042e5762c0350a8339a9
2014-08-13reduce code duplicationTomaž Vajngerl
Change-Id: Ie5910239d7a54a29262e556af779bda9fa2dddca
2014-08-12fdo#75757: remove inheritance to std::vectorTakeshi Abe
Change-Id: I5781799bbd8cc321ff7f659013c6cf68b3253989 Reviewed-on: https://gerrit.libreoffice.org/10868 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-11fdo#81933 do not select 1st slide unconditionallyDavid Tardon
This is a regression from commit ad0c4bf5790546242884da0c2ec281f2db9e14a0 . But I do not see why this code would be needed for that either. Change-Id: Ied3a5d25b2bec9542aa83c4d7fa36ed5313fc797
2014-08-10LOKit: ensure DrawViewShell is available (prevent crash)Tomaž Vajngerl
Change-Id: Id143f5fabdcb8b7451d750563c76b77f9c3787a3
2014-08-08Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann
Change-Id: Ib769dbbcb78e9440805aee40019ab98cd52e8477
2014-08-08Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann
Change-Id: I610172167c49afa3989aa1626b10b8aaa1f91578
2014-08-08Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann
Change-Id: Icb959b7e2e8558f251d4bfd3b21124ca31132183
2014-08-07cppcheck: va_list 'args' was opened but not closed by va_end()Julien Nabet
Change-Id: Id7602dd19ac142dbe2680ddf7eab308a087e971a
2014-08-07Handle collada libraries seperately: --disable-colladaZolnai Tamás
Depends on gltf support. Change-Id: Ief0452da3d03b0ddbca45272e5f5cd268691aeca
2014-08-07Consistency around SdrYesNoItem in svx/sxmsuitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I25002e5b6043baa8c93b180a03f475bea5906e4f
2014-08-06Consistency around SdrMetricItem in svx/sxelditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." (SdrEdgeLine1DeltaItem::Clone had been recently---and in retrospect needlessly ---introduced in 596ec6f52fe3a8d56d5c20df568633cfbcadc74d "Missing SdrEdgeLine1DeltaItem::Clone override" before 3efa3ad7b6de78c291f49858e50e6bedbd6a2173 "SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlying" revealed that SdrEdgeLine1DeltaItem was a needless derivation of SdrMetricItem.) Change-Id: I154d32d46a7c01c792aa4e812cf576d4d749e0c9
2014-08-06Consistency around SdrOnOffItem in svx/sdasitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Icdeff7f37901f99158bb00de5e912c181bf3e688
2014-08-05Let GetObjectItemPool return a referenceStephan Bergmann
Change-Id: Ibbcfa3452afcf88dbb6050765e081a1be2381334
2014-08-05fdo#81552 Fail nicely if avahi doesn't let libreoffice publish itemsBryan Quigley
Change-Id: Ie264a032a71bda336158e18bd2b14c569f23f42d Reviewed-on: https://gerrit.libreoffice.org/10735 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-05fdo#79917: Add 'Save a Copy' to Calc/Impress/Draw.Heiko Scheidt
Was added to writer in LO 4.1 but menu entries for other modules were overlooked. Change-Id: I90bcaa727eaa8fd8b35218f73c101f25c7a71d7b Reviewed-on: https://gerrit.libreoffice.org/10707 Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com> Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com>
2014-08-05Clear() an SdPage while it is still an SdPageStephan Bergmann
... because when Clear() is later called in the SdrObjList sub-object dtor, freed SdrObject dtors may call back via SdrObject::SendUserCall into this virtual SdPage::Changed, but then this is only an SdrObjList, causing undef behavior. Change-Id: I09a2d1445a51a70e8f795ff869027899ad0f528b
2014-08-05GetPage requires mpPage to be an SdPageStephan Bergmann
...which is apparently not always the case; at least observed that during CppunitTest_sd_html_export_tests. Change-Id: If3d73249845adfa6b489e783693768e755033f4a
2014-08-05Avoid undef out-of-range value -1 for XPropertyListType enumStephan Bergmann
Change-Id: If2dedafe6d8517eba4dd4921d15dd2d969d181dd
2014-08-05Consistency around SdrOnOffItem in svx/sdshitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-08-04Consistency around SdrOnOffItem in svx/sdtagitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04prevent memory leakMarkus Mohrhard
Found by Lsan. Returning this or a heap allocated object asks for trouble. Let the caller handle it and return null instead of this. Change-Id: I7586e103bef5a8c2727adfe214b052d6962d4467 Reviewed-on: https://gerrit.libreoffice.org/10716 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-04Consistency around SdrMetricItem in svx/sdtditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-03put ReadThroughComponent to anon. namespace to avoid redefinitionTomaž Vajngerl
Change-Id: Idcc97e067b0f389a5d9e01013ab2fc20d2dd4ccd
2014-08-02fix deps for sd_import_testsDavid Tardon
Change-Id: Ica864f8fc654df3dfeb83850ede43473904de261
2014-08-01bnc#862514: Handle corner case in slide sorter correctly.Jan Holesovsky
We should never return -1 when bIncludeBordersAndGaps is true; but that could have happened in a corner case: * export SAL_USE_VCLPLUGIN=gen * start LibreOffice * open a presentation with many slides * resize the window so that it shows the slides _exactly_, no slide is cut off in the slide sorter * point the mouse pointer into the left "Slides" sidebar (slide sorter) so that it does not cause any mouse-over effect (somehow between the left border, and the slides - there is space that can do this) * turn the mouse wheel all the way down so that the last slide is at the bottom * turn the mouse wheel up _once_ * turn the mouse wheel down _once_ - it will look like the view does not change (the last but one is still at the bottom), but you can see the scrollbar jump to the top * and now you can again start turning the wheel all the way down to repeat the procedure :-) Change-Id: I0253c89513222a1f2eb3263068997d10eea0f130
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922