summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2015-10-15sd search: restore start selection if nothing was foundMiklos Vajna
For one, if sd::Outliner::RememberStartPosition() cares about storing the current selection in the DrawViewShell case in maStartSelection, then sd::Outliner::RestoreStartPosition() should probably restore it. For another, sd::Outliner::StartSearchAndReplace() returned true in the "nothing was found" case, which restarted the spellchecking, which killed the selection. If the selection has been restored already, then at least don't kill it in the find case: find is read-only, so no need to restart the spellchecker. Change-Id: Idd886d449a9cfb164887fc6b1fde27b5e63e272b
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15convert Link<> to typedNoel Grandin
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-14coverity#736798 Dereference before null checkCaolán McNamara
Change-Id: I44402f7c644d60e2166956ca5f98955cc73e5bab
2015-10-14coverity#736803 Dereference before null checkCaolán McNamara
Change-Id: I0bdd28c1f43da999ae2bd35d45c1958061f90c07
2015-10-14coverity#736804 Dereference before null checkCaolán McNamara
Change-Id: If4b656ccea684fda64a3f93f5b6729c713be48b0
2015-10-14LOK: include part numbers in CALLBACK_SEARCH_RESULT_SELECTION payloadMiklos Vajna
Without that, the result in Calc/Impress is ambiguous. Change-Id: I8dfd8dafc996102ed583688fddd721c7600dc48c
2015-10-14sd tiled rendering: search rectangle is part-specificMiklos Vajna
Change-Id: I88865db539779bc401550d7b4a3729b89d7e18b1
2015-10-14tdf#95041 Fix more sidebar node namesSamuel Mehrbrodt
Change-Id: I79e7755ecd6d4e1a331680337742629da52fed0c
2015-10-14tdf#95041 Fix sidebar node namesSamuel Mehrbrodt
Change-Id: I3435de44e04268dc557faedba944c2c33385b89c
2015-10-14coverity#1326209 Dereference after null checkCaolán McNamara
Change-Id: Ie8a10cb0f92758b45aff456f52331092e8a4e1df
2015-10-14sd tiled rendering: initial search allMiklos Vajna
Change-Id: Icee3a07103fad1bf70637fbf23299f50b7ad838d
2015-10-13coverity#735838 Dereference after null checkCaolán McNamara
Change-Id: I5a0a9cfdac0444beb049bf9e883ffced25500950
2015-10-13coverity#1326205 Unchecked dynamic_castCaolán McNamara
Change-Id: I1fe77d041a281b14d6af15f25bd06ac78420c608
2015-10-13coverity#1326204 Unchecked dynamic_castCaolán McNamara
Change-Id: I39c942e2ce35283761e3b8daa1ae41986a170ca8
2015-10-13coverity#1326211 Unchecked dynamic_castCaolán McNamara
Change-Id: I09892b8e17aacf32db51764d8fd766603a8542e1
2015-10-13CppunitTest_sd_tiledrendering: CALLBACK_SEARCH_RESULT_SELECTION testcaseMiklos Vajna
Change-Id: I8a2fcaad5806ef204cdac0f6eaac615d50d6d9e8
2015-10-13sd tiled rendering: implement LOK_CALLBACK_SEARCH_RESULT_SELECTIONMiklos Vajna
Given that sd doesn't support find-all yet, this works for normal find only at the moment (so it may report multiple rectangles, but always a single match). Change-Id: I47bd0d0161b9d1dc843bb503f5521f311fc158c4
2015-10-13tdf#95002 sd tiled rendering: fix handling of images on page switchMiklos Vajna
It turns out a full invalidation is still needed to trigger the loading of graphics on the new page, so instead of not invalidating just don't emit the notification about it during page switch. Change-Id: Ic99a3d4e268b3db61cf09c78ed0f310c9d365867
2015-10-13cppcheck:variableScopeNoel Grandin
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af Reviewed-on: https://gerrit.libreoffice.org/19329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12sd tiled rendering: make invalidation in DrawViewShell::SwitchPage() optionalMiklos Vajna
In case of tiled rendering clients already get LOK_CALLBACK_SET_PART when switching slides, so it's pointless to additionally invalidate windows for help lines. Change-Id: Ibc15c9862ae85bd72328161fa5f7e72d82fd2a97
2015-10-12convert Link<> to typedNoel Grandin
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12sd: avoid unnecessary invalidations during searchMiklos Vajna
Search works by using sd::outliner::OutlinerContainer to iterate over all text objects of the document. We used to switch to each and every object, and only then search in it. In large presentations this means the number of invalidations during search was dependent on the number of slides between the current slide and the first match. Fix this by not calling sd::Outliner::SetObject() (which would call sd::Outliner::SetPage()) right after finding a text object, only later when we know it has matching content. The result is that the number of invalidations is not O(n) but O(1) till we find the first match. Change-Id: I29a11c8737a7e1db6a247eb98617d12495c8bb41
2015-10-12Related: tdf#74132 CppunitTest_sd_export_tests: clean up testSearch()Miklos Vajna
Not needed anymore since the dialog is gone. Change-Id: Icd3747683d2656a9404b405fc29aae6183dcfe15
2015-10-09xmloff: fix ODF import of gradient draw:angle attribute a bitMichael Stahl
ODF 1.2 part 3, 18.3.1 angle, says "An angle, as defined in §4.1 of [SVG]" and "If no unit identifier is specified, the value is assumed to be in degrees." Unfortunately OOo could only read and write 10th of degree here. See also https://issues.oasis-open.org/browse/OFFICE-3774 As the first step towards fixing that, implement the import for draw:angle values with an angle unit identifier, but leave the import as-is if the angle identifier is missing. Change-Id: Ib88d417c03998ebcfc569b01492f0e1f851bbc85
2015-10-09sd: add SdPage::dumpAsXml()Miklos Vajna
Change-Id: Ifef668530d660b0b6330f1e60ed558501a74611e
2015-10-07loplugin:mergeclassesNoel Grandin
Change-Id: I8f5c2ae658f8784233db98f752b6f9fa53110195
2015-10-07Prefer getSelectedFiles to getFiles (sfx2+sw)Julien Nabet
+ tweak files of other modules which needed it Change-Id: Ibb673eba6609734addd233ac1477698c01b94678 Reviewed-on: https://gerrit.libreoffice.org/19180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-10-06tdf#91097 Fix also for DrawMaxim Monastirsky
Change-Id: Icbb3ff1b3eae9e3116a1c9f989962f4d569e2a30
2015-10-06tdf#91097 Substitute rectangle and ellipse uno commandsYousuf Philips
Change-Id: Ib6578ddd7897d9c5d63b5dc8d8465f6107cc24a6 Reviewed-on: https://gerrit.libreoffice.org/19130 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-10-06Disable spellcheck when LOK is activeMiklos Vajna
It's not useful when viewing, and for editing probably a dedicated overlay would be better (like the one we have for cursor/selections already). Disable for sw/sd explicitly, sc had it disabled implicitly already. Change-Id: I7134f5d1a1546787c22019e6b1abdc0dd887f888
2015-10-06loplugin:unusedmethodsNoel Grandin
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-06presenter console: add 'Restart Timer' buttonMiklos Vajna
Use case is that the presentation is started a few minutes in advance, so the audience can check if they are at the correct room, seeing the title side. Then previously the presentation had to be stopped and started again, so the presenter had an idea how much time the talk took so far. The side effect of this workaround was that the audience saw a short flash while the presentation was not running. Fix this by adding a button to just restart the timer, then it's not needed to stop/start the presentation manually. The two icons are just placeholders for now, real design is still needed. Change-Id: Id67e7e53a339ea5672dfb1c261f63d43466e9eff
2015-10-05LOK: added the button type and key modifier to postMouseEvent()Mihai Varga
To get a better functionality we need to know the button type (left, right, middle). We also need the key modifier (ctrl, alt, shift) for actions such as ctrl+click (to open a link) or shift+click to select Change-Id: Iaccb93b276f8a6870dd41cc5132dbb85d2bbf71b
2015-10-02sd tiled rendering: default to transparent background outside slide areaMiklos Vajna
Change-Id: Ic9023640c34c3d7efd00e2eb0894ed4d01109d8d
2015-10-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I1bbf4ee7c67d40ffc7b289e0d75e4aed224067ec
2015-10-02Fix building sd remotecontroll codeStephan Bergmann
...after d68a0fc050ea4d57e15246f8e71781cd42ebdaa1 "loplugin:unusedmethods" Change-Id: If167025b7892738cbbbefd5fe4966a5e6aee57f3
2015-10-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Ia06d96d373888ce45508814c9752d09117e55d10
2015-10-02loplugin:unusedmethodsNoel Grandin
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01Impress: set current page Id before showing the new pageMihai Varga
For tiled rendering this has the effect of not invalidating the previous slide when switching slides. After switching slides, an invalidation occurs caused by showing the new slide, and calling 'GetPart' before 'SwitchPage' finishes returned the old part number. Change-Id: I1cafd0e51cd39be3a80d0559ae3051238b8df744 Reviewed-on: https://gerrit.libreoffice.org/17562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-01tdf#92341 Make Autocorrect entry actually workSamuel Mehrbrodt
Change-Id: I83e028428933e2153b639ca6b34fd69db88fb53f
2015-10-01tdf#93587: insert table in draw ole objectJulien Nabet
Don't disable "Insert table" option in case of Ole object Change-Id: Ibe87d35db320f4a9d5c971e3f7b25199fcacbde4 Reviewed-on: https://gerrit.libreoffice.org/18897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-09-30implement save slide background for impressCaolán McNamara
to go along with the existing "set background", same sort of thing as the competitor's effort Change-Id: I2a1106771ead2cd926f3d631850447499340697c
2015-09-30Fix typosAndrea Gelmini
Change-Id: Ib96bf8adc3f94fa0b8b306d2a609dd2eea940dd1 Reviewed-on: https://gerrit.libreoffice.org/18974 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30Fix typosAndrea Gelmini
Change-Id: Ic205d774251cd5657cc5ba66ab548935aeaf1eb5 Reviewed-on: https://gerrit.libreoffice.org/18973 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30Fix typosAndrea Gelmini
Change-Id: I3ea8a90f0ec917b4e26335fcd31a5f7e0888589e Reviewed-on: https://gerrit.libreoffice.org/18972 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-19 17:42:19 +0000