summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-06-03cid#1485165 avoid Missing move assignment operatorCaolán McNamara
Change-Id: I9113e589f74a119fc24e174e7e35036beb0d7acd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116643 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-01cid#1485150 Uncaught exceptionCaolán McNamara
remove the reported exception path from the dtor call Change-Id: I438a9c3de41d516e1994aeb1509bb8ee333bf23f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-01no need to allocate these on the heapNoel Grandin
Change-Id: I6eb3853883c724b5cb28bbf4debf6f56a587ff88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-01no need to allocate these on the heapNoel Grandin
Change-Id: Iddbc48638fbd1326df79b59080132280029c5d46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31flatten vectorNoel Grandin
Change-Id: I7459bcc499d6734328b5be63a4bebd2102d52e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116481 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31no need to allocate these on the heapNoel Grandin
Change-Id: I05c00d0a4f077594d91b05698a1c04922f06a1cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31GtkLabel:track-visited-links was removedCaolán McNamara
but we have some uses of it, which all look accidental Change-Id: Iccb12d904e8dc7410205735e49526b73bb81083e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31no need to allocate SvxNumRule separately in SvxNumBulletItemNoel Grandin
Change-Id: I7903565a468fc0fbec603c88b92cca6560a86728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31Simplify construction of a hardcoded IPv4 addressStephan Bergmann
Change-Id: I822313ee708935dd4ecb636c13a961fdd054d660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116434 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-31tdf#142537 PPTX export: fix placeholder style exportAttila Bakos (NISZ)
Regression from: b6b02e0b4c9d739836e1f61a886ea45b01e6696e (tdf#111903 tdf#137152 PPTX export: fix placeholders) Placeholders lost the formatting, which has been fixed. (fill, effects, and outline) Change-Id: I2b9300b85cf3641d89d748a03377f950e668a2af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116113 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-31Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.Gülşah Köse
SvxBackgroundColorItem is just copied from SvxColorItem. There is nothing special to SvxBackgroundColorItem class. SvxColorItem is a generic item and it's used on many places related with colors. We can use SvxColorItem for background colors too. Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2021-05-28no need to allocate SfxStyleFamilies on the heapNoel Grandin
Change-Id: Ibedb36dec14c61927ef594ddf47fda94728530a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-28tdf#125071 PPTX: fix missing custom slide show exportTibor Nagy
Follow-up to commit ecf48b2d4f3e54dbb2c1e295120d73e7b7a11338 "tdf#131390 PPTX: fix custom slide show is not imported". Change-Id: I2a85e2ea08f6a70cd5f26cfb99a0ff1add2c296a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116177 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-28no need to allocate these SfxItemSet on the heapNoel Grandin
use std::optional where the code needs to control the lifetime of the object explicitly Change-Id: Ia550ce051360f68911abc68c945a97d62a637b06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26Refactor module media item handlingJan-Marek Glogowski
Move common functionality into svx::MediaShellHelpers. Change-Id: I6f5db59bdcff7cad00a64e76f6aad7b8ecb4ffa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116126 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26tdf#96061 Unset the highlight propertyGülşah Köse
When we have highlight property on specific part of the text the following texts were highligthing. To prevent this we unset the highlight property when we have not highlight property anymore. Change-Id: I802cde1c784afe47201a9ba4f41827dd0c705035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115800 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-25tdf#131390 PPTX: fix custom slide show is not imported.Tibor Nagy
Change-Id: I62e1bfaae23d1b18e71a2c16651d01144a26907c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115475 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21use toggle instead of click for RadioButtonCaolán McNamara
Change-Id: I57cd1c074e4c4fc48ee83ac63a7c0ec5bcae5ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21use toggle instead of click for RadioButtonCaolán McNamara
Change-Id: Ic246c68749f79cc1b25fed08a66fd8a0d57495f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115884 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara
Change-Id: Ic8957a59addbf08f2b2e4e84167991f00048c6a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115876 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara
Change-Id: Icacf5444d65fb5bac4a6c85d9e5c36b98da3e57a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115867 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara
Change-Id: I6a80946481ee6fc40b2ee207a64287d1a5f96110 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115864 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20only the listbox handler does anything, remove the othersCaolán McNamara
Change-Id: I7c63b21c0902edd4586e6f249d50e6f0d475a851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115860 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19Fix typosAndrea Gelmini
Change-Id: I800e966cee8343099fb79f08959ba246a831aee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115826 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-05-19use toggle instead of click for CheckButtonCaolán McNamara
Change-Id: I0cbe6cd1b93557ceba535a835c4a199761ca5f00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19tdf#108450 and tdf#134665 Fix Impress Grow/Shrink Animation ScalingEdward Lynch
Also, change typo from 'veri' to 'vert' which was preventing the selection of the vertical option in the 'Size' drop down menu Change-Id: Ied568a607ca0ac70b481842eee33d54805685116 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106815 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19CppunitTest_sd_pdf_import_test: remove pdfium dependencyMiklos Vajna
This is no longer needed, we only call VCL functions in the test today. Change-Id: I86257acf6864f672e81b60cec6bd0f90dd89b373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115770 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-18loplugin:unusedmethodsNoel Grandin
Change-Id: I8191f4a9eb25b12242354813303fb7d30489d2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18tdf#128985: sd_export: Add unittestXisco Fauli
Change-Id: Id6cfeaeaf8484787705f06b7b1acc9a75287546d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115735 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-17Fix typosAndrea Gelmini
Change-Id: I4be77bf074f93fc978e34e5ba4c4693896e4c467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-05-17split OutputDevice from WindowNoel Grandin
as part of a longer-term goal of doing our widget rendering only inside a top-level render- context. I moved all of the OutputDevice-related code that existed in vcl::Window into a new subclass of OutputDevice called WindowOutputDevice. Notes for further work (*) not sure why we are getting an 1x1 surface in SvpSalGraphics::releaseCairoContext, but to fix it I clamp the size there (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code? Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-14Improve loplugin:stringviewStephan Bergmann
Issue the "instead of O[U]String, pass [u16]string_view" diagnostic also for operator call arguments. (The "rather than copy, pass subView()" diagnostic is already part of handleSubExprThatCouldBeView, so no need to repeat it explicitly for operator call arguments.) (And many call sites don't even require an explicit [u16]string_view, esp. with the recent ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator += overloads". Just some test code in sal/qa/ that explicitly tests the O[U]String functionality had to be excluded.) Change-Id: I8d55ba5a7fa16a563f5ffe43d245125c88c793bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115589 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-14Add extended tips to print dialogOlivier Hallot
The extended tips were not imported for the print dialog in the firts round. Change-Id: Ie4e5282720d927fec51a823bb43c1617349105bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115576 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-05-13Revert "simplify the vcl<->toolkit connection"Noel Grandin
because it introduces a link-time dependency of vcl on toolkit, and toolkit already depends on vcl This reverts commit f7a86c5cdf4323c99d26512bf78de7f7c380667d. Change-Id: Ibdd4f3e8221d70e2abd8fcbda67f85af3ac0396e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-12simplify the vcl<->toolkit connectionNoel Grandin
No need to store two different pointers and hide the underlying class behind an UNO interface Change-Id: I72c55e912caa9eae1cffa6c9d1b1d480e5668d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-11tdf#91874 Command Popup - HUD to search and run LO commandsTomaž Vajngerl
This adds Command Popup functionality, which is a HUD like pop-up window, which can be used to search and run commands presented in the main menu (but not limited to that only). This is the initial version, which has limitation in searching and running the command (doesn't work for some currently). Change-Id: I92cdd3130b8de42ee0863c9e7154e7c7246d9377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115380 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-10svx: fix crash with active text edit vs slide deleteMiklos Vajna
The problem is that SdrObjEditView::HideSdrPage() may delete SdrPaintView::mpPageView when it calls SdrGlueEditView::HideSdrPage(). But SdrObjEditView::pTextEditPV is a non-owning reference to that. GetTextEditBackgroundColor() in svx/ calls SdrObjEditView::GetTextEditPageView(), so in case SdrObjEditView::pTextEditPV is not cleared, we would access a deleted SdrPageView. Change-Id: I948bae8e0e8d557e38aa8f243e9eea522b21a043 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115324 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-10tdf#124457 PPTX animation: export repeatCountTibor Nagy
Aanimation timing property "repeatCount" wasn't exported. Note: PPTX uses a 1000 multiplication in repeatCount to support fractional movement of animated objects, e.g. 1500 means one and a half steps. Change-Id: Iac0dd10007c3e48f06c131d61671e1f78cad45a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115138 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-08ref-count SfxItemPoolNoel Grandin
so we can remove SfxItemPoolUser, which is a right performance hog when we have large calc spreadsheets Change-Id: I344002f536f6eead5cf98c6647dd1667fd9c8874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115247 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-07add missing truncate-multiline propertiesCaolán McNamara
Change-Id: Idbb227185806f97e00e99faa88a3fc6818e75513 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06add SfxItemPoolDeleter utilityNoel Grandin
add use so we can hold the pool with std::unique_ptr Change-Id: I685fbc37c0ae145a5b48a66a88eab9fb29a0fc0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115174 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-06Resolves: tdf#138855 crash on use of Outliner freed by GetFocusCaolán McNamara
probably since... commit 3a662445a0e3666637e5eb140b106a1347f050eb Date: Sun Jun 23 17:54:49 2019 -0800 tdf#126061 Make text edit outliner view show cursor Change-Id: Ic4e8b5984d5b21c3b789eba943d35d4cad1ba867 Reviewed-on: https://gerrit.libreoffice.org/74676 Change-Id: Ibd6cf9e6f539e651d6e98f2af4a2eba55f081b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06use Widget::get_clipboardCaolán McNamara
there's no different from GetSystemClipboard except potentially for the libreofficekit case where per-frame clipboards are possible Change-Id: I3173e39f81a03a7cbe114ebca6020d5ed36a659a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06Removed executable bits on pptxAndrea Gelmini
Change-Id: Ifbe14a29ac80143c23c189c80599e38816cc6b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115163 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-05-05loplugin:constmethodNoel Grandin
Change-Id: I7913fd8144d521b8293ac43036d0fad82e457cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-05rhbz#1956977 crash on switch from active comment to slide sorterCaolán McNamara
Change-Id: I2b5a5cb8b0631971b775a70d96f2cbf0c118c090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-04tdf#54037 PPTX export: fix internal hyperlinksTibor Nagy
exported as external by accident: after reloading the bad export, clicking on the hyperlink opened the same file in another document, because the exported link contained also the full file name reference instead of the slide name, according to the OOXML Relationship TargetMode="External". Change-Id: I08cf1537cd307b0b6f51ba1c3f61d89e220d44fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114891 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-04tdf#103347 PPTX import: fix duplicated slide nameTibor Nagy
PPTX import uses title text as slide names, but this resulted duplicated slide names in the case of repeating title text, which forbidden by UNO API: == GenericDrawPage.idl == /** Gets or sets the name of this page. <p>Duplicated page names inside a document are not allowed. */ [optional] interface com::sun::star::container::XNamed; Now the import code skips the duplicated title text, resulting default numbered slide names instead of the duplicated title names. Note: it seems, this hasn't fixed the jumping slide selection, e.g. sometimes pressing Shift-F5 still presents the first slide instead of the actual one. Change-Id: I98511c3c9a59598ea113e7387db5202d7f8a7cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114810 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2025-02-15 00:13:58 +0000