summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2017-07-13sd: Use std::unique_ptr<> as SdUndoGroup owns SdUndoActionsTakeshi Abe
Change-Id: Iaba3f3cf91e30b549e1b8ce3e54c0ef50df9f1d4 Reviewed-on: https://gerrit.libreoffice.org/39823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-07-12EditEngine: Making ODF Format Default for Copy/PasteVarun Dhall
Change-Id: Idfb4dacf4a1595ff974bbca195e419ff6a98418b Reviewed-on: https://gerrit.libreoffice.org/39876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-11loplugin:useuniqueptr in scaddins..svxNoel Grandin
Change-Id: I309f98f6b820103a926e9fe94d67d0aff6eb6476 Reviewed-on: https://gerrit.libreoffice.org/39754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11simplify calls OUString::copy in foo.copy(x, foo.getLength() - x)Noel Grandin
Change-Id: I20318c77dcc3bc2a64336541ef5a3f412bfd9483 Reviewed-on: https://gerrit.libreoffice.org/39803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11use more range-for on uno::SequenceNoel Grandin
Change-Id: Ifad32425d79be5a22d33d721bdc5fb993f699759 Reviewed-on: https://gerrit.libreoffice.org/39763 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10sd: fix unitialized "pItem" pointer in SlideBackground::SlideBackgroundMarkus Mohrhard
/sd/source/ui/sidebar/SlideBackground.cxx:176:17: runtime error: downcast of misaligned address 0x00009cf8cd67 for type 'const SvxSizeItem', which requires 8 byte alignment (regression from fba28df77d7e98663d1cf77ac206f8799fce4108) Change-Id: I822efe57f35c851b6f63e1e5489ab2448a19963d Reviewed-on: https://gerrit.libreoffice.org/39753 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-09Added margin feature to the Draw's SideBarpv2k
Change-Id: I53b5430d1563fcceae29418fd5907ac42ea856e7 Reviewed-on: https://gerrit.libreoffice.org/37626 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-09Slightly different approach to tdf#106679Katarina Behrens
cowardly avoiding use of DrawViewShell in constructor Change-Id: Ib40406d439403d0e2de270827bf5c2f06cfb18c2 Reviewed-on: https://gerrit.libreoffice.org/39368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-07tdf#108925: Too small bullet size confuses the userTamás Zolnai
Add a constraint for bullet relative size to avoid too small bullets which are hardly recognizable. Use the same 25% lower limit what MSO uses. Change-Id: Id956ecf3ec831c569188b944be58da03bf30a55e Reviewed-on: https://gerrit.libreoffice.org/39696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-07loplugin:unnecessaryparen handle parens inside call exprNoel Grandin
stick to single-arg function calls, sometimes parens in multi-arg calls might be there for clarity Change-Id: Ib80190c571ce65b5d219a88056687042de749e74 Reviewed-on: https://gerrit.libreoffice.org/39676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07C++11 remove std::binary_function bases from functorsJochen Nitschke
std::binary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::binary_function base class was used by deprecated std::bind2nd, this was solved in individual commits. The members first_argument_type and second_argument_type were used in chart2/source/controller/dialogs/DataBrowserModel.cxx: DataBrowserModel::implColumnLess and are inlined in this commit. Change-Id: I60ded60a8d4afd59e15ac15a58e18d2498c9be5a Reviewed-on: https://gerrit.libreoffice.org/39659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06use OString::operator== in preference to ::equalsNoel Grandin
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf Reviewed-on: https://gerrit.libreoffice.org/39646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06GSoC: Recent Charaters Toolbar Dropdown ControlAkshay Deep
Change-Id: Ib04d26fa5556e5c32db6799c16d0bbedc45504ec Reviewed-on: https://gerrit.libreoffice.org/38944 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-06remove unused text property of spinbuttons for animation delayStanislav Horacek
to remove numbers from translatable strings Change-Id: I347fc15a3f80c6c2cb72d7676138c9b80557a478 Reviewed-on: https://gerrit.libreoffice.org/39610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-06ensure safe GlobalEditData release of xForbiddenCharsTableCaolán McNamara
ensure that when the editeng GlobalEditData dtor is called that the vtable of the xForbiddenCharsTable shared_ptr will point to functions that are callable from editeng. otherwise a shared_ptr created in the sw uwriter cppunit test, but now belonging to GlobalEditData, will have deleter entries pointing to functions in uwriter that have been unloaded and are not available anymore Change-Id: I375a84156c0b1a0f8b24194fc07f0c512f556dbc Reviewed-on: https://gerrit.libreoffice.org/39605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-06rework as a shared_ptrCaolán McNamara
mostly to try and track down a crash on exit of sw uwriter under windows Change-Id: Id67e93863056da319dd8225038d60a7f5783b103 Reviewed-on: https://gerrit.libreoffice.org/39604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-05coverity#1414486 Unchecked dynamic_castCaolán McNamara
and coverity#1414482 Unchecked dynamic_cast coverity#1414480 Unchecked dynamic_cast coverity#1414479 Unchecked dynamic_cast Change-Id: Ia33e4cfa5c13beeae5dfa46411f526433d87ea99 Reviewed-on: https://gerrit.libreoffice.org/39568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-05new loplugin unnecessaryparenNoel Grandin
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04tdf#105831 Add Donate entry on Help menuOlivier
The full implementation depends on infra Task #2179 https://redmine.documentfoundation.org/issues/2179 revision1: change to https, per demand of #2179 Removed ellipsis Code changed as suggested Change call to pass BCP47 string, with language as fallback. task #2179 will be reviewed accordingly. Change-Id: I573542da0f394d7128faab0106df852d622c98b3 Reviewed-on: https://gerrit.libreoffice.org/34693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-04support for saving a modified image instead of original versionMarco Cecchetti
Normally when you save an image through the "Save..." entry in the context menu for an image, the saved image is the original one more eventually applied filters (which are not removeable). Further applied transformations like rotations, cropping, color effects are not included in the saved image. This patch offers the user to choose if saving the original image (with filters) or the modified version through a pop-up dialog. The new feature is available in Writer, Draw and Calc. Change-Id: I4f983e3a5e8a6839fa5789a96c4d8c44477c1fd7 Reviewed-on: https://gerrit.libreoffice.org/39480 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-07-04loplugin:unusedfields in sdNoel Grandin
Change-Id: I42def3dc21ae1a18e1c98d1aeeff4ed4425e941a Reviewed-on: https://gerrit.libreoffice.org/39479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03tdf#108609 rtl mode set on ruler when it should be ltrNoel Grandin
regression from commit 8ccbc16b5e3f94b8db105232d7085a8553e6bc03 "convert SvxFrameDirection to scoped enum" Change-Id: I2063ddf4344fb41b54f2ad96a471df4d3205406d Reviewed-on: https://gerrit.libreoffice.org/39478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:unusedfields in slideshow..svtoolsNoel Grandin
Change-Id: I74d5a4b8cfc4b18267f99648a3112b163c91fd8c Reviewed-on: https://gerrit.libreoffice.org/39474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:unusedfields bIsMarked in SvTreeListEntryNoel Grandin
write-only since GetIsMarked was removed in commit 06ea347b939895d3091ce747c26de58f4d4a766a "loplugin:unusedmethods svtools" which in was unused since introduced by commit b755fb8c0f6b1282f62c12f378c0a5ecac64d490 Author: Steve Yin <steve_y@apache.org> Date: Mon Nov 25 16:15:58 2013 +0000 Integrate branch of IAccessible2 Change-Id: I1342d4c020e53380f4c52fadcbf36ff520efaad4 Reviewed-on: https://gerrit.libreoffice.org/39470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-03Translate German comments and debug strings (leftovers in dirs scaddins to sd)Johnny_M
Translates leftovers found using a custom regex and manually checking the rest of the affected file. Additionally: - A few spelling fixes Change-Id: If54a0ecc58a429ee1c63abd43411c50304dab176 Reviewed-on: https://gerrit.libreoffice.org/39450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-03loplugin:unusedfields in svxNoel Grandin
Change-Id: I027b70ee92ab07eb68452457c3ee45de3ad22c8b Reviewed-on: https://gerrit.libreoffice.org/39412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: sdStephan Bergmann
Change-Id: I5b83c826da2613e537025f2c849a80468c7d8504
2017-07-02DocumentRenderer::Implementation::GetProperties rOptions is unusedStephan Bergmann
...ever since the code's introduction in 3667b8e20a4c35aa2dfae63f159b2c96b4ade2b1 "#i92516# Refactored printing code, adapted it to new printing model, moved it to DocumentRenderer." Change-Id: Ie375fb3e7815ca0450c6d2b0d502a9c162b39bfb
2017-07-02SlideSorterViewShell::Create parameter bIsCenterPane is unusedStephan Bergmann
...ever since b390fae1706b9c511158a03e4fd61f263be4e511 "renaissance1: #i107215# Reorganized and improved layouting." Change-Id: I69bd8074cc7c33d8c85ff9ac43fb380795c28ee3
2017-07-02ViewShellManager::Implementation ctor parameter rManager is unusedStephan Bergmann
...ever since 5f47590d3911eb49ec86c671019fd32469fba4ae "INTEGRATION: CWS viewswitch" Change-Id: I49c474354cdb11fadf0f949bb5c19dcbb1f22e8d
2017-07-02ClientBox::CalcActiveHeight parameter nPos is unusedStephan Bergmann
...ever since the code's introduction in 2d63c4689a13599ec9389c370726005f01fea08c "Basic Impress Remote + linking of dialog and server." Change-Id: I312315263fbb73dea421ddeb16381318a6fd8bec
2017-07-02ViewShellManager::Implementation::DestroySubShell rParentShell is unusedStephan Bergmann
...ever since the code's introduction in 5f47590d3911eb49ec86c671019fd32469fba4ae "INTEGRATION: CWS viewswitch" Change-Id: Ib39ed80d06e24acd2e450c5d0faa4684414cb77c
2017-07-02SelectionFunction::ModeHandler::StartDrag parameter eMode is unusedStephan Bergmann
...ever since 8c9901906bbc6b59baa0b2ef918b7e7fe89538b8 "renaissance1: #i107215# Reorganized the selection function. Introduced button bar." Change-Id: I54ebea0f74d83fe4f4455a3b666bbb9737764b49
2017-07-02Layouter::Implementation::GetTargetSize rPreviewModelSize is unusedStephan Bergmann
...ever since 1e89c38545f74a2d18564f9df6ec1ff4d5ef9390 "renaissance1: #i107215# Fixed minor compilation problems." Change-Id: I8d3c79e5082747f14fb774bccb8b4a53507f9167
2017-07-02PresenterCanvas::UpdateSpriteClip rSize parameter is unusedStephan Bergmann
...ever since the code's introductioj in 61114869c76de15bf63c929d07f524cd545f418f "INTEGRATION: CWS presenterfixes: #i89792# Added UpdateSpriteClip() method to fix sprite clipping." Change-Id: I4a2a9bf80f751a2524ef97688bc694d6805d702d
2017-06-30fdo#43157 convert OSL_ASSERT to assert in sd/source/ui/slidesorterBernhard Widl
Change-Id: I2348501e620defa7997d257c230fe6a6ac351fca Reviewed-on: https://gerrit.libreoffice.org/39407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-30tdf#108833 sd: don't unconditionally enable Undo after importMichael Stahl
Change-Id: Id637e649ccf3782658832d909b3a7150a0606229
2017-06-30tdf#108863 sd: disable Undo earlier if no Undo StepsMichael Stahl
If 0 Undo Steps, the Undo is disabled by a timer somewhere calling SfxShell::SetUndoManager(). This seems a bit risky, so disable it already when the sd::UndoManager is created. Change-Id: I9caf14fe32251d1f92cb5fa0683838316275eab3
2017-06-29fdo#43157 convert OSL_ASSERT to assert in sd/source/ui/slidesorter/cacheBernhard Widl
Change-Id: I5280fe279ac901082450fb1c5f4f601653b87598 Reviewed-on: https://gerrit.libreoffice.org/39392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-28SvXMLEmbeddedObjectHelper::Create bDirect parameter is unusedStephan Bergmann
...ever since 63d13cb2ee2c4725599714f6184bcd6e77a1eab7 "#87246#: OLE object support through SAX interface" Change-Id: Ib1d63a3a6adf64e2b5d3a16df5a7c6473d46abfb Reviewed-on: https://gerrit.libreoffice.org/39364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-28sd lok: disable undo state if conflict with other viewsHenry Castro
Change-Id: I046d118fca32c95f7734d6e29598da56578c9ec0 Reviewed-on: https://gerrit.libreoffice.org/39333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-06-28-Werror=ignored-qualifiers (GCC 8)Stephan Bergmann
Change-Id: Ic660ab732fc53bfaaf161624972aa0e8fbbc82a4
2017-06-28sd: Kill forward declaration of non-existent RequestDataTakeshi Abe
Change-Id: I0feef07e46b0056408d75abed631646e0520e4c1 Reviewed-on: https://gerrit.libreoffice.org/39306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-06-28sd lok: fix Undo/Redo Document RepairHenry Castro
REPAIRPACKAGE is sent to enable Undo/Redo actions when two views have conflicts. Change-Id: I58133f5b9006c41a297711c52ed0acfce3c19f92 Reviewed-on: https://gerrit.libreoffice.org/39325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-06-27Fix typosAndrea Gelmini
Change-Id: If4373f47fdf0ccfcbd490299f8b8d09e17bf92cd Reviewed-on: https://gerrit.libreoffice.org/39272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-26loplugin:oncevar in sdNoel Grandin
Change-Id: I56649b4df8c517f152ed4e9132985bbef22f8634 Reviewed-on: https://gerrit.libreoffice.org/39241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26s/catched/caughtNoel Grandin
Change-Id: I7ea6977a9749e86f8058b78cdb91cd2c62da8264 Reviewed-on: https://gerrit.libreoffice.org/39164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26Fix PageShape export to pptxPaul Trojahn
The export code is not called, because the PageShape is actually of type presentation.PageShape and not drawing.PageShape. A PageShape has no text at all, which results in an empty p:txBody element that fails validation, so it needs to be checked first if the shape actually has text. Change-Id: I559f15c2396739c74d5c4f36eb952754bc040ce8 Reviewed-on: https://gerrit.libreoffice.org/38574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-01-31 10:39:15 +0000