summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann
Change-Id: I0d1d7f598a0c61d36d72f9d51cccdcd1071c30b6
2015-06-26tdf#87905: Use darker background colour for master viewKatarina Behrens
for the area behind the slide, that is Change-Id: Ie020f43a81e5eaa257c20d0a7b6feffce1614205 Reviewed-on: https://gerrit.libreoffice.org/16466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Philippe Jung <phil.jung@free.fr>
2015-06-25implement equalize width and height for impress/drawCaolán McNamara
Equalize width/height adjusts width/height of selected objects to the width/height of the last selected object. Change-Id: I7c222a6591112cb674322d310ebd87f04a9198bd
2015-06-25tdf#91378-Empty Custom Properties are lost while saving in .pptx formatHeena Gupta
Conflicts: sd/qa/unit/export-tests.cxx Reviewed on: https://gerrit.libreoffice.org/15966 Change-Id: Ibc24ab9633b51fe41ad483121646cc391319fe6f
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I397db197dfa3108ee3c025a60dd9e437dd05a95d
2015-06-24Get rid of comphelper::string::is*Ascii functionsStephan Bergmann
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
2015-06-23Revert "Typo: readd -> read"Andras Timar
The comment is about re-adding something, not about reading This reverts commit bc8adace59ab5bebb93610e0ec3b16ef2a8f5151.
2015-06-23allow slide design to affect multiple standard pagesCaolán McNamara
modify this minimally and select all standard pages selected in the slidesorted, unselect them afterwards and loop over the selected ones. This looks like it could do with a rework to disentangle the master/standard pages stuff, but leave it as is in this commit Change-Id: Ifd01fe21c91e5e6b07b2d8bba0d85facadc25998
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-23rendercontext: Mass fix of using the wrong size.Jan Holesovsky
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-21Fix typosAndrea Gelmini
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-20tdf#84909 Additional tweaks to the standard, draw and text toolbarsYousuf Philips
Change-Id: I2a1a222855b3dfdc4147f14a559d13432745e456 Reviewed-on: https://gerrit.libreoffice.org/16388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-19LOK: return used format in Document::getTextSelection()Miklos Vajna
This allows requesting text/html, with falling back to plain text if necessary. Change-Id: Ie6d4e0e173311ba018553043b6a869abf193bf6f Reviewed-on: https://gerrit.libreoffice.org/16377 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-19rendercontext: Fix crash with double-buffering in the Styles combo box.Jan Holesovsky
Decouple the actual window from rendercontext in UserDrawEvent. Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
2015-06-19sd::ViewShell::GetTextSelection: fix text/richtext handlingMiklos Vajna
Change-Id: If7d75d48667cd48d9426b02a38d2cf539b248d26
2015-06-19loplugin:passstuffbyrefNoel Grandin
Change-Id: Ic889efaca00ad9600b1b5c8452aa7ee819e63c89
2015-06-19sd: implement getTextSelection() in SdXImpressDocumentMiklos Vajna
Change-Id: I29df1873b3954aa64a613e06c53c8e9acfa6a79d Reviewed-on: https://gerrit.libreoffice.org/16369 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18Bugfix test for tdf#88295Katarina Behrens
Change-Id: Ic9c4330e9b14e43448302132b6c01a8d93001d2f
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-17loplugin:cstylecastStephan Bergmann
Change-Id: Ia8e0b5ded9f73cf448910593184a0e8936180a12
2015-06-16Use template function to reduce copy'n'pasta codeKatarina Behrens
Change-Id: I22964bfcfb80a3e97903674dbf71a1b7be3a0920 Reviewed-on: https://gerrit.libreoffice.org/16308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16tdf#91909 Uno commands for slide navigation and sortingPhilippe Jung
The following change adds the following uno commands to draw and impress. Commands are in standard toolbar and not visible by default. NextPage: go to the next page PreviousPage: go to the previous page FirstPage: go to the first page LastPage: go the the last page MovePageUp: Moves the current selection above the page preceding the selection. MovePageDown: Moves the current selection below the page following the selection. MovePageTop: Moves the selection to the top. MovePageBottom: Moves the current selection to the bottom. Change-Id: I2dbd923f14fd9901fb513c58b51bc7ab91ad0a83 Reviewed-on: https://gerrit.libreoffice.org/16211 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-16tdf#91887 handle LOK_MOUSEEVENT_MOUSEMOVE in SdXImpressDocumentMiklos Vajna
Change-Id: If6948e523fd681dbe289909df68364806628ead6
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15tdf#91001 Fix inc/dec font for complex selectionsMaxim Monastirsky
By "complex selection" I mean: 1. Selection with an empty paragraph that has a bullet. 2. Selection that has different font sizes. This is a regression of 5b32d9c4406a68507ac9737ee0ada8bd1d424815 that tried to fix tdf#61492. In reality in order to fix that, it seems to be enough to pass an empty SfxItemSet, because what we really need is to invalidate the bullet width (by setting it to -1), thus force recalculation, and this occurs anyway. Change-Id: I92545192f8c78ef7f1d66d72f0d8e8f256f87604
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15cppcheck:redundantConditionNoel Grandin
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-15Fix commentMaxim Monastirsky
Change-Id: I9313a8d52ed25385cf4048bc3fe6dac4f542f9af
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-14tdf#91857 Reorganize impress's menu barYousuf Philips
Change-Id: I35d25b920bb5c195916500b1190e593143d62ab1 Reviewed-on: https://gerrit.libreoffice.org/16274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-13Fix typosAndrea Gelmini
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-13TyposJulien Nabet
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-12tdf#92001 'Handles' contains array of PropertyValuesAndras Timar
Change-Id: I17ea45f2b1dd46a7f1c0f3ce8c680bef9ec533fa Reviewed-on: https://gerrit.libreoffice.org/16249 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-10Fix sd ID conflicts and duplicatesPhilippe Jung
Fix the following cases: - two names for same ID in sd/inc/app.hrc. Two ID defined. - ID defined in include/sfx2/sfxsids.hrc and redefined in sd/inc/app.hrc. Only the sfx2 ID is kept - ID defined in include/svx/svxids.hrc and redefined in sd/inc/app.hrc. Only the svx ID is kept Change-Id: I21c7c25cb6db3c43ea2f9aac5aac75fabe61eaf0 Reviewed-on: https://gerrit.libreoffice.org/16209 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Philippe Jung <phil.jung@free.fr>
2015-06-10bSwitchOff is always false nowMaxim Monastirsky
Change-Id: Ic79c0f1cf2816da60962f67c57efb75685d984f1
2015-06-10tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e
2015-06-10sd: fix gcc-4.7 buildMiklos Vajna
Change-Id: Ia368b9760097b6041757a27f228ace587e243683
2015-06-08tdf#91890:Impress Crash when click on Transition icon in sidebarRishabh Kumar
Change-Id: I8ea350b97fcbf914b60ba580a72df967fdcfadef Reviewed-on: https://gerrit.libreoffice.org/16163 Reviewed-by: Philippe Jung <phil.jung@free.fr> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I0c6d14f0762ae804b931472bc201826821572e3e
2015-06-08Resolves: tdf#91932 enable CaseMap property in impress/drawCaolán McNamara
I don't see why this was explicitly disabled, works fine out of the box for me, import/export already hooked up in odf Change-Id: I5e6bdbc6a4f3cbcd97330c7d9fb33589489afee2