summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-06-13Make .uno:Objects3DToolbox item work in menusMaxim Monastirsky
Similar to the other insert shape group commands. Change-Id: I67524c1d521246b76d953ed9a8aff506535bf550 Reviewed-on: https://gerrit.libreoffice.org/73970 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-06-12loplugin:unusedmethodsNoel Grandin
Change-Id: I42667e8483d2cb4363227344faca3899bd95d424 Reviewed-on: https://gerrit.libreoffice.org/73824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-12Revert "improve empty tools::Rectangle (width)"Noel Grandin
This reverts commit a46a257794f1f53b294735fc876c394be23a3811. Too many issues, I'm going to try landing this in smaller pieces to make it easier to fix regressions Change-Id: Ie5e8979838017af86c119c887b580385ba068d54 Reviewed-on: https://gerrit.libreoffice.org/73859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-12sd: document the left pane classesAshod Nakashian
Change-Id: Id037e2f5f733ef7266ef6d48ff2ff7dea956ea25 Reviewed-on: https://gerrit.libreoffice.org/69070 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/73487 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-12Fix assert on loading a video presentation in gtk3Jan-Marek Glogowski
Regression from commit a46a257794f1 ("improve empty tools::Rectangle (width)"). Change-Id: I2d6d5bc140fe4012a5b17bb01fd325225cb776b8 Reviewed-on: https://gerrit.libreoffice.org/73844 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-11tdf#120844 Remove tabletext.xml from sdraw and from simpressRoman Kuznetsov
Change-Id: Ide91a0eb3776322e5adb4dbd0acc697dbb41b500 Reviewed-on: https://gerrit.libreoffice.org/73337 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-06-11tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b Reviewed-on: https://gerrit.libreoffice.org/73476 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-11loplugin:virtualdown in AccessibleShapeNoel Grandin
Change-Id: I35c8c4b2c561f3ce4fdc3d94cc74463abbc087f4 Reviewed-on: https://gerrit.libreoffice.org/73769 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-11loplugin:virtualdown in SvxBulletAndPositionDlgNoel Grandin
Change-Id: I98da96a09a61fe8a197065773d649dc55d6095b7 Reviewed-on: https://gerrit.libreoffice.org/73765 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-09loplugin:constantparamNoel Grandin
Change-Id: I7bbc4e1546acf58f1ca24bfec5e465bad5ca90de Reviewed-on: https://gerrit.libreoffice.org/73732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-09revert part of "loplugin:unusedmethods"Noel Grandin
i.e. commit 53312ca4ee722a6d5ba22d1f578c6de5fbc37207 to fix screenshot build Change-Id: I87df7b5e1b1afaeb314420484f2c924e64031764 Reviewed-on: https://gerrit.libreoffice.org/73731 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:unusedmethodsNoel Grandin
Change-Id: I52efd8d843d0e4cc7a6adefb0eb95aa50469af38 Reviewed-on: https://gerrit.libreoffice.org/73693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:singlevalfieldsNoel Grandin
Change-Id: I7c00b7d932bf96a0725eac5482580461baea6977 Reviewed-on: https://gerrit.libreoffice.org/73697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:unusedfieldsNoel Grandin
Change-Id: I9758fd606c7d4c251a3ac06661d642a47260b5fc Reviewed-on: https://gerrit.libreoffice.org/73674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08 Fix typoAndrea Gelmini
Change-Id: Idd668a1d16ae17d4821804859d0d5eb6b92ae345 Reviewed-on: https://gerrit.libreoffice.org/73683 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Related: tdf#111522 svx: fix crash with view1 doing textedit and resize/rotateMiklos Vajna
The two actually affected functions are SdrEditView::RotateMarkedObj() and SdrDragObjOwn::EndSdrDrag(), but it looks like the other functions in SdrEditView are safe to be changed the same way. I expect IsUndoEnabled() can't be changed, though: that would mean there would be no undo for the text edit itself, either. If other actions still crash, the pattern is the same: put a breakpoint on the SdrUndoAction constructor and see the backtrace to find the function that calls IsUndoEnabled() without calling CanDoSdrUndo() at the same time. Change-Id: If9324e311ec6e9f68a951559e903e14bb72ea31c Reviewed-on: https://gerrit.libreoffice.org/73669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-07tdf#125551 PPTX export: correct position and size of diagramsGrzegorz Araminowicz
Save position and size of diagram background instead of whole group shape. Some diagrams contain shapes that are outside these boundaries. That caused diagram to grow and move. Change-Id: I909c13a5dc268f77832234b3884b91292922823c Reviewed-on: https://gerrit.libreoffice.org/73663 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-06-07notebookbar_compact updateandreas kainz
Change-Id: I256c2ec3934d728b5b68fbca8b7ba99a50a840ff Reviewed-on: https://gerrit.libreoffice.org/73661 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-07tdf#125563 Adapt adjustment values to binary shape geometryRegina Henschel
All presetTextWarp shapes are mapped to MS binary WordArt geometry in current implementation. But they use different reference systems for coordinates and different unit for angles. So _all_ adjustment values have to be adapted. Error was, that only angles were treated. Correct test file to actually contain the claimed 213.25 degree. Other bugs than adjustment values will be addressed in separate issues. Change-Id: I719b364af23887e50f003cf9878665755b8989ae Reviewed-on: https://gerrit.libreoffice.org/73624 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-06-07lok: re-factor getTextSelection.Michael Meeks
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-07improve empty tools::Rectangle (width)Noel Grandin
This is the width part, the height part will come next. Instead of storing "empty" as a special value (which is easy to get wrong, eg. some image filters pass in that special value, expecting it to be a valid width), just use separate boolean values for width and height empty. Also lots of code was calling GetBottom() or GetRight() on an empty rectangle, getting back that magic value and doing calculations on it, resulting in completely bogus data. So (1) make the various Rectangle methods do something reasonable when the empty flags are set (2) fix various other code to handle empty better (3) assert when code accesses Bottom or Right and the empty flag is set. Change-Id: I1163378cd2773dd8b386210f83400bb6b4701069 Reviewed-on: https://gerrit.libreoffice.org/73564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07tdf#42949 Fix IWYU warnings in svl/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Except source/svdde/* which is WIN-specific Also recheck include/svl Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe Reviewed-on: https://gerrit.libreoffice.org/73630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-06tdf#125556 URL fragment leaked from one object..Noel Grandin
to another when importing Powerpoint ppt file regression from commit 4245454d0c3d6df2d0e0a75aed6f22f0a26ce3e2 Date: Wed Feb 28 15:50:29 2018 +0200 loplugin:useuniqueptr in SdrPowerPointImport Change-Id: I5f415dfa1f6125629b9f3be1d799cb596c64c605 Reviewed-on: https://gerrit.libreoffice.org/73602 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-06weld HeaderFooterDialogCaolán McNamara
Change-Id: I6a5068106d0f243646cf12ec676dff60a04922ee Reviewed-on: https://gerrit.libreoffice.org/73596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06sd: support inserting background image from file via .uno:SelectBackgroundAshod Nakashian
The UNO command always prompted the user via file open dialog. This change allows for passing the filename as an argument to allow for inserting slide background programatically. Also, hide the Insert Image button in the sidebar since we can't use that (just yet), because it invokes .uno:SelectBackground directly. We would need to send LOOL a notification to invoke this on its own end to first prompt the user for a file. (cherry picked from commit 2118143bdd246921439ba9e835207585203dd45f) Change-Id: I20c0e33d66f8bcd72a6388e39c4ac92e64978f45 Reviewed-on: https://gerrit.libreoffice.org/73481 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06Cosmetics.Ashod Nakashian
Change-Id: Ic86960ce2f690bebc51c9120053bdd50232f0358 Reviewed-on: https://gerrit.libreoffice.org/73480 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06ViewShellBase const correctnessAshod Nakashian
Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac (cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28) Reviewed-on: https://gerrit.libreoffice.org/73479 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-05tdf#111522 svx: fix crash with view1 doing text edit and view2 doing sdr undoMiklos Vajna
If one view has an active text edit, then current code doesn't handle manipulating the undo text outside the text edit, so avoid problems by simply not adding an undo action to the undo stack for shape creation or move. Other actions might want to do the same in the future: check for CanDoSdrUndo() before calling SdrUndoFactory member functions. [ Found no existing test suite similar to CppunitTest_sw_uiwriter, so added one. ] Change-Id: I3a364bf4fe6f9b0c13aa07283681b1045368cf7a Reviewed-on: https://gerrit.libreoffice.org/73558 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-05The Bluetooth code doesn't compile with macOS SDK 10.15Tor Lillqvist
Change-Id: I8fffa4cef9628e6872c881cd0cbdfe85495fa324
2019-06-04SmartArt: bullet list improvementsGrzegorz Araminowicz
by default start bullet list at second level use stBulletLvl parameter to change this behaviour Change-Id: I5084e7bf1902fdca83bea6d57a8c1f37dd2e65be Reviewed-on: https://gerrit.libreoffice.org/73440 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-02NB tabbed finished sync between different appsandreas kainz
Change-Id: Ia3e1be0656eb066bd18e21fe365dcf0adec150b4 Reviewed-on: https://gerrit.libreoffice.org/73293 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-01NB tabbed big sync between different appsandreas kainz
Change-Id: I1616bcdd6e88615423e033f4ef276700fb3ba3ba Reviewed-on: https://gerrit.libreoffice.org/73277 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-31SmartArt: more constraints used in linear algorithmGrzegorz Araminowicz
* both width and height of children and space is taken from constraints * better handling of space between children (not lost in some cases) * children centered in the other axis Change-Id: I25b8360790de0292b2b5c313dfa55e58dc042193 Reviewed-on: https://gerrit.libreoffice.org/73201 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-31drop unneeded includesCaolán McNamara
Change-Id: Ie0f52bb1d6866075d0b664bfc3ddc47c02e4f81b Reviewed-on: https://gerrit.libreoffice.org/73169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29NB tabbed layout update in all appsandreas kainz
Change-Id: I3fe17af05869fe7eb540b85b24742cf0045d7569 Reviewed-on: https://gerrit.libreoffice.org/73185 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-29weld SfxDocumentInfoDialogCaolán McNamara
Change-Id: I79d5d8973a19c0e639081ec61ac596620518d0b5 Reviewed-on: https://gerrit.libreoffice.org/73145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-29tdf#120905 Add missing doxygen comments.Gülşah Köse
Change-Id: I3211f32521d578b1a5f72df7c5ccc4267ee01d38 Reviewed-on: https://gerrit.libreoffice.org/73101 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-29SmartArt: sort shapes by Z order after layout algorithmsGrzegorz Araminowicz
so that they are laid out in correct order Change-Id: I82baa61311197880654d09f356decc666e6fa4c7 Reviewed-on: https://gerrit.libreoffice.org/73094 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-29NB tabbed layout update in all appsandreas kainz
Change-Id: Ic291a6f9907e2449093469ae8a899093dc296e26 Reviewed-on: https://gerrit.libreoffice.org/73127 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-28NB: add tabbed_compact and contextual NB to Drawandreas kainz
Change-Id: Ibdca2026f29483948c2fafaf499a82d2a4acf08b Reviewed-on: https://gerrit.libreoffice.org/73095 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-28NB Draw add tabbs for 3D and MasterPageandreas kainz
Change-Id: I51bf435b555302fe96493f540f5e5a8dc33d0267 Reviewed-on: https://gerrit.libreoffice.org/73081 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-28tdf#120905 Remove old FuOutlineBullet dialog code.Gülşah Köse
Change-Id: I4bd0986f23414edc857ca890f6437c6029116e72 Reviewed-on: https://gerrit.libreoffice.org/73070 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-05-28SmartArt: adjust text size to fit shapesGrzegorz Araminowicz
up to maximal size of primFontSz constraint. Do not override text size changed by user. Change-Id: If7ea6bbb96cb839831d877edc274a1b0eefdaf21 Reviewed-on: https://gerrit.libreoffice.org/73050 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-28tdf#120905 Remove temporary uno command.Gülşah Köse
Change-Id: Id12838cf08a2e5b74b53bd0036804b886b41098f Reviewed-on: https://gerrit.libreoffice.org/73041 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-05-27tdf#42949 Fix IWYU warnings in include/svx/[sS][a-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I84fc75e06e61e5391aef6e237c36daad95dedb84 Reviewed-on: https://gerrit.libreoffice.org/72550 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-25Fix typosAndrea Gelmini
Change-Id: I09ea15a845bdae45453983862edbcbe9550cce86 Reviewed-on: https://gerrit.libreoffice.org/72942 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-25tdf#125326 NB tabbed impress insert tab add photo album commandandreas kainz
Change-Id: Ia9adea465427a492ed0062c28e3e6dc09cc77673 Reviewed-on: https://gerrit.libreoffice.org/72927 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-25NB draw tabbed add PhotoAlbumandreas kainz
Change-Id: Ieff9c7c7904b19b4202415b860b7a372503f46b6 Reviewed-on: https://gerrit.libreoffice.org/72926 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-25NB draw tabbed update insert tabandreas kainz
Change-Id: I22ec1ef8914262d20824b0d6d41a694820bac1b7 Reviewed-on: https://gerrit.libreoffice.org/72925 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-19 02:17:08 +0000