summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-10-03fdo#84617: Guard the destructor with SolarMutex.Jan Holesovsky
The same pattern as introduced elsewhere recently. Change-Id: Ie7b4fd1ec26d417f63bee26dd336dfc54f4847dc
2014-10-02Bin EE_CNTRL_URLSFXEXECUTE which was only set, never testedTor Lillqvist
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02bnc#657899: Paragraph vertical spacing differs from PowerPointTor Lillqvist
We need to set the "paragraph summation" flag also for .pptx import. (As is already done for .ppt import.) This is what in the Options (Preferences) UI is called "Add spacing between paragraphs and tables (in current document)", on the LibreOffice Impress:General page. This is a setting that when set becomes local to the document. I actually don't really understand why this needs to be a user-visible option, wouldn't it be enough for it to be an internal flag that is set for documents imported from .ppt and .pptx, and is clear otherwise? Change-Id: I525178957276e7d587b6ac4be8ae7919fc245a27
2014-10-02coverity#1242520 silence Arguments in wrong orderCaolán McNamara
Change-Id: I88b96d42f5ee96641dc21e3e55415f6dc32b3951
2014-10-02coverity#1242496 Resource leakCaolán McNamara
Change-Id: I419b217df306d41ed99e603bae9381f54c633598
2014-10-02coverity#1242497 Resource leakCaolán McNamara
Change-Id: I2c4295c7d308257290aaf04181805d7dc71d6553
2014-10-02coverity#1242800 Result is not floating-pointCaolán McNamara
Change-Id: Idcd1b3bd542512707b722708e4b3336c71fbff80
2014-10-02coverity#1242906 Unused valueCaolán McNamara
Change-Id: I7a282e5adc60e4b123469f46fb480805377626b4
2014-10-02coverity#1242934 Result is not floating-pointCaolán McNamara
Change-Id: I800f978102f1d1427584cf55d3da7768e7c7f2f3
2014-10-01Remove leftover SAL_WNODEPRECATED_DECLARATIONS_PUSH/POPStephan Bergmann
...from times when code used std::auto_ptr. Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
2014-10-01sd: std::auto_ptr -> std::unique_ptrStephan Bergmann
ToolBarManager::Implementation::Update in sd/source/ui/view/ToolBarManager.cxx is dubious. It takes its parameter by value (so in UnlockUpdate() the passed-in mpSynchronousLayouterLock is reset upon passing it in), but the comment that it "is [...] released at its end" together with the redundant pLocalLayouterLock.reset() at the end of Update() make it look as though the intention was to pass by reference. However, resetting mpSynchronousLayouterLock even in the case where pass-by-ref would fail to reset it is apparently important, as otherwise e.g. JunitTest_svx_unoapi would run into the OSL_ASSERT(mpSynchronousLayouterLock.get()==NULL) in LockUpdate() with a call stack of ... -> Update -> SetValid -> UpdateLockImplementation -> LockUpdate. Change-Id: I7d2717d5e1f8aa69c79a626c100d7fefb0cfb120
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30sd: SdUnoForbiddenCharsTable gets a SolarMutexGuard tooMichael Stahl
Change-Id: Ie742b7e38e60f6a77f6b7c3e56ac415d8cb836e1
2014-09-30bnc#584721: invisible text because of wrong color (white)Zolnai Tamás
Color::getColor() method uses some caching mechanism which works wrong when the result depend on one of the input parameters. So avoid caching in these cases. Change-Id: Ifa9221e21e685715454de86d5cec09ff6c266307
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-28fdo#70998 Termchange: Picture->ImageSamuel Mehrbrodt
Change-Id: I4113d35e2a4778c9833e659b1e4ff4fbb1ab9734
2014-09-27Term change: Sound/Movie -> Audio/VideoSamuel Mehrbrodt
Change-Id: I389a3db5ca23718035413cbd0252f62eb8c870c3
2014-09-27Add missing title to the Header and Footer dialogAdolfo Jayme Barrientos
Change-Id: I720bf1be02b9b4decf5373d49de136b0e57c61c9 Reviewed-on: https://gerrit.libreoffice.org/11657 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-27fdo#53682 Merge 'Insert Image' and 'Insert Audio/Video' in submenuSamuel Mehrbrodt
Change-Id: I4ddbd134ba15a48c0c529a11bcb1cd1f71f3a51a
2014-09-26fdo#83808 Scale images proportionally by default in Impress/DrawSamuel Mehrbrodt
Change-Id: I16cacb90150aef3aa2ad4607e05298f0bc47c1ae
2014-09-26remove unnecessary casts in misc calls to SvStream.Write*Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26remove unnecessary static_cast'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-26bnc#897769: OOXML import: Import border lines using reference too.Matúš Kukan
Do not ignore 'lnRef' element. Also fix typo to apply 'seCell' properties to the right cell (southeast). Change-Id: Ia45f7016f358b70e6db06a232c569335ce9d7051
2014-09-25fdo#84235 Remove Navigator from Context menuSamuel Mehrbrodt
Change-Id: Ie84fe35db0dfca08e2b270636f06bef90c1455ab
2014-09-25Fix validation problems pointed out by CppunitTest_sd_export_testsMiklos Vajna
Regression from e8bdd38882522591723097c028ca7a6927ee70c4 (fdo#83751-FILESAVE:Custom Properties dropped while exporting to .pptx, 2014-09-11), there were two problems here: 1) Using the wrong filter when the output is expected to be suitable for validation. 2) Writing empty custom property values, which is not valid. Change-Id: Ic18c789c53bd40cc8aa07385cb5fd0d5c7ada6ab
2014-09-25fdo#83751- Add test case for custom properties in pptxHeena Gupta
Change-Id: I83fb0462c662e0da1f1c5c6dfec4bd8d94d97b87 Reviewed-on: https://gerrit.libreoffice.org/11420 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-25fdo#83751-FILESAVE:Custom Properties dropped while exporting to .pptxHeena Gupta
Change-Id: Ic4b8acfc3cbd8c86b765a950d61742c229f3fb6d Reviewed-on: https://gerrit.libreoffice.org/11390 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-25editeng: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I25e3599a37d720cbcf70ea13ab30234e54637d53
2014-09-25fdo#63483: support for modify passwd in Impress and DrawKatarina Behrens
iow, allow opening Impress and Draw ODF documents read-only Change-Id: I379b9f92b9bfb20e99998177d9a5fae80069d98f Reviewed-on: https://gerrit.libreoffice.org/11495 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-25Stop using unnecessary std::auto_ptrTakeshi Abe
No need to allocate mpMasterPages dynamically. Thanks David Tardon for pointing it out. Change-Id: Id91ce50b190c7807f4c59d211110c28409c244ca Reviewed-on: https://gerrit.libreoffice.org/11484 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25Revert "fdo#73151 Always open Styles&Formatting dialog in the sidebar"Stephan Bergmann
This reverts commit 473ed449a4b6f550dc1af47a07c6e0ef243a98b2, which made JunitTest_toolkit_unoapi fail, as AccessibleDropDownListBox.createTestEnvironment (qadevOOo/tests/java/mod/_toolkit/AccessibleDropDownListBox.java) was no longer able to find its AccessilbeRole.COMBO_BOX AccessibleDropDownListBox, which it apparently expected to find in a docked stylist (cf. DesktopTools.dockStylist in AccessibleDropDownListBox.initialize).
2014-09-24Fix falloutSamuel Mehrbrodt
from e16c8534f446a7cc311d6d5026aae5457e4f8e6c Change-Id: I05154dd06b062aaf7fdffe1aa3792f9710293021
2014-09-24fdo#47302: Added insert->fields->page title buttonJennifer Liebel
Change-Id: Iebc8298a7e6a7d423d2667eec8a46a936cc4d2cd Reviewed-on: https://gerrit.libreoffice.org/11599 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-24fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
This removes the floating window for Styles&Formatting as discussed in fdo#73151. Change-Id: I352d27a4d30632dcfda8963c23629e62ab850524 Reviewed-on: https://gerrit.libreoffice.org/11253 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-24Replace some std::auto_ptr function parameters with std::unique_ptrStephan Bergmann
Change-Id: Ic66d325fd9559c6dde9556c26e5b2a7e60376c49
2014-09-24unused using-declarationsMatúš Kukan
Change-Id: I2bfb15821579b2636f6ae6b453b821ddfa0ccfcc
2014-09-23Fix build breakages with gcc 4.7. It doesn't like '<::'.Kohei Yoshida
"<::" -> "< ::" Change-Id: Ie83b0e6c09972b175ce72e37d20b5122a16e922b
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23n-up printing done by vcl, brochures by draw/impressCaolán McNamara
Change-Id: If38365d949ad91d50138798a0a386f9543eb4f22
2014-09-22fdo#78826 HIG: missing colons and capitalization in sdAdolfo Jayme Barrientos
* Title Case for headings and command buttons * Sentence case for radio buttons, check boxes, etc. Change-Id: I68342d2f4c66e2253dded31d80783b3629a3d1d6 Reviewed-on: https://gerrit.libreoffice.org/11577 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-22remove unused fields pName and pMethodName in SfxSlot classNoel Grandin
Change-Id: Icca5a0dee296fae1abeb78ea8ffa2f9e934bb111
2014-09-21Related fdo#80538 Re-adding toolbar separatorsYousuf Philips
Change-Id: I29c2171495c0419fa5b6a7b99725d6098331afd0 Reviewed-on: https://gerrit.libreoffice.org/11523 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-18IsDraw doesn't mean the app/page is DrawCaolán McNamara
it means a slide in impress. commit 7b31e45ec7106d2cfbdbb7915d97667ba710f81c Date: Mon Jun 23 20:55:21 2014 +0100 Make Draw use paper size when printing - fdo#63905 Previously, Draw/Impress use the default size from the printer. Now Draw uses the paper size (specified in page formatting). Impress still uses the old method - not sure if this is correct but printing handouts etc probably complicate print/paper size. suggests the intent is for this to not affect Impress and to only affect Draw, so this does that Change-Id: I481a824ef244fd837992c893f6de0c051af0a26b