summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-11-22tdf#143316: fix datetime footer regression on mso2010Sarper Akdemir
Exports language in run properties of the datetime footer. And also overrides the placeholder "Date" text with formatted datetime text if the datetime footer is a nonfixed one. Fixes regression from: 166671f4aa19deec47c10a220ae1d29fa57faa93 (tdf#59323: pptx import: import footer fields as properties) Change-Id: Ib888e5cf51ea7e14fb13278e96610051e1e5fe5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124123 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-20cid#1494386 Dereference null return valueCaolán McNamara
Change-Id: I3dee29c68166c88bce30d2c88a6684be43f8e717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-20tdf#118776 drawingml: treat XML_nofill as (mostly) transparentJustin Luth
100% transparent typically ends up as COL_AUTO which certainly doesn't do what is intended. So set as 99% transparent to get effectively the same invisible effect. Adapted patch and re-used unit test from an earlier commit authored by Xisco. This depends on tdf#137438 not spamming the text properties with outline props. Only one existing unit test that matched this condition: -export-tests-ooxml1.cxx customxml.pptx -empty textbox - text entered here SHOULD be invisible. Change-Id: I077b748e500713188421f0eeefdfd85c46555e84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125301 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Justin Luth <jluth@mail.com>
2021-11-19uitest: better use execute_dialog_through_action in these casesXisco Fauli
Change-Id: Ic2317db908afc12973624034f29c1de6f4efd60c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125561 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-19Drop F_PI1800/F_PI18000, and unify deg2rad/rad2deg conversionsMike Kaganski
Change-Id: Ib89b00c3dc8cd440e8a88906eea133becd1cef64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125509 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-11-19PPTX import: handle <a:clrScheme name="...">Miklos Vajna
We had doc model for this, but the UNO API and the PPTX import was missing. Change-Id: I199e9cc235a783d91700ce74f17d442f41d3c3f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125532 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-11-19gtk3: use GtkPopover default for selected cases that are within a documentCaolán McNamara
and where inability to escape window under X11 hasn't been a problem to date Change-Id: I14aa5fe2cf443b6214aed48266d5bd32b8b9c700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19gtk3: default to an explicit constrain-to for PopoversCaolán McNamara
with the intent to do the same replacement with GtkWindow under X11 for gtk3 that we do in MenuButtons for the popover with direct popovers when the constraint is GTK_POPOVER_CONSTRAINT_NONE Change-Id: I629c30b44a9e362ba0d924bb229930b5f0dc7ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19tdf#137438 drawingml: separate outline from text importJustin Luth
By ignoring the a:ln group, the contents in that group (like transparency) were being applied to the text. Well, it should only apply to a line around the text, which LO isn't doing. [Well, LO can do this as Fontwork, but perhaps that doesn't match so well with text in shapes generally?] At any rate, don't allow one group's settings to override the others. Keep them separate and then apply a bit of merging logic to try to achieve the best look. So emulate a little bit. If the outline is not very transparent (less transparent than the main text) then it may (if thick or opaque enough) dominate the text. For simplicity (and because there is no right answer overall) I just compared transparency and used the more opaque colour. Unit tests potentially affected: -export-tests-ooxml1.cxx: tdf100348_FontworkBitmapFill.odp -> PPTX -now imports black instead of yellow (MSO sees gradient colors) -so previously completely wrong, and now perhaps even more wrong? -export-tests-ooxml3.cxx: tdf114848.pptx -shows blue text regardless - defined by area. -can't see where this is set in MSO2016. Perhaps illegal? - : tdf125573_FontWorkScaleX.pptx -no visual difference. Same as tdf100348, but with black outline. - : tdf119087.pptx -should be green, not purple. [Added test for that.] - : tdf143315-WordartWithoutBullet.ppt -no visual difference (COL_AUTO outline?) -import-tests2.cxx: tdf129686.pptx -poor test usage (but also weird transparent default). -no visual change. -ooxmlimport2.cx: tdf143476_lockedCanvas_position.docx -no visual difference. Irrelevant since we can't RT Change-Id: Iff0d95506dd64825444a99e62a6c2bd5e1dc122f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125300 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-18uitest: sd: the redo action fails at times ...Xisco Fauli
... to add back the animation to the list in the sidebar, and thus the test fails. Remove it for now. At least the undo part of tdf#135033 is still tested Change-Id: I7dc416645db53ec3f08376d04de9be036ce53fdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125505 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-18import pptx color schemes as color setsSarper Akdemir
initial import work for color sets. Themes (which we get the color schemes from) in MSO can be different for each master - will need to support that too. [ Miklos: actually added that per-master-page support. ] (cherry picked from commit 3b21d166f585dcdf8d576d166aeff3cfd4694aab, from the feature/themesupport2 branch) Change-Id: Ia06d2645018e6bfa70817bbddba2374641ae13dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125477 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-18tdf#135033: sd: Add UItestXisco Fauli
Change-Id: Idc3cb84972d01496e378e224d65cd4db71648c40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125446 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-18introduce XColorSetsManager interfaceSarper Akdemir
[ Miklos: rather go with a beans::PropertyValues-based interface to allow extending this incrementally, without an API change. This allows getting / setting a per-document theme via the UNO API, but the concept from the original commit is unchanged. ] (cherry picked from commit 3f1bca8b4f451fa30bf341116390738c456d651f, from the feature/themesupport2 branch) Change-Id: I24be34a5a7b68549b21a6cd55144901d4fe2c5f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125436 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-17tdf#137637: sd: Add UItestXisco Fauli
Change-Id: I5c0b3e85977b0e795a57e23dea0f7c8252777ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120652 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-16rtl::Static->thread-safe staticNoel Grandin
Change-Id: I0f39dea1392eb2ba11881615aedbe386870282ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-16Use basegfx::deg2rad instead of *0.01745329251994Hossein
* Replaced multiplying by magic number 0.01745329251994 with basegfx::deg2rad() which is equal to M_PI/180.0 * Instances of this could be found using: git grep 0.01745329251994 *.cxx *.hxx Change-Id: Ib813251f6223e4218fe977c0211732c22199295d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125294 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-16tdf#135033: Make undo of adding and editing animations possibleKatarina Behrens
weird this somehow sneaked out when converting custom animation pane to sidebar when undoing other operations (delete etc.) stayed in place Change-Id: I6287682839d0e0401cc60bf82257d86765f3a858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125110 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-14tdf#145655 toggle on always-show-icon for animation panel 'add' buttonCaolán McNamara
Change-Id: If50d88f9c4a491f747ab0b39b50823cec92ccb27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12tdf#126605: sd: move UItest to CppUnittestXisco Fauli
Change-Id: I6c7da3f903199027cd7cb446bdc559fcc27b3828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125096 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-12uitest: sd: Add UItest for .uno:ExportToPDFXisco Fauli
Change-Id: I9ec7fd16c51c0240d041784d03aba687e07656ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125092 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-12coverity: annotate with markup so they will stay silencedCaolán McNamara
Change-Id: I8ac0ae4cd64d8171eebd98d89d1fe954280987b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-11Impress- Correct commands mentioning Page instead of SlideNnamani Ezinne
Replaced UNO commands that have similar implementation but their labels bear Page instead of Slide Change-Id: I5fb24493478b0a8fdd4e324066d8112497fc9eb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124888 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125047 Tested-by: Jenkins
2021-11-11Fix typo in commentMike Kaganski
Change-Id: I3eddb816734cd31f0d60344b51e8386c9a551ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124969 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-08use more OUStringLiteral in MediaDescriptorNoel Grandin
Change-Id: I0567d103db8db401c737fed98483912a39352929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-07forward decls go after #includeNoel Grandin
Change-Id: I54c33508639044092356eed5144720261b4f65db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-05tdf#111785: sd_export_tests-ooxml2: Add unittestXisco Fauli
Change-Id: I70bcc1855fc33ee3e6254ad620502bb4e72409d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124767 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-05use more DECL_DLLPRIVATE_STATIC_LINKNoel Grandin
to avoid unnecessarily exporting symbols Change-Id: I224848cea217977088fe0643511660a7c99b7277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-05use more DECL_DLLPRIVATE_LINKNoel Grandin
to avoid unnecessarily exporting symbols Change-Id: I6855894d0166c300ced169e36861f38811baa48d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-04tdf#114613: sd_uiimpress: Add unittestXisco Fauli
Change-Id: I8bace97c83f97a4b2aed8ca7fb99e51e06995b8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124719 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-04tdf#91060: sd_export_tests: Add unittestXisco Fauli
Change-Id: Idb9156fb1ab1cc9c9a59a50af85db174eeefc3b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124717 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-04tdf#144918 PPTX import: fix internal hyperlink on shapesTibor Nagy
Slide names in internal hyperlinks of shapes could be replaced with the placeholder name 'Slide n', resulting non-functioning hyperlink during the slideshow. Follow-up to commit 83d92437e05a9ec872d9303953fa408dd4dcbcde "tdf#144616 PPTX import: fix hyperlinks on shapes". Change-Id: I733ddcdcdf92b32c4e6272d3cf48da872a63cd47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124135 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-03tdf#144914 PPTX export: fix interactions and hyperlinks on shapesTibor Nagy
Follow-up to commit 83d92437e05a9ec872d9303953fa408dd4dcbcde "tdf#144616 PPTX import: fix hyperlinks on shapes" Change-Id: I56538da8d97e052af03c78e8d7eaa16c5c2fde1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123748 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-03tdf#141908: CppUnittests: replace usage of sal_Int32 with colorsRishav Chattopadhya
Change-Id: Idb078379c4388d7dd9525500e18064f2f873e6ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124091 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-11-03loplugin:finalclassesNoel Grandin
Change-Id: I80ac98249f8ef6b24939de59e32eda4fa2e79fba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124631 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-03Drop TWIPS_PER_PIXEL and use o3tl::convertMike Kaganski
Change-Id: I8ee3fddaccf6809c95319db1da9a1d2897d00c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124626 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-03loplugin:constparamsNoel Grandin
Change-Id: Iebeb531fad5cc819b536788925cf8508737198b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-02extract a ReorderingDropTarget for reuseCaolán McNamara
Change-Id: I0ae69bbf644e220e1bf3352d98eb4fd735167416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02Resolves: tdf#136945 fix custom slide show dnd to reorder pagesCaolán McNamara
Change-Id: Ib28d6779e772fd8ad30899354cde2c281085b328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124593 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktopHenrik Palomäki
Change-Id: I0b95ad5d1e46ed04717d7dccec7c6621b5d4d1e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124595 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-11-02tdf#136945 use ListStore instead of TreeStore to avoid dnd creating subnodesCaolán McNamara
because this just wants a flat list and a drop "on" a row shouldn't create a child of that row, but a sibling Change-Id: I0a6b360ffe13018d6878bd4bc3012ee3f5807a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31gtk[3 vs 4]: remove can-focus from GtkToolButtonCaolán McNamara
so tab-cycling inside sidebar panel toolbars works as wanted It needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-30Prepare for removal of non-const operator[] from Sequence in sdMike Kaganski
Change-Id: I82dc012188f846161beeb54901c2f5d298e5c3b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124385 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-30add SfxUnoFrameItem arg to indicate what frame sent this SfxRequestCaolán McNamara
Change-Id: I35b581e1ab66a5fbd9bd9c1034a5c8f22c0294e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-30sd: uitest: test "save to ODP as read-only with password protection"Xisco Fauli
Similar to the UItest added in 1b53c1dfc76f08ca7df40a0673aa50eca700d072 < tdf#144374 DOCX: export the password for editing > for the DOCX format Change-Id: I4e6914d5224ba051d68ffebaffcadaa16c8f349b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124445 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-27sd: split CppunitTest_sd_import_tests in twoXisco Fauli
it already has 118 tests and growing Change-Id: Ie1d657b2db245e11b147e0b7c9f83302fd3ef6d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124274 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-27sd_import: use a template for makefilesXisco Fauli
Change-Id: I52dcd19b6e5806cc1c0abe6ef3c78e1dce82dd68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124271 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-26uitest: rearrange tests to avoid "close_doc: no active frame"Xisco Fauli
Change-Id: I92bf81801797821c9ec4aa73c005f1d6c6f6da62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124182 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-26tdf#141908 - CppUnittests: replace usage of sal_Int32 with color4k5h1t
Change-Id: Iaff808a86a8b3ea8f760402faded81d8b8081ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121316 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-26Make sure that self-assign test checks typesMike Kaganski
This may be important with static empty sequence cppu::g_emptySeq, that is common for sequences of different types. The changes in sd/qa/unit/data/xml/*.xml fix places where anys with empty Sequence<OUString> used to wrongly take 'if(aAny >>= aPropSeq)' branch in dumpPropertyValueAsElement (drawinglayer/source/dumper/XShapeDumper.cxx). Change-Id: I5b0544ca94b30437c01dd46f376408f91510bcb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124167 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-31 02:33:08 +0000