summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-04-03weld SvPasteObjectDialogCaolán McNamara
Change-Id: I5248950fd3650df309015fbaf4302d2541a6374a Reviewed-on: https://gerrit.libreoffice.org/52337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-03new loplugin:dbgunhandledexceptionNoel Grandin
enforce that DBG_UNHANDLED_EXCEPTION is called first in a catch block, otherwise it cannot do it's job properly Change-Id: I906436c6861212c44f8f21552ccbceb54f15c6e1 Reviewed-on: https://gerrit.libreoffice.org/52303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-03NB: remove Notebookbar selection in calc and impressandreas kainz
Change-Id: I5295b106cbcb7fc344512b2db96aeb785ba85f46 Reviewed-on: https://gerrit.libreoffice.org/52300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-03Fix CppunitTest_sd_dialogs_testStephan Bergmann
Change-Id: I59538fa101cedc909fcb308c894e7b96db85c2eb
2018-04-03long->sal_Int32 in tools/gen.hxxNoel Grandin
which triggered a lot of changes in sw/ Change-Id: Ia2aa22ea3f76463a85ea077a411246fcfed00bf6 Reviewed-on: https://gerrit.libreoffice.org/48806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-03tdf#42949 Remove unnecessary localization headers from sdGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<sdresid.hxx\> -e \<strings.hrc\> sd | xargs grep -c SdResId | grep :0$ | grep -v /pch Change-Id: Ibcd9b8403c398ec205c9bcc2ed1f04a7ef6a37aa Reviewed-on: https://gerrit.libreoffice.org/52199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-03pass area param to DBG_UNHANDLED_EXCEPTIONNoel Grandin
and update sallogareas plugin to enforce this Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a Reviewed-on: https://gerrit.libreoffice.org/52249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-03vcl: use BitmapEx::Scale() where needed and SetSizePixel() elsewhereChris Sherlock
Change-Id: If4b2f3c209d1aefbe5756645d448c992387bae16 Reviewed-on: https://gerrit.libreoffice.org/52268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-02drop the spurious invisible_char[_set] propertiesCaolán McNamara
Change-Id: I8264a4f6035fd19c7a892902c41127615eaf6dd3 Reviewed-on: https://gerrit.libreoffice.org/52265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02weld Break dialogCaolán McNamara
Change-Id: I1657a02c775cf08e0888ba4cc9f9ae3b06550020 Reviewed-on: https://gerrit.libreoffice.org/52256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02tdf#115131 made a common submenu for toolbars and notebookbarsKshitij Pathania
Also added the submenu in base, maths and draw Change-Id: I94850c09c08fd3848eabe2597679634f30fbc735 Reviewed-on: https://gerrit.libreoffice.org/49575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-31loplugin:unusedfieldsNoel Grandin
Change-Id: Id2dea1d3a56d5d3be03c5a2a4f2ef530a05f9b19 Reviewed-on: https://gerrit.libreoffice.org/52185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-31RequestQueue::RemoveRequest should return bool if dbglevel >= 2himajin100000
Change-Id: Ie6120abf9c96cf4ba53111650a86fbf33418ac13 Reviewed-on: https://gerrit.libreoffice.org/52161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-30weld SvxCharacterMap dialogCaolán McNamara
and SmSymDefineDialog There's a whole bunch of interrelated stuff which needs to work at the same time. add menu support, keyboard support, better mouse support, a gtk scrollable adaptor to support pseudo scrolling drawing bodge, plugable uitest support for custom widgets, plugable a11y support for custom widgets via the existing atk_object_wrapper_new wrapper for XAccessible In this specific case, change SvxCharacterMap from something that has an internal scrollbar to a scrolledwindow where the scrollbar is external, which drops the need for the a11y impl of SvxCharacterMap to emulate being a scrolled window and internal table and just needs the table a11y impl Change-Id: Ia2743d6958021c525a1900154dcbb69ae33fc400 Reviewed-on: https://gerrit.libreoffice.org/52084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ic044a6e4568e707022d87bc5712205fbdf084ba2 Reviewed-on: https://gerrit.libreoffice.org/52067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: I7805ac9bc6f8c0aa5ba4804777e7d7c2c29a78f3 Reviewed-on: https://gerrit.libreoffice.org/52066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29coverity#1433646 Dereference after null checkCaolán McNamara
Change-Id: Ie3a352551a82656939c7d25b7f922a03b80d232b Reviewed-on: https://gerrit.libreoffice.org/52061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29coverity#1433644 silence Dereference after null checkCaolán McNamara
Change-Id: I699fb3e07d21dc1852c0d50d4a7d478bcf1d1a96 Reviewed-on: https://gerrit.libreoffice.org/52063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29loplugin:virtualdown in editengNoel Grandin
Change-Id: Id86a38521fe287a824bdda4b0fd2d68e97ae1b73 Reviewed-on: https://gerrit.libreoffice.org/52036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:virtualdown in vclNoel Grandin
Change-Id: Iea173295b7bc5e7f8a5e0215dc13ab32190c6f8f Reviewed-on: https://gerrit.libreoffice.org/51999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in sdiocmpt Change-Id: I39f05bcf7168fe9fbe6cf90b2499037ec5680cc5 Reviewed-on: https://gerrit.libreoffice.org/51806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28Translate German function namesJohnny_M
Akt -> Current in ppt filter Change-Id: Id32efb885e5e1b04c7fd8f3ce0f21537b2e7576c Reviewed-on: https://gerrit.libreoffice.org/51800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28loplugin:virtualdown in sc..sdNoel Grandin
Change-Id: If93dc12f484839e6d2b44d6568b506f0c15b4735 Reviewed-on: https://gerrit.libreoffice.org/51989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28tdf#115005: New option to prevent adding fallback imagesSerge Krot
A new option AddReplacementImages was added to prevent addition of fallback images that could increase the file size of the package in several times. Added unit test. Change-Id: I50eebba51072d3c93bfe6bed59e9f007568810c0 Reviewed-on: https://gerrit.libreoffice.org/51939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-27tdf#116438:Apps should ask if rotation should be appliedhimajin100000
For Calc,Draw,Impress. Writer already does this. Change-Id: I92512719673fb39a973b8a68378e93f30d82c327 Reviewed-on: https://gerrit.libreoffice.org/51447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-27loplugin:expressionalwayszero improvementsNoel Grandin
Change-Id: I00bdbc58d2295a0be30b47c85eae6b9abfec17b2 Reviewed-on: https://gerrit.libreoffice.org/51868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-26loplugin:useuniqueptr in OutlineViewShell and ViewShellNoel Grandin
Change-Id: Ia40444b4ba3c8b02d195d979ff6d84cfe4d8b44e Reviewed-on: https://gerrit.libreoffice.org/51845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25tdf#116544 crash on unhandled IllegalArgument exceptionCaolán McNamara
Change-Id: I290ba6097d6d91bf4677e7e92c896bd6359cbc49 Reviewed-on: https://gerrit.libreoffice.org/51833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23loplugin:useuniqueptr in PPTWriterNoel Grandin
Change-Id: I5c099e97d51808d2dcaf6d1385d1e3cab2e2ddf2 Reviewed-on: https://gerrit.libreoffice.org/51762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23loplugin:useuniqueptr in PPTExStyleSheetNoel Grandin
Change-Id: Ib830a1be4f840c06ebda9830351d82ad31706be1 Reviewed-on: https://gerrit.libreoffice.org/51738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23Typo: GetSelectItemId -> GetSelectedItemIdSamuel Mehrbrodt
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b Reviewed-on: https://gerrit.libreoffice.org/51750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectLanguage -> GetSelectedLanguageSamuel Mehrbrodt
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2 Reviewed-on: https://gerrit.libreoffice.org/51747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23loplugin:useuniqueptr in OutlineViewNoel Grandin
Change-Id: I6da98d8634076826cfdbe8d77fa72cb2b99ffe84 Reviewed-on: https://gerrit.libreoffice.org/51672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in DrawDocShellNoel Grandin
Change-Id: I051fb0523622ef2ab93639f0d28b4dc5f4efdbac Reviewed-on: https://gerrit.libreoffice.org/51671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in SdTransferableNoel Grandin
Change-Id: I7ace5ab37ce6df240d3b7fbe8c0fd12618fa3031 Reviewed-on: https://gerrit.libreoffice.org/51669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in DrawViewShellNoel Grandin
Change-Id: I5125e973fbda75b2c7e52e294db74bc3bd5e0bd9 Reviewed-on: https://gerrit.libreoffice.org/51662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22loplugin:useuniqueptr in PresenterTextView::ImplementationNoel Grandin
Change-Id: Ie5641d3a4b0791aa4ae4f126afeb3ec6f9760909 Reviewed-on: https://gerrit.libreoffice.org/51661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20Exclude a redundant variableMike Kaganski
Change-Id: I0a7d6a7068155259313408e8d8e61f72af705cc6 Reviewed-on: https://gerrit.libreoffice.org/51647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20drop unnecessary includesCaolán McNamara
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20Speed up SdPage comparisonMike Kaganski
Move trivial comparisons to front; return early on object comparison Change-Id: I4db927ac87dbb165e80b70046ff44a260b8a504b Reviewed-on: https://gerrit.libreoffice.org/51624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20tdf#115005 Do not remove original vector images from slidesSerge Krot
During calculation of the quality index of the image, we should take into account also SVM vector image type. Its mime type is image/x-vclgraphic. Change-Id: I7c723e99995f73258bb59d976a6c7670c51f7a25 Reviewed-on: https://gerrit.libreoffice.org/51599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-19coverity#1430077 add assert for 'Division or modulo by zero'Caolán McNamara
and coverity#1430076 Division or modulo by zero coverity#1430078 Division or modulo by float zero coverity#1430082 Division or modulo by float zero coverity#1430083 Division or modulo by zero coverity#1430085 Division or modulo by zero coverity#1430102 Division or modulo by zero coverity#1430103 Division or modulo by zero Change-Id: I9d7190f95d19a755c681f1f897a8921105ef7c46 Reviewed-on: https://gerrit.libreoffice.org/51568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19tdf#116364: Revert "tdf#113660: show Master Slide label in handout view"Xisco Faulí
This reverts commit 605b01dc591eaa72788be255baf1f9b9dde76414. Change-Id: I99a2de6a425b1ecd2e9059a9867adac3fc75e619 Reviewed-on: https://gerrit.libreoffice.org/51403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-03-19sd: fix incorrect visible center calculationPranav Kant
Don't call PixelToLogic twice. Thanks Ashod for noticing. Change-Id: Id280dad7e310ceaf8678f900e6e70214848dd925 Reviewed-on: https://gerrit.libreoffice.org/51529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-17tdf#84205 If theme not found, use firstSzymon Kłos
Not a complete fix, workaround. Change-Id: If4d765eaeae3419f4f1deb4e1cfbe0113a71da94 Reviewed-on: https://gerrit.libreoffice.org/51440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-17sd lok: Enable mapmode in case of lok to calculate centerPranav Kant
This reverts the solution in 9fee132c18b658c9ea9fb1114c1fefa56b57532a. Also, calculate center using the new function for chart, image, and text shape insertion. Change-Id: Ie893050b7c875760db0194e7a3f0c2cd3068963b Reviewed-on: https://gerrit.libreoffice.org/51343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-17sd lok: Set the view size to full page size + fix unit testsPranav Kant
... such that during insertion of objects when sd calculates the center of the view to place the object, it is the center of the whole slide, not the center of the default rectangle of 800x600. It's also important to hide rulers, scrollbars so that correct center is calculated; we don't need them anyways in LOK. Change-Id: I2d1577bc963d324959b272ed3174571ab197d014 Reviewed-on: https://gerrit.libreoffice.org/51416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SvUnoWeakContainerNoel Grandin
just use a std::vector here, these are small objects, no need to allocate them separately Change-Id: Ie9f8df88eb7c291e2c99177d0f5e4bfc1c7ab542 Reviewed-on: https://gerrit.libreoffice.org/51415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-31 01:25:44 +0000