summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2022-01-14make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin
(*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-12used cache value in ViewObjectContact::getPrimitive2DSequence (2nd attempt)Noel Grandin
Rely on the cached primitives in VOC. But only enable it for calc and draw right now, by adding a flag at the SdrModel level. This way we can leave it disabled for writer, where it definitely doesn't work. Change-Id: I11ca4836eb773c0f078cdb82056c6e0309d15a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-12gbuild: build static LO / link static executablesJan-Marek Glogowski
This allows to build a complete static LibreOffice on Linux, except for linked externals. Since LO's static build implies disabled dynamic loading, one must select one VCL backend to be compiled in. See the (large) comment in solenv/gbuild/static.mk trying to explain, why this implementation was chosen (spoiler: seems there is no other way) and what is actually implemented. This will collect all libraries, statics and externals of executables. If the executable uses components, it will get linked to all static components. While it works with any Executable, it just makes sense for soffice.bin, because the static component map sucks every dependency in, bloating most other binaries. In theory on could generate the dependencies based on the list of used components (see gb_CppunitTest_use_components), then generate a specific static constructor map, directly include it in the exe's cxx code and then link the minimal dependencies. The static LO should build on Linux with: --enable-customtarget-components --disable-dynamic-loading Tested VCL plugin config is: --disable-gtk3 --disable-gen --enable-qt5 The partial build support is split into a 2nd patch. Change-Id: Iafc95752fae9e88095f54a21f1e30a4f080815e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126790 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12Fix typosAndrea Gelmini
Change-Id: Ib132f2582fce1fb62755926d3f55987ea474ec74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128297 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-10document GenericCheckDialog, GraphicSizeCheck and related classesTomaž Vajngerl
Change-Id: If3f8c33601f7823c87b75d601e0b8620d4bfe197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128205 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06It's called a slide, not a foilTor Lillqvist
Change-Id: I8b5b062faf9d2728c729384bbdafead00d5bf917 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128042 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-01-06ofz#42785 TimeoutCaolán McNamara
Stream::Seek (like istream::seekg) clears any eofbit Change-Id: I90253e69a52c4099aa2971294a215dff37e8a246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127975 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-06tdf#135843 Fix the missing border handlingGülşah Köse
Adding +1 at that stage causes indexoutofbounds. But never throws that exception and tries to pull empty cell style instead. As a result we can not see the border. Actually no idea why +1 used here. Change-Id: Id54ba6445d022540173af3bbf5d679b7edefc55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127990 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-01-05tdf#146499 Crash to desktop when activating presentation modeNoel Grandin
mutex deadlock, regression from commit 62efb188668a3296591dcfa3658185e2f982e356 use comphelper::WeakComponentImplHelper in SlideShowView Change-Id: I1822d4beffaa44be7f789db4bd0f5a25d1896396 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-05tdf#146534 pptx import: make Z rotation work with rotation transformSarper Akdemir
Expands previous idea from a9c5c0d814a266096483572b84c72875ef8efd77 (tdf#133037 OOXML shape import: camera rotation along Z) and uses it also for shapes that have a true bUseRotationTransform flag Also fixes same Z rotation exporting twice from InteropGrabBag to both spPr and textBody causing text overrotating on roundtrip. Change-Id: If0f192af029ca86b932a63613f961be1f5003c5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127880 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-04Revert "use comphelper::WeakComponentImplHelper in AccessibleSlideSorterView"Miklos Vajna
This reverts commit 2d541dedde4ec516eacd7669bdc3ed8fb6fc2548. It switched to a non-recursive mutex in AccessibleSlideSorterView, which now deadlocks regularly when opening Impress documents: #0 0x00007ffff65b5de3 in __lll_lock_wait () at /lib64/libpthread.so.0 #1 0x00007ffff65ae301 in pthread_mutex_lock () at /lib64/libpthread.so.0 #2 0x00007fffcdac12ed in __gthread_mutex_lock(__gthread_mutex_t*) (__mutex=0x5646c40) at /usr/include/c++/7/x86_64-suse-linux/bits/gthr-default.h:748 #3 0x00007fffcdac2f40 in std::mutex::lock() (this=0x5646c40) at /usr/include/c++/7/bits/std_mutex.h:103 #4 0x00007fffcdac3fcf in std::unique_lock<std::mutex>::lock() (this=0x7fffffffb980) at /usr/include/c++/7/bits/std_mutex.h:267 #5 0x00007fffcdac3c86 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7fffffffb980, __m=...) at /usr/include/c++/7/bits/std_mutex.h:197 #6 0x00007fffcdac514b in accessibility::AccessibleSlideSorterView::getAccessibleChildCount() (this=0x5646c10) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:200 #7 0x00007fffdce577c3 in AtkListener::updateChildList(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> const&) (this=0x5647130, pContext=uno::Reference to (class accessibility::AccessibleSlideSorterView *) 0x5646c88) at vcl/unx/gtk3/a11y/atklistener.cxx:149 #8 0x00007fffdce579e0 in AtkListener::handleChildAdded(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> const&, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&) (this=0x5647130, rxParent=uno::Reference to (class accessibility::AccessibleSlideSorterView *) 0x5646c88, rxAccessible=uno::Reference to (class accessibility::AccessibleSlideSorterObject *) 0x42d3698) at vcl/unx/gtk3/a11y/atklistener.cxx:178 #9 0x00007fffdce5806e in AtkListener::notifyEvent(com::sun::star::accessibility::AccessibleEventObject const&) (this=0x5647130, aEvent=...) at vcl/unx/gtk3/a11y/atklistener.cxx:441 #10 0x00007ffff4fef0d5 in comphelper::AccessibleEventNotifier::addEvent(unsigned int, com::sun::star::accessibility::AccessibleEventObject const&) (_nClient=44, _rEvent=...) at comphelper/source/misc/accessibleeventnotifier.cxx:262 #11 0x00007fffcdac4df2 in accessibility::AccessibleSlideSorterView::FireAccessibleEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) (this=0x5646c10, nEventId=7, rOldValue=uno::Any(void), rNewValue=uno::Any("com.sun.star.accessibility.XAccessible": {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x42d3698}, <No data fields>})) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:148 #12 0x00007fffcdac7bf0 in accessibility::AccessibleSlideSorterView::Implementation::GetAccessibleChild(int) (this=0x5646ce0, nIndex=1) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:746 #13 0x00007fffcdac79ca in accessibility::AccessibleSlideSorterView::Implementation::GetVisibleChild(int) (this=0x5646ce0, nIndex=1) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:725 #14 0x00007fffcdac529d in accessibility::AccessibleSlideSorterView::getAccessibleChild(int) (this=0x5646c10, nIndex=1) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:213 The problem is that both getAccessibleChild() and getAccessibleChildCount() take a lock, so this requires a resursive mutex for now. Change-Id: I32205d19451d86e112922e3194661cce2406f70a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127946 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-01-03tdf#127696 PPTX export: fix lost outline character formattingTünde Tóth
Now outline font property export is supported partially in PPTX export and in text shape export in other OOXML formats. Note: OOXML/MSO has customizable Text Fill and Text Outline in Format Text Effects, while LO has only simple and buggy outline character formatting property, showing only white or completely transparent outline fill color. Transparency issues and the buggy outline font handling of LO (e.g. 1% font color (line) transparency results 100% fill transparency of the outline text) haven't been handled yet. Change-Id: Ic34bce4efd4a544d799b1d89af1107c4918061d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126996 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-03tdf#146223 PPTX import: fix master objects visible propertyTibor Nagy
Master objects were always visible after the import, which could change the background of the slides. Change-Id: Idc5260718f2916e207f751286044e9a7fabdee89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126833 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-01-02loplugin:unusedfieldsNoel Grandin
Change-Id: I20a387563a0f65bc9a7149ab0b08b09f1946e9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127867 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in PresentationFactoryProviderNoel Grandin
Change-Id: Iab203714c4b500b064e8fab568cd3cebf0037fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in CenterViewFocusModuleNoel Grandin
Change-Id: Ia326a78c3f96ac213a3d729e3c1deafc04f70ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29lok: hide useless insert image button in sidebarSzymon Kłos
do this also in draw, not only in impress Change-Id: Iaaf2349cfb98b801957b71bd4504f0e9efbfba4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124840 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124902 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127669 Tested-by: Jenkins
2021-12-29flatten ModuleController a littleNoel Grandin
no need to allocate these maps separately Change-Id: If83f6540933716ab720778740a1e20f0bb14fd7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in PresenterCustomSpriteNoel Grandin
Change-Id: I4d85620cc189fb918d0b52a569f8612c51a39f2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in PresentationFactoryNoel Grandin
Change-Id: Iff8c17951e3d17c280f47211432ee619ff188ea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in sd::SlideShowNoel Grandin
Change-Id: I40f53eb70decec86564b658c3a0ebec5b44d14fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in sd::DocumentRendererNoel Grandin
Change-Id: I0eea3b1cd1e4b9a83d2227c48c687827adbb0218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in CallbackCallerNoel Grandin
Change-Id: I98844120f2cf6b1137a781b6401bcd45859b0689 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127656 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in SlotStateListenerNoel Grandin
Change-Id: I36c95472aeff208dd5f1e68c5b398635a5bfad53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in FrameworkHelper::DisposeListenerNoel Grandin
Change-Id: Ie044a38af7d65b57e7b0ce15590dc6f6cb20ce2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in SlideSorterModuleNoel Grandin
Change-Id: I5acc47ba25c9dd293a21e4d634fc82eb239a7b06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in ViewShellWrapperNoel Grandin
Change-Id: I4684fb5ab74afb8dd8d7debe9e1ed9dceb9021e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in ModuleControllerNoel Grandin
Change-Id: I58e716a67509560b405c6e613e0700f46a59462b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in sd::framework::ConfigurationNoel Grandin
Change-Id: Ib86f6da9dabac4cec43d7ee53de56972b2301c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in ViewTabBarNoel Grandin
Change-Id: If64cb90586532ee20321cfbf3dd634781a9d9a9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127651 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in AccessibleSlideSorterViewNoel Grandin
Change-Id: Id8e49fde253fd79eeae142d9fd7069fd8c3a9035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in LifetimeControllerNoel Grandin
Change-Id: Id3d9e766fbe2f3707946c0ac2f1c25319685c515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in ViewTabBarModuleNoel Grandin
Change-Id: Ie3c5f2f868cf68f2701c3cbd4bf0091894c901d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in ToolBarModuleNoel Grandin
Change-Id: I98caacf7ea4d994d81927e9dba6e4d46f0057f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in PresenterHelperNoel Grandin
Change-Id: I56eb9e0dc3730e2ad0af946bfe3f9494f6ff8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in PresenterPreviewCacheNoel Grandin
Change-Id: I23537d6050a4055c1d06b227722a6f6991f245cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127635 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in SlideRendererNoel Grandin
Change-Id: I0372899c0f1f7c9c0090e7a2392c152f6606e688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127634 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in sd::ListenerNoel Grandin
Change-Id: I55ae2617b7464fa2b0cad0ad53e660dee704805c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in SlideshowImplNoel Grandin
Change-Id: I5adfe14dfb6d466f288c4ab665aa1642d8fd175f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127632 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28inline SlideShowView::initNoel Grandin
only called from one spot Change-Id: Ib1351d91f8949c60b4c4a909e5b0672e4ac3f0f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28no need to allocate these separately in SlideShowViewNoel Grandin
Change-Id: Ibbcdd0469b9b8c7ed7385206af40e751fe039f71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127606 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in SlideShowViewNoel Grandin
Change-Id: I61c82bf27764d1743181b94f89981dc9f03849e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127605 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in sd::sidebar::PanelFactoryNoel Grandin
Change-Id: Icb6cb535e0b4447635aeeb77079465d2033b6a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in sd..controller::ListenerNoel Grandin
Change-Id: Idecb4bc7bf3516464ff6bd637a5c9b3bfa06ea9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in SlideSorterServiceNoel Grandin
Change-Id: Ic1fbe40e5dd3795d2fb8680772e0a0073b408710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-28use comphelper::WeakComponentImplHelper in EventMultiplexerNoel Grandin
Change-Id: I0941e4b4beb1e549453f3a94e246160aaf63e1e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27use comphelper::WeakComponentImplHelper in ShellStackGuardNoel Grandin
Change-Id: Ibb771041d60512ee0ca2201ecf810d0703a47884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27use comphelper::WeakComponentImplHelper in AccessibleSlideSorterObjectNoel Grandin
Change-Id: I18a77111cf8285d5b66ce400624fa417fefc9e4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127563 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-27remove incorrect SolarMutexGuardNoel Grandin
we are not calling anything that needs the SolarMutex here, and all the other places that touch mnClientId are just using the local mutex, which is already locked when we call here. Change-Id: I5905db1f413051966461ea3a6b75d24360903ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-03 16:45:25 +0000