summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-02-24drop an unneeded includeCaolán McNamara
Change-Id: I086036cf19b7e011da17ab5767460ac3e10eab2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24drop unneeded includeCaolán McNamara
Change-Id: I1a5a0f7b799f332d9f1d43ad50c8a6d924c71cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111494 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23loplugin:unusedmethodsNoel
Change-Id: Ie0534244cc7a30ad006e65baf125c59757c90d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23loplugin:unusedfieldsNoel
Change-Id: Ieb1b890040964e755de5bdf5f8576d4d3bd8a407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111386 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23weld fieldmenuCaolán McNamara
Change-Id: I37a1609669631fdafcb4dea59a2a43c1c94e16e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111380 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23replace SdTemplatePopup_ImplCaolán McNamara
Change-Id: I734124939139e34c776e5e4fe52acde08abf24ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23update pchesCaolán McNamara
Change-Id: I44424081b7f55710c4db7f10d1829de1ae08be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111363 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-21loplugin:refcounting in sdNoel
Change-Id: Ic95aa7a3c1fdab1baef744ec85ffc9c98dee5f1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20Add unittest for tdf#123841 Unfilled rectangles make filled rectanglesmsrijita18
Change-Id: Ic429ab5aa21102a44c9a559438bf3659a9d9137c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110849 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-20loplugin:refcounting in svxNoel
Change-Id: I79afd219a29ad176ce72020579d2b29a0b3ec09d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20drop some unneeded includesCaolán McNamara
Change-Id: I0fe18c3e535bee2213606b7189778c40403a97ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20loplugin:refcounting in svlNoel
Change-Id: Iae192caa9d05f71ce02aae966ef1d71232d1a7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19uitest: remove duplicated testsXisco Fauli
The document properties dialog's code is the same for the three components, no need to test the same things in three different places Change-Id: I26effca2093fdf6c5a98c641c03b7c1b5205838f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-19weld slidecontextmenuCaolán McNamara
Change-Id: I7777a3fea3ddf920c45daa244826dffb7effa58c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111238 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19ignore "fake" keypress in slideshowCaolán McNamara
where the fake keypress is needed to workaround https://gitlab.gnome.org/GNOME/gtk/issues/1785 which exists as a problem in gtk < 3.24 Change-Id: If8cdd536668f515327ab8fc11033e5f9c6e56a35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111237 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19weld MasterPagesSelector context menusCaolán McNamara
Change-Id: I0ed933d81ef8f5004c8efa36dd0cdcdca947a0a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111233 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19RecentMasterPagesSelector menu has no "edit" entryCaolán McNamara
its the same menu as MasterPagesSelector and the same "large" vs "small" enable/disable logic should be in use Change-Id: I3672c47299d585fbcec6fa2000fc0c84d6481ce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19update pchesCaolán McNamara
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19foward declare NotebookBarAddonsItem instead of using includeCaolán McNamara
Change-Id: I57e5a8f28a40994b61ab0f554401e4f70c8ffc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19rename get_vscroll_width to get_scroll_thicknessCaolán McNamara
and add split customize_scrollbars to form a separate set_scroll_thickness Change-Id: Ia4b1c85d6ae85b0fb7aeb852d3a91b36b63143db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-19Fix typoAndrea Gelmini
Change-Id: Ia84a41df2359180ddd615aeb5ea6c9915e311e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111154 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-02-18Better fix for tdf#125824: switch page only for the current view.Tamás Zolnai
First workaround was avoiding undoing: 9dca7c2fac5c6b83a6910aa61b1a2a316f36d948 Second workaround was forcing all views to exit text editing: e6c7a018a0cfee395ce2886d41c908a2447ef5cc Instead of these solutions, we allow to continue text editing in other views. What we do is avoiding jumping to the object location in all views while undoing. In theory, the two views / windows should be able to edit the document's different parts independently. So one view should not jump to the location where the other view edits something / does an undo. It works both with multi-window and Collabora Online's collaborative editing. Change-Id: I7ffe29bf175b8f855fe3e92b3d7e11ca6bcd3f5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111073 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 7db8c3d36db3ed727ade2609b7c1017cc813a560) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111112 Tested-by: Jenkins
2021-02-17tdf#106612: sd: Add UItestXisco Fauli
Change-Id: I5364f963207fc9aa23ea133e3a0861b6e5f7455d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111063 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-17tdf#128213 Add unit test for text camera z rotation.Gülşah Köse
Change-Id: I50dab62ba1013d4ae17684edde620f9c94c5ec47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111028 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-17tdf#82616: sd: Add UItestXisco Fauli
Change-Id: I84c148f98517cd4f7cb07f268b71bf2ac7e18322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111031 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16tdf#139511: sd: Add UItestXisco Fauli
Change-Id: I21bd6c0643333cdf98d65b3fa3f141dc6ddfa937 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110982 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16tdf#140387 grab focus to first panel widget on panel gaining focusCaolán McNamara
otherwise focus is getting lost in these currently mixed vcl+gtk widget panels. Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-15loplugin:referencecasting in sdNoel
Change-Id: I3d5e0fd3f9d8ea61aad5846a0ee19568a5d365a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-14Move unit conversion code to o3tl, and unify on that in more placesMike Kaganski
This also allows to easily add more units, both of length and for other unit categories. The conversion for "Line" unit (312 twip) is questionable. Corresponding entries in aImplFactor in vcl/source/control/field.cxx were inconsistent (45/11 in; 10/13 pc; 156/10 pt). They were added without explanation in commit c85db626029fd8a5e0dfcb312937279df32339a0. I haven't found a spec of the unit (https://en.wikipedia.org/wiki/Line_(unit) is not specific). I used the definition based on "by pt", "by mm/100", "by char" (they all were consistent); "by pc" seems inverted; "by twip" was half as much. This accepted conversion makes unit test for tdf#79236 pass. Change-Id: Iae5a21d915fa8e934a1f47f8ba9f6df03b79a9fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110839 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-13rename Ruler::GetType to drop using Window::GetTypeCaolán McNamara
Change-Id: I78da4bb35f5f3e7253737ddc3be1460fbf605ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110831 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-13tdf#137406 removed Apply to Master button in Slide Master modeGokce Kuler
Change-Id: Ic19c38a5e6e561cae45cd0a40cfe56d7002efe9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110835 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-13Related: tdf#62688 support Ctrl+A to select all in impress commentsCaolán McNamara
Change-Id: Ic8e052752e333202cb44719a85ae949c85b735e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110823 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-12drop unnecessary includeCaolán McNamara
Change-Id: I09837025e60d240b85515d9355ddd42f1d4e94d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-12weld impress annotation windowCaolán McNamara
Change-Id: Idc89f4e382392103d373b6a84edaae10abd56056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-12Fix typoAndrea Gelmini
Change-Id: Ic97185ff3e243ae60814b562278a90661521d6ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110794 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-02-11uitest: sd: Add support for sidebar uiobjectXisco Fauli
Change-Id: I2074afebbb3a6dfe098af0e447807663682b56a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107782 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-11tdf#134210 Better testing for cropping bitmap of custom shape.Gülşah Köse
Change-Id: I592e2e99306a4aa27dce17e8b8d75e4bb2262cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110723 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-11devtools: move devtools from svx to sfx2Tomaž Vajngerl
It's a better suited location for devtools as we can access the classes when we handle the .uno:DevelopmentToolsDockingWindow event. Change-Id: I753ca56808804c9cf6713920f92cd7d313f1f156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110733 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-11fix spelling MakeBlancPage->MakeBlankPageNoel Grandin
Change-Id: Id1f37e25473e480ba4ae219e0ed64324ce73852a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10uitest: sd: check embedded document is open in a new dialogXisco Fauli
Change-Id: Ie2e9e7c9f97fba5f4bb8915098e61f86947197fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110702 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-10tdf#134210 Handle greyscale effect on bitmap filled custom shapes.Gülşah Köse
Change-Id: Ia4a0828dad80e32cc0c7fe12227ffca717d62e03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110572 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10tdf#134210 Import crop position of bitmap filled shape.Gülşah Köse
Change-Id: I6a62d68cd0f57e53934851a2f53dae05bf7d3730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110262 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-08update pchesCaolán McNamara
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-08Improve loplugin:cppunitassertequal for CPPUNIT_ASSERT(a && b)Stephan Bergmann
...by re-enabling the code temporarily #if'ed-out in a528392e71bc70136021be4e3d83732fccbb885e "Fixed/improved loplugin:cppunitassertequals" (and which then triggers lots of other lopglugin:cppunitassertequal CPPUNIT_ASSERT -> CPPUNIT_ASSERT_EQUAL warnings). For two css::uno::Reference equality comparisons in cppu/qa/test_any.cxx, it was more straightforward to rewrite them with an explicit call to operator == (which silences loplugin:cppunitassertequal) than to adapt them to CPPUNIT_ASSERT_EQUAL's requirement for arguments of identical types. In sc/qa/unit/ucalc_pivottable.cxx, ScDPItemData needs toString, which has been implemented trivially for now, but might want to combine that with the DEBUG_PIVOT_TABLE-only ScDPItemData::Dump. Change-Id: Iae6d09cf69bd4e52fe4411bba9e50c48e696291c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110546 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-06Use more conversion functions from <tools/UnitConversion.hxx>Mike Kaganski
This unifies conversion functions to provide both floating-point and integral overloads, with correct rounding for the latter. Also sanitizing code it templatized to allow reuse if needed. Change-Id: Ibe1c9fe4d5baa226c600445779dbaf7dc41a02cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110487 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-04Fix typoAndrea Gelmini
Change-Id: I7cc5e98fe967da00228c1540ac28a0074e6d5e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110344 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-02-04use more getSdrObjectFromXShapeNoel
Change-Id: Ia237643ab040425f231f781c86e7e060f0b53717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-03tdf#124708: sd_uiimpress: Add unittestXisco Fauli
Change-Id: I82e045af25924179b69e427439bcdbe6a11163b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110347 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-02verbs can be sal_Int32 instead of tools::LongCaolán McNamara
Change-Id: I51c88b837928760c72b77de1535f7843b4fd575e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-02use css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY instead of bare 0Caolán McNamara
Change-Id: I3fb67bcdaa27159790d36100f897efa7d43856ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-08 05:07:08 +0000