summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14Use = for initializationStephan Bergmann
...so that an automatic loplugin:cstylecast rewrite (with a to-be-committed enhanced loplugin) won't rewrite that to -Werror,-Wvexing-parse al_Int16 nTmp( sal_Int16(style::ParagraphAdjust_LEFT) ); Change-Id: I27a8b8fea129f9f1d755499bf204a7c8f2b35976 Reviewed-on: https://gerrit.libreoffice.org/47868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-14change testN821567 to work on more import/export filtersTomaž Vajngerl
- rename the test to something sensible - comment the test use case - change the test to cover more import/export filters Change-Id: Ib9be1148d239d99e70e62efaafb69daf25c72164 Reviewed-on: https://gerrit.libreoffice.org/47852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-12ofz#5274 Out-of-memoryCaolán McNamara
Change-Id: I3e69f5e2be848933a43d09c620dafd946486e731
2018-01-12More loplugin:cstylecast: sdStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I144975b94fe2725ac740a953ca2133e99f8a3fce
2018-01-11loplugin:redundantcast: sdStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: I1dc10a2acaf134a3cff142a4ec4afc906b88c260
2018-01-11Fix Tab key cycle through slide background panelKatarina Behrens
Remove empty widget container, lot of garbage placeholders and redundant adjustment. Regression from commit fba28df77d7e98663d1cf77ac206f8799fce4108 Oh dear, how could I possibly have reviewed this in? Change-Id: I25af642afad094faba5b0ba1e37cfbf1a954e52f Reviewed-on: https://gerrit.libreoffice.org/47720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-07UI Duplicate dlg: enable negative angleLaurent BP
Duplicate dlg (Shift+F3) should accept negative angle and angle between 359° and 360° Change-Id: I933816698143a9766a5127f3cefeaec317077289 Reviewed-on: https://gerrit.libreoffice.org/47393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-07tdf#113880 improve slide transition sidebar deckYousuf Philips
* added padding around transition list control * make controls in 'modify transition' accessible * correct alignment of variant label Change-Id: I129e387be1458b7f08fab7f460d9ae60cd5dd391 Reviewed-on: https://gerrit.libreoffice.org/47320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-06tdf#114848 Don't save empty themesSzymon Kłos
Change-Id: I7136f5c0bc884a2f9ea945b4e0bc093a5ef2d8df Reviewed-on: https://gerrit.libreoffice.org/47481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-01-06remove unused definesNoel Grandin
In particular, the STR_SVT_MIMETYPE defines are dead since commit 1b694dad643334ec1bab3f823dcd68f44a05ebe3 Date: Thu Aug 24 22:14:27 2017 +0200 loplugin:unusedmethods Change-Id: I641ec0a14efedc55c9d6a4de4a28784c273602e9 Reviewed-on: https://gerrit.libreoffice.org/47464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05lokdialog: Allow language switching in SfxModule(s).Jan Holesovsky
Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b Reviewed-on: https://gerrit.libreoffice.org/47385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-04ofz#4943 Direct-leakCaolán McNamara
Change-Id: I45b7c6befadda58d7919732597647b9e2cbd46d8 Reviewed-on: https://gerrit.libreoffice.org/47373 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-04drop Cache typedefNoel Grandin
Change-Id: Id1c568f7d089c345643227a6e9d0fee09aabfab8 Reviewed-on: https://gerrit.libreoffice.org/47345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03loplugin:passstuffbyref more return improvementsNoel Grandin
slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02loplugin:passstuffbyref improved return in sd,variousNoel Grandin
Change-Id: I4b6ea89ae2072f4389a696ea3c96d8f7a5731e7a Reviewed-on: https://gerrit.libreoffice.org/47246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02RID_* can be extern global variablesNoel Grandin
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: https://gerrit.libreoffice.org/47245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02Fix typosAndrea Gelmini
Change-Id: If8f042c6ef02c204f8946900e9ea8b99f06a631c Reviewed-on: https://gerrit.libreoffice.org/47240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-31tdf#114045 do not add undo action for table attributesMark Hung
CreateUndoAttrObject() create extra undo steps when using table paint brush on table cells. Undo action for each selected cell is processed individually in SvxTableController::ApplyFormatPaintBrush(). Change-Id: I65034a2b510898db26a7a8ddc4b5f3b742fd9b88 Reviewed-on: https://gerrit.libreoffice.org/46729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-12-30tdf#90626 PPTX: Fix image bullet position in PPTPaul Trojahn
Scaled bullet points aren't centered in PPT, so padding needs to be added to get them to the correct position. Change-Id: I61509dd43ef9cd697dcbc3cabbf58a21d625ddec Reviewed-on: https://gerrit.libreoffice.org/46994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-29loplugin:unnecessaryparen improve return checkNoel Grandin
Change-Id: I8128aa4b5fc60efd1dbf5971cdde11e588f5f64b Reviewed-on: https://gerrit.libreoffice.org/47167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I0e56430afa65b6b5826d56212ac501c0244fce9b Reviewed-on: https://gerrit.libreoffice.org/47145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-27tdf#109100: Hide label for margin control in ImpressAron Budea
Change-Id: Ib61656913df673ebfde61e2c921f84cb81195a3b Reviewed-on: https://gerrit.libreoffice.org/46974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-27delete operators properlyJochen Nitschke
Change-Id: Ia917b70712717387aa8d7a17334efd41931bdb88 Reviewed-on: https://gerrit.libreoffice.org/47087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-25various coverity exception warningsCaolán McNamara
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23tdf#95827 Reorganize draw's menu barYousuf Philips
Change-Id: Ied9be2da293e6d318548019e29ae4f95e568144a Reviewed-on: https://gerrit.libreoffice.org/46867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-22Revert "unused SID command in sd"Noel Grandin
This reverts commit 46db544b41fd30f61dd7b7b4fa2b97ab22ceb079. Change-Id: I8eed13269000a7fc4c52c1695e36df8607b470ac Reviewed-on: https://gerrit.libreoffice.org/46965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21unused SID command in sdNoel Grandin
Change-Id: I88f207d86bf8d92036f5cc286bf7ab260adea306 Reviewed-on: https://gerrit.libreoffice.org/46887 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21Correct impress slide pane popup Navigate labelYousuf Philips
Change-Id: Idd582e4559cd6bd1005de0d8158e57d40ddd3c98 Reviewed-on: https://gerrit.libreoffice.org/46903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-21TypedWhichId in svx part 2Noel Grandin
Change-Id: Id927679c9f07f1dd820f4fdca9a45eb7aede037c Reviewed-on: https://gerrit.libreoffice.org/46850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21Fix typosAndrea Gelmini
Change-Id: I5c6e252072089a06f0be4292d51aed020cbc67fe Reviewed-on: https://gerrit.libreoffice.org/46888 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-20tdf#79077: Load/save PapersizeFromSetup bit into ODF for sdKatarina Behrens
Change-Id: Ibf9ae8229b62cbcbdb8f56e7353301745a12ef5b Reviewed-on: https://gerrit.libreoffice.org/45322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-19remove unused typedefsNoel Grandin
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Fix typosAndrea Gelmini
Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f Reviewed-on: https://gerrit.libreoffice.org/46599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-18convert SVX_GRAPHICFILTER constants to scoped enumNoel Grandin
Change-Id: I220a2cfe9ea9ef2aa85e4ad8278be70c338891a5 Reviewed-on: https://gerrit.libreoffice.org/46705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18tdf#90626 PPTX: Fix image bullet sizePaul Trojahn
This solution comes with a few limitations. The bullet isn't centered in Powerpoint and has to be between 25% and 400% of the size of the first character in the paragraph. This isn't optimal, but should produce acceptable results under most circumstances. Change-Id: I6c37169282aa351b81d78e06678424203b78f6d7 Reviewed-on: https://gerrit.libreoffice.org/44911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-17tdf#91857 Round of improvements to Impress's menus for 6.0Yousuf Philips
Change-Id: I844b8396a55820da904d4813cbb84c56c33af51c Reviewed-on: https://gerrit.libreoffice.org/46583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-17coverity#1426171 Unchecked dynamic_castCaolán McNamara
and coverity#1426170 Unchecked dynamic_cast coverity#1426164 Unchecked dynamic_cast coverity#1426165 Unchecked dynamic_cast and duplicated lines look like cnp gone wrong Change-Id: I195204e9d0a4d591fbe210241203a17b22b25ec1 Reviewed-on: https://gerrit.libreoffice.org/46603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16sal_uIntPtr->SfxItemPropertyMapEntry* in SdExtPropertySetInfoCacheNoel Grandin
Change-Id: I65d284cc1fbc013a17d4bb2f0dd7d7d8d3ccf56f Reviewed-on: https://gerrit.libreoffice.org/46507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16convert EETextFormat to scoped enumNoel Grandin
and drop unused BIN constant Change-Id: I4ecda96f39147f7e9bceb11ecdb4f0ffe42d2053 Reviewed-on: https://gerrit.libreoffice.org/46589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr/sal_uLong->void* in Popover idsNoel Grandin
Change-Id: Ifd7eeadeacffb90ea303c1e6bca807d310098f66 Reviewed-on: https://gerrit.libreoffice.org/46484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15tdf113594: marking gluepoints immediately.Mark Hung
pPV was for the parameter of MarkGluePoint that was removed in ec38966951f2, and was kept somehow and is converted to bool here. Just replace the default boolean value to false ( that means marking instead of unmarking. ) Change-Id: I4c4b9dd368537b7b90cc4effae482a7b8a41eec9 Reviewed-on: https://gerrit.libreoffice.org/46472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15tdf#114477: Can't set character highlighting on a text box using sidebarTamás Zolnai
Change-Id: I9ef9d6dacc87fb26351eae5eaedd72fd0a081672 Reviewed-on: https://gerrit.libreoffice.org/46494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-14tdf#81475 Organize the form toolbarsYousuf Philips
Change-Id: Ic79b326c4c15f656ce533eb37bbd27853b8f4af7 Reviewed-on: https://gerrit.libreoffice.org/43861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-13tools: reimplement SVLIBRARY macro & remove it from solar.hMichael Stahl
Change-Id: I03f8f5fd656d62410821f2f2851f1c584c97d1f4
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-13tdf#114310 Removed '(in current document)' from compatibility optionsHeiko Tietze
Change-Id: Ie91ca2c9aac9b3ab7ca103bf2e6b55d453255d77 Reviewed-on: https://gerrit.libreoffice.org/46242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>