summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2015-10-12xmloff: fix ODF import of gradient draw:angle attribute a bitMichael Stahl
ODF 1.2 part 3, 18.3.1 angle, says "An angle, as defined in §4.1 of [SVG]" and "If no unit identifier is specified, the value is assumed to be in degrees." Unfortunately OOo could only read and write 10th of degree here. See also https://issues.oasis-open.org/browse/OFFICE-3774 As the first step towards fixing that, implement the import for draw:angle values with an angle unit identifier, but leave the import as-is if the angle identifier is missing. (cherry picked from commit aadda5d17f6e422da143ea774f759bfc5f629c5b) Change-Id: Ib88d417c03998ebcfc569b01492f0e1f851bbc85 Reviewed-on: https://gerrit.libreoffice.org/19284 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-09-23check stream status and string lengthsCaolán McNamara
(cherry picked from commit 7af19f45b35c428d3e06972806e5a05489f45955) if nSize was 1 with unicode encoding nSize would wrap around in lcl_getMaxSafeStrLen (cherry picked from commit f6368c29bdc3a9017bcae3f064d2cd8c7e37ed10) rework this so we don't read the string, backup and re-read the string again (cherry picked from commit 8523e57e427ef5b0b7f7067dcdd07f01176d2160) Change-Id: I99f3d4a2ec760228f485d01fce856deb9c068431 Reviewed-on: https://gerrit.libreoffice.org/18691 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-09-18reusing i here from the outer loop is definitely bogusCaolán McNamara
(cherry picked from commit 637ad743bb74a826ddd4db5efbcd33779b9132cd) Change-Id: I4ee52c76b2c1723639185bc99b85d83be5b4fdd7 Reviewed-on: https://gerrit.libreoffice.org/18687 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-09-11tdf#93097 oox: fix import of metadata from non-relative stream pathsMiklos Vajna
Commit ef2668bad976f1fbb70759887cafd35ea7833655 (PPTX import: fix missing document metadata, 2014-08-28) implemented metadata import for the PPTX filter, but in case the metadata stream is not an existing one, then OHierarchyHolder_Impl::GetListPathFromString() invoked by OStorage::openStreamElementByHierarchicalName() throws. The bugdoc is generated by a 3rd-party tool that always starts the stream path with a slash, and MSO seems to just ignore that: so let's do the same to be able to open the document. (cherry picked from commit 46cf9bb76b29f2bfa6639d9aaf4f26dee365bc0c) Conflicts: sd/qa/unit/import-tests.cxx Change-Id: I6c0715adeb19b9055669f6a45055415dd2c44e28 Reviewed-on: https://gerrit.libreoffice.org/18372 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-30check stream statusCaolán McNamara
Change-Id: I6b9537cf94ac1c5d996ba64ddf878745dadde254 (cherry picked from commit 452cd9e75de657e996e17510fe5d3539065489d1) Reviewed-on: https://gerrit.libreoffice.org/18129 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-30pClientData can be nullCaolán McNamara
Change-Id: I9375f84affdaef30d9b1ded31525e6b7b8709cbc (cherry picked from commit 7d4c77e374310bef538465d11980d1d610cbe0f1) Reviewed-on: https://gerrit.libreoffice.org/18150 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-29check stream statusCaolán McNamara
Change-Id: I609c8c4f4e843601361b61f55e0325ad99db3c23 (cherry picked from commit dc1be62d75e654e17c2f4c02804b7fd48d5a2515) Reviewed-on: https://gerrit.libreoffice.org/18119 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-29eof isn't a Error, so use good not GetErrorCaolán McNamara
Change-Id: Ie1df87c7eb9d391d0fa4a579f744051a1f1b2ae1 (cherry picked from commit 078235028a8c4ea36b6b366348016e19759c456a) Reviewed-on: https://gerrit.libreoffice.org/18118 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-29guard against 0 item sizeCaolán McNamara
Change-Id: I9c4c2f0fe2d892615b3c70e08da0cab6da13338a (cherry picked from commit 2aadad1e89e96cb80c15fe1069cb6365f0cade1d) Reviewed-on: https://gerrit.libreoffice.org/18117 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-29check seeks and readsCaolán McNamara
Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562 (cherry picked from commit 1847753ab135f522df6a293a8539155437f0129f) Reviewed-on: https://gerrit.libreoffice.org/18116 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-28check for stream status after a read, not after a seekCaolán McNamara
Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716 (cherry picked from commit eea399ddd52a0de368321963bb828bc15632dd0b) Reviewed-on: https://gerrit.libreoffice.org/18075 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28check stream state after read attemptCaolán McNamara
Change-Id: Ie3836f2e95acab963634181a07565343501f00f8 (cherry picked from commit 9a695e071020639926f8b038aba64eb016a1801a) Reviewed-on: https://gerrit.libreoffice.org/18079 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28check SeekToEndOfRecord for successCaolán McNamara
Change-Id: I7413a4e9e491b65122eaadb38ad574161f1aa943 (cherry picked from commit d417ffb7dd93306be7c89526a75acab53dbd8831) Reviewed-on: https://gerrit.libreoffice.org/18077 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28check seekCaolán McNamara
Change-Id: I358758999bb918e73cdee2224e575e72c2131453 (cherry picked from commit 0c713e45f9831073e34777f50abf9b5801f08ed9) Reviewed-on: https://gerrit.libreoffice.org/18085 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28check seeks and offsetsCaolán McNamara
Change-Id: I2b6ded138b9101415fc49e93e1ec3ebcd3a9d2ae (cherry picked from commit 5ed690a3e8a575784ca25048e0229ebc52e6fccd) Reviewed-on: https://gerrit.libreoffice.org/18086 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28avoid loops in atom chainsCaolán McNamara
(cherry picked from commit de71eae5807ff94c8eace0eccaabf1ffa08e77b6) Change-Id: Icc40c0ee6c7d8d305cf7cc60cbf3e511c763aedd Reviewed-on: https://gerrit.libreoffice.org/18080 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28check status of SeekToCaolán McNamara
(cherry picked from commit 932f6de91904f86f38d2914b9ce07b94dfadac0c) Change-Id: Ia2bb397c3fdd783cab77a6b0dbc31c9e3d19326b Reviewed-on: https://gerrit.libreoffice.org/18081 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28check returns of SeekToEndOfRecordCaolán McNamara
Change-Id: Ia593dd0e2239a97f17bb03f005d22028da482445 (cherry picked from commit d400f155fdc3867ad4a067c2bf85588fc0fbb2a2) Reviewed-on: https://gerrit.libreoffice.org/18083 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28clip strings to max available sizeCaolán McNamara
(cherry picked from commit 580d3837b26f09ed02fe3583de40fa045a3fde0f) Change-Id: Icc1378c9c27b9b6d229bcffc6a63017f82be70d4 Reviewed-on: https://gerrit.libreoffice.org/18101 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28check seek for successCaolán McNamara
Change-Id: I02420ffb3af009d08ce54a0932e2c7a287703a72 (cherry picked from commit 1830b4f2e324090962a993315ce76752d24d4088) Reviewed-on: https://gerrit.libreoffice.org/18078 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-28avoid hang in certain pptsCaolán McNamara
Change-Id: Iedba71b72fc815b274ca5e0da0903a558947cb06 (cherry picked from commit 90dc4e38928fffc3ed5fcbed40109712eb97e203) Reviewed-on: https://gerrit.libreoffice.org/18076 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-27extend seek, loop ending tests to ppt specific codeCaolán McNamara
(cherry picked from commit c249f93d96ec87b0acbd25ffe087543d6fe9fb14) Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f Reviewed-on: https://gerrit.libreoffice.org/18053 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-27various hangs, check seeks and record lengthsCaolán McNamara
(cherry picked from commit a8b2dc80c41022515c3a1df6f7ea245c3390dc39) Change-Id: Ided7f9376f41ee8cb1f6903e54a2d51e0e07e1a7 Reviewed-on: https://gerrit.libreoffice.org/18026 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-26don't hang on unreachable record endsCaolán McNamara
Change-Id: I288f7ff0327831603eda6e827c8acbae678dfaff (cherry picked from commit cadac8400a018c8c566379f7767ea5edff78523d) Reviewed-on: https://gerrit.libreoffice.org/18021 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-26fix crash on loading certain pptsCaolán McNamara
Change-Id: I544a67e3706c7d12414cc075118ef2f0f5ddd0f6 (cherry picked from commit 334dba623dfb0c4fb2b5292c2d03741b7b33aef1) Reviewed-on: https://gerrit.libreoffice.org/18020 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-09when skipping hidden pages omit the hidden pages from page bookmarksCaolán McNamara
three slides, set second to hidden, export to pdf (without toggling on include hidden slides), in evince/acroread click on the "slide 3" title, and the viewers will not jump to that slide, seeing as the index is mis-calculated assuming 1-1 export-import pages Change-Id: I2f21eb655684ac4cb06384a8e9a17b419f644f3f Reviewed-on: https://gerrit.libreoffice.org/16863 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-07-09fix crash on loading presentation with page name fieldCaolán McNamara
regression from commit 42b521f800a08b11432cf906ce1bdf9fcbfffdeb Date: Wed Apr 22 23:31:43 2015 +0200 tdf#88056: Implement ODF import/export of page title field Change-Id: I577a7c52836bbb13cc93910b4458aee5482ffc86 Reviewed-on: https://gerrit.libreoffice.org/16851 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-07-07fix deselect of textbox on slides with images in underlying masterCaolán McNamara
The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing (cherry picked from commit abbe4f9d64073d77c4be93b7c89c03d0651bacef) (cherry picked from commit 4189530530320a82adc785a4426735423a1188c1) Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93 Reviewed-on: https://gerrit.libreoffice.org/16742 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-06-20tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Conflicts: include/svx/nbdtmg.hxx (cherry picked from commit 71b35212265bb93b10ca35ab964a36e6b6cc552b) Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e Reviewed-on: https://gerrit.libreoffice.org/16337 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-06-17tdf#91001 Fix inc/dec font for complex selectionsMaxim Monastirsky
By "complex selection" I mean: 1. Selection with an empty paragraph that has a bullet. 2. Selection that has different font sizes. This is a regression of 5b32d9c4406a68507ac9737ee0ada8bd1d424815 that tried to fix tdf#61492. In reality in order to fix that, it seems to be enough to pass an empty SfxItemSet, because what we really need is to invalidate the bullet width (by setting it to -1), thus force recalculation, and this occurs anyway. Change-Id: I92545192f8c78ef7f1d66d72f0d8e8f256f87604 (cherry picked from commit 2a05cb81d363cce181d3e31967cea2cfff1bd06d) Reviewed-on: https://gerrit.libreoffice.org/16336 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-27tdf#88056: Implement ODF import/export of page title fieldKatarina Behrens
to/from loext namespace, since new tag's needed for the new field and it isn't approved by ODF-TC yet Change-Id: I70ceb4e16e1199663520dbdf3beae31423bc81d0 Reviewed-on: https://gerrit.libreoffice.org/15485 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-05-14misspell some words, copy and paste slide to gimpCaolán McNamara
and we don't want to see the mis-spelt underlines Change-Id: Ib3ae29297a1697e0f7b0caa816504da7edf721d1 Reviewed-on: https://gerrit.libreoffice.org/15679 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-30tdf#86329 Interactive crop preview shouldn't scale proportionallyTrent MacAlpine
Add extra check to keep images proportionally scaling by default from affecting interactive crop preview rectangle. Change-Id: I2b15bbc8628934e3d3cf17927885ede890505cd3 Reviewed-on: https://gerrit.libreoffice.org/15505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit 18a592a5bfc3c4592b7118cceae774fcc00ae94d) Reviewed-on: https://gerrit.libreoffice.org/15521 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-28Fix tdf#90911 wrong parameter size on getsocknameJuergen Funk
This was crashing on selected versions for Windows. Change-Id: I7e9dd39db06f6ed93d2ae0d49275387e53983a89 Reviewed-on: https://gerrit.libreoffice.org/15559 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 84c73c983577e33dda266bbfcdd89b9e1202906b) Reviewed-on: https://gerrit.libreoffice.org/15560 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-04-27Actually execute testPDFImportSkipImagesStephan Bergmann
(cherry picked from commit b8ca219893a6e14bfea3cec5522532c144ad2fa6) Conflicts: sd/qa/unit/import-tests.cxx Change-Id: Ie3dda6d7ea24031eadf86801867a94f95c11310e
2015-04-22fix re-export of novell590442-1.ppt to pptCaolán McNamara
we always open a container, so always close it the close container is inside the nRowCount != 0 condition, so remove that and always write the close (cherry picked from commit 7aa166da24c81b7c22a0ec5daf7e09640ffb009b) Conflicts: sd/source/filter/eppt/epptso.cxx fix re-export of novell590442-1.ppt to ppt we always close this container, even if we didn't open it original commit always opened the SpgrContainer, and always closed the SpgrContainer. (but seems to have a loophole, presumably never hit where the SpContainer could be opened and not closed) make a container guard which opens in ctor and closes in dtor. should make ppt export crash stats hit 0 (cherry picked from commit deaed8aff6de824a76d939a02edb0d2ff4a4ccec) squash patch here is unreadable, but component parts are fairly trivial, remove nRowCount guard and unindent block, and then add in helper and use that to push/pop containers Change-Id: If05677ae46e8873b8780794bdd84f29505ea4112 2aead7397448b674e433a4097c97285067a6dc6e Reviewed-on: https://gerrit.libreoffice.org/15478 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-04-14fix export of ooo120353-1.odp to pptx, mismatch of start and end elementCaolán McNamara
cut and paste error I guess from the block above it Change-Id: I121e1d1a9f08ea3731bb7f65c385f264b3c2d2f4 (cherry picked from commit 1d4e66a79453f7b020a3dcea328c03637407add9) Reviewed-on: https://gerrit.libreoffice.org/15308 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-04-14fix assert on re-export of ooo48994-1.ppt to pptCaolán McNamara
Change-Id: Ic8274e7d060f315d7891f8f5cf576f834ca89117 (cherry picked from commit eece059c1f728059b536763bffd2d4fc3537833e) Reviewed-on: https://gerrit.libreoffice.org/15313 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-04-12tdf#90403 PPTX import: use real table sizeAndras Timar
PowerPoint ignores a:ext cx and cy value of p:xfrm, and uses real table width and height. PowerPoint 2010 saves files where cx and cy contains good values, but I found files in the wild whose cx and cy values did not match to actual table width and height, and there was a visible difference between rendering of Impress and PowerPoint. Change-Id: I3f80c0cea4cac46763d449f918bb78dca1a6562d Reviewed-on: https://gerrit.libreoffice.org/15123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 037fe3671cbdad51f52d2f69f72f47f463dba7c2) Reviewed-on: https://gerrit.libreoffice.org/15132 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-31bnc#910045 wrong cell fill color defined by table styleZolnai Tamás
Problems were with those table styles which used color themes to define cell fill color. Reviewed-on: https://gerrit.libreoffice.org/15089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit debf3ffb87d607704ddea97f6710c3ceaa9a243d) Signed-off-by: Andras Timar <andras.timar@collabora.com> Conflicts: sd/qa/unit/import-tests.cxx Change-Id: Ibde90df81ff253ba65618dde4038093d1caabfe8
2015-03-31bnc#902652 OOXML: fix import of insets when shape and/or shape text is rotatedAndras Timar
5ac575ee3e109 did not get it right, the vert attribute (i.e. the rotation of text) is relevant, not the rotation of the shape. In that case both text and shape rotation were 270 degrees. I checked that the bugdoc of bnc#773048 looked good after this. Change-Id: I6e0401cd138a82040df82d7da1a47311db7771e4 Reviewed-on: https://gerrit.libreoffice.org/15076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit af686aa8694903bde5952656cd69993c8c8393d7) Reviewed-on: https://gerrit.libreoffice.org/15082 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-04gbuild: CppunitTest: always use unittest configurationMichael Stahl
The sc_subsequent_filters_test was failing because of a lock file because it did not use the unittest configuration. Refactor gb_CppunitTest_use_configuration so it uses both the instdir and unittest configuration to prevent such errors. In case there ever is a test that does not work with the unittest configuration it should call gb_CppunitTest_use_instdir_configuration. (cherry picked from commit f0a60415597bae7ca54767b397a217882578ce97) Conflicts: dbaccess/CppunitTest_dbaccess_RowSetClones.mk sc/CppunitTest_sc_condformats.mk sc/CppunitTest_sc_recordchanges.mk Change-Id: Ibc00d42f8b6102d50d922f51173120798fa45c6e Reviewed-on: https://gerrit.libreoffice.org/14738 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-26SkipImages option for PDF importMihai Varga
This option allows images and drawings to be skipped while importing a PDF, the main reason was performance improvement where images were not needed. And I've also added unit tests for it. Change-Id: I6595d3ff22d5389eab4fe8450460d083f626d216 Reviewed-on: https://gerrit.libreoffice.org/14628 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-09tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). (cherry picked from commit 905d4db48a0b98f540c8abc3e12fb80be4826029) Conflicts: vcl/source/gdi/impgraph.cxx Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82 Reviewed-on: https://gerrit.libreoffice.org/14357 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-01-27font cache gets broken on adding an embedded fontCaolán McNamara
Change-Id: I665cde5d4c89443238efb283c86277dedf621197 (cherry picked from commit 20142afafc809890d5e8dcfd4103c46319a488df) Reviewed-on: https://gerrit.libreoffice.org/14045 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-19Resolves: fdo#32664 pass keyboard media keys through to the OSCaolán McNamara
if we didn't make use of them. (cherry picked from commit 508c020cf5f7999f0c23d972133f9b6bf85de245) Conflicts: sw/source/uibase/docvw/edtwin.cxx vcl/osx/salinst.cxx vcl/win/source/window/salframe.cxx Change-Id: Iee1c2fef5966a614b068c832bf8c6b51973b4c8a Reviewed-on: https://gerrit.libreoffice.org/13993 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19use supersampling in Impress if fast opengl scaling is availableLuboš Luňák
So far it's been always disabled, with the exception of the slide preview extension. Change-Id: Iaee6fe2d5267c9dfdc31cbf4fb90a9ac0e08e781 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19rhbz#1136013: svx: try to make the ExternalToolEdit not crash all the timeMichael Stahl
This thing was starting a timer that re-starts itself forever, and when the file it was watching changed, it would just assume the drawing objects were still there (and the document, for that matter...) (cherry picked from commit 5f6bdce0c0ac687f418821ce328f2987bf340cda) Conflicts: sc/source/ui/drawfunc/graphsh.cxx Change-Id: I35f187f0828097a05618dc1733dce819fc6bffc6 Reviewed-on: https://gerrit.libreoffice.org/13995 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-18fdo#88339 Fixed Draw/Impress constrained image movementTrent MacAlpine
fixed on master by c6a1a8e6f8d97d24b4063909ef22824875326e28 Change-Id: Ib45cb3167acfd4f409b05a0e1b8d37af36fd6725 Reviewed-on: https://gerrit.libreoffice.org/13900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/13978 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-01-08Fraction fiasco: avoid assert on clicking "master pages" in impress sidebarCaolán McNamara
avoids the dread assert in vcl wrt. "detect overflows" in ImplLogicToPixel of vcl/source/outdev/map.cxx but the whole thing looks a nightmare if a high precision double is given as an arg to Fraction and the underlying boost foo uses longs longer than 32bits to represent that. Change-Id: Ia0fa911cf07ed613e0b1bbd97b63a291f29628cb (cherry picked from commit 00205f178f4c1edfc2201fa298e7335ca3dd7b44) Reviewed-on: https://gerrit.libreoffice.org/13812 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>