summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db Reviewed-on: https://gerrit.libreoffice.org/62817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02loplugin:useuniqueptr in SdCustomShowListNoel Grandin
Change-Id: I604f4cd616ec6eb31198806456a660e7a1e915ca Reviewed-on: https://gerrit.libreoffice.org/62662 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01Draw menubar: Spahe section updateandreas kainz
Change-Id: Ia378a3375ba8fb0e3a9b446bd891466dfcf4bdbf Reviewed-on: https://gerrit.libreoffice.org/62758 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-01Limit the unique_ptr scope to get rid of .reset()Mike Kaganski
Change-Id: I5d852f4d7f5de24ff49eaada6f53cd197ee2d0f7 Reviewed-on: https://gerrit.libreoffice.org/62715 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-01oox smartart, vertical bracket list: fix node counter conditionMiklos Vajna
The visible effect of this was that the 2nd level text nodes were missing from the layout result. The cause is that when it comes to counting nodes of a condition, we assumed that the current layout node is a presentation of a model node, but this is not necessarily true. Fix the problem doing a "first presentation child of", then a "presentation of" navigation in that case, which leads us to the correct model node, so counting its children works. (An alternative way of getting non-zero children would be a "presentation parent of" navigation, followed by a "presentation of" navigation, but that would lead us to the document root, so we would count the number of 1st level elements, not the correct 2nd level elements.) Change-Id: Iccebe0e2e56b7acb7fbe2c38a7c9ebb2abb309b9 Reviewed-on: https://gerrit.libreoffice.org/62703 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-11-01loplugin:useuniqueptr in SdPPTImportNoel Grandin
Change-Id: I843a2626c6351789bee3d68f0ab9debca9caa733 Reviewed-on: https://gerrit.libreoffice.org/62663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01rename RemoveX->Remove in SfxUndoArrayNoel Grandin
accidentally left it this way when doing commit 19e715973e15f9e7cf6e8237643dbbc14f8eb87a Date: Mon Oct 29 16:15:27 2018 +0200 loplugin:useuniqueptr in MarkedUndoAction Change-Id: I250676df7af27f485c5d34281ef0da1e127eb24c Reviewed-on: https://gerrit.libreoffice.org/62694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01tdf#120920 Assertion failure when switching slide layouts with text enteredNoel Grandin
no need to call StartListening here, has already been done inside SdPage::CreatePresObj Change-Id: I590e51f7afeb336d562d3ad9ccc123f542897aae Reviewed-on: https://gerrit.libreoffice.org/62689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31tdf#120540 draw/impress UI: add Format / Table submenuJustin Luth
Although these commands were available in context menus, there was no main menu access to these commands. Also: -cleanup unused context/popup labels related to table items. Change-Id: Ia574c3783bb279e869c2b8c716f6fb394aa21873 Reviewed-on: https://gerrit.libreoffice.org/61715 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-31loplugin:useuniqueptr in ParagraphObj::ParagraphObjNoel Grandin
Change-Id: I4c5dcdad18988381b64479cad077234978437795 Reviewed-on: https://gerrit.libreoffice.org/62661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31cppCheck RedundantAssignment variable p3DObjZdibák Zoltán
Change-Id: Ib423480bdb5d2cee183b5d1bda5b1a9ff05fdafc Reviewed-on: https://gerrit.libreoffice.org/62667 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-30toolbar impress and draw update for image and draw contextandreas kainz
Change-Id: I463441256f294185349177afb83936230a6c6dea Reviewed-on: https://gerrit.libreoffice.org/62636 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-30loplugin:useuniqueptr in MarkedUndoActionNoel Grandin
Change-Id: Ic06b990112df5bc135cfd7af6f1129580f294428 Reviewed-on: https://gerrit.libreoffice.org/62509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-30tdf#42949 Fix IWYU warnings in sd/source/ui/inc/{framework,tools,view}/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also a typo fix :) Change-Id: I7c96e8459f6fb75b07f6447715e8165800ecba53 Reviewed-on: https://gerrit.libreoffice.org/62259 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-30Tabbed Notebookbar: Show Draw toolbar didn't work so was removedandreas kainz
Change-Id: Iab3af7ee75597b148a60d6d7d90c6104d80ca2cb Reviewed-on: https://gerrit.libreoffice.org/62536 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-30context menu: finish draw and calc context menuesandreas kainz
and update NameGroup arrangement Change-Id: I373229793fa1605e731c04824112118c15e05c29 Reviewed-on: https://gerrit.libreoffice.org/62528 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29update tabletext context toolbar for draw and impressandreas kainz
Change-Id: If4a78aa0c95c0d6943c34caf0636e9867556b725 Reviewed-on: https://gerrit.libreoffice.org/62516 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29context menu: sync page context menu between draw and impressandreas kainz
Change-Id: I7ea70042a6a1f2724bf5a2573eb388f4af2bfd4e Reviewed-on: https://gerrit.libreoffice.org/62492 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-29loplugin:oncevarNoel Grandin
Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-29tdf#42949 Fix IWYU warnings in sd/inc ; sd/source/ui/inc/Gabor Kelemen
Found with bin/find-unneeded-includes after recent improvements - remove UNO headers from blacklist - remove newly found unneeded fw declarations - fix up some not self contained headers Change-Id: Ib262e361b62162d96ce8308500b1a41a971353df Reviewed-on: https://gerrit.libreoffice.org/62258 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-28drop unnecessary requires lib="LibreOffice"Caolán McNamara
Change-Id: I5444e5076ca69e8f6f8d28e36f4e744721cf43ef Reviewed-on: https://gerrit.libreoffice.org/62445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28update old 'interface-requires' comments to <requires> tagCaolán McNamara
Change-Id: If7533650ae543f9d43a3a50fdfc137141fa64586 Reviewed-on: https://gerrit.libreoffice.org/62444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: Iaa1a1811b638aadfe6b06b3465a182cb675031b5 Reviewed-on: https://gerrit.libreoffice.org/62476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I2b2ea62ff4ed3e16cd4fa2a5e588d001d21121cb Reviewed-on: https://gerrit.libreoffice.org/62465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28svx: remove newly unused XFillExchangeDataMichael Stahl
Change-Id: I0260504ba108421e82ad50f9680dda9a05710678 Reviewed-on: https://gerrit.libreoffice.org/62456 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-28tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl
This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-28tdf#119773 update sd table context menuandreas kainz
Change-Id: Ib85e6a3be4f2771b9772751d6526e8f278bb0a40 Reviewed-on: https://gerrit.libreoffice.org/62240 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-28tdf#120703 PVS: V547 Expression '!pTmp' is always trueMike Kaganski
Change-Id: Ia31961d65592ebd2718446eaa931aab785b8ba65 Reviewed-on: https://gerrit.libreoffice.org/62457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#120376 sd: fix duplicated styles on copy/pasteMichael Stahl
Unfortunately the comparison was inverted, so a style is copied iff it already exists, which is clearly the reviewer's fault... (regression from 57db6e24b5ad43d447c30e44a112c74c7e75b46b) Change-Id: I3425982feb08e980eca9243cc16120897b65a70f Reviewed-on: https://gerrit.libreoffice.org/62436 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-27tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorIzabela Bakollari
Change-Id: Ifc9fcc718b318c439484a6cc98a4e71c8d445fd8 Reviewed-on: https://gerrit.libreoffice.org/62417 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Jenkins
2018-10-27tdf#120703 (PVS): V519 The variable is assigned values twice successivelyMike Kaganski
Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27 Reviewed-on: https://gerrit.libreoffice.org/62406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-26tdf#120861 move paste special to a submenu in menubarandreas kainz
Change-Id: I4b6a2eb32ff155855bb9e5d1638f7239252278f3 Reviewed-on: https://gerrit.libreoffice.org/62301 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-26oox smartart, linear layout: take horizontal position from constraintsMiklos Vajna
Both horizontal size and position looks sane now. Change-Id: I6f040e4f0ff49be74420fafc4bcc5e899b6e94f7 Reviewed-on: https://gerrit.libreoffice.org/62397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-26oox smartart, linear layout: take width from constraintsMiklos Vajna
Finally the "parent text" of the test document now has correct width. Change-Id: I05c552dda66ad91f19cfc335b464549920269f69 Reviewed-on: https://gerrit.libreoffice.org/62395 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-26tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-26use unique_ptr when Clone()'ing PoolItemsNoel Grandin
and fix a handful of small leaks in the process Change-Id: I876e12ff5305f9dda84532d4182fb91657d6fa0c Reviewed-on: https://gerrit.libreoffice.org/62389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26loplugin:singlevalfields improvementNoel Grandin
look for any kind of types, not just POD types, helps to find smart pointer fields that are only assigned nullptr Change-Id: I2d887e98db012f03b646e1023985bcc196285abc Reviewed-on: https://gerrit.libreoffice.org/62382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Fix typosAndrea Gelmini
Change-Id: I64cfe4c24d3abb4a8445fd2e7b832b2bdb0b40d3 Reviewed-on: https://gerrit.libreoffice.org/62310 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Introduce OutputDevice type OUTDEV_PDFJan-Marek Glogowski
Originally I thought mpPDFWriter can be used to create PDF from any OutputDevice, but it's actually just set for the internal VirtualDevice of the PDF writer. So this gets rid of all the special mpPDFWriter and GetPDFWriter() handling and replaces it with checks for OUTDEV_PDF. But since ImplPDFWriter used to be a OUTDEV_VIRDEV, this also introduces OutputDevice::IsVirtual(), which now replaces most of the direct OUTDEV_VIRDEV checks. Change-Id: I11824143b6b8833ecc81119762448cbdf1145dbc Reviewed-on: https://gerrit.libreoffice.org/62257 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-24weld AdvancedSettingsDialogCaolán McNamara
make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24Translate German commentsJohnny_M
Change-Id: I4e0150aac5a785ea2cb0884dede1596164a18af0 Reviewed-on: https://gerrit.libreoffice.org/62079 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-24clang-tidy performance-unnecessary-copy-init in sdNoel Grandin
Change-Id: I4a494aebdae9b9cba3794e5eee1f3a29eb3ec838 Reviewed-on: https://gerrit.libreoffice.org/62250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23remove all use_action_appearance linesCaolán McNamara
Change-Id: I031676e939f53a28b1a62654ffe0a91b95dea029 Reviewed-on: https://gerrit.libreoffice.org/62234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22sd: Use the regular textbox popupmenu for outline text objectsMaxim Monastirsky
Having a separate menu for just one kind of a text box makes no sense. It isn't good for developers that must remember to sync changes between the two, and likewise for users which do customization, and that have to make the same changes twice. In fact both menus are identical, except that the outlinetext menu has also .uno:TextAutoFitToSize. But this commands seems to work also for other kinds of text boxes, and we actually have a request in tdf#116898 to have it in the context menu. So we can just move .uno:TextAutoFitToSize to textbox.xml, and then remove the separate outlinetext.xml. Fortunately there is no fear of losing existing user customization for outlinetext.xml, as it wasn't exposed to the customization dialog by error (no corresponding entries were added to ImpressWindowState.xcu/DrawWindowState.xcu). Change-Id: I3568cb95d862d4ab91bedfa691dcc6659a3bf86f Reviewed-on: https://gerrit.libreoffice.org/61972 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22tdf#119596 DrawText Contextmenu in Writer, Calc, Draw, Impressandreas kainz
and all other sw modules Change-Id: Ifd7161f58170f32555134250b91e537eeada3c99 Reviewed-on: https://gerrit.libreoffice.org/61988 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-22Resolves: tdf#120785 no parent set via status barCaolán McNamara
Change-Id: Ibdc0f75b18330b77e18293f7485e165d2133290e Reviewed-on: https://gerrit.libreoffice.org/62179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#119506 Draw Contextmenu in Writer, Calc, Draw, Impressandreas kainz
and all the other sw modules Change-Id: Ie407f858bf1d17f3af4c2948fcd4cb40bc9e8c92 Reviewed-on: https://gerrit.libreoffice.org/61963 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22tdf#119547 Media Contextmenu sync in all appsandreas kainz
similar layout to graphic Change-Id: Id97460cdeb1db62326b7cb2e7655a39af2c1ae99 Reviewed-on: https://gerrit.libreoffice.org/61962 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-05 19:08:12 +0000