Age | Commit message (Collapse) | Author |
|
* Sort presentations options, put similiar options next to each other.
* Move non-document option (Navigation bar) to "Display" area.
Also improve wording a little bit for more clarity
Change-Id: I18de6b95ea26033ef78709845db40e428a1d6c84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158831
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Instead of hiding it in the general options dialog.
As written in https://bugs.documentfoundation.org/show_bug.cgi?id=157788#c4
"The options in Slide Show Settings should all apply to the workstation";
the options which are saved per user/workstation and not per document, should not be moved
away from that dialog.
Instead the other options should also be saved per user/workstation.
Change-Id: I720c949f08877abb8ef8f94dbcfa6c85f349631d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158808
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: I0aeb180ee132bff359d46d963985196f5a24610f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158798
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
After 8c39af455c4dee53c6f3c918b0497f80a4fb0f21
"uitest oneprocess mode: default to this and clean up one test"
Change-Id: Ib6e0fc3de2997beebc650253ae3ea19a3314ae09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158844
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ie6ac8530b3351a2c9899c33932ba6ab70b246cd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158797
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: Ibaa2851fede2ecd78b86388e151b4484e1ff60db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158796
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
This fixes a form control's hyperlink being set by Insert - Hyperlink.
Calc and Writer do something similar - checking for ButtonType.
Change-Id: Ia36b216c8f749bc2a5dfba448a4771d9d7d50256
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158765
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I6117b384fdad215e6c04b6e74df22fe9daa6a526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157705
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158739
Tested-by: Jenkins
|
|
Change-Id: Iff3c2b8fb5ae0939157aaec67f5830c80cf46ea0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158747
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
If it is importing all Slide Master from pptx file, unfortunately
it breaks the exporting to pptx due to save and reload unit test failures
According to the documentation
http://officeopenxml.com/prSlideLayout.php, so the file pptx has a
relationship Slide -> Slide Layout -> Slide Master
The Slide Layout is a template an unique to be reused
with Slide Master, so exporting requires to compare
the templates due to LibreOffice relation Slide -> Slide Master
Adjust unit test values:
SdOOXMLExportTest2::testTdf106867
revert adcde78935fb8ca2b93322aa3a558d0b3ccdbfad
SdOOXMLExportTest2::testTdf112280
revert adcde78935fb8ca2b93322aa3a558d0b3ccdbfad
SdOOXMLExportTest2::testThemeColors and
SdOOXMLExportTest3::testTdf114848
The file tdf84205.pptx does not contain theme2.xml,
and save and reload it does not caintain theme2.xml too
fix "An uncaught exception of type com.sun.star.container.NoSuchElementException"
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I622e9d5d68c406ff520387f3903808613d1cd3d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158084
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158676
Tested-by: Jenkins
|
|
it already has 93 tests
Change-Id: Ic0459705255d8728f31c9c07760b2e2f07fac77e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158669
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This reverts commit ae3b97a69688553e6c40ef4b64655db09d5a0f5e.
Change-Id: I39fd84b5efbff0a2cafe090f4f866c801cef19b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158357
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
See https://gerrit.libreoffice.org/c/core/+/158341
Change-Id: I8a5b326063bef0cbd2d2c71a0f0650c8298c6514
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158583
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...which had caused an (explicit --without-fonts) Fedora build to hit the
std::abort in PrintFontManager::Substitute
(vcl/unx/generic/fontmanager/fontconfig.cxx) during
CppunitTest_sd_import_tests-smartart's testTdf134221::TestBody, apparently for
some aTargetName = "DejaVu Sans"
Change-Id: I3b050eb3225595e6ce22a8df22dbb11f920cac4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158492
Reviewed-by: Dan Horák <dan@danny.cz>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Iedf8c33833ce08d42fd52a7080fa6b60e9555c09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158417
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
sd/qa/unit/data/pptx/smartart-composite-infer-right.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/smartart-interopgrabbag.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/smartart-snake-rows.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/tdf132302_SmartArt_rightArrow.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/smartart-tdf134221.pptx
replaced some "微软雅黑" with "Noto Sans"
sd/qa/unit/data/pptx/tdf135953_SmartArt_textposition.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/tdf145528_SmartArt_Matrix.pptx
replaced some "Calibri Light" with "Noto Sans"
replaced some "Calibri" with "DejaVu Sans"
sd/qa/unit/data/pptx/tdf148665.pptx
replaced some "Poppins Medium" with "Noto Sans"
sd/qa/unit/data/pptx/tdf148921.pptx
replaced some "Tahoma" with "Noto Sans"
sd/qa/unit/data/pptx/pptx/tdf149551_SmartArt_Gear.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/tdf149551_SmartArt_Pie.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/tdf149551_SmartArt_Pyramid.pptx
replaced some "Calibri Light" with "Noto Sans"
sd/qa/unit/data/pptx/tdf149551_SmartArt_Venn.pptx
replaced some "Calibri Light" with "Noto Sans"
Change-Id: Ie224100d024dc4f3321650e33f13ed5a61b444e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158364
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5e0d0f604714cbc395cd6b0c7a9b5665f0d5f93b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157631
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I9a602a5da35146c103b7c21a00067f80f4922ac2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158341
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I1d6cc72738e3120c10e6d978dad18ec2fb36edd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158346
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...in include files. This is a mix of automatic rewriting in include files and
manual fixups (mostly addressing loplugin:redundantfcast) in source files that
include those.
Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I9f20b9b6febd94e85095dc018908cfa5011741d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158326
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
based on Stephan Bergmann's point on:
<https://gerrit.libreoffice.org/c/core/+/138652/comment/bb5fc1a4_75e060c9/>
the font used in the test file was Calibri, which likely was
being replaced with the best approximation on a given system.
Changed that to Liberation Sans which is a font that is bundled
with LibreOffice to improve the test's robustness.
Change-Id: I7ff75baeb9259dea244913ca9d5025948291f1e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158234
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I4dc708ee57a7e305f4e377bde0e486299df56f0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158297
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The vast majority of this is just eliminating copy/paste,
since I have now created a popupmenu.xml list for the popup menu.
The "fix" is adding this to the Table menus.
.uno:ObjectAlign is basically just a "label".
Now it is a label for two different "views":
* a toolbar widget dropdown
* a menu subcategory
Perhaps it is confusing to have one UNO entry
serve these two similar purposes?
I suppose someone might also complain that a simple
<menu:menu menu:id=".uno:ObjectAlign"/>
isn't clear that this is a submenu.
I considered making mine a new ObjectAlignMenu,
but the annoyance of having to create a duplicate string translation in
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
made me just reuse the existing label.
Change-Id: I17e037e0c9c5d1f57ac9f174a76cd041983bcea4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157894
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
- replace 'Calibri Light' with 'Noto Sans' (we bundle the later)
- replace 'Calibri' with 'Arial'
With this:
diff --git a/sd/CppunitTest_sd_import_tests-smartart.mk b/sd/CppunitTest_sd_import_tests-smartart.mk
index 9b7362b08152..72e0dead7731 100644
--- a/sd/CppunitTest_sd_import_tests-smartart.mk
+++ b/sd/CppunitTest_sd_import_tests-smartart.mk
@@ -11,4 +11,6 @@
$(eval $(call sd_import_test,-smartart))
+$(eval $(call gb_CppunitTest_set_non_application_font_use,sd_import_tests-smartart,abort))
+
# vim: set noet sw=4 ts=4:
doesn't abort anymore. In fact the second replacement is just for
completeness, the first was enough alredy.
Change-Id: I455b473233e351b7a2ee6a1b1b66049e63a8a6ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158263
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
to avoid some more spurious SAL_WARN
Change-Id: Iff1dfea4857e780d0b3739c7b1688eb7df243907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158232
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
I misread https://gerrit.libreoffice.org/c/core/+/158181/3#message-f54ed5a8dcf1d68fea73ace5ff9851d3d5fe5a2f
Change-Id: I31523af088f8fa83f43a8a49e449d27b0f230149
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158229
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
See https://gerrit.libreoffice.org/c/core/+/157763
Change-Id: I397adc22e29c595c3bfaf0331a1774f192f0fc85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158181
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Idcde4728f4db5b878c126c29c1953dff7c47f05a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158139
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I0a0a7badb25eea99632f734aa52231a9f3df67e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158137
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
These 11 suites depended on the UITest default to not use oneprocess
mode. Explicitly avoid that mode in these suites, because they currently
fail that way. This allows changing the default in the future, so new
suites automatically benefit from the oneprocess mode (it runs faster,
somewhat similar to cppunit).
Change-Id: I8c493ca63310815c1364bb6182c3285a9c7fbd63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158128
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: If39b6c561525bbf66d34edfbff0f1a3ef4531f85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158129
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I30b2ac77b58e2ae1d1e997a0c830c513542b973d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158101
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Currently, the value of the "Show navigation panel" parameter for
presentations is not saved. The section in which this setting is
now located, apparently, is saved in files. It might make sense
to move this setting to Tools -> Options -> LibreOffice Impress -> General,
because it relates to the device rather than the slideshow.
Change-Id: I2286a4a6d432b11fce2b9c3e65fa6b82e004275f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158057
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
notifyViewRenderState should be executed as soon as a view is created in
order to give a view id to the client
Change-Id: I31b7e61599f546bd5ec134775e6235633a6526f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154681
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
(cherry picked from commit 6c6bb1d434d5c0be2f71470483f3ce56f5210e01)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154709
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
This reverts commit 86eb7ad2b4488dcd29c21ae3fc525056b681e199.
Reason for revert: More generic solution in I1ca8cfe539a662100f6c581fd633ab1ebd5c6bfb
Change-Id: Ie2769a90f776602e38fc2795e08d591f9ae8d618
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158035
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Band aid for follow-up issues, eg. tdf#157706, tdf#157706...
Change-Id: I1ca8cfe539a662100f6c581fd633ab1ebd5c6bfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158024
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Seems to cause more issues than it solves, reverting for now
This reverts commit 884fd220d0025a92510d3ff4710c8c517c8f271e.
Change-Id: If32a9d3bd922afe5611e5258987eec9ec685bc8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157951
Tested-by: Jenkins
Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
|
|
...now that warning about O[U]String vars that could be O[U]StringLiteral is no
longer useful
Change-Id: I389e72038171f28482049b41f6224257dd11f452
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157992
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...from 28b6480c6bdd179f3943f768926b7f196226c768 "tdf#105303: Drop html export
wizard"
Change-Id: I996324e06a2f5eb04d722c45be9ce54715490b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157970
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Iabb67f465ef76c8c2fef822fb3844120a54ee243
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157971
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
As in the classic toolbars, do not promote direct printing
since it easily leads to mistakes and wasted paper.
Additionally, the printer settings is really never needed,
so it should not have a prominent place, especially on COMPACT.
At the same time, I standardized the File menu:
- always include print (especially useful for accessibility)
- always use the same order
- consistently provide access to print/web preview
Change-Id: I9ffbba179206274b5ed1788e496b7c5aa0503726
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157984
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: I76ec68fb6482d7c348a08021413c640cf640d7f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157836
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...by moving the char8_t -> char reinterpret_cast out of any potential constexpr
paths into a new TranslateId::getId. And demonstrate constexpr'ability by
making the aCategories var in OApplicationIconControl::Fill
(dbaccess/source/ui/app/AppIconControl.cxx) constexpr. (And there might be more
such cases that could now be made constexpr.)
Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ic21ff7bf48f07f7277979d52e99d2c5c268de83f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157825
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I64b1f1f179e263962394afbbebd0be5486720e75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157763
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Check pointer to be vaild
Change-Id: Id7be4756496f034c4a6a4407cb625e68a66573c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153051
Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 93a28b3bc8a50226a111464b08ac51d1feb05988)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157761
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I19bf2738496e0289e9fe07ac5241781b4c0bc416
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157758
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I59b869c84381e2904edbc399b3d1598896e1dd29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157699
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|