summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20character spacing control possible to use outside sidebarSzymon Kłos
Change-Id: Ic0c6458268b529bd0107d6ed5a35f49241cfb833 Reviewed-on: https://gerrit.libreoffice.org/24146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-04-19tdf#99396 SvxTableController::SetVertical: implement undo supportMiklos Vajna
All the table and cell objects know how to undo this change, what was missing is the begin/end undo calls and the broadcast of the cell format change. Change-Id: I3dfd203faf5c579da2937fedab5647129a8e903a Reviewed-on: https://gerrit.libreoffice.org/24247 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-19introduce DEBUG_SD_CONFIGURATION_TRACE instead of OSL_DEBUG_LEVEL>=2Eike Rathke
... and partly revert the corresponding pieces of 3d2f43438d4fe6947965a98262b0db42c8d5e680 that removed them as unused code. Change-Id: Ib5418df6a675004d0822b77ef12a77564d3348c8
2016-04-19warning C4101: 'rException' : unreferenced local variableStephan Bergmann
Change-Id: I64d3ff11d635c8600116867e2ea95442035adac0
2016-04-19Related: tdf#99396 sd: make table controller undo code unit-testableMiklos Vajna
With these it's possible to create a table controller with the unit test user profile (that lacks .ui files) + also the sd undo stack can be asserted. Change-Id: I48f09e4bb985c32227deed736cd158dec9f4f315
2016-04-19sd doc model dump: include undo manager infoMiklos Vajna
So that it's easy to see where the implementation for a given undo action is. Change-Id: I93b8603f75d0b5a68922e02540b9db6824f4d0db Reviewed-on: https://gerrit.libreoffice.org/24243 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-19tdf#99387 - protect LOK document size API from corner-cases.Michael Meeks
Change-Id: I5dd1d37ea783a65f0c8f3ad9c3c9cabf72ae036d Reviewed-on: https://gerrit.libreoffice.org/24239 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-19cppcheck: silence known condition warning in sdJochen Nitschke
Change-Id: I918eb21eef5696295ed1b9eb86e04121651245f8 Reviewed-on: https://gerrit.libreoffice.org/24206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann
Change-Id: Iee63999e4953a083783cb5c9811640150616472d
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15clang-tidy misc-forward-declaration-namespaceNoel Grandin
Change-Id: I0566e9992e0d96ee710c8bce2ae6f44a9e83b4e4
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘and’ of equal expressions", as DEFAULT and INHERIT are both defined as zero in the UNOIDL css.animations.AnimationFill constant group Change-Id: I59e53fe9bf73f6eec8f7aa82a216736a79e0d47c
2016-04-14loplugin:passstuffbyref in sdNoel Grandin
Change-Id: If5a68861451efe025b77f71a20e805b71240b827
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#97087 Give comprehensible names to timersMuhammet Kara
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-13tdf#84258 Link icons and use new commands in menu/toolbarsMaxim Monastirsky
Change-Id: Ia034fd91926ec6729346274f524d3751d59fcf35
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iaa556ac8ce6a2220ab3643968193fbab5077a56f
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iefc0bf0e7d64b0ed4b339ca89191649e4bc6fba2
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I6c8565653ece37251a98103f71408ace2a0946a8
2016-04-12clang-tidy performance-unnecessary-value-param in sdNoel Grandin
Change-Id: Id55410931305a9695a001977a5227b430a984e99
2016-04-12tdf#99224 PPTX export: implement support for images with textMiklos Vajna
In case an image had text, then ShapeExport::WriteGraphicObjectShapePart() wanted to write "only the text", but PowerPointShapeExport::WriteTextShape() had no idea how to write an image, so at the end nothing was exported. Change-Id: I6c1ad0b41d4c5dc260b952322fb8a59e7f175603
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11sd: inline BEGIN_SHAPE/END_SHAPE macrosMiklos Vajna
They are used only once. Change-Id: I9d3f3ae1fd8210f09bc11b267ccb2d0a437701f8 Reviewed-on: https://gerrit.libreoffice.org/23991 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-11clang-tidy performance-unnecessary-value-param in ooxNoel Grandin
Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e
2016-04-11cid#1358429 null pointer dereferenceMiklos Vajna
Change-Id: Iec3e2218c356c5a3d01edc0aa55ad9fd18e957f2
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10tdf#99155: fix crash on clicking subcategory title in customanimationsJulien Nabet
Change-Id: I87b8664366c44d80a3ad1b4062ccb99bb1cdb8b9 Reviewed-on: https://gerrit.libreoffice.org/23955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-08lok context menu: Expose context menuPranav Kant
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-07tdf#97087 - Give Idles comprehensible and unique namesMuhammet Kara
Change-Id: I435d26c00f48506a3f6bfb22aae156e91636842a Reviewed-on: https://gerrit.libreoffice.org/23887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-07Avoid reserved identifiersStephan Bergmann
Change-Id: I63ab4de02702c6f74caa3a65f7d297e2a95a65cd
2016-04-06Indentation fixesMiklos Vajna
Change-Id: Ieba9dfed344e04067278300365172162d6d44aae
2016-04-05loplugin:constantparam in sdNoel Grandin
Change-Id: Ife610abb1f8ed19ab219301d41d7fc2174ff1d29 Reviewed-on: https://gerrit.libreoffice.org/23830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04Use std::size_tMiklos Vajna
And include <cstddef> where necessary. Change-Id: Icc1208528d6a8b04375d55ccbf3cd6ef046b454f Reviewed-on: https://gerrit.libreoffice.org/23796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01sd: add license boilerplate to source/ui/animations/CategoryListBox.hxxChris Sherlock
Change-Id: Ib49bfa10a59c59cb568e0235cdd30ceee8a74840 Reviewed-on: https://gerrit.libreoffice.org/23745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31loplugin:unreffunTor Lillqvist
Presumably the use of testSearchAllFollowedBySearch was removed by accident. Change-Id: I074426cd644fb64d0a8d3682b361e1aa8c20be0f
2016-03-31sd: overloading in C++ fail episode 6315Michael Stahl
Change-Id: I334037739f00bbb318fa780fcca898e099bc8fb8
2016-03-31sd lok bccu#1525: Unit test for the fix.Jan Holesovsky
Change-Id: I55107bd36a9b716ecbef4d01dd670617b141cc48
2016-03-31sd lok bccu#1525: Don't rely on the window size in the LOK case.Jan Holesovsky
Otherwise the table is inserted in the top left corner. Change-Id: Ia5d7099d4bace6f18cd7e8d3409427119240b756
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31Slide Show Settings Dialog: Help should be a secondary action button.Akshay Deep
Change-Id: I126f0d5c1ca3bcf54600fb938f3321da4e7700ee Reviewed-on: https://gerrit.libreoffice.org/23562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30tdf#96505: fix wrong SfxDispatcher::Execute calls ...Michael Stahl
... that are now busted on all 64-bit platforms since commit 57d0caacee2f395be2e89b78f8ece2d47b2c8683 but were already busted only on 64-bit WNT before. SfxDispatcher::Execute(sal_uInt16 nSlot, SfxCallMode eCall, const SfxPoolItem* pArg1, ...) assigns the varargs to a "const SfxPoolItem *", so passing in "0L" is only correct if long is 64-bit, but on WNT 64-bit long is 32-bit, so use "nullptr" already. Change-Id: I50448d8ad121c4881be549623d44c44b00e56d98
generated by cgit (git 2.34.1) at 2024-07-12 20:14:33 +0000