summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-11-12Related: tdf#121239 missing contour toggle in draw/impressCaolán McNamara
Change-Id: I384ba1f4fc67d1da7738f25f8b5d3fade315342c Reviewed-on: https://gerrit.libreoffice.org/82471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12tdf#121239 give writer, calc and draw/impress the same underline optionsCaolán McNamara
uno:Underline is the "real" deal, and has multiple underline options uno:UnderlineSimple is "some underline on" vs no underline calc and writer had UnderlineSingle, UnderlineDouble and UnderlineDotted for that specific type of underline on vs not-on add those to draw/impress too and then use UnderlineSingle instead of Underline in the format menu so that when UnderlineDouble is applied, UnderlineSingle is not show as applied, instead of using Underline ot UnderlineSimple which would show as on if UnderlineDouble was applied Change-Id: I6f9fcf37c2c90d215ea52b536e4fa84734754850 Reviewed-on: https://gerrit.libreoffice.org/82469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12tdf#128651 SdrObjCustomShape::NbcSetSnapRect needs logic rectRegina Henschel
SdrObjCustomShape::NbcSetSnapRect needs a logic rect in its parameter. A general change to snap rect as input in NbcSetSnapRect is not possible, if the transformation has to be kept. Therefore callers need to be adapted. This is done her for SdrUndoAttrObj. The error was that for a transformed custom shape with text, undo and redo had generated a wrong size of the shape. A least the following actions were affected: extrusion on/off, shadow on/off, and changes in line or fill properties. The unit test uses extrusion on. Change-Id: I8b6990d3d57d25f15f18e8690fc49dbe5e2a2728 Reviewed-on: https://gerrit.libreoffice.org/82367 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-11-12Related: tdf#121239 super/sub not shown as toggles in draw/impressCaolán McNamara
Change-Id: Ibb4a8a638bdba0ec0b2a859c685233d36b6c852e Reviewed-on: https://gerrit.libreoffice.org/82468 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11Related: tdf#121239 overline missing in draw/impressCaolán McNamara
where underline already exists Change-Id: I87df3f3965526266b94f10fa04448b32a81fd99a Reviewed-on: https://gerrit.libreoffice.org/82459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11Fix typoAndrea Gelmini
Change-Id: I234d2a47d5c6717d194cc8407066fa5954c16253 Reviewed-on: https://gerrit.libreoffice.org/82409 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-10tdf#106638 oox: reset font settings if necessary.Mark Hung
Direct formatting was used when symbols were inserted. However when there wasn't any direct formatting of Latin fonts in the following runs, it didn't know how to reset the font. Get the default font with XPropertyState and try to reset to the default value if symbol fonts are set. Change-Id: I83c9317ba61a96375128f1cc3ed478d958ddaa5c Reviewed-on: https://gerrit.libreoffice.org/81956 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-11-08Fix tdf#124708: CRASH: Selecting all and deletingMuhammet Kara
Change-Id: I0de912dad97f266a56ab52a351b0676f17675ed5 Reviewed-on: https://gerrit.libreoffice.org/82332 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-08jsdialogs: apply .uno:FillColor in ImpressSzymon Kłos
Change-Id: Ic85233716998f3a88792501266c4d8214c4ab1a2 Reviewed-on: https://gerrit.libreoffice.org/82292 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82303 Tested-by: Jenkins
2019-11-08jsdialog: apply .uno:XLineColor in ImpressSzymon Kłos
Change-Id: I02bd0ce5d3b71e6acf28f56aead41abc76b42465 Reviewed-on: https://gerrit.libreoffice.org/82280 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82300 Tested-by: Jenkins
2019-11-08jsdialog: apply .uno:LineWidth in ImpressSzymon Kłos
Change-Id: I7b9a3e5d6af5ccf9e9be28c5a1460fbf8553ff08 Reviewed-on: https://gerrit.libreoffice.org/82275 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82281 Tested-by: Jenkins
2019-11-07Removed duplicated includeAndrea Gelmini
Change-Id: Ic1fa4455449bab3c83528c5474d478fbe5ce220b Reviewed-on: https://gerrit.libreoffice.org/82055 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-07android: ODR fix of RID_PAGEFORMATPANEL_MARGINS_CM.Jan Holesovsky
Without this, we get a linking error that RID_PAGEFORMATPANEL_MARGINS_CM is defined twice. Change-Id: Ib9c07adcb0a8def991d1e39429c1bb4947cd7d32 Reviewed-on: https://gerrit.libreoffice.org/82159 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-06Resolves: tdf#128631 dispatch active ole asyncCaolán McNamara
like we do for the other things that might create dialogs Change-Id: I31ca267526ddeac8d0c7163af45c11be7750cb4c Reviewed-on: https://gerrit.libreoffice.org/82143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06Impress Options Dialog Print updateandreas kainz
Change-Id: I401562e96c05a6c2af0bbe928bd92f7e611cced6 Reviewed-on: https://gerrit.libreoffice.org/82111 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06SdAbstractDialogFactory::Create is still needed by CppunitTest_sd_dialogs_testStephan Bergmann
This partialy reverts c02c4df9414ed2bef96565522238ca05013d3ac3 "make some classes module-private". Change-Id: Ice669f8a19d2721959b74125a3b2bddb8c06d60d Reviewed-on: https://gerrit.libreoffice.org/82120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-06Impress Print Dialog spacing HIG alignandreas kainz
Change-Id: Ic0d7ade5f8aeb9300ecb8d39c613f155f6587b2a Reviewed-on: https://gerrit.libreoffice.org/82112 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06Impress Sidebar Tabledesign updateandreas kainz
Change-Id: I54bc3e8a7d7a059311e72bb47b9945359dd32d0e Reviewed-on: https://gerrit.libreoffice.org/82114 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06Impress Options Dialog General updateandreas kainz
Change-Id: I019cba1f1e0031ea16b4c69f3ed2f41a1bd6a39f Reviewed-on: https://gerrit.libreoffice.org/82110 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05restore accessibility relationsCaolán McNamara
that went astray in... commit d3f9ff5202c72220ef3bc7d84d149f9beeb1d290 Date: Tue Nov 5 09:25:39 2019 +0100 Impress update Presentation Dialog Change-Id: I5dafc0a86d42be726d6c4ab5dc14877f4d6eb733 Reviewed-on: https://gerrit.libreoffice.org/82067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05Impress Effects Dialog updateandreas kainz
Change-Id: Ifa9a4c60038cd86e286e7bc1cf9fe97b0eceb5cb Reviewed-on: https://gerrit.libreoffice.org/82064 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05Impress update Presentation Dialogandreas kainz
Change-Id: I31d959bad05844adf77287ef5089cfa8bce5aa3e Reviewed-on: https://gerrit.libreoffice.org/82053 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05make some classes module-privateNoel Grandin
Change-Id: Ice9a57eedb166672dbdfae6da2a172ab77566a19 Reviewed-on: https://gerrit.libreoffice.org/81983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05jsdialogs: .uno:ChartBackColor with string argumentSzymon Kłos
Change-Id: I2f28a0ba957548b020eacf3d630dccef6ebbf5ed Reviewed-on: https://gerrit.libreoffice.org/82057 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-05Impress update Header Footer Dialogandreas kainz
Change-Id: I2662399692b18be511511020b66942c91699dc92 Reviewed-on: https://gerrit.libreoffice.org/82054 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05jsdialogs: .uno:Color with string argumentSzymon Kłos
Change-Id: Ifdc95ff8c6a71340de3ed66cf58bc937e3730810 Reviewed-on: https://gerrit.libreoffice.org/82038 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-02New loplugin:conditionalstringStephan Bergmann
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-02cid#1455210 Dereference before null checkCaolán McNamara
Change-Id: Iadf78e41afabc8e3468e23bd5b249e47c019c843 Reviewed-on: https://gerrit.libreoffice.org/81936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455215 Improper use of negative valueCaolán McNamara
Change-Id: I0a397cb54192b613bf61a8faa384507b9731b828 Reviewed-on: https://gerrit.libreoffice.org/81940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01Resolves: tdf#128476 limit sidebar navigation panel file name combobox widthCaolán McNamara
Change-Id: I81549ada6f6b736ad54e18a4fec6807b8d0412af Reviewed-on: https://gerrit.libreoffice.org/81875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01loplugin:finalclasses in sd/incNoel Grandin
Change-Id: I29c7656d532fc0c8bcf1379a2f54d052aa4253e8 Reviewed-on: https://gerrit.libreoffice.org/81877 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31Fix missing param for screenshotting SdTabPageDialogMuhammet Kara
Change-Id: I8f467c9e72811cb6d7f015f7d7d9a944882d48ec Reviewed-on: https://gerrit.libreoffice.org/81820 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-31tdf#113041: Kill WaitCursor after FindAll in Draw and ImpressMuhammet Kara
Change-Id: Ibfbbc673a00839f538febc5bab1140b2e53535eb Reviewed-on: https://gerrit.libreoffice.org/81809 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-31tdf#114175: No slides in DrawMuhammet Kara
In the past in Draw and Impress the same term 'slide' was used. Although it was decided to use 'page' in Draw and 'slide' in Impress; in several locations of the user interface this has been changed but not everywhere. Change-Id: I8f0911a6ae1775335950c0212dac52962a2af46a Reviewed-on: https://gerrit.libreoffice.org/81779 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-31tdf#84257: Consistent 'slide' naming in Impress UIMuhammet Kara
Change-Id: I6af0f6d79e145a4a0497cd72f960ee21d595b311 Reviewed-on: https://gerrit.libreoffice.org/81796 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-30tdf#114175: Set proper title for page rename dialog in DrawMuhammet Kara
Change-Id: I014a4a654b9f6f4f330e61d1436d2a7aceead0c1 Reviewed-on: https://gerrit.libreoffice.org/81738 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-30tdf#114175: Proper naming for 'Insert Page' undo action in DrawMuhammet Kara
Change-Id: Ia22b4ee8cde95dac936715ef89ca5ef9811ede12 Reviewed-on: https://gerrit.libreoffice.org/81735 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-30tdf#126324 pptx unit test for custom date importTamas Bunth
Add unit test for importing custom date field (<c:fld> element of type "datetime") Change-Id: Ifcb5641c99eeb79afe54b801750e68792880c000 Reviewed-on: https://gerrit.libreoffice.org/81682 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-30svx: prefix members of SdrModelMiklos Vajna
See tdf#94879 for motivation. Change-Id: I08d77b07092894b67f33ce4cdbe29302b61121d3 Reviewed-on: https://gerrit.libreoffice.org/81717 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-29remove unnecessary includesCaolán McNamara
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f Reviewed-on: https://gerrit.libreoffice.org/81676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29lok: simplify the function "SlideBackground::DumpAsPropertyTree"Henry Castro
Change-Id: I288bcfa2f6ba82e83c541430d3782f2001645396 Reviewed-on: https://gerrit.libreoffice.org/81544 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-29tdf#108202: Correct Draw page naming in insert pages, and page naming dialogsMuhammet Kara
Change-Id: I2485bc29d6286cc30436fa9ecfb29e724578db41 Reviewed-on: https://gerrit.libreoffice.org/81631 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-28tdf#125191 Give object copies unique namesJim Raykowski
This patch makes a unique name for a copy of an object having a user given name. Change-Id: I14a7f45cc02962fc34a1532dd5db1cb9657b41d3 Reviewed-on: https://gerrit.libreoffice.org/77500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-25sd: fix missing includeMiklos Vajna
Change-Id: I696268d5eb27c51a9058da354676feceba4813da
2019-10-25lok: ensure that the paper size list box control has selected items inHenry Castro
the slide background panel. When a client side request the property tree data on the background panel the paper size list control has no selected items yet. I was tempted to force update the selected item in "Slide Background:: Initialize", however, I am not sure why it is not initialized the list box. This is done after an asynchronous update, maybe it is because the impress document is not initialized yet. anybody knows?. I prefer not to have side effects, so let's force initialization on in the tiled rendering case when the function SlideBackground::DumpAsPropertyTree is called. Change-Id: I596b75da46f2180342cb50bde03ee0ff1d414f05 Reviewed-on: https://gerrit.libreoffice.org/81483 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-23Resolves: tdf#128313 disambiguate flow-to search resultsCaolán McNamara
for a11y between find/replace where our result is a single thing, and find-all/replace-all where the result is potentially many things, which allows that searching in a selected calc column will flow-to the current cell, not the entire ~infinite set of cells in the column Change-Id: Ib3e56fceb90d869f157427f090cdffe986a5a588 Reviewed-on: https://gerrit.libreoffice.org/81396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-11 04:31:52 +0000