summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-04-11sd: inline BEGIN_SHAPE/END_SHAPE macrosMiklos Vajna
They are used only once. Change-Id: I9d3f3ae1fd8210f09bc11b267ccb2d0a437701f8 Reviewed-on: https://gerrit.libreoffice.org/23991 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-11clang-tidy performance-unnecessary-value-param in ooxNoel Grandin
Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e
2016-04-11cid#1358429 null pointer dereferenceMiklos Vajna
Change-Id: Iec3e2218c356c5a3d01edc0aa55ad9fd18e957f2
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10tdf#99155: fix crash on clicking subcategory title in customanimationsJulien Nabet
Change-Id: I87b8664366c44d80a3ad1b4062ccb99bb1cdb8b9 Reviewed-on: https://gerrit.libreoffice.org/23955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-08lok context menu: Expose context menuPranav Kant
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-07tdf#97087 - Give Idles comprehensible and unique namesMuhammet Kara
Change-Id: I435d26c00f48506a3f6bfb22aae156e91636842a Reviewed-on: https://gerrit.libreoffice.org/23887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-07Avoid reserved identifiersStephan Bergmann
Change-Id: I63ab4de02702c6f74caa3a65f7d297e2a95a65cd
2016-04-06Indentation fixesMiklos Vajna
Change-Id: Ieba9dfed344e04067278300365172162d6d44aae
2016-04-05loplugin:constantparam in sdNoel Grandin
Change-Id: Ife610abb1f8ed19ab219301d41d7fc2174ff1d29 Reviewed-on: https://gerrit.libreoffice.org/23830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04Use std::size_tMiklos Vajna
And include <cstddef> where necessary. Change-Id: Icc1208528d6a8b04375d55ccbf3cd6ef046b454f Reviewed-on: https://gerrit.libreoffice.org/23796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01sd: add license boilerplate to source/ui/animations/CategoryListBox.hxxChris Sherlock
Change-Id: Ib49bfa10a59c59cb568e0235cdd30ceee8a74840 Reviewed-on: https://gerrit.libreoffice.org/23745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31loplugin:unreffunTor Lillqvist
Presumably the use of testSearchAllFollowedBySearch was removed by accident. Change-Id: I074426cd644fb64d0a8d3682b361e1aa8c20be0f
2016-03-31sd: overloading in C++ fail episode 6315Michael Stahl
Change-Id: I334037739f00bbb318fa780fcca898e099bc8fb8
2016-03-31sd lok bccu#1525: Unit test for the fix.Jan Holesovsky
Change-Id: I55107bd36a9b716ecbef4d01dd670617b141cc48
2016-03-31sd lok bccu#1525: Don't rely on the window size in the LOK case.Jan Holesovsky
Otherwise the table is inserted in the top left corner. Change-Id: Ia5d7099d4bace6f18cd7e8d3409427119240b756
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31Slide Show Settings Dialog: Help should be a secondary action button.Akshay Deep
Change-Id: I126f0d5c1ca3bcf54600fb938f3321da4e7700ee Reviewed-on: https://gerrit.libreoffice.org/23562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30tdf#96505: fix wrong SfxDispatcher::Execute calls ...Michael Stahl
... that are now busted on all 64-bit platforms since commit 57d0caacee2f395be2e89b78f8ece2d47b2c8683 but were already busted only on 64-bit WNT before. SfxDispatcher::Execute(sal_uInt16 nSlot, SfxCallMode eCall, const SfxPoolItem* pArg1, ...) assigns the varargs to a "const SfxPoolItem *", so passing in "0L" is only correct if long is 64-bit, but on WNT 64-bit long is 32-bit, so use "nullptr" already. Change-Id: I50448d8ad121c4881be549623d44c44b00e56d98
2016-03-29tdf#95932: PPTX import: Incorrect inheritance of shape styleMatus Uzak
Inheritance Order: 1. Reference Shape's properties, 2. Shape style, 3. Shape properties. You MUST NOT inherit reference shape's style, because it's already part of inherited reference shape's properties. That would overwrite shape properties applied at point 3, at slide layout/master level. Change-Id: Id1ab550295988b0087a67c6819dfe32f84825e4e Reviewed-on: https://gerrit.libreoffice.org/23182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-29cid#1357164 correct CovertyScan possible DIVIDE_BY_ZEROArmin Le Grand
Also covers cid#1357165, exclude possibility that value equals zero at the same place negative values get excluded Change-Id: If3fd6143fb13f0d29f5fba304f9f337f7a7aa74c Reviewed-on: https://gerrit.libreoffice.org/23592 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-03-25fix headless buildOliver Specht
disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-24loplugin:constantparam in sdNoel Grandin
Change-Id: I1a7f4cab28a70c45e5232e1c44f6ca6f7b014bff
2016-03-23tdf#93868: PPTX import: Incorrect inheritance of shape fill propertiesMatus Uzak
DrawingML: The useBgFill attribute specifies that the shape fill should be set to that of the slide background. Change-Id: I8b568e730f00326d51e7b604579f4ff990b26f8a Reviewed-on: https://gerrit.libreoffice.org/23039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-22add HAVE_FEATURE_ATL to disable failing tests due to ATLMayank Gupta
Change-Id: Ifcdf8bf9eb4c22df6493f85592c9c72fac28876e Reviewed-on: https://gerrit.libreoffice.org/23144 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-03-22tdf#98646 Fixed freeze by flattening loopsArmin Le Grand
DrawViewShell::MakeVisible was using loops for finding the area to change the visible part of the EditView to. That could (and did) potentially loop for a long time for very large objects, deep zoom or numerical problems. That loops were flattened, the results checked to be the same. Also added a test for numerical overflow for getting values from the Rectangle describing the object size. Despite these values being the result of erraneous import, I opt for checking and avoiding using these values. Change-Id: I783dc1f2ad9b6a60a47e660b0d576ea3f22a4e42 Reviewed-on: https://gerrit.libreoffice.org/23278 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-03-22tdf#84323: Make osl::Thread::wait more readableGurkaran
It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-20Revert "tdf#93124: Fix incorrect text fit in imported PPT"Thorsten Behrens
Change broke autofit feature, see bugreport. This reverts commit 5ca1f04976930c6fd656ebf89d667c80e2466897.
2016-03-19tdf#93124: Fix incorrect text fit in imported PPTMike Kaganski
To make text adjustment to full width, the alignment optimizations had to be removed, and bAutoFit was removed, too. Allso, to fix tdf#41245 again, the SDRTEXTFIT_AUTOFIT that is set in SdStyleSheetPool::CreateLayoutStyleSheets had to be overridden. I touch the following commits: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2000efb31f864e912c6cf52760eea0e602b6893 http://cgit.freedesktop.org/libreoffice/core/commit/?id=3550256daa5451c1d51d220d5489c1b20150c374 http://cgit.freedesktop.org/libreoffice/core/commit/?id=812aff65ad0661fed9687a429c763dc8f2144a0c Change-Id: I7f7934e2982baf0240c740e09fcb9bd348079064 Reviewed-on: https://gerrit.libreoffice.org/18895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-18convert SvButtonState to scoped enumNoel Grandin
Change-Id: I601f9e2fe33e85cf3f7dc52ee20d68202bd2b09d
2016-03-18convert SvLBoxButtonKind to scoped enumNoel Grandin
Change-Id: Ia8e19473132cf95837acc499c5831b5ca8786a68
2016-03-18loplugin:constantparam in sdNoel Grandin
Change-Id: Idad86a005a7df1af38722fa0e909ed9b6e0858fa
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-18loplugin:constantfunction in editengNoel Grandin
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17tdf#65219 Fix temp files clean up in sd unit testsAleksas Pantechovskis
Change-Id: I99037b01c1d644b1803b315cc5e3d8fa5a19bcfb Reviewed-on: https://gerrit.libreoffice.org/22986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-17loplugin:constantparam in sfx2Noel Grandin
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd Reviewed-on: https://gerrit.libreoffice.org/23321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in svxNoel Grandin
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80 Reviewed-on: https://gerrit.libreoffice.org/23303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16tdf#98678 removed double for-loopArmin Le Grand
By error the for-loop was added twice, removed one Change-Id: If098dae28857bd87a07bb828bab2c7330c5fd7f8 Reviewed-on: https://gerrit.libreoffice.org/23294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-16tdf#84953 Only resize proportionally when dragging on a cornerSamuel Mehrbrodt
Change-Id: Iec4eda867216575e058fa673788d9345da05c872 Reviewed-on: https://gerrit.libreoffice.org/23291 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-16coverity#1356337 Resource leakCaolán McNamara
Change-Id: Id00ee8abd5f22bf0594ad41e3922222872d6c5ca
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16sd: add license boilerplateChris Sherlock
Change-Id: Iab97ad48b44d2c1bc8c6712dfe9e3d52a974f0a0
2016-03-15tdf#97919 Also resize ole objects proportionally by defaultSamuel Mehrbrodt
Change-Id: I1c3b13aa4cb0127451353f20179f39b6eebe12ec Reviewed-on: https://gerrit.libreoffice.org/23284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15sd image resizing: Small code cleanupSamuel Mehrbrodt
The decision whether to resize proportionally should be made in FuPoor::doConstructOrthogonal Change-Id: I9f27bc377db2933f781f962b0048527ded533b34 Reviewed-on: https://gerrit.libreoffice.org/23281 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>