summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-01-22ofz optimize this unique name generator a tadCaolán McNamara
Change-Id: Ie18f71febbfc5e1ed4300782919bbd92d76ea51b Reviewed-on: https://gerrit.libreoffice.org/48318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-22StartExecuteAsync doesn't need a second paramNoel Grandin
we can just use this to store a keep-alive reference in AsyncContext Change-Id: I0152aef5386aa9753b48afdfc958790f10d13560 Reviewed-on: https://gerrit.libreoffice.org/48294 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-22C++17 deprecated std::shared_ptr::unique()Michael Stahl
Most of these calls are in assertions, and the ones that aren't should be guarded by SolarMutex, so the thread safety concerns that caused unique() to be deprecated don't look relevant, so use use_count(), which oddly enough isn't deprecated. Change-Id: Ia166615af6c3ce85145c391752669c7461bd35fb Reviewed-on: https://gerrit.libreoffice.org/48222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-20Addition of focus_on_click to notebookbar ui filesMaxim Monastirsky
(automatic rewrite) Change-Id: I959b58b3b0b69de9344b0f7188594a19e8b9d4ea Reviewed-on: https://gerrit.libreoffice.org/48176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-01-20More loplugin:cstylecast on macOSStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Iff4877e8a42804c952c48c13332caf0a83c92870 Reviewed-on: https://gerrit.libreoffice.org/48216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986 Reviewed-on: https://gerrit.libreoffice.org/48185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19inline some definesNoel Grandin
which don't add any value anymore Change-Id: I45977d972d4d02926630b749d3ec736416138cf5
2018-01-19new loplugin:emptyifNoel Grandin
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19Unit test for tdf#114488Samuel Mehrbrodt
Change-Id: Ib9430d2c1cc05c7b73273270f8f96e716fc4dc3f Reviewed-on: https://gerrit.libreoffice.org/48129 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-18lokdialog: Convert the Format -> ... -> Area... to async exec.Jan Holesovsky
Change-Id: I3756bd472b4e54db1d1c9da382d5d655f472bdb7 Reviewed-on: https://gerrit.libreoffice.org/48080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokdialog: Convert the Format -> ... -> Line... to async exec.Jan Holesovsky
Change-Id: Ieaf440abf819d503d388a8b060dbf7fe6548db9e Reviewed-on: https://gerrit.libreoffice.org/48073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-18lokdialog: Convert the Format -> ... -> Position and Size... to async exec.Jan Holesovsky
Change-Id: Idcdbfb1366db61e247c31eab5cb27a39978b0fd9 Reviewed-on: https://gerrit.libreoffice.org/48055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-17Fix typosAndrea Gelmini
Change-Id: I18ce04cbaa79c827a52e2441e98ee2e3377b5877 Reviewed-on: https://gerrit.libreoffice.org/48077 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17CppunitTest_sd_import_tests: clean up manual model/frame/controller assemblyMiklos Vajna
Change-Id: I50341e783ad0964167dc9819a28aa1f264de44b0 Reviewed-on: https://gerrit.libreoffice.org/48032 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-17Fix typosAndrea Gelmini
Change-Id: I5fff9ccb1bc74b85ee378439ffa2272583ffcb0f Reviewed-on: https://gerrit.libreoffice.org/48024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-17tdf#100898: slide transition panel is now Tab-reachableKatarina Behrens
This is a cheap-o solution, a better approach would be to remove intermediate sidebar/SlideTransitionPanel and create panel layout directly in sd PanelFactory, but that would require quite some code rearrangement Change-Id: Ief2d8c3dc365b739b2eba65c6142d5301610d479 Reviewed-on: https://gerrit.libreoffice.org/48018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-16use more ScopedVclPtr to avoid missing disposeNoel Grandin
follow on to commit 315be3a276b01e88c794da1dbc6252a8b803d269 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 12 10:48:59 2018 +0000 VclPtr, missing dispose Change-Id: Idfa4709f10928ef6d53ada93db0f5452e5d5c4eb Reviewed-on: https://gerrit.libreoffice.org/47982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16Fix typosAndrea Gelmini
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2 Reviewed-on: https://gerrit.libreoffice.org/47858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-15Fix typoAndrea Gelmini
Change-Id: I51c97356c9c2939f2d94d6388c829a179ca00daa Reviewed-on: https://gerrit.libreoffice.org/47853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-15More loplugin:cstylecast: sdStephan Bergmann
Change-Id: I77ed2793aad62377ec6fc2513e06e2371c1c77ad
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14Use = for initializationStephan Bergmann
...so that an automatic loplugin:cstylecast rewrite (with a to-be-committed enhanced loplugin) won't rewrite that to -Werror,-Wvexing-parse al_Int16 nTmp( sal_Int16(style::ParagraphAdjust_LEFT) ); Change-Id: I27a8b8fea129f9f1d755499bf204a7c8f2b35976 Reviewed-on: https://gerrit.libreoffice.org/47868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-14change testN821567 to work on more import/export filtersTomaž Vajngerl
- rename the test to something sensible - comment the test use case - change the test to cover more import/export filters Change-Id: Ib9be1148d239d99e70e62efaafb69daf25c72164 Reviewed-on: https://gerrit.libreoffice.org/47852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-12ofz#5274 Out-of-memoryCaolán McNamara
Change-Id: I3e69f5e2be848933a43d09c620dafd946486e731
2018-01-12More loplugin:cstylecast: sdStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I144975b94fe2725ac740a953ca2133e99f8a3fce
2018-01-11loplugin:redundantcast: sdStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: I1dc10a2acaf134a3cff142a4ec4afc906b88c260
2018-01-11Fix Tab key cycle through slide background panelKatarina Behrens
Remove empty widget container, lot of garbage placeholders and redundant adjustment. Regression from commit fba28df77d7e98663d1cf77ac206f8799fce4108 Oh dear, how could I possibly have reviewed this in? Change-Id: I25af642afad094faba5b0ba1e37cfbf1a954e52f Reviewed-on: https://gerrit.libreoffice.org/47720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-07UI Duplicate dlg: enable negative angleLaurent BP
Duplicate dlg (Shift+F3) should accept negative angle and angle between 359° and 360° Change-Id: I933816698143a9766a5127f3cefeaec317077289 Reviewed-on: https://gerrit.libreoffice.org/47393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-07tdf#113880 improve slide transition sidebar deckYousuf Philips
* added padding around transition list control * make controls in 'modify transition' accessible * correct alignment of variant label Change-Id: I129e387be1458b7f08fab7f460d9ae60cd5dd391 Reviewed-on: https://gerrit.libreoffice.org/47320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-06tdf#114848 Don't save empty themesSzymon Kłos
Change-Id: I7136f5c0bc884a2f9ea945b4e0bc093a5ef2d8df Reviewed-on: https://gerrit.libreoffice.org/47481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-01-06remove unused definesNoel Grandin
In particular, the STR_SVT_MIMETYPE defines are dead since commit 1b694dad643334ec1bab3f823dcd68f44a05ebe3 Date: Thu Aug 24 22:14:27 2017 +0200 loplugin:unusedmethods Change-Id: I641ec0a14efedc55c9d6a4de4a28784c273602e9 Reviewed-on: https://gerrit.libreoffice.org/47464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05lokdialog: Allow language switching in SfxModule(s).Jan Holesovsky
Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b Reviewed-on: https://gerrit.libreoffice.org/47385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-04ofz#4943 Direct-leakCaolán McNamara
Change-Id: I45b7c6befadda58d7919732597647b9e2cbd46d8 Reviewed-on: https://gerrit.libreoffice.org/47373 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-04drop Cache typedefNoel Grandin
Change-Id: Id1c568f7d089c345643227a6e9d0fee09aabfab8 Reviewed-on: https://gerrit.libreoffice.org/47345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03loplugin:passstuffbyref more return improvementsNoel Grandin
slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02loplugin:passstuffbyref improved return in sd,variousNoel Grandin
Change-Id: I4b6ea89ae2072f4389a696ea3c96d8f7a5731e7a Reviewed-on: https://gerrit.libreoffice.org/47246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02RID_* can be extern global variablesNoel Grandin
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: https://gerrit.libreoffice.org/47245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-02Fix typosAndrea Gelmini
Change-Id: If8f042c6ef02c204f8946900e9ea8b99f06a631c Reviewed-on: https://gerrit.libreoffice.org/47240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-31tdf#114045 do not add undo action for table attributesMark Hung
CreateUndoAttrObject() create extra undo steps when using table paint brush on table cells. Undo action for each selected cell is processed individually in SvxTableController::ApplyFormatPaintBrush(). Change-Id: I65034a2b510898db26a7a8ddc4b5f3b742fd9b88 Reviewed-on: https://gerrit.libreoffice.org/46729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-12-30tdf#90626 PPTX: Fix image bullet position in PPTPaul Trojahn
Scaled bullet points aren't centered in PPT, so padding needs to be added to get them to the correct position. Change-Id: I61509dd43ef9cd697dcbc3cabbf58a21d625ddec Reviewed-on: https://gerrit.libreoffice.org/46994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-29loplugin:unnecessaryparen improve return checkNoel Grandin
Change-Id: I8128aa4b5fc60efd1dbf5971cdde11e588f5f64b Reviewed-on: https://gerrit.libreoffice.org/47167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I0e56430afa65b6b5826d56212ac501c0244fce9b Reviewed-on: https://gerrit.libreoffice.org/47145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-27tdf#109100: Hide label for margin control in ImpressAron Budea
Change-Id: Ib61656913df673ebfde61e2c921f84cb81195a3b Reviewed-on: https://gerrit.libreoffice.org/46974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-27delete operators properlyJochen Nitschke
Change-Id: Ia917b70712717387aa8d7a17334efd41931bdb88 Reviewed-on: https://gerrit.libreoffice.org/47087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-25various coverity exception warningsCaolán McNamara
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23tdf#95827 Reorganize draw's menu barYousuf Philips
Change-Id: Ied9be2da293e6d318548019e29ae4f95e568144a Reviewed-on: https://gerrit.libreoffice.org/46867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-22Revert "unused SID command in sd"Noel Grandin
This reverts commit 46db544b41fd30f61dd7b7b4fa2b97ab22ceb079. Change-Id: I8eed13269000a7fc4c52c1695e36df8607b470ac Reviewed-on: https://gerrit.libreoffice.org/46965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-05 03:05:06 +0000