summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-08-07cppcheck: va_list 'args' was opened but not closed by va_end()Julien Nabet
Change-Id: Id7602dd19ac142dbe2680ddf7eab308a087e971a
2014-08-07Handle collada libraries seperately: --disable-colladaZolnai Tamás
Depends on gltf support. Change-Id: Ief0452da3d03b0ddbca45272e5f5cd268691aeca
2014-08-07Consistency around SdrYesNoItem in svx/sxmsuitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I25002e5b6043baa8c93b180a03f475bea5906e4f
2014-08-06Consistency around SdrMetricItem in svx/sxelditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." (SdrEdgeLine1DeltaItem::Clone had been recently---and in retrospect needlessly ---introduced in 596ec6f52fe3a8d56d5c20df568633cfbcadc74d "Missing SdrEdgeLine1DeltaItem::Clone override" before 3efa3ad7b6de78c291f49858e50e6bedbd6a2173 "SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlying" revealed that SdrEdgeLine1DeltaItem was a needless derivation of SdrMetricItem.) Change-Id: I154d32d46a7c01c792aa4e812cf576d4d749e0c9
2014-08-06Consistency around SdrOnOffItem in svx/sdasitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Icdeff7f37901f99158bb00de5e912c181bf3e688
2014-08-05Let GetObjectItemPool return a referenceStephan Bergmann
Change-Id: Ibbcfa3452afcf88dbb6050765e081a1be2381334
2014-08-05fdo#81552 Fail nicely if avahi doesn't let libreoffice publish itemsBryan Quigley
Change-Id: Ie264a032a71bda336158e18bd2b14c569f23f42d Reviewed-on: https://gerrit.libreoffice.org/10735 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-05fdo#79917: Add 'Save a Copy' to Calc/Impress/Draw.Heiko Scheidt
Was added to writer in LO 4.1 but menu entries for other modules were overlooked. Change-Id: I90bcaa727eaa8fd8b35218f73c101f25c7a71d7b Reviewed-on: https://gerrit.libreoffice.org/10707 Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com> Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com>
2014-08-05Clear() an SdPage while it is still an SdPageStephan Bergmann
... because when Clear() is later called in the SdrObjList sub-object dtor, freed SdrObject dtors may call back via SdrObject::SendUserCall into this virtual SdPage::Changed, but then this is only an SdrObjList, causing undef behavior. Change-Id: I09a2d1445a51a70e8f795ff869027899ad0f528b
2014-08-05GetPage requires mpPage to be an SdPageStephan Bergmann
...which is apparently not always the case; at least observed that during CppunitTest_sd_html_export_tests. Change-Id: If3d73249845adfa6b489e783693768e755033f4a
2014-08-05Avoid undef out-of-range value -1 for XPropertyListType enumStephan Bergmann
Change-Id: If2dedafe6d8517eba4dd4921d15dd2d969d181dd
2014-08-05Consistency around SdrOnOffItem in svx/sdshitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-08-04Consistency around SdrOnOffItem in svx/sdtagitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04prevent memory leakMarkus Mohrhard
Found by Lsan. Returning this or a heap allocated object asks for trouble. Let the caller handle it and return null instead of this. Change-Id: I7586e103bef5a8c2727adfe214b052d6962d4467 Reviewed-on: https://gerrit.libreoffice.org/10716 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-04Consistency around SdrMetricItem in svx/sdtditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-03put ReadThroughComponent to anon. namespace to avoid redefinitionTomaž Vajngerl
Change-Id: Idcc97e067b0f389a5d9e01013ab2fc20d2dd4ccd
2014-08-02fix deps for sd_import_testsDavid Tardon
Change-Id: Ica864f8fc654df3dfeb83850ede43473904de261
2014-08-01bnc#862514: Handle corner case in slide sorter correctly.Jan Holesovsky
We should never return -1 when bIncludeBordersAndGaps is true; but that could have happened in a corner case: * export SAL_USE_VCLPLUGIN=gen * start LibreOffice * open a presentation with many slides * resize the window so that it shows the slides _exactly_, no slide is cut off in the slide sorter * point the mouse pointer into the left "Slides" sidebar (slide sorter) so that it does not cause any mouse-over effect (somehow between the left border, and the slides - there is space that can do this) * turn the mouse wheel all the way down so that the last slide is at the bottom * turn the mouse wheel up _once_ * turn the mouse wheel down _once_ - it will look like the view does not change (the last but one is still at the bottom), but you can see the scrollbar jump to the top * and now you can again start turning the wheel all the way down to repeat the procedure :-) Change-Id: I0253c89513222a1f2eb3263068997d10eea0f130
2014-08-01typo: more then -> more thanTakeshi Abe
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-31WaE: 'aPageKind' may be used uninitialized in this functionTor Lillqvist
Change-Id: Idb44259f11715b1d2c769bfebca7300cc397b7cf
2014-07-31Consistency around SdrMetricItemStephan Bergmann
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem while others where of trivial derived classes SdrTextMinFrameHeightItem etc., that appear to only existed for better-named constructors. Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-31cleanup usage of MapUnit enumNoel Grandin
some places were using the wrong enum constant, and some places were unnnecessarily converting to sal_Int16 Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31fix some dodgy FieldUnit conversionsNoel Grandin
the FieldUnit enum was being converted in some dodgy ways and in some places the MapUnit enum values were being used. Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-30Impress/Tiled Rendering: implement setPartMode.Andrzej Hunt
Change-Id: I831953ac3fa1d0a15b64aa008cc3bfb79e72575a
2014-07-30Impress/Tiled Rendering: return correct number for getPart.Andrzej Hunt
It looks like page ids begin with 1. Change-Id: I367285b8cfa1fcc9b8f22a9bb3c679d7e9579099
2014-07-30Impress: Implement getPartName.Andrzej Hunt
Change-Id: I614838505fef901fc37e8d3906bb59c60b034453
2014-07-29Drop unnecessary SfxApplication::CreateResManager wrapperStephan Bergmann
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-26coverity#704759 Dereference after null checkCaolán McNamara
Change-Id: I1f41d2bc43391175a4587f501f02775adc43bc8e
2014-07-26coverity#704753 Dereference after null checkCaolán McNamara
Change-Id: I4886995b925e3332e67d08a60e53a251be9f81e5
2014-07-26coverity#704748 Dereference after null checkCaolán McNamara
Change-Id: I88552b40658df85bbfbf0848e94085aa8eb649b6
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-22fdo#76754 Speed up registration of new listeners to SfxBroadcasterTobias Lippert
Also change behavior for the GetListenerCount() method which now returns the count of listeners. The previous behavior is available in method GetSizeOfVector(). Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89 Reviewed-on: https://gerrit.libreoffice.org/10344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-21coverity#707130 Uncaught exceptionCaolán McNamara
Change-Id: I76bbe1adb60e7662b4da1effc57feb54ad8733bd
2014-07-21fdo#79343 When searching in Draw or Impress, leave focus in search barAlex Henrie
Setting bGrabFocus to false resolved the problem. Change-Id: I7678be76e1cca2a3d58635b4fc44aa3b1cdddb9a Reviewed-on: https://gerrit.libreoffice.org/10362 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-21fdo#80536 UI: Menu entry for 'Edit File' -> 'Edit Mode'Joren De Cuyper
In this commit not only a menu entry is created, also the name is changed from 'Edit File' to 'Edit Mode'. Change-Id: Icd7998307cb0337dd2ee95b298452557ab37375b Reviewed-on: https://gerrit.libreoffice.org/10211 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-19XFillStyle -> css::drawing::FillStyleMiklos Vajna
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-18coverity#1226487 Dereference null return valueCaolán McNamara
Change-Id: Icbdf4f4b1739a63aa02260ddc3b29097cb157b63
2014-07-18coverity#1226485 Dereference null return valueCaolán McNamara
Change-Id: Ib875f26170b90416e2ab1c498d93fb727d9633ce
2014-07-18Resolves: fdo#81487 pasting into outline view crashes impressCaolán McNamara
CreateTitleTextObject will call indirectly ImpPageChange which triggers tools::EventMultiplexerEvent::EID_PAGE_ORDER and so in outlview.cxx without ignore page changes level in action the outliner is filled in from the slide contents in FillOutliner clearing the outliner contents and filling it fresh, but.. a) this hack tower is not prepared for all the outliner iterators to become invalid b) the contents of this title object is empty, because it was just created, and we didn't get a chance to fill in its text. This all works for typing vs pasting because the KeyInput uses the OutlineViewPageChangesGuard guard which sets the ignore pages changes bit. So, given that OutlineView::UpdateDocument expects the iterators of the outliner to be valid during the lifetime of the method lock the full method with the OutlineViewPageChangesGuard guard Change-Id: Iecbf37d54f5f0c5a181be5f27832f769a3d2e389
2014-07-17fix build failureMarkus Mohrhard
Change-Id: I95af4c2750c01e3e48f6708306b25f774c29e592
2014-07-17Related: rhbz#1117853 nStartPara of EE_PARA_NOT_FOUNDCaolán McNamara
we know that nStartPara is EE_PARA_NOT_FOUND so rOutliner.GetAbsPos must have returned that, but we don't know the circumstances that lead to that yet. Change-Id: I53a488317d154b4a3c050248b8737da0a611ca43
2014-07-17Render slides by default.Andrzej Hunt
We should probably introduce an API to allow selecting notes instead, however the default mode is to open whichever view we had open last for a given document -- whereas for nowwe probably always want to render the slides. Change-Id: I26540613d1a510f23e5abfc8fee2ad743c180f34
2014-07-17Allow setting DrawViewShell PageKind directly.Andrzej Hunt
Currently the only way to change the PageKind is via the UI controls (i.e. via ExecCtrl) -- however for tiled rendering we want to select the PageKind directly. Change-Id: I3a3fa8f8cefaa0e0212832aef4026433fc596263
2014-07-17make the temp file names random in sd testsMarkus Mohrhard
All the temp files got the same names for the temp files which might conflict when two tests try to get teh same temp file at the same time. Additionally it makes the dbgutil check by Norbert for finding leaked temp files useless. Change-Id: I692107f7705787c360247785b8d95daf4199c2a6
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-16Update test data to match my gradient handling changeTor Lillqvist
Thanks to vmiklos for pointing me to the instructions. Change-Id: Ic95ef443beceb9a30e4179cf2364bd753992c05e
2014-07-15Unit test for cell properties, where lastRow is used in table (bnc#887225)Matúš Kukan
Change-Id: Ia11dadcbedf6acc035b2d86da39a115bdb298591
2014-07-15fdo#80020 Fix regression for style sheet inheritanceTobias Lippert
The inheritance relationship of styles in Draw was lost when writing files. Change-Id: I81588a031bf4c649338fad9b7342fbbe11df9aef Reviewed-on: https://gerrit.libreoffice.org/10309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-14sd: stop calling graphics styles "Image Styles"Michael Stahl
(regression from a71a562a9958fc58a5fb914bcf7f8056a353f618) Change-Id: Ie3a44a80c720f59831bc2b1da91792fb8aa24d62
2014-07-14Related cp#1000084: Make this work for other apps too and set proper defaultMatúš Kukan
Extend d98c817cc71e62a2beecc7142062f9ef33a7149b and fix default. Change-Id: I79ad35bd5ad6fbd6e7d260864d4bf40fafb6b604