summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-06-28sd draw page: add PreviewMetafile UNO propertyMiklos Vajna
This allows an unnecessary GDIMetaFile -> WMF -> GDIMetaFile roundtrip, and also avoids the odd black border at the bottom / right of the preview metafile in the PDF import-as-graphic filter. Change-Id: I7e3e782bbe0cf56def352e23b60864bb7773b607 Reviewed-on: https://gerrit.libreoffice.org/26743 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-28Revert c7b9b9204ce2b3c1e0dbc0d79e4e01d27ad2ac7eMike Kaganski
Also make changes to make loplugin:staticmethods happy Change-Id: Ia55d063c0fa5a1d9392e09f23ebb1266f46745b9 Reviewed-on: https://gerrit.libreoffice.org/26740 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-28GSoC kill notebookbar after the real impress closeSzymon Kłos
Change-Id: I641ebdd7610289a872dd0c8de9b297e5e6ba0b45 Before: notebookbar was closed even if exit was canceled by user
2016-06-28loplugin:singlevalfields in variousNoel Grandin
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28svtools: survive swapout/in of graphic with embedded pdfMiklos Vajna
Use case is to insert a pdf file in Impress, then choose Save from the context menu of the image. On one hand, for some reason only bitmap images can be saved, so add an exception for the graphic-with-pdf case. SVG is not affected, as it counts as bitmap with its PNG replacement image, it seems. On the other hand, copying the GraphicObject around triggers swapout/swapin of the graphic, and there the original pdf data was lost, fix that. Change-Id: I8b4b67cd951e39b0250a101766f487ddb1088cab Reviewed-on: https://gerrit.libreoffice.org/26739 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-28loplugin:staticmethodsStephan Bergmann
Change-Id: I6e5a1c33eeb5eb139f12d4a9d696c53ad65a3af7
2016-06-28loplugin:overrideStephan Bergmann
Change-Id: I5307c3ca3ebef72a08055e9389bc53e760d4178c
2016-06-28ODP export: add embedded pdf supportMiklos Vajna
This is basically the draw shape equivalent of SwGrfNode::GetReplacementGrfObj(), that already had explicit code for PDF purposes. Change-Id: I00a619082f59a3e377d45c3a59615cadae295586 Reviewed-on: https://gerrit.libreoffice.org/26724 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-28notebookbar: added slide transition tabSzymon Kłos
- created VclVBox control which creates SlideTransitionPane - SlideTransitionPane extended with second constructor which loads ui in horizontal mode - introduced CloseMethod for NotebookBar to kill widgets in right order Change-Id: Ic3ba35cb7734aa744a4804c5b670fed7c1bec204 Reviewed-on: https://gerrit.libreoffice.org/25844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-28tdf#99729 prerequisite: model-level user data r/wMike Kaganski
This commit introduces a system for reading/writing common model-level user data (like compatibility flags from settings.xml). It is designed to reduce code duplication in cases where an option is applicable to any type of document. Change-Id: Id4e31df14f49cbb673f4a6df943ccec6d98eb9aa Reviewed-on: https://gerrit.libreoffice.org/26719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-27Move accessibility relations to .ui files, Part 11: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. As of this commit, all accessible relations of type "SetAccessibleName" have been moved to .ui files other than a few exceptions. Change-Id: I5972211f58de70889066dec3c74341b405f82c85 Reviewed-on: https://gerrit.libreoffice.org/26520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-27GSoC notebookbar: switching tabs depending on contextSzymon Kłos
+ sfx2::sidebar::EnumContext moved to the vcl module + TabPage contains vector with context values + vcl builder reads control's contexts from the "class" mark + ContextTabControl shows tabs depending on context Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d Reviewed-on: https://gerrit.libreoffice.org/26447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-27tdf92852 correct layout type mapping for 'Title, 6 Content'.Mark Hung
While creating slideLayouts, a number of layouts are iterated and master pages are created temporarily. The layout property of the slide is set based on the mapped value. Old value (33) seems to be typo, and is not accessible by users via UI. The layout contains a graphical object and hence generates unexpected image in the exported PPTX document. Change-Id: I53af11058994a48ed6239f57f9b2b95484c76411 Reviewed-on: https://gerrit.libreoffice.org/26559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-27loplugin:singlevalfields in sdNoel Grandin
Change-Id: Idde7bdbd57080518fc416ce97a062ab979393d8e Reviewed-on: https://gerrit.libreoffice.org/26656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24loplugin:singlevalfields in svtoolsNoel Grandin
Change-Id: I80fe1d4646af2b8d8e6362a25f6cda4b7ac29eab Reviewed-on: https://gerrit.libreoffice.org/26603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23Remove unused SfxObjectShell::libreOfficeKitCallback()Miklos Vajna
All clients have been converted to use SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: I793dad5194769f331037b12a1b1afba96ddea4ba Reviewed-on: https://gerrit.libreoffice.org/26584 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-23support for ms binary format validation in sd module export testsVasily Melenchuk
Change-Id: Ie03b0485bbe8ecaa452f19fbcbfe3bf5829aff68 Reviewed-on: https://gerrit.libreoffice.org/26515 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-22tdf#93124: The arbitrary number 100 seems to be too high, let's try 50Tor Lillqvist
The test fails on a tinderbox. Adding a temporary printf shows that the number there is 71. Change-Id: Ic8fbaab9e3d3434e20ba6aef5cc1acd66b5f4283
2016-06-21Remove no longer needed vcl::ITiledRenderable::registerCallback()Miklos Vajna
All clients has been changed to use SfxViewShell::registerLibreOfficeKitViewCallback() instead. Change-Id: I2538268dc9c4b449f68b5d2b05a72de584c29fd0 Reviewed-on: https://gerrit.libreoffice.org/26540 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20Remove unused includesStephan Bergmann
Change-Id: I25bb67449c8c572075d354e62b1c731e95655b4f
2016-06-20This code unlikely wants conversion from UNO Bool or Char AnysStephan Bergmann
...which would be the main difference with convertPropertyValue, in addition to throwing an exception upon failure that would be caught directly by the surrounding try-catch block Change-Id: I960e23b797c71be655c4059125effade84d0630c
2016-06-20Remove no longer needed SdrModel::libreOfficeKitCallback()Miklos Vajna
All former clients are changed to call SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: Ic5dcf0a8a4241338fcd6941f13ce438157676481 Reviewed-on: https://gerrit.libreoffice.org/26521 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20tdf#100441: Fix listbox state in master vs. normal modeKatarina Behrens
Events appear in following order: normal -> master: 1. EID_EDIT_MODE_MASTER, 2. EID_EDIT_VIEW_SELECTION master -> normal: 1. EID_EDIT_MODE_NORMAL, 2. EID_END_TEXT_EDIT This is only partial fix, selecting the right master page in other than normal mode is still broken Change-Id: I2dd91e77c4ed5627079fc9d2b39e40c8e74a9f8e Reviewed-on: https://gerrit.libreoffice.org/26484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-18uitest: loplugin:stringconstantMarkus Mohrhard
Change-Id: I863615af7a942b91513511ba515b82f3523c6aa5
2016-06-18uitest: support more impress operationsMarkus Mohrhard
Change-Id: I74ab526dabbee1f8c203274f187c065d9fb413fd
2016-06-18uitest: add initial code for impress main edit windowMarkus Mohrhard
Change-Id: I82eabe1df33878316907e664ddbcd8edf6a73d33
2016-06-18uitest: annotate a few draw/impress windowsMarkus Mohrhard
Change-Id: I6352842535fddc99d30a4d0180ac01e7f8d5cd48
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16comphelper: enable LibreOfficeKit::isViewCallback() by defaultMiklos Vajna
This requires porting the sw/sd/sc_tiledrendering test code to the new internal API, as only the public LOK API is unchanged. Change-Id: Ic6a2f96421da4a16bdee7d0cbb3f6e35bc6ddff9 Reviewed-on: https://gerrit.libreoffice.org/26379 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16sort the arrayDavid Tardon
Change-Id: Iab15a4344d2174db2763603d0107bc9ec372e4fb
2016-06-16rhbz#1343752 fix view status in menuDavid Tardon
... after commit 229fc164dc1773484b74eca016863cf68860e81b . Change-Id: Ibfbbb86c81527f008b8e1cbe9d8ca3174a944931
2016-06-16tdf#86759 and tdf#89466: Enable Page Background Panel for DrawSusobhan Ghosh
Rename Slide Background Panel to Slide in Impress. Reorder Properties Deck Change-Id: Ib2039c41c56a0182887f19aa362d633dcabfe9dd Reviewed-on: https://gerrit.libreoffice.org/26159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15SfxObjectShell::Current may return nullptrMarkus Mohrhard
See http://crashreport.libreoffice.org/stats/crash_details/caa7efba-fbe8-4c58-966d-c4bc356b5a63 Change-Id: Idc8b3a2e482a5423080735f46f50d415835f747d Reviewed-on: https://gerrit.libreoffice.org/26341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-15tdf#100209: Master slide of master slide makes no senseKatarina Behrens
so just disable the controls when in master view Change-Id: I9551cc5c0d123e58555d248b78859c1f77de6690 Reviewed-on: https://gerrit.libreoffice.org/26276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15crashreport: 644837b5-c445-4779-a75d-dd69fc2e3a6fCaolán McNamara
This can be reproduced by switching to master slide sidebar in impress , use the mouse to wheel up and down and then go straight to clicking the window manager close button The dispose doesn't ultimately drop its reference to the document so keeps it open if the scroll-wheel previous event widget vclptr keeps the widget around Change-Id: Ic90bcadf2489094358737be7f522129bd555a1ba
2016-06-15sfx2: bring the view shell's LOK callback up to date with SdrModelMiklos Vajna
This fixes CppunitTest_sw_tiledrendering in the LOK_VIEW_CALLBACK=1 case. Change-Id: Ib79e57908c3edda0154341baba8279ede4281a42 Reviewed-on: https://gerrit.libreoffice.org/26313 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15tdf#61396 Possibility to edit a template not in Template RepositoryAkshay Deep
Menu Sequence: Open Template... Save as Template... ---------------------- Manage Templates Change-Id: I0d0c8ca15d8dc38662e7f84a4f598933c13dd512 Reviewed-on: https://gerrit.libreoffice.org/26179 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-15sc, sd: add per-view support to recently added LOK_CALLBACK_SET_PART callsMiklos Vajna
These caushed an assertion failure when opening a Calc or Impress document in gtktiledviewer. Change-Id: If9cf1ef6c5a9d8e1b0d578b20dd3f513989b669b Reviewed-on: https://gerrit.libreoffice.org/26311 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15LOK: fire SET_PART event when Impress page is changedAshod Nakashian
Change-Id: Iebddffbdc66397b1f2937ed7320f7800c8bab4cc Reviewed-on: https://gerrit.libreoffice.org/26301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-15tdf#42949: clean up includes in include/filter with iwyuJorenz Paragas
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe Reviewed-on: https://gerrit.libreoffice.org/26238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-14Function to change sidebar panel title, via UNO APIKatarina Behrens
Change-Id: I147da965d71746220958852bf796197c30f219a3 Reviewed-on: https://gerrit.libreoffice.org/26243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-13sd: implement per-view LOK_CALLBACK_SEARCH_RESULT_SELECTIONMiklos Vajna
This way views can search without disturbing each other. Change-Id: I40e69b6102a959ef1f1825a7af1438c2f2fcf807 Reviewed-on: https://gerrit.libreoffice.org/26227 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13sd: implement per-view LOK_CALLBACK_HYPERLINK_CLICKEDMiklos Vajna
Change-Id: If0759525326f963b497a6e011027719fc376eaf9 Reviewed-on: https://gerrit.libreoffice.org/26226 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13sd: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna
With this, gtktiledviewer no longer crashes on load when opening a sample ODP file. Change-Id: I19857d6dcfab74c9fa282754e450c951f7ca564c Reviewed-on: https://gerrit.libreoffice.org/26223 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13sd: implement per-view LOK_CALLBACK_DOCUMENT_SIZE_CHANGEDMiklos Vajna
These callbacks were invoked from the model, so need to iterate over the view shells and invoke them on all the views. Change-Id: Ie8107f4782b513b874d0b94464ea372994dabbe9 Reviewed-on: https://gerrit.libreoffice.org/26221 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-13notebookbar: reduced paddingSzymon Kłos
Change-Id: I43df4ba611d7b377829ac3b5f17ff26077e9f13d
2016-06-13Related: tdf#93135 adjust the ui to reflect the text fit options entanglementCaolán McNamara
We have two major groups of text fitting options in draw/impress ones that apply only to custom shapes * Word wrap text in shape * Resize shape to fit text those that apply to other elements, e.g. text boxes, legacy rectangles and lines * Fit width to text * Fit height to text * Fit to frame * Adjust to contour Of the second group, only "fit to frame" is always available. Text boxes have "Fit width to text" and "Fit height to text", while stuff like legacy rectangles and lines etc have "Adjust to contour" instead. A fun issue is that (currently anyway) the bit for "resize shape to fit text" in custom shapes and the bit for "fit height to text" in text boxes is the same bit, SDRATTR_TEXT_AUTOGROWHEIGHT. So before this change in all circumstances the same collection of checkboxes for all settings was visible. With context used to enable or disable which ones could be set according to the type of shape it was. Simultaneously there is logic to enable/disable checkboxes depending on if other checkboxes that control contradictionary options were checked/unchecked. e.g. "Fit to frame" disabled if "fit height to text" is enabled. So its not apparently why some can be enabled and some disabled by clicking about the place in the shared collection. In this commit we split the sizing options into their two families, one frame and column for each of "custom shapes" and "everything else". When adjusting a single selected object we use context to determine which column to show or hide. When editing multiple objects or the underlying graphic styles we show both columns. When editing a presentation style we show just the text box column. (The use of HasText in the original code is a concern, cause it doesn't make sense to me, using it like that means that in the original dialog format->text on an empty text box from F2 shows the contour option, but after entering text and then format->text it shows a set of different text box sizing options, so that's dropped here) Because (currently) the same SDRATTR_TEXT_AUTOGROWHEIGHT bit it used for two apparently different things then we visually toggle on all things that use that bit in multi-column mode when its togged on, i.e. on editing a style visually both "fit height to text" and "resize shape to fix text" are kept in sync when you toggle one or the other. We don't disable the "resize shape to fit text" checkbox (unlike the fit height to text checkbox which controls the same bit) if "fit to frame" and "adjust to contour" are set, and give it additional powers to unset those if clicked. This hopefully makes the ui describe the way things actually are. Because this SDRATTR_TEXT_AUTOGROWHEIGHT is currently sort of doing two purposes selecting a freshly drawn custom rectangle and using format->default formatting will cause it to change properties because the underlying SDRATTR_TEXT_AUTOGROWHEIGHT bit is cleared. The way things should probably be I guess is that there should be a SDRATTR_TEXT_AUTOGROWSIZE property (which used to exist but wasn't hooked up to anything) just for custom shapes which overrides the old family of options if set. Change-Id: I49241c90d919eeb5caa8775beab57746d5c6df04
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-01 21:08:16 +0000