summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-01-01drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for sd Change-Id: I9bc9bffb93db2244320ee505fcecec9e9223fb76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-01use SdrAngleItem for ID_VAL_ANGLE*Noel Grandin
Change-Id: I093f7e0beba2fe7b90cb891fcdfc80f1f87c9197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-01use SdrAngleItem for ATTR_COPY_ANGLENoel Grandin
Change-Id: Ieea4d18cec6fd46d2f8d5f58f6246857e07f2129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-30use Degree10 in XPolygonNoel Grandin
Change-Id: I1820455de46bd428e1fbc0601aba58d377fdb930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108488 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-30vcl: remove {Read,Write}ImpGraphic and ImplExportNative from GraphicTomaž Vajngerl
ReadImpGraphic and WriteImpGraphic have been reimplemented in the TypeSerializer some time ago, but the code has not yet been moved to use that class. This commits does that and changes all the code using those 2 methods and removes them. With this implemented in the TypeSerializer, it is easier to handle In addition it also removes ImplExportNative (and the method on the Graphic interface). This was really used only in one method, and it could be implemented in the mthod itself. Change-Id: I0982429d1c1d5ed7ef07627d87ed9a08df43f040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108256 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-28use SdrAngleItem for SID_ATTR_TRANSFORM_ANGLENoel Grandin
as a precursor to introdcing a strong_int type for hundredths of a degree Change-Id: Ie2d7ad3b48d01defb43bf2e11e6494c4b999de0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-27ofz#28918 Direct-Leak in SotStorage::OpenSotStreamCaolán McNamara
Change-Id: I2d99a13822b07d98e03d7e7de91ca44ab4f8599d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-27Simplify loplugin:stringviewparam comparison operator handlingStephan Bergmann
In practice, it works fine to look at all of them, regardless of actual argument types. Change-Id: Ifc49cbcd6003c8837c1b3f81d432c59fb0657bf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108366 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-26tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorBayram Çiçek
Change-Id: Id4034a57580f37fd71f841deec9edfe9b7c26a67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108286 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-24tdf#138937 don't use attributes that depend on preset dataMark Hung
if preset data is not found. Curve, polygon, and free form motion paths do not have preset data. Create the path in these cases as well. Change-Id: Idd3b24b81a15de53e302e8cb7f3636d72e10b4da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108022 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-12-24custom literal for Degree10Noel Grandin
Change-Id: Id13869138a622e62d9ffebf2c89bddccda6aff01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-24vcl: move access functions into appropriate bitmap access filesChris Sherlock
Split class functions into BitmapInfoAccess.cxx, BitmapReadAccess.cxx and BitmapWriteAccess.cxx Split header files into BitmapInfoAccess.hxx and BitmapReadAccess.hxx Change-Id: I7dcbe1d26c5b64d297658a6b809c93d7ad7f053d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108039 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-23remove deprecated (and unwanted) resize-modeCaolán McNamara
which probably got in initially by accident on scrolling in glade's property templace when the mouse was over "resize mode" and then copied and pasted around the notebook especially Change-Id: Icd01848b7f51f670db1cb150ffba4ee7a487ce96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23add utility NbcRotate methodNoel Grandin
Change-Id: I66d016a22158f9f9ef68a80842e95e45516f0b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23use Degree10 in SdOptionsSnap and fix some conversionsNoel Grandin
Change-Id: I254b11d08049c4fbeaf77dc84812b19bc7f55c45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23Use optional rest argument of OUString::startsWithStephan Bergmann
Change-Id: Id8f9e7464c2c35a1a5ffadbc4c9c5d1f0d780923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-22replace deprecated xpad/ypadCaolán McNamara
drop entirely suspicious xpad/ypad which are probably accidental Change-Id: Ie80d93502359373e38cc61f63cd5bec962f5d193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22split SotStorageStream into two classesNoel
since it has two completely different paths of control Change-Id: I89b739d318d52245208a4bda1230f69d19f3ae0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-21missing use-underline on large/small entriesCaolán McNamara
Change-Id: I0f16402ea0464cf0a8d072ca5d507fe74a531453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108096 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-21weld impress layoutmenuCaolán McNamara
Change-Id: Ibc8038b37f8ff689050d9abb4ec0d2fac2eaadf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19unused forward declareCaolán McNamara
Change-Id: I1091eb69e49f1f81e5f8399ef421a55fceae7413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19make *String(string_view) constructors explicitNoel Grandin
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19use more string_view in SfxItemPropertyMapNoel
Change-Id: I053dedcbf0b110a61752722d247d6ee5e9ba481d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18throw exception in SvStream when reading past end of fileNoel
to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files. Change-Id: I351be031bb083a3484a9a1b650a58892700e6fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17tdf#137729: sd: Add UItestXisco Fauli
Change-Id: I936ac8a526c8b3013f9ca37dda572cb6a2c7e3f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107890 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-17tdf#125449: sd: Add UItestXisco Fauli
Change-Id: I33a70d6a789d51b33c663ddbacd9ce4c35b89460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107917 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-17prefetch graphics also for page before and after in slidesorterLuboš Luňák
The idea is that this will make them preloaded for when the user scrolls e.g. using PageDown. Change-Id: Icac9b6e88b25e9b0434c5ab7a152f47866dfadc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107823 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-17tdf#137729 sd UI: unique hatch names in slide/page area dlgJustin Luth
A custom hatch on a page background was not getting a name, so it was exported referring to an empty string, which was implemented as using the first available hatch. Ensuring that a name exists causes the hatch to be exported in the styles, and thus can be referred to in content.xml All praise goes to Katarina since this just copies her similar fix for grandients in tdf#125449. Too bad it took me a whole day to find that. Unfortunately, Katarina didn't provide any unit tests for me to copycat as well. Change-Id: If2be0830b521946fb1b88b247319a7e6c2c61c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107258 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-12-17fix --disable-pdfium buildCaolán McNamara
Change-Id: I6b7b089ecbd39336f4ea71d541112fd70c95acbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-17tdf#138976 change "Cancel" button to "Close" in Template Manager dialogSeth Chaiklin
Change-Id: I3e8cbdb70f70002f1fe2b873e899f25a72463358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-16tdf#138963 Clicking the position statusbar box disables selectionCaolán McNamara
if there is no object selected, since... commit d3dbbdce4eb71ae848e7682374e011c4a6129b15 Date: Wed Jan 17 15:20:31 2018 +0100 lokdialog: Convert the Format -> ... -> Position and Size... to async exec. Change-Id: Idcdbfb1366db61e247c31eab5cb27a39978b0fd9 Change-Id: I959789b055a880ac4c48a863c17eb6769b322577 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-16uitest: sd: fix GOTOXisco Fauli
pages count starts from 0 Change-Id: I31ce182af1bccf9b129e9c0f2f409ee81419902b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107840 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-15update pchesCaolán McNamara
Change-Id: I280dea8fe5f346a5555f4bf479896877579d63e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-11Strength-reduce some OUStringToOString("..."+...)Stephan Bergmann
...to "..."+OUStringToOString(...), in preparation of making OUStringToOString take a std::u16string_view Change-Id: Ic01ca249d4d0eb58ac959ffdf96471308a3715dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107600 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-10Online: "Copy hyperlink location" feature improvement.gokaysatir
Lambda functions are replaced with class pointers. Change-Id: I48628d3105533aad2463bd8ade1f65cf5b154b0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104058 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-12-09Some OUString::fromUtf(u8"...") simplificationsStephan Bergmann
Change-Id: I2b23d115c4df23ef99d162a02fa8f560f9a3a825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107471 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-09passed_freed_arg: InsertObjectAtView returns false if pObj was deletedCaolán McNamara
Change-Id: Ife8049e0426659f9b83504f1aced52b62159554b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-08drop unneeded includeCaolán McNamara
Change-Id: I43e64a01873ddc738d050591719261146befd873 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107406 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07move various notebookbar widgets into vclCaolán McNamara
and we can drop their factories then Change-Id: I1e261886dd7700710ba628da4bbeeba65efa1531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-07remove OpenGL VCL backend codeLuboš Luňák
It is by now practically unmaintained, even bugreports in bugzilla have been already closed for it. AFAICT this used to be really used only on Windows, where it's no longer the default. There's still some OpenGL code left, because there are still two other places that use OpenGL. One is OpenGL slideshows, which reuse some of the base OpenGL code (and I've checked they still work even after this removal). Second one is OpenGL canvas, which it seems has never been finished or enabled (or so it most probably should be dumped too). Change-Id: I7ea5aef77ec252eb8e712d167db591209be84a13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107290 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-07tdf#42949 Fix new IWYU warnings in sd/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I360874fb66c9359abf46a00116d73f87ad122168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106083 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-06move bluez_bluetooth_headers use_externals into ENABLE_SDREMOTE_BLUETOOTH caseRene Engelhard
... since it's where it is used, and otherwise one gets a -I$S/external/bluez_bluetooth when we don't want or even need that Change-Id: If3757adb7960ad5adfc857052bb8322f8754ecdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107178 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2020-12-04update pchesCaolán McNamara
Change-Id: I3e22c2000da03f6f3345353846213203993aa865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-04tdf#34828 sd navigator: fix crash when page item entry is selectedJim Raykowski
Page items in the tree are given user data value 1. Drawing obect items are given user data value of the object pointer they represent. Need to check that the user data is not 1 before casting to an object pointer. Change-Id: I58109e556268e805f62ad2f16b363411e4341d2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107185 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03tdf#96505: Get rid of cargo cult long integer literalsGökhan Özeloğlu
Change-Id: I7226f93a87e0b31634a3c0942f3f5ec8778161fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106843 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-13 17:17:56 +0000