summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-12-13Resolves: tdf#129347 ensure impress docking window has enabled inputCaolán McNamara
the default inputmode is taken from the parent, if the templates dialog is open when the sidebar is created then the template dialog has set the toplevel window disabled-input Change-Id: I27cd0a6d6127cc2033a2304c27d72b88f16b0b1a Reviewed-on: https://gerrit.libreoffice.org/85119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13Resolves: tdf#129346 if nothing currently selected, select somethingCaolán McNamara
in the slidesorter Change-Id: I66853ba56eab93dfb18de7496212eb64e97cd2bf Reviewed-on: https://gerrit.libreoffice.org/85108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13Draw/Impress add Extension support to Tabbed NBandreas kainz
Change-Id: I44ab4107a826ed14bec770a4367cfb8eee09d316 Reviewed-on: https://gerrit.libreoffice.org/84900 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-12use covariant return type for SfxPoolItem::CloneCaolán McNamara
and can then remove some casting Change-Id: Id821c32ca2cbcdb7f57ef7a5fa1960042e630ffc Reviewed-on: https://gerrit.libreoffice.org/85022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12Remove some redundant user-provided dtorsStephan Bergmann
...which silences various -Wdeprecated-copy-dtor warnings from Clang 10 trunk about copy functions being implicitly defined as non-deleted even though the class has a user-declared dtor Change-Id: I3409d403c3c709de4ad94eccbc2d7869e41847cc Reviewed-on: https://gerrit.libreoffice.org/85032 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-11jsdialog: send items on status changeSzymon Kłos
Use existing mechanism, delete sending in getter code which caused unnecessary work. Change-Id: Ibc191c16b95fd58e7065e019f48f3837cfed5bbd Reviewed-on: https://gerrit.libreoffice.org/84914 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-12-11Related: tdf#129267 format numbers with the UI localeCaolán McNamara
Change-Id: I70d8cc48869073596c101eec6a6d3a79db044a78 Reviewed-on: https://gerrit.libreoffice.org/84883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129267 draw also has a similar panel comboboxCaolán McNamara
Change-Id: Icde8c951ba3a0672cbc20989c90783e7c1606965 Reviewed-on: https://gerrit.libreoffice.org/84880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Sidebar: Don't expand table design styles verticallyMuhammet Kara
Otherwise, they become veeery high in Online. Change-Id: I2572eb6ac94ad5e46aa596095cd718aef63eed6c Reviewed-on: https://gerrit.libreoffice.org/84868 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-10Set text field modified on edit in ImpressSzymon Kłos
To avoid not saved changes when user enters text field and then closes the browser. Change-Id: Iee06392eedcf8c1875017dbfb55552059f94bba3 Reviewed-on: https://gerrit.libreoffice.org/77504 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82086 Tested-by: Jenkins
2019-12-10jsdialog: apply FillGradient with JSON argSzymon Kłos
Change-Id: I0ca53a53ff53e66d2f25ad4eb13305edbc3aaa12 Reviewed-on: https://gerrit.libreoffice.org/84798 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-12-10use double prime for inch symbolCaolán McNamara
Change-Id: I6a663bcb55155bd2331aa79cebd5b922c2ee7605 Reviewed-on: https://gerrit.libreoffice.org/84787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09separate cm from value in built-in en_US stringsCaolán McNamara
Change-Id: I64f78192d176fe225baea789e2283c5c95ab62fa Reviewed-on: https://gerrit.libreoffice.org/84786 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09drop newly unused SfxFloatingWindowCaolán McNamara
Change-Id: I8ac3957579c76a89b9692bdb50cbe7a56e1693e3 Reviewed-on: https://gerrit.libreoffice.org/84444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06tdf#127237 fix table background color in Impress importnd101
When the background color is set at the table level in PPTX, instead of at cell level, the background color fails to show up in Impress. Change-Id: I2838e5b56e4a2414494ee99c0f8975b7256ac6dc Reviewed-on: https://gerrit.libreoffice.org/78377 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-06tdf#129165: fix menuXisco Fauli
Change-Id: Ia749f32e02b0977a4a3b732b85fe87750df36424 Reviewed-on: https://gerrit.libreoffice.org/84403 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-05tdf#101513 arrangement of customizeable items in NB groupedbar compandreas kainz
Change-Id: I79f91f9b1f1fc5d91912061c004865a94f1371a6 Reviewed-on: https://gerrit.libreoffice.org/84563 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-05CppunitTest_sd_dialogs_test still needs some symbols as SD_DLLPUBLICStephan Bergmann
...after e189a3f5b5c4f381dcf109eb9a2ee9b6d32d5551 "make some classes module private": > [LNK] CppunitTest/libtest_sd_dialogs_test.so > sd/qa/unit/dialogs-test.cxx:107: error: undefined reference to 'SdAbstractDialogFactory::Create()' > sd/qa/unit/dialogs-test.cxx:160: error: undefined reference to 'typeinfo for sd::DrawView' Change-Id: Ib173d576bfe3c59c31229bb769999693d8ec9d57 Reviewed-on: https://gerrit.libreoffice.org/84575 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05tdf#128666 Only enable hyperlink actions when just the field is selectedSamuel Mehrbrodt
Change-Id: I984df967877a47fb9f89c3626737348a87d3ffa5 Reviewed-on: https://gerrit.libreoffice.org/84418 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-05add ConfigureDialog item in NB burger menu buttonandreas kainz
Change-Id: I926a0b5ff9cb09a8a05e60c0a86eb11a2a201073 Reviewed-on: https://gerrit.libreoffice.org/84503 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-05tdf#101513 arrangement of customizeable items in NB tabbed compactandreas kainz
Change-Id: Ibf1f958d2086b0a631097aee9f903aee202767c1 Reviewed-on: https://gerrit.libreoffice.org/84468 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-05tdf#109425 NB tabbed accessible for screen reader usersandreas kainz
Change-Id: If5c1db1579d40e68ba6e8092025e687dd8addd03 Reviewed-on: https://gerrit.libreoffice.org/84472 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-05make some classes module privateNoel Grandin
Mark some stuff SAL_DLLPUBLIC_RTTI in include/vcl/metaact.hxx in order to make ASAN happy. Change-Id: I97febe0968bf58b9cbe60ce647f0ada25e6f4bb0 Reviewed-on: https://gerrit.libreoffice.org/84202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-04drop dbgutil SdrItemBrowser FloatingWindowCaolán McNamara
Change-Id: I7a4ca90ea23271e7b6f60d7e47e4513978d3222d Reviewed-on: https://gerrit.libreoffice.org/84356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04remove some unnecessary includes and update pchesCaolán McNamara
Change-Id: Ieee11f2ea3c5c18a84316a8b7c39a261afd720ed Reviewed-on: https://gerrit.libreoffice.org/84308 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04tdf#124258 Draw NB groupedbar_full not available for drawandreas kainz
Change-Id: Iff6768a377f9bcc6fb3da997ded90d0e78e8b9f3 Reviewed-on: https://gerrit.libreoffice.org/84382 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-04tdf#101513 arrangement of customizeable items in NB tabbedandreas kainz
Change-Id: I1cef677fcc91403dbaa92fd8dcf8a5fcc5bc6b03 Reviewed-on: https://gerrit.libreoffice.org/84383 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-04tdf#128927 groupedbar compact replace color with filterandreas kainz
Change-Id: Ie907e80c58d079262369fdfdce83e4b613a366bb Reviewed-on: https://gerrit.libreoffice.org/84381 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-03use scoped enumStephan Bergmann
Change-Id: If2dce427fd8d52224996aaef93081d5a2e239893 Reviewed-on: https://gerrit.libreoffice.org/84322 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03remove some useless comment linesNoel Grandin
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03Disable slide copy/cut when LockContentExtraction is setSamuel Mehrbrodt
Change-Id: I7bf9ba907a152fab81a9472bc7baf00331753828 Reviewed-on: https://gerrit.libreoffice.org/84289 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Jenkins
2019-12-03Use SAL_STRINGIFYStephan Bergmann
Change-Id: Id4074390936ddf7051b5d45c76fd8668972e34f8 Reviewed-on: https://gerrit.libreoffice.org/84287 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Fix compilation with `make -- dbglevel=2`Alex Henrie
Change-Id: Icdf93751b00453eb033fd577413bd6bc3527f87c Reviewed-on: https://gerrit.libreoffice.org/84286 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-02missing include (but just change use of BOOST_ASSERT to plain assert)Stephan Bergmann
Change-Id: Ie789049d418f6137f76b80c54f343e5dd72fb849 Reviewed-on: https://gerrit.libreoffice.org/84261 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-02use weld::WaitObjectCaolán McNamara
Change-Id: Ib2ad0f0fe17c4db66693ef91e3cdbc8511eb8314 Reviewed-on: https://gerrit.libreoffice.org/84166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-01Introduce o3tl::optional as an alias for std::optionalStephan Bergmann
...with a boost::optional fallback for Xcode < 10 (as std::optional is only available starting with Xcode 10 according to <https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite all code to use o3tl::optional instead of boost::optional. One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per fed7c3deb3f4ec81f78967c2d7f3c4554398cb9d "Slience bogus -Werror=maybe-uninitialized" should no longer be necessary (and whose check happened to no longer trigger for GCC 10 trunk, even though that compiler would still emit bogus -Wmaybe-uninitialized for uses of boost::optional under --enable-optimized, which made me ponder whether this switch from boost::optional to std::optional would be a useful thing to do; I keep that configure.ac check for now, though, and will only remove it in a follow up commit). Another longer-term benefit is that the code is now already in good shape for an eventual switch to std::optional (a switch we would have done anyway once we no longer need to support Xcode < 10). Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses boost::property_tree::ptree::get_child_optional returning boost::optional, so let it keep using boost::optional for now. After a number of preceding commits have paved the way for this change, this commit is completely mechanical, done with > git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g' (before committing include/o3tl/optional.hxx, and relying on some GNU features). It excludes some files where mention of boost::optional et al should apparently not be changed (and the sub-repo directory stubs). It turned out that all uses of boost::none across the code base were in combination with boost::optional, so had all to be rewritten as o3tl::nullopt. Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b Reviewed-on: https://gerrit.libreoffice.org/84128 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Rewrite uses of boost::optionalStephan Bergmann
...to only use functions that are also available for std::optional (in preparation for changing from boost::optional to std::optional): * uses of get are replaced with operator * or operator -> * uses of is_initialized are replaced with operator bool * uses of reset with an argument are replace with operator = (All of the replacements are also available for boost::optional "since forever", so this change should not break builds against old --with-system-boost. An alternative replacement for is_initialized would have been has_value, but that is only available since Boost 1.68.) Change-Id: I532687b6a5ee37dab28befb8e0eb05c22cbecf0f Reviewed-on: https://gerrit.libreoffice.org/84124 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30tdf#94947 Set preset-id for user defined motion paths.Mark Hung
User defined motion paths ( curve, polygon, freeform line ) did not have preset-id. Set the preset-id so that the preset type will be highlighted in the custom animation pane after editing. "libo-motionpath-curve", "libo-motionpath-polygon", and "libo-motionpath-freeform-line" are used for the three user defined motion paths. This patch is related to tdf#94947, though it doesn't make the original document display correctly by guessing the missing preset-id, but it prevent empty preset-id to be generated when creating those three motion path animation. Change-Id: I50c0133bea32e022b07e5d8c0a024810844f124d Reviewed-on: https://gerrit.libreoffice.org/83079 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-11-30sd: fix typo maEffectDiscriptorMap -> maEffectDescriptorMap;Mark Hung
Change-Id: Ie0e8dc67969ca680e80c544f954d3bef9adbcb33 Reviewed-on: https://gerrit.libreoffice.org/83078 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-11-29jsdialog: migrate left/right margin to generic items dumpSzymon Kłos
Change-Id: Ie687393ae4b9a7f8350eea07c1d417c11fc532bd Reviewed-on: https://gerrit.libreoffice.org/84002 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29jsdialog: migrate after/before spacing to generic items dumpSzymon Kłos
Change-Id: I18f0596baa8e1136f4546a943eafab9a13929c06 Reviewed-on: https://gerrit.libreoffice.org/83999 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-29do not completely disable a test for !OpenGL if OpenGL may be brokenLuboš Luňák
The code comes from f062b89b277a0830f038cafdd13bd074b5188455 and is more like patching things up. A proper fix should be elsewhere, but at least patch this up more to be less wrong. Change-Id: Ic9b24680688d104028b1e1bf6fccc16e6f786aa8 Reviewed-on: https://gerrit.libreoffice.org/83880 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-11-28Removed executable permission on fileAndrea Gelmini
Change-Id: I9bb45358d4f3ff0d069042e64721b8a5c8ad64a1 Reviewed-on: https://gerrit.libreoffice.org/84021 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-28jsdialogs: share the commands updates sending codeSzymon Kłos
Change-Id: I34c1e03a8f92efe0c0dd391d16ff907919e65b00 Reviewed-on: https://gerrit.libreoffice.org/83748 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 880ff26edff0f7dfdd0d5b74fd9d7026fd2d8523) Reviewed-on: https://gerrit.libreoffice.org/83954 Tested-by: Jenkins
2019-11-28tdf#113198 set default shape paragraph alignment..Tamas Bunth
to center when importing oox document. Using MS Office, the default aligment of a (text) paragraph inside a shape is centered. Change-Id: Id9bcaaab109df65f4124f733b2cfee438e82b79b Reviewed-on: https://gerrit.libreoffice.org/83193 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-11-27jsdialog: send generic fill items also in writer and impressSzymon Kłos
Change-Id: I656ee47fff4e43f77caef62c071a5aa3b867f444 Reviewed-on: https://gerrit.libreoffice.org/83945 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-27tdf#127090 Export textbox rotation attribute.Gülşah Köse
In case "rotated textbox in a custom shape" handle draw:text-rotate-angle attribute while exporting ODP to PPTX. Change-Id: I13b99da586af5e77e51a7cc93a751ab21bed7170 Reviewed-on: https://gerrit.libreoffice.org/83888 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-11-27Better handling of text rotation attribute.Tamás Zolnai
We need to have a separate attribute for vertical option and for rotation option. So rotation won't be lost by setting the text direction. So I added a rotation member variable and use that as an orthogonal variable to the vertical text direction. A follow-up fix for tdf#100926. The problem was that the rotation was imported / exported correctly from/in ODP, but the text was not displayed as rotated. Change-Id: Icddc0689f06fdcd52df6dc911e02a9a948c42654 Reviewed-on: https://gerrit.libreoffice.org/83809 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-27jsdialogs: send .uno:FillStyle updates in ImpressSzymon Kłos
Change-Id: I9b266d9134678e98a5540ec3681d24b3ea43506a Reviewed-on: https://gerrit.libreoffice.org/83382 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/83778 Tested-by: Jenkins
2019-11-27Remove unused RecentlyUsedPageCaches::value_typeStephan Bergmann
(found by upcoming loplugin:unusedmember) Change-Id: Ib0d6afbafcc210fbf839b64c370743071c51f5b4 Reviewed-on: https://gerrit.libreoffice.org/83819 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-27 03:50:11 +0000