summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2023-07-18tdf#126095 sd notebookbar: don't force table/media toolbarJustin Luth
Perhaps the entire function could return early in case the notebookbar is active, but only if all of them have a context notebookbar tab. Some of them I can't check since I don't know how to trigger them. Images, media, and tables all do have a context bar. (Media's bar is missing useful things like location, mute, and even file-location path. (Those will come separately in another commit.) Change-Id: Ic4623a1cab3abc1ac1f83622cbd11e549d2b0b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154559 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-18related tdf#126095 sd notebookbar: give room to .uno:AVMediaToolBoxJustin Luth
There are lots of controls on the media player (like mute, position etc) that are obviously not accessible if the control is squished to a small size. Giving full access is especially important if we do not show the extra toolbar, but depend on this notebookbar context switch. Change-Id: Ie766c426182469015a3431b83c852ce16d7436f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154560 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-17tdf#156308: Restore use of /org.openoffice.Office.Recovery/AutoSaveMike Kaganski
... instead of respective values from /org.openoffice.Office.Common/Save/Document The history of the problem: d0f9685d2cfc3927add412b276c804dcc20cb6a5 (2004-11-26) made SvtSaveOptions use org.openoffice.Office.Recovery/AutoSave, *in addition* to org.openoffice.Office.Common/Save/Document/*, as "forward AutoSave/AutoSaveTime to new config location" part of i#27726; at this point, org.openoffice.Office.Recovery/AutoSave/* took precedence (they were read last). 8e6031e126782ced6d7527b19cf817395e9b63e4 (2004-11-26) implemented autorecovery.cxx, already reading org.openoffice.Office.Recovery/AutoSave/* d5b9283985633fdb423269cab961bba2acc3539e (2021-07-25) made SvxSaveTabPage and SfxApplication::SetOptions_Impl use officecfg::Office::Common::Save::Document::* instead of SvtSaveOptions. 134f40136a9bea265d8f2fedfdb41a1e65d81b49 (2021-07-25) dropped SvtSaveOptions_Impl::ImplCommit, and its saving of officecfg::Office::Recovery::AutoSave::* (which likely detached officecfg::Office::Recovery::AutoSave from officecfg::Office::Common::Save::Document, making UI edits not stored to the former). aeb8a0076cd5ec2836b3dfc1adffcced432f995f (2022-05-23) made AutoRecovery::implts_readAutoSaveConfig read officecfg::Office::Common::Save::Document::* instead of proper officecfg::Office::Recovery::AutoSave::*. This change restores the intended use, and deprecates corresponding values in /org.openoffice.Office.Common/Save/Document. Change-Id: I33d48e3945326c80d356bfc930ed8a7f042c982b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154500 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-17tdf#130581 - Add undo command for hide/show slidesAndreas Heinisch
Change-Id: I7305e222df65fda6523940ca63f5759857c94bea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153375 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-07-15Resolves tdf#156182 - Automatic text color unreadable with darker cellsHeiko Tietze
Change-Id: Ia5e405fc05613726b5011174c8d00ca204eb31b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154352 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-07-13tdf#153446 sd FuText: handle mouse-up without mouse-downJustin Luth
This is a follow-up to the previous commit which did the same thing to all of the other FuConstruct elements. It isn't essential to have for FuText, just nice for consistency. FuText is much more complex than the other FuConstructs, and has been this complex since initial import. In patchset1, I removed a large chunk of code that I assume is now obsolete with my change, but now I just left it in. Without any documentation or unit tests, it is hard to know for sure why this function creates a textbox on mouse-up. So I chickened out and did the smart thing of just leaving stuff I don't know anything at all about alone. Change-Id: I105178e6af343eed505a803c6c3642eec073f6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154083 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-12tdf#153446 sd fuconstruct: handle mouse-up without mouse-downJustin Luth
The situation where this was happening occurred when the notebookbar had a pop-out of additional functions available. This pop-out removed the focus from the draw window, so the mouse-down was used to regain focus in Draw. The mouse-up just needed to be absorbed or else the "drag the shape to create" would be changed into a select. I checked as many "situations" as I could possibly have conceived of after reviewing the code in this area. The ones I know I need are !bMBDown and !IsAction(). The rest are just to try to avoid getting me into trouble. [FuText also could benefit from this, but that function is much more complex, and so I don't dare to interfere. It already does BegCreateObj on a mouse-up, but the textbox it creates is hard to notice.] Change-Id: I4ed2564e81d8a7ce82e7edec43e4e9acc6e97760 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154069 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-12tdf#105362 better support for transparency in PNG & GIF exportArmin Le Grand (allotropia)
The granularity to decide at the SdrView what to paint was not fine enough, so I added code to get what we need: Do avoid page decorations (including PageBackgrund aka 'wiese'), but do include/process MasterPage content. Change-Id: I49df05abc89b4bcebc973c37d30be0a0c72e59ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154301 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-07-12Categories for link targets in ImpressSzymon Kłos
Writer and Calc presented possible link targets inside documents as a Tree, with items under their categories. This patch makes the same for Impress so we don't mix master pages with regular pages. Change-Id: Ifd98300b0d609c28d6c1880332fff7e750b5e1b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152389 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153985 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-12tdf#141135 notebookbar: use radio buttons instead of checkboxesJustin Luth
I mean of course in the places where mutually exclusive options are side by side. I mainly searched in menu.xml where menu:style="radio", and then changed the notebookbar menu items to do the same thing. It was all done by hand, unfortunately. Before testing, ensure you have no customized notebookbars: rm instdir/user/config/soffice.cfg/modules/*/ui/* git grep -B10 '.uno:NormalView\|.uno:BrowseView' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:PageMode\|.uno:MasterPage' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:.uno:PagebreakMode\|.uno:NormalViewMode' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:DefaultCellStyles' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:CommonAlign' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:StyleApply' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:TextBodyParaStyle' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:NumberListStyle' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:OutputQuality' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:ParaRightToLeft\|.uno:ParaLeftToRight' *.ui | grep -A10 GtkMenuItem git grep -B10 .uno:SpacePara *.ui | grep -A10 GtkMenuItem git log -p -1 | grep '^+' | grep -v GtkRadioMenuItem Change-Id: Ia2e29a6541fed66f4bcb0936d715969994671e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154337 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-10svx: prefix members of GeoStatMiklos Vajna
See tdf#94879 for motivation. Change-Id: Id8d116bfa375f7dd30ca8dcdec0ee02df8105030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154234 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-07-06tdf#141058 oox,sw: OOXML import/export of decorative on shapesMichael Stahl
Also add a test for PPTX (using the oox filters), and add a SdrObject to the testTdf143311 for DOCX (using the writerfilter/docxsdrexport). Change-Id: Iccee46c0d30316c33c0947b117e2604c96fa0182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154137 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-05simplify sd: already asked if mxTextObj.get().is()Justin Luth
Change-Id: Ibb303cf53722684b0f98f0195ec6d55376bcfd1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154073 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-05simplify SvxUnoDrawPool initialisationNoel Grandin
Change-Id: Iaca5eec19935c50cc7cade4f3dab139a5232473a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-05tdf#138504 svx,etc.: decorative flag on SdrObject shapesMichael Stahl
* SdrObject new member m_IsDecorative * new Undo SdrUndoObjDecorative * surprising amount of changes in sw including additional SwUndoFlyDecorative * svx API SvxShape property "Decorative" * UI checkbox "Decorative" * ODF import/export as loext:decorative on style:graphic-properties * PDF/UA export: ViewObjectContcat tag shapes with this flag as Artifact Change-Id: I37f7a0597eab92c6c6aff94fad6c16c59b231c80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154063 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-05Make sure views get new themes on .uno:ChangeThemeParis Oplopoios
It would be that sometimes .uno:ChangeTheme would not load the new scheme because it was using EditableConfig::GetCurrentSchemeName which uses a static name - normally great except for when you need different views to have different color schemes in tiled rendering Change-Id: I5b149bd1a4776337f76753c6de98d5386a899d34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153939 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 77f5b9259864798b6efc213f6dfa685cd440f71a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154001 Tested-by: Jenkins
2023-07-04loplugin:unusedvarsglobalNoel Grandin
Change-Id: Ia86c8bd0bdc85c375eb3837ba97f9e171d9dac6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-03tdf#155630 Use common getPolygon for sdDr. David Alan Gilbert
Unfortunately the SetLineEnds in sw is different enough from sw and sc to make sharing it a pain. However we can share the GetPolygon function we already moved into svx. Expose the svx function into the header and use it in sd. Change-Id: I05b0f820286c8ce848fa0d6c69603d3625c2b4d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-03Delete DrawViewShell copy constructorsParis Oplopoios
DrawViewShell does not get copied so best to set these to deleted to highlight this. Change-Id: I3d35d3a47137b15346d54a08d3d7af480b0872bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153864 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-07-02pAttr is always dereferenced, use a reference instead of a pointerCaolán McNamara
Change-Id: I76ebce9085b9e47a6c571ddbcafa44d0d3a0f97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-30loplugin:unusedmethodsNoel Grandin
Change-Id: I8d3402a69237b665462e04440ad73fe29e2133db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-30tdf#156091: handle OWN_ATTR_TEXTCOLUMNS in SdStyleSheet::getPropertyValue_ImplMike Kaganski
Somehow I failed to implement this from start. In commit 95ebd24a629b4c8cd62cc20c0701683512cc8fa0 (editengine-columns: ODF support [API CHANGE], 2021-06-08), I implemented its support in SdStyleSheet::getPropertyState; then, in commit f2ea39c70da3f82bb39f8b51b5484172360b1fc2 (Avoid crash getting default item for OWN_ATTR_TEXTCOLUMNS, 2021-06-22), I added its support in SdStyleSheet::setPropertyValue; and finally, the time has come to support getting its value. Better late than never. Change-Id: Ifa1f933f00336bf6d01a5c71d0c92baf846ccabb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29loplugin:unusedmethodsNoel Grandin
Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29mbIsUIReadOnly is deadNoel Grandin
after I removed SetUIReadOnly in commit e2c7a6bd572644b928704f6cb3696b568ac0aba1 loplugin::unusedmethods and that was dead because of commit cb32938d572777c9a5d75007cc76ba50c5a698eb [API CHANGE] remove unused SlideSorterService Change-Id: Ib0e170794e0f448b094b3d1ca5d309deab4c1bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29loplugin:unusedfields make it a little smarterNoel Grandin
around dealing with operator[] on map data-types Change-Id: Idd6654948ae2d03d634fcf30a8d98530a78ab4ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-28xmloff: ODF import: adapt generator parsing to 2-digit major versionsMichael Stahl
DocumentInfo currently assumes that a LO version encoded in "BuildId" property has only 1 digit major version, which is now wrong and would start to give incorrect results when major version "30" will be detected as LO_3x. Add the dots as separators into the BuildId because it's not going to work without. Change-Id: I8918afe3642cbefa8488c57658f1505c9a20eddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153649 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-27tdf#145130 Keep existing gradient geometry using sidebarRegina Henschel
When setting the start or end color of a gradient of a slide using the sidebar, the new colors were set to a default gradient instead of using the existing one. Change-Id: I0212d2d88e7eb144334308dedd057958ae0a8287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153634 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-06-27loplugin:stringstatic look for more stringsNoel Grandin
that can be initialised at compile-time instead of runtime Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-26new loplugin:constexprliteralNoel Grandin
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-26ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ia064835f3fee71e9a177b2ab37f66e3fd2a94fce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-26FillSdAnimationInfo is never passed a nullCaolán McNamara
Change-Id: Iaf292fc3476fbbc21fede3856a50864951c1db8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-24CID several. Use ctor 'from other' instead 'first..last'Regina Henschel
This covers CID#1532461, CID#1532462, CID#1532464, CID#1532467, CID#1532479. Now solutions without iterator are used. In all cases constructions like maColorStops = basegfx::BColorStops(rGradient.GetColorStops().begin(), rGradient.GetColorStops().end()); are replaced with solutions like maColorStops = rGradient.GetColorStops(); And instead of constructions like aColorStops.emplace_back(maColorStops.front().getStopOffset(), aStartBColor); aColorStops.insert(aColorStops.begin(), maColorStops.begin() + 1, maColorStops.end() - 1); aColorStops.emplace_back(maColorStops.back().getStopOffset(), aEndBColor); now it is like aColorStops = maColorStops; aColorStops.front() = basegfx::BColorStop(maColorStops.front().getStopOffset(), aStartBColor); aColorStops.back() = basegfx::BColorStop(maColorStops.back().getStopOffset(), aEndBColor); Change-Id: I66662d2286e7707b205c58977bc3f850b2a49dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-24Change LocaleDataWrapper::getDuration() parameter to tools::DurationEike Rathke
... instead of tools::Time Change-Id: I8e49de43a1870541d75add34089eec67b7a8be31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153533 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-23tdf#155901 MCGR: preserve first and last gradient stop tooRegina Henschel
Error was, that only the in-between gradient stops were preserve. First stop was set with fixed offset 0, last stop with fixed offset 1. The offsets of first and last gradient stop of the original gradient were lost. Now in all cases (hopefully) the complete gradient stops vector is preserved and the original offset is used, if e.g. the user changes the color. For calculating transparence the indirect way over Color is removed. Instead percent is directly transformed to the 0..1 values of BColor. That avoids rounding errors. Change-Id: Icdf699a6c2e9c6289d2f77033858448e58396a60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153395 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-06-21tdf#142833 sd notebookbar: There is no PrintPreview, use WebHtmlJustin Luth
Well, that surprised me, but there is no print preview available in Draw or Impress. They can only do a pathetic Preview in Web Browser. AFAIAC, this could be removed since it is so useless. But that would leave an empty hole under "Print directly" so for now just substitute something useless for something non-functional. Change-Id: If7fbb1b549c2b24d2ca6f77f14333811c405e465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153196 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-21sd: send correct slide visibility statusPranam Lashkari
The term visible may be a bit aambiguous here, we try trying to send info about if the slide is hidden or visible in the slide show. The correct property for that is "exclude" Change-Id: Ic505036181b71686656bd2338b9d0329c12d9e74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152688 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit fe79008f70e7a790e4f78c1714c27ea223512327) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152988 Tested-by: Jenkins
2023-06-21tdf#122270 sd: refresh notebookbar after switch to/from master viewJustin Luth
Although the state of the uno items was changing, the notebookbar was not refreshing to display the new state. Change-Id: Ifda5e6dcfa1d569ba75d0c94cdf0bc94c63977d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153360 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-20tdf#155863 sd: fix resizing of cropped images to original sizeTibor Nagy
Resizing with the function "Original Size" (e.g. in the context menu) resulted distortion in case of cropped images, if the original image and its cropping have different aspect ratios. Now zoom the cropped image to the original resolution instead of stretching it to the same size. Change-Id: I5e59f8b48dc03844a739c3eb803e3195a12d9c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153170 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-20tdf#126095 impress notebookbar: don't force Master/Presentation toolbarsJustin Luth
When in the notebookbar mode, non-notebookbar toolbars should not be enabled automatically by the application. The user still has the ability to turn them on. Change-Id: Ib601b63390a8d806604b68ed2ea198198f4318ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153303 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-20tdf#155920: next effect in END mode should no resume showDaniel Lohmann
When starting a presentation and moving over the last slide into the END mode the next effect should not resume the presentation. Instead it should exit the presentation. Furthermore, when hitting then the back key it should show again the last slide (only resuming the presentation, not directly resuming and moving back to the slide before the last. Change-Id: I816232725d923601356e0bc8e39421f256d184eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-20sd: fix setting theme for notes masterTomaž Vajngerl
Notes master also needs a theme set or the document will not load properly. For now we don't save the theme for the notes master on import, so we can only set the default "LibreOffice" theme instead. Change-Id: Ia9e5db53d4e1a4ca06b10d147cc879475166dfd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153314 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-19tdf#155086 remove code that sets theme color to shapes as DFTomaž Vajngerl
Remove this functionallity for now until we support theme colors in shape styles. Then we can do it for the default style, and not as a direct format for each inserted shape. Change-Id: Ib042072954a79cadc750372333c40269fbe4ca40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153244 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-17oox, writerfilter, xmloff: use frozen data structures for static dataTomaž Vajngerl
Change-Id: I4a53fa57f52900104d249c84cde36c9d3b9e1300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-17improve exception messageNoel Grandin
the colon here made me think a piece had been chopped off. Change-Id: I1e0f0ef9c16e0fd8f7619a3d8e58e8e0886fda9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-15sd: fix crash deleting 2 slides during paintTileLuigi Iucci
pPageView was null in SdXImpressDocument::paintTile while trying to paint form controls, which is a corner case in most cases then we skip painting in order to avoid a crash Change-Id: I6c166035220c058fac276f2b7746a8ebc9651f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-14Add editengine view separation in tiled renderingParis Oplopoios
Editengine now gets the background color from the current view instead from a global variable Change-Id: I98a0fccf4d0c83f4dabf8e534a9228b8a5e271d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 7baa475342b67c10537e11da37b8862648679b02) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153073 Tested-by: Jenkins
2023-06-14Make encodeForXml accessible for other modulesSzymon Kłos
and share similar code Change-Id: I7729a46d40845893f577c273c1ab340f69ebb51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151230 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151754 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-14SdNavigator: Improve unique name detectionJim Raykowski
Commit ace75043781b5fe36546ec75574a14617f4feb30 added the ability to rename page and object names from the Navigator. An approach that searches entry names in the tree was used to check for unique naming. This does not guarantee uniquess as the name may already be used for an object in another view, for example, Notes view. This patch guarantees name uniqueness by checking the document model to see if an object with the name already exists. Change-Id: Iad419420d6010b94380c55b7dc71a8d4abbec784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152843 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-06-12tdf#154451 UITest_impress_tests: do not use oneprocess mode for nowXisco Fauli
Jenkins started to fail more frequently after 18cab645488184f1d861fb4e67aebb383f6e3779 "tdf#154451 UITest_impress_tests{,2}: enable oneprocess mode" Let's see wether this improve the situation Change-Id: I4983cb8bb90808287e1c32d70e73ff2defbbcc0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152903 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-12sd: lok: only register supported viewsHenry Castro
The Presentation ViewShells: SlideSorter, Outline, Presentation They are not supported in tiled rendering case, so switch to default view. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I33b255e0ca530734af6490d14fe48a2512272afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147095 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152900 Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-10 22:37:49 +0000