summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-03-06update pchesJulien Nabet
I just used ./bin/update_pch.sh Change-Id: I06a7f36eb4c511b8d6c6477fd87e57f0d9702457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-06loplugin:staticdynamic look for static after dynamicNoel
Change-Id: Ic3066d9a9441e369370cc6aa0fbffb9a321bc928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111985 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06drop check for visibility before calling updateMotionPathTagsCaolán McNamara
presumably this is effectively always the case Change-Id: I05ac9075ea340f800cdb9b8fda6e01c8ba1fa186 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112034 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move MouseButtonDown logic to LayoutValueSet childCaolán McNamara
Change-Id: I8d70321856219988618d99ba5884b89950441b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112012 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move valueset resize into LayoutValueSet classCaolán McNamara
Change-Id: If1a5dbcdac95a167779b30c26f4aa61bbe104cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05with widget layout we don't need to explicitly track the parent resizeCaolán McNamara
Change-Id: I17e153ecc8b1b79bbbfbbccfe88a46f5905611fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112010 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05drop unneeded DEBUG SetTextCaolán McNamara
Change-Id: I3844494d87992d1a23fee78aaa3b3912cb9fc5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move handler for ESC to close slideshow from navigator down to contentsCaolán McNamara
Change-Id: Ie021bcf86043cf2ae02eb39911c748135452853c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05parent panel doesn't need an explicit KeyInput handlerCaolán McNamara
the treeview child one is sufficient Change-Id: I3a5e7a262055e5f03cf5323eeaa8c169eaab2693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05updateMotionPathTags is already called from the ctorCaolán McNamara
#3 0x00007fffd0fe1939 in sd::CustomAnimationList::Select() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:981 #4 0x00007fffd0fe4f62 in sd::CustomAnimationList::update() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:864 #5 0x00007fffd0fe353b in sd::CustomAnimationList::update() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:639 #6 0x00007fffd0ff5f4b in sd::CustomAnimationPane::onChangeCurrentPage() (this=0x391e9c0) at sd/source/ui/animations/CustomAnimationPane.cxx:1664 #7 0x00007fffd0ff4321 in sd::CustomAnimationPane::initialize() (this=0x391e9c0) at sd/source/ui/animations/CustomAnimationPane.cxx:208 #8 0x00007fffd0ff527b in sd::CustomAnimationPane::CustomAnimationPane(vcl::Window*, sd::ViewShellBase&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (this=0x391e9c0, pParent=0x391a3e0, rBase=..., rxFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x166a030) at sd/source/ui/animations/CustomAnimationPane.cxx:156 so don't recall it on StateChangedType::Visible StateChange Change-Id: I311d97ad69b295669e7c31e18f669ae6b123b7d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move properties from container vcl::Window to window-filling childCaolán McNamara
Change-Id: I5ddd17220ff8b45678716c406297d305aa2229e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05don't use the vcl::Window parent to derive a treeview sizeCaolán McNamara
Change-Id: Ic366a90fbdcd735d377c8a00766cdfa0add31c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111998 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05use valueset as the menu parentCaolán McNamara
Change-Id: I99c4bc5110ce494287342db5c2d4c42b1a79ee38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111993 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05use valueset as the menu parentCaolán McNamara
Change-Id: I3e8a841f838c4874e40d7d9e6abfbd61e2bb068d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05emplace_back: use perfect forwarding if possibleThorsten Behrens
When using that new-ish method, try giving the compiler a chance to construct in-place. Left out harder cases using initializer lists, and might have missed slightly less obvious places. Change-Id: Ifcc3a6d4599474457e37dd17a35c41fc73e7a17e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111980 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-03-04SidebarPanelBase is always created with a PanelLayoutCaolán McNamara
Change-Id: I825452fbd56435edcc0a2ffb7abe0f834bf10fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04inherit NavigatorWrapper directly from SdNavigatorWinCaolán McNamara
Change-Id: Ifdb2aae5d9af32577adedd3512ab1f8a1e8047e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111975 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04drop newly unused PanelBaseCaolán McNamara
Change-Id: I5e84823fd25508c953dbe98c9d63e2333b4d6f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111974 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04remove intermediate TableDesignPanelCaolán McNamara
Change-Id: Icdc1aef7a0d53239ee41e818a56d137aa959249c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111973 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04remove intermediate CustomAnimationPanelCaolán McNamara
Change-Id: I34e1e3f87565cb9d8bf33f8e8f22844081785e21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111969 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04make both 'empty' widget and its treeview replacement the same sizeCaolán McNamara
so on flipping one visible vs the other the panel scrollbar position is equally valid for each mode Change-Id: Iae422c30eb8b752c407070b66852fe23fdc38912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111967 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04allow slide transition panel to be narrowerCaolán McNamara
Change-Id: Ib1fc71fe189b199fef6feb4f5f72f4513dfded97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111965 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04remove intermediate SlideTransitionPanelCaolán McNamara
Change-Id: Ifdecbd56b3da30081ed40e9940c7c2a6c7e1e48a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111962 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04use a single context menu handler at the valueset levelCaolán McNamara
instead of a custom right click handler in the valueset and a separate context menu handler in its parent Change-Id: Ia174892beb72ab79a3ceda1ad8992ce90a410db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111957 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04allow focus into master page panelCaolán McNamara
Change-Id: I34ab8ad6d267ffaab8ead2581e0d892ee37ec095 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111956 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03update pchesCaolán McNamara
Change-Id: Ide49c48738ecd537d4eb69390d22807561d3b4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03loplugin:refcounting in sdNoel
Change-Id: I5e259fc7028b75910efd6a99ed445690a9c496ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-01loplugin:refcounting in svxNoel
Change-Id: I87b1d0684e6e8921b222f76a13a36706c0eb8c87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111750 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-01LOK: disable rotation mode on selection of shapemert
Change-Id: Iff0ed673ae1c61ff0d753cf3a1f871213f8b3a7d Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110399 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111509 Tested-by: Jenkins
2021-03-01Added .uno:MoveShapeHandle uno commandmert
This is now only available for Draw/Presentation It will allow interactive dragging/resizing operations via the command. Later it will be implemented for other modules too. Change-Id: Iaed7d25cf4035591083e779c13a6f0227a3b564f Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111508 Tested-by: Jenkins
2021-03-01new loplugin:staticdynamicNoel
look for places we are dynamic_cast'ing after static_cast'ing, which means the dynamic_cast is a waste of time. Change-Id: Ife11bb675020738040646230bbd038278d84f7f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111631 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-27hide background options in master slide view in sidebarPranam Lashkari
Change-Id: Idecf4c849f9f5ac338ea24ca04cbbf9afe5cad5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106213 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 962bd10e456d95c7579ffb380b3e69f67cf5ea11) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111680 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-02-27drop intermediate vcl container for impress annotation floating toplevelCaolán McNamara
Change-Id: Ia285322d69ea8ac803e1ee5ed8ba195388189058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-27calculate text height after setting paper sizeCaolán McNamara
Change-Id: Ifb92109ead6b4a321d4abd81c2d36c415cbd767a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111655 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-26cid#1473323 Identical code for different branchesCaolán McNamara
Change-Id: I8997b1b0d43fca8dbf3081736ebc3d7a1e2fbb2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-25allow use of FloatWinPopupFlags without including complete floatwin.hxxCaolán McNamara
Change-Id: Ica412938ead6f213668b3aa876bff81d8f512f1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111526 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24drop an unneeded includeCaolán McNamara
Change-Id: I086036cf19b7e011da17ab5767460ac3e10eab2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24drop unneeded includeCaolán McNamara
Change-Id: I1a5a0f7b799f332d9f1d43ad50c8a6d924c71cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111494 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23loplugin:unusedmethodsNoel
Change-Id: Ie0534244cc7a30ad006e65baf125c59757c90d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23loplugin:unusedfieldsNoel
Change-Id: Ieb1b890040964e755de5bdf5f8576d4d3bd8a407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111386 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23weld fieldmenuCaolán McNamara
Change-Id: I37a1609669631fdafcb4dea59a2a43c1c94e16e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111380 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23replace SdTemplatePopup_ImplCaolán McNamara
Change-Id: I734124939139e34c776e5e4fe52acde08abf24ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23update pchesCaolán McNamara
Change-Id: I44424081b7f55710c4db7f10d1829de1ae08be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111363 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-21loplugin:refcounting in sdNoel
Change-Id: Ic95aa7a3c1fdab1baef744ec85ffc9c98dee5f1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20Add unittest for tdf#123841 Unfilled rectangles make filled rectanglesmsrijita18
Change-Id: Ic429ab5aa21102a44c9a559438bf3659a9d9137c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110849 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-20loplugin:refcounting in svxNoel
Change-Id: I79afd219a29ad176ce72020579d2b29a0b3ec09d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-20drop some unneeded includesCaolán McNamara
Change-Id: I0fe18c3e535bee2213606b7189778c40403a97ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20loplugin:refcounting in svlNoel
Change-Id: Iae192caa9d05f71ce02aae966ef1d71232d1a7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19uitest: remove duplicated testsXisco Fauli
The document properties dialog's code is the same for the three components, no need to test the same things in three different places Change-Id: I26effca2093fdf6c5a98c641c03b7c1b5205838f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-19weld slidecontextmenuCaolán McNamara
Change-Id: I7777a3fea3ddf920c45daa244826dffb7effa58c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111238 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>