Age | Commit message (Collapse) | Author |
|
Impress
Menubar -> Insert -> Slide Number open the Header and Fooder Dialog
Change-Id: Ie6c03358254265422ef2b760aa182515a44480d4
Reviewed-on: https://gerrit.libreoffice.org/56976
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
They wouldn't really compile anyways and only cause unnecessary
blacklist entries.
Some '- memory' entries can already be removed from the blacklists.
Change-Id: Iab53d5a57121f61abe935e712dc23a55390235bf
Reviewed-on: https://gerrit.libreoffice.org/56979
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Adds ellipsis to "Insert Image" in Impress Slide properties sidebar.
Change-Id: I8f93d35e7fbb217cd10e9a549397d816a3e164f6
Reviewed-on: https://gerrit.libreoffice.org/56929
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
support for "mandatory" property was introduced in
d77f8eef165a7c6fd97cc06dcbc4ead55e7b633c but implementation was
made only for Calc and Draw.
decrease minimal width for "size" element: it is using too much
horizontal space in small window.
Change-Id: I184ac3a03ffa0a018f012d0f5da3c2da54f6c365
Reviewed-on: https://gerrit.libreoffice.org/56719
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
... (introduced with 6fffd09833a5bd602b0117f48656afd07fd40f41 "tdf#109190 sd:
only MakeVisible on mouseclick-up") during CppunitTest_sd_misc_tests,
<https://ci.libreoffice.org//job/lo_ubsan/960/console>:
> /sd/source/ui/inc/DrawViewShell.hxx:117:50: runtime error: load of value 190, which is not a valid value for type 'bool'
> #0 0x2b20592e1a9c in sd::DrawViewShell::IsMouseButtonDown() /sd/source/ui/inc/DrawViewShell.hxx:117:50
> #1 0x2b20594e7c0c in sd::DrawViewShell::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drviewsh.cxx:61:11
> #2 0x2b2059074b41 in sd::DrawView::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drawview.cxx:501:9
> #3 0x2b207669a227 in SdrObjEditView::ImpMakeTextCursorAreaVisible() /svx/source/svdraw/svdedxv.cxx:1959:17
> #4 0x2b20766e4ea4 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdedxv.cxx:2171:13
> #5 0x2b2076396e58 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdcrtv.cxx:868:16
> #6 0x2b203f8d7b36 in SdrView::SetAttributes(SfxItemSet const&, bool) /include/svx/svdview.hxx:192:81
> #7 0x2b203f8ab5a1 in SdMiscTest::testTdf99396TextEdit() /sd/qa/unit/misc-tests.cxx:215:9
> #8 0x2b203f934ad8 in void std::_Mem_fn_base<void (SdMiscTest::*)(), true>::operator()<, void>(SdMiscTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11
> #9 0x2b203f9347e3 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11
> #10 0x2b203f9341f1 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11
> #11 0x2b203f932bc9 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2
> #12 0x2b203f935550 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14
> #13 0x2b203f931265 in CppUnit::TestCaller<SdMiscTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
> #14 0x2b1ff4edce7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
> #15 0x2b20120c14d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14
> #16 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #17 0x2b20048ad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
> #18 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #19 0x2b2000939e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
> #20 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #21 0x2b1ff4e172df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
> #22 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
> #23 0x2b1ff4e91b70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
> #24 0x2b1ff4f66ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10
> #25 0x2b1ff4ed9efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5
> #26 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
> #27 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
> #28 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
> #29 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
> #30 0x2b1ff4fa6686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5
> #31 0x2b1ff4f64e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3
> #32 0x2b1ff4fa7b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3
> #33 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13
> #34 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14
> #35 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1
> #36 0x2b1ff6bdc444 in __libc_start_main (/lib64/libc.so.6+0x22444)
> #37 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494)
Change-Id: Idff283298ee2fa11467ff4b8604da642e5a09a8f
Reviewed-on: https://gerrit.libreoffice.org/56854
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It is possible to cancel a mouse-down without a mouse-up
(for example with an ESC button).
So, cancel an obsolete "MouseSelecting" on mouse-down.
Change-Id: I37d641612cf2cd8099af8f04b12fdb364c4f9e24
Reviewed-on: https://gerrit.libreoffice.org/56857
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: I4c7cc0f462fdd3ee2d2b44bc73f0313e6cd4176a
Reviewed-on: https://gerrit.libreoffice.org/56423
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
since they don't depend on SvTreeList at all
Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f
Reviewed-on: https://gerrit.libreoffice.org/56819
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Since MakeVisible is called on both
mousebuttom-down and mousebuttom-up,
this also eliminates useless double-processing.
In the problematic use case, the user pressed Ctrl-A to select
a tall table. When clicking to de-select the cells, the contents
moved around in unexpected ways because the rectangle is at the
end of the selection during down-click, not at the cursor location.
The re-arrangment of the screen invalidates the mouse-up,
so the intended cursor position shifted.
In the bug's calendar example, position the screen so that items
20-31 are hidden, select the whole month, and then click
on 5. Before, it would move the screen down to show 31, and
the cursor would be placed at the screen position where 5
had originally been. Solved by only repositioning on
mouse-click up.
However, mouseButtonDown must still be honoured while
selecting, otherwise you can't select off-screen content
with the mouse.
Change-Id: I41c90a7b113dc59a3c8c385139a5bb41993646fa
Reviewed-on: https://gerrit.libreoffice.org/56262
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
SdrText::SetOutlinerParaObject was modified to not check for
self-assign, and instead assert because
the existing check was no longer possible.
Fix bug in SdrUndoObjSetText::Undo(), where it was calling
SdrText::SetOutlinerParaObject unnecessarily,
because NbcSetOutlinerParaObjectForText already does that.
Optimise Outliner::GetEmptyParaObject by creating a new constructor for
OutlinerParaObject,
so we don't need to copy the new object we get back from
GetEmptyTextObject, unnecessarily.
Change-Id: I57c475583d6c31658c154e24992b3d587bad9841
Reviewed-on: https://gerrit.libreoffice.org/56730
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
we trade off a little accuracy for finding more possible write-only
fields.
Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269
Reviewed-on: https://gerrit.libreoffice.org/56715
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
There are actually 2 bugs here that affect the export, and just 1 new
attribute.
Change-Id: Id2d9eeeb62c97011712a376a844dec7c8a744116
Reviewed-on: https://gerrit.libreoffice.org/56606
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I043576ca1fa83180b326f65b05f6bc5c21814e82
Reviewed-on: https://gerrit.libreoffice.org/56701
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...followup to commit 76505bbd862b17b9b02a2d6e68bac308890dec70
which made the border invisible by setting the color to COL_AUTO.
But being invisible isn't good enough because on a round-trip
we are now losing the "noFill" attribute and saving a defined
border. However, COL_AUTO is turned into white during import,
in both LO and in MSO, so round-tripping displayed a
white border instead of an invisible one.
Change-Id: If6cb513ca6e4336e49bc56a9509aede2e1937063
Reviewed-on: https://gerrit.libreoffice.org/55658
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
When passing DND_ACTION_MOVE to View::InsertGraphic, the whole object gets
replaced. DND_ACTION_LINK should be used, because it just replaces the
graphic and keeps crop information.
Marking the object is not needed, because InsertObjectAtView and
ReplaceObjectAtView already take care of that.
Change-Id: I0d829ec39a9d484a7c8946252e90eddb12ea9756
Reviewed-on: https://gerrit.libreoffice.org/56401
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
in every app there is in view as last subgroup zoom
ordinary you have fullscreen and zoom with the submenu
as in draw there fuulscreen isn't available panning was shown
and the submenu was updated to show also the draw specific zoom items
Change-Id: I390ac40815aa28c7df883cf63dcd214b181785ed
Reviewed-on: https://gerrit.libreoffice.org/56586
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Eventually MotionPathTag::Notify() and CustomAnimationPane::
updatePathFromMotionPathTag will be called to update the
motion path of the effect.
Change-Id: I1cd0756ea24d9b56ad3c44c99ef015c584c74dc7
Reviewed-on: https://gerrit.libreoffice.org/56353
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
ie. OOXML export/import of "_MarkAsFinal" MSO document property.
Change-Id: I01f0702d5467e78eb93ce8dce8ba25874839c3e3
Reviewed-on: https://gerrit.libreoffice.org/56475
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Import custom document property _MarkAsFinal as LoadReadonly
setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX
and PPTX documents.
Before this fix, LibreOffice opened read-only OOXML documents
as editable, also saved and exported _MarkAsFinal=true silently,
resulting unintented read-only warning info bar in MSO.
This commit improves interoperability a lot, because this is a
basic document protection of MSO, recommended on its UI.
Note: LoadReadonly (on File->Properties...->Security, property
"Open file read-only") doesn't show "Edit read-only" info bar
from commit 630186ff4e0eba7317e542f8c3eca39ebd068721,
but it's still possible to switch on editing by Edit->Edit Mode.
MSO shows info bar for _MarkAsFinal. (There is an advantage to
hide the info bar in LibreOffice in a mixed environment,
to avoid overwriting of press-ready MSO files by LibreOffice.)
Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal
in MSO: (1) Switching on editing doesn't remove the LoadReadonly
property automatically in LO. (2) Saving with LoadReadonly doesn't
switch off editing of the actual (still opened) document in LO.
Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216
Reviewed-on: https://gerrit.libreoffice.org/56180
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
new statusbar element property mandatory=true/false to determine
if this element can be hidden if total statusbar width is not
enough to fit all elements.
marked some calc and draw statusbar elements as not mandatory.
Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f
Reviewed-on: https://gerrit.libreoffice.org/56443
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7
Reviewed-on: https://gerrit.libreoffice.org/56491
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I4bd0a9dd7be5b6ad7c1307f73c89ab0ee915ce9f
Reviewed-on: https://gerrit.libreoffice.org/56495
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
fixes 6.0 commit 9ae1e094d5a8a5b4432c88ebea0ca9fc1c79f602
> PPTX export: correct position of rotated groups
However, there was nothing excluding the re-positioning
to only group items.
Change-Id: I62e36b46c0d2ac3e41f8d7d4ed82df11e6eb1ee5
Reviewed-on: https://gerrit.libreoffice.org/56386
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: If4725a7c170a4f10b1ffd0cfc769fcdca70e2eaf
Reviewed-on: https://gerrit.libreoffice.org/56493
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I79fcbaa12def04aa36bdf1928638b70ad490448c
Reviewed-on: https://gerrit.libreoffice.org/56494
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I163a080cfae988db38fbd7b3d9de1531f6ba4089
Reviewed-on: https://gerrit.libreoffice.org/54112
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I8902a792d9dc1ba2bc50a53c10a387f34af50307
Reviewed-on: https://gerrit.libreoffice.org/56339
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic1f213b039b9c3e1cedc041d3e136eb09496570d
Reviewed-on: https://gerrit.libreoffice.org/56338
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I53241b4cd45ffd6cdbf81c2984a7e95e67a00b93
Reviewed-on: https://gerrit.libreoffice.org/56335
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia17fbfbbb76d035c669e797c98a095667187ee80
Reviewed-on: https://gerrit.libreoffice.org/56337
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I95c17965e7de1daf0b548220326e05371b71b1ae
Reviewed-on: https://gerrit.libreoffice.org/56336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib1005ab0a0a007d2bad956c8ca0c23c475736d5f
Reviewed-on: https://gerrit.libreoffice.org/56332
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic2e93c1493159c9602bd68b409052117766dcc02
Reviewed-on: https://gerrit.libreoffice.org/56328
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The fix I was about to suggest broke this file on round-trip.
It is not enough to just exclude if not a group-shape, or
else the group-shape detection is not good enough.
Change-Id: I0048bb9221262afdd373b18b5d73ec9468b7d670
Reviewed-on: https://gerrit.libreoffice.org/56340
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
... by reserving enough space at once.
As the length of these vectors depends/grows on user's input,
this change can be a micro optimization.
Change-Id: I1baa7d1433875491e86403d727f11f676d29a833
Reviewed-on: https://gerrit.libreoffice.org/56346
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8b31b0feedd84893327b2a4acc436d46c2306450
Reviewed-on: https://gerrit.libreoffice.org/56240
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Unlike regular shape object whose shape effect were kept
after change text grouping to "as object", the effects of
all the outline objects were removed. Re-add the effect
if nothing is left there.
Change-Id: I6d06fad709639f2d2976f6027b8d193f66893c90
Reviewed-on: https://gerrit.libreoffice.org/55973
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: I8ca3b421dbfa83c19234f5cbde0a2ae340d3d268
Reviewed-on: https://gerrit.libreoffice.org/55979
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: Ia2c670c708caaf8ab50a13e0635c13a759fd5941
Reviewed-on: https://gerrit.libreoffice.org/55974
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: Ib63147a9f4dceb35e21bcf0ca5c1afebf5263721
Reviewed-on: https://gerrit.libreoffice.org/56048
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: Ib3708c9650f273de4a2f549d2ce9f2465bd37d6c
Reviewed-on: https://gerrit.libreoffice.org/56206
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ie93b7695e4c67fc55089b21a5df37a3468ad4bee
Reviewed-on: https://gerrit.libreoffice.org/55565
Tested-by: Jenkins
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
The exception in the case of a running slideshow has been around
since the function was introduced, but more and more code
has been building up in front of that if clause. Since no
changes will be made, include that exception in the initial
exit clause to avoid unnecessary computations.
This cleanup is prep work for a bug fix.
Change-Id: Ief0b07d8108e1576459486ef61f038443f64705f
Reviewed-on: https://gerrit.libreoffice.org/54678
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
and enable the corresponding gla11y warning
Change-Id: Iabf850f6831cb7d269aa74c9ab50461d35871a16
Reviewed-on: https://gerrit.libreoffice.org/55750
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I3ea0b0ed28e85e7f8cf00e73b6698a5773c886ba
Reviewed-on: https://gerrit.libreoffice.org/56197
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
BitmapEx and tools::Time are both value objects, no need to use
std::unique_ptr for them
Change-Id: Ibeed7da46ccc8fd3cd3301d364ae33c33c0114bb
Reviewed-on: https://gerrit.libreoffice.org/56198
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic18811145db90a7f9eff61e94069e68b3c80c298
Reviewed-on: https://gerrit.libreoffice.org/56196
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a
Reviewed-on: https://gerrit.libreoffice.org/56162
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id67b08d8d8a08d7e19ef8534b7bb9d689a571e06
Reviewed-on: https://gerrit.libreoffice.org/56105
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib146bdfd04f428d922e23ec6b5054d53326ca5f3
Reviewed-on: https://gerrit.libreoffice.org/56106
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|