summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2024-11-21Fix typosAndrea Gelmini
Change-Id: I98f88e799a9a5128677f26e0c740c0764ffc8d9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176934 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-21Make rendering more flexible, render fields in separate layerTomaž Vajngerl
If the amster page has a field (like slide number) then render the objects containing fields into a separate master slide layer. Also change the rendering in such a way to be more flexible and has less conditions. So in the renderer it doesn't really matter if we are rendering a master slide or slide, what matters only is if the object is already rendered and if we need to stop rendering for some specified reason (like we encountered a field and need to stop rendering and need to switch to a new layer). Change-Id: I37ea2528427bbc1b3de938f960fb344866ee9399 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176911 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-21CppunitTest_sd_tiledrendering2: move to tiledrendering folderXisco Fauli
In preparation for a follow-up commit Change-Id: Ifb3ee72cef3493cb1774c0a0c5ac6b5850309396 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176878 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-20Resolves tdf#163856 - Disentangle boundaries optionsHeiko Tietze
* Boundary toggles removed from app colors * Object boundaries completely removed (color replaced with DOCBOUNDARIES; Impress placeholder on/off now an expert option) * Toggle options added under formatting aids * Individual UNO commands marked deprecated * New command added to show all boundaries * Frames follow sections now in state and color * Kind of wrapping doesn't matter anmymore Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2024-11-20switching PageKind without switching EditMode retains current pageCaolán McNamara
i.e. ChangeEditMode doesn't do anything if the EditMode is unchanged but the PageKind was switched from Notes to Standard. So the same page of the other mode is still selected. An explicit SwitchPage is required to change the page from the other mode. This results in the reported mode of "2", but rendering actually still rendering as if in "mode 0", so a request to render a 'standard' page returns an image of the currently still-selected 'notes' page, which confusingly can be cached and not shown until served as a reply to a later request of the 'standard' page. See DrawViewShell::ReadFrameViewData and other places for more of this pattern. Change-Id: Ie8aa8f93f45189fd6f9c37c4077fa2b547ca4815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176084 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 95e9c210ef8380b0909c6ba596e3023bafef4083) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176824 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-19intruduce RenderContext, RenderOptions to remove code duplicationTomaž Vajngerl
To remove code duplication when rendering main and master slide, it is needed to put them into common code, so add RenderContext and RenderOptions classes to put the common code into those. Change-Id: Icf4039f85e0aa5bf4d43e6fe5efb725c90504173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176762 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-19improve loplugin passparamsbyrefNoel Grandin
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-18tdf#163251 Fix for missing flags in single click obj creationAshSinc
Change-Id: I0f6e65c4cf3ad9cac3096144d8a0efec29030739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174420 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-11-15render master and slide content separately (drawinglayer render)Miklos Vajna
This renders master and the main slide as 2 separate layers, which is useful because in a huge slideshow we can reuse the master slide and only render the rest of the slide, which should be more compact in size as the master slide is the one that usually contains the (complex) background. Change-Id: I5e86d718b7ab3b03bd0b6146ce4df218a4dd72d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176622 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-15Cleanup notebookbar.ui for drawHossein
Fix duplicate IDs found by glade-previewer Change-Id: I5331d5ebdc226bb370d2fd6d6f00c2315952f5ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176625 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-14Fix typosAndrea Gelmini
Change-Id: I67b770e3973b78cd59bc1e7c23d780187814c07a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176587 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-14render slide layers with VCL / drawinglayer primitivesTomaž Vajngerl
Instead of using slideshow module to render the slide layers, use the VCL / drawinglayer instead, which makes it possible to render transparency correctly and fast. Change-Id: Idfc9fcc8bc0e2bc139df93d1805f7a19fb1bce1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176575 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-14tdf#163805: set fill style to solid on fill color selectionPranam Lashkari
problem: The issue here is that the table does not have a fill style set, but using the fill tool from the menubar does not give any error or warning, either, which confuses the user. Change-Id: Ib7d6ecdbb315b6eb2eca21423fba28d3cb086450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176245 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit c0623158f010e08e0bfadaffb988eac14e1ff34e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176238 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins
2024-11-13tdf#163486: PVS: variable is used after being declaredXisco Fauli
V614 The 'pEffect' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it. Change-Id: Ic93aa42fa34af873f8dced5da0c1f55a8dcbd58d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176554 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-13tdf#36709 editeng: Layout for font-relative first-line indentJonathan Clark
This change extends layout for font-relative paragraph first-line indentation into Edit Engine. Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-13tdf#163486: PVS: variable was assigned the same valueXisco Fauli
Since commit ca644612762921e772ca95d5e8737325d9f343d2 Author: Radek Doulik <rodo@novell.com> Date: Tue Jun 26 12:25:03 2012 +0200 remember spell check/find&replace start position only 1st time The 'mnStartPageIndex' variable was assigned the same value. Change-Id: I567f15e88d853804516010b10d9bd571d95f10aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176527 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-13lok: slideshow: export slide duration also when there is no transitionsMarco Cecchetti
Change-Id: I234cb814a2096a0071de9cea3f7f8289c107b2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176520 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-13lok: slideshow: not export endless and repeat property per each slideMarco Cecchetti
Endless and loopAndRepeatDuration properties has to be exported as presentation property Change-Id: I223ab488c8be0726f84a229a63595be6f9455c76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176468 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-12loplugin:reftotemp in sdNoel Grandin
Change-Id: Ib38fdc34dc2112f1aac3914baa074c7574f34f7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-12clang-tidy: performance-unnecessary-copy-initialization in sdNoel Grandin
Change-Id: I2521bc29afb9ae98d7db2fab81f93264c91c4065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176438 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-12tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 981, 1008 V1037 Two or more case-branches perform the same actions. Check lines: 1018, 1025 Change-Id: Iea6f6edc65490587cb974f6d3baa17d3a337a0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175217 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-11lok: enable Zoom transition and RotateIn sub-trans. typeJaviya Vivekkumar Dineshbhai
Change-Id: I017403afe90a249cf4c703d813d44b02b0c1430b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176371 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-11cid#1607564 silence Overflowed integer argumentCaolán McNamara
Change-Id: Ib008987be1102782fd92214ae8bf35f8f862d2a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176381 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-11cid#1607838 silence Overflowed constantCaolán McNamara
Change-Id: I4201afc8ee115200f47de4e7b7974f82735a1f01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176380 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-10com::sun::star -> cssMike Kaganski
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-08sidebar: move apply to all slides above repeat settingsSzymon Kłos
Button "apply to all slides" setups properties selected above to all the slides. Repeat options are common to the whole presentation. Let's move repeat section to the bottom so it is less confusing Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I19bb8d10c3969ceb033e2a6d26489999bb7451c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174357 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: vivek javiya <vivek.javiya@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176283 Tested-by: Jenkins
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08lok: disabled misc shape wipe non supported transitionJaviya Vivekkumar Dineshbhai
Change-Id: I1a2f67e20fb39a711a6da41ee1152499cf91c28a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176266 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-08Avoid checking exact interface type of Any valueMike Kaganski
Change-Id: Ic883c3a9fd8eb87469aec6b6570a39aadf575c3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176184 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-08Simplify a bitMike Kaganski
Change-Id: I618b0f8bcb2e8032ee12367c73e1136685f66b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176183 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-08tdf#95852 sd: not TopViewShell if mbFormShellAboveParentJustin Luth
This fixes a 5.0 regression from commit 967a386bccb15b99915a1e878e42450fbe9a2d0e on Wed Nov 5 20:15:32 2014 +0100 Fix for SUSE L3 bug 624546 (freedesktop 83733) Change-Id: Id5ec9a853f8abcc329d03434cd6cfcf35195bd2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176086 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-07loplugin:passstuffbyref in sdNoel Grandin
Change-Id: I95a95b8962bf1d168fee92943c611ce70abf3cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176201 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-07lok: enable MiscShapeWipe transition and sub-tras. Heart, FanOutHoriz.Javiya Vivekkumar Dineshbhai
Change-Id: I6511da17b3222bc83c0870f100fb7e8eafc78bef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-07[API CHANGE] a11y: Switch AccessibleRelationType to enumMichael Weghorn
Switch css::accessibility::AccessibleRelationType from integer constants to an enum. This provides more type safety and improves the debugging experience, e.g. GDB now prints com::sun::star::accessibility::AccessibleRelationType::AccessibleRelationType_CONTENT_FLOWS_TO instead of just "2" when printing the value of a corresponding variable, so it's no longer necessary to manually look up what constant has that integer value to know what relation this refers to. offapi/com/sun/star/accessibility/AccessibleRelationType.idl had this comment: > <p>We are using constants instead of a more typesafe enum. The reason > for this is that IDL enums may not be extended. Therefore, in order to > include future extensions to the set of roles we have to use constants > here.</p> However, the a11y UNO API is internal (not published), so that shouldn't be a concern. Change-Id: I44a7d56cb085dc24effb24fcd34bb222b78ef4cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176153 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-06Libreoffice Theme Part 1.0: Make registry colors accessible from VCLSahil Gautam
Enable UI color customization via an extension. This patch doesn't include any UI changes as that needs to be discussed with the community first (ticket: https://bugs.documentfoundation.org/show_bug.cgi?id=163620) Part 1.0 (this change) is responsible for loading all the ThemeColors from the registry into a `static ThemeColors` object, which then is accessed in various VCL_PLUGINS as a source for the application colors. The user now has to go to the registry (expert configuration), and enable the theme by setting "LibreofficeTheme" to "true". It can also be enabled via an extension (demonstrated in the Theme Template). `testGetViewRenderState` changes to "Dark" scheme which is not present. Changes in this patch don't allow that and use 'Automatic' as the fallback. This caused the unit test to fail. So the test was changed to have "Dark" scheme before changing to it. Theme Template: https://github.com/printfdebugging/libreoffice-theme-template Project Report: https://printfdebugging.in/libreoffice/01-themes-gsoc-2024/ Change-Id: I5193d4d34fcd2f4c5d6f124a871bd5c7f14e95a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168016 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-06loplugin:passstuffbyref in svxNoel Grandin
Change-Id: Ic5fd72cb64208c278ffc129591cd3d1131efdc08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06cid#1556442 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607753 COPY_INSTEAD_OF_MOVE cid#1554790 COPY_INSTEAD_OF_MOVE cid#1556463 COPY_INSTEAD_OF_MOVE cid#1554838 COPY_INSTEAD_OF_MOVE cid#1556231 COPY_INSTEAD_OF_MOVE cid#1556878 COPY_INSTEAD_OF_MOVE cid#1554913 COPY_INSTEAD_OF_MOVE cid#1558064 COPY_INSTEAD_OF_MOVE cid#1557043 COPY_INSTEAD_OF_MOVE cid#1556985 COPY_INSTEAD_OF_MOVE cid#1556766 COPY_INSTEAD_OF_MOVE cid#1557351 COPY_INSTEAD_OF_MOVE cid#1554863 COPY_INSTEAD_OF_MOVE cid#1556764 COPY_INSTEAD_OF_MOVE cid#1556279 COPY_INSTEAD_OF_MOVE cid#1555970 COPY_INSTEAD_OF_MOVE cid#1556942 COPY_INSTEAD_OF_MOVE cid#1557964 COPY_INSTEAD_OF_MOVE cid#1555166 COPY_INSTEAD_OF_MOVE cid#1556496 COPY_INSTEAD_OF_MOVE cid#1557175 COPY_INSTEAD_OF_MOVE cid#1558054 COPY_INSTEAD_OF_MOVE cid#1557392 COPY_INSTEAD_OF_MOVE cid#1557850 COPY_INSTEAD_OF_MOVE cid#1555118 COPY_INSTEAD_OF_MOVE cid#1557131 COPY_INSTEAD_OF_MOVE cid#1556614 COPY_INSTEAD_OF_MOVE cid#1609650 COPY_INSTEAD_OF_MOVE cid#1555114 COPY_INSTEAD_OF_MOVE cid#1555241 COPY_INSTEAD_OF_MOVE cid#1555442 COPY_INSTEAD_OF_MOVE cid#1556473 COPY_INSTEAD_OF_MOVE cid#1557654 COPY_INSTEAD_OF_MOVE cid#1554689 COPY_INSTEAD_OF_MOVE cid#1556316 COPY_INSTEAD_OF_MOVE cid#1557929 COPY_INSTEAD_OF_MOVE cid#1554807 COPY_INSTEAD_OF_MOVE cid#1554858 COPY_INSTEAD_OF_MOVE cid#1555103 COPY_INSTEAD_OF_MOVE cid#1555517 COPY_INSTEAD_OF_MOVE cid#1556424 COPY_INSTEAD_OF_MOVE cid#1557252 COPY_INSTEAD_OF_MOVE cid#1557566 COPY_INSTEAD_OF_MOVE cid#1608020 COPY_INSTEAD_OF_MOVE cid#1557742 COPY_INSTEAD_OF_MOVE cid#1555884 COPY_INSTEAD_OF_MOVE cid#1554809 COPY_INSTEAD_OF_MOVE cid#1555336 COPY_INSTEAD_OF_MOVE cid#1555173 COPY_INSTEAD_OF_MOVE cid#1556067 COPY_INSTEAD_OF_MOVE cid#1557040 COPY_INSTEAD_OF_MOVE cid#1556235 COPY_INSTEAD_OF_MOVE cid#1557366 COPY_INSTEAD_OF_MOVE cid#1555910 COPY_INSTEAD_OF_MOVE cid#1556716 COPY_INSTEAD_OF_MOVE cid#1558022 COPY_INSTEAD_OF_MOVE cid#1555769 COPY_INSTEAD_OF_MOVE cid#1555940 COPY_INSTEAD_OF_MOVE cid#1557077 COPY_INSTEAD_OF_MOVE cid#1555270 COPY_INSTEAD_OF_MOVE cid#1555660 COPY_INSTEAD_OF_MOVE cid#1556302 COPY_INSTEAD_OF_MOVE cid#1555678 COPY_INSTEAD_OF_MOVE cid#1556538 COPY_INSTEAD_OF_MOVE cid#1557689 COPY_INSTEAD_OF_MOVE cid#1555009 COPY_INSTEAD_OF_MOVE cid#1555433 COPY_INSTEAD_OF_MOVE cid#1555671 COPY_INSTEAD_OF_MOVE cid#1555255 COPY_INSTEAD_OF_MOVE cid#1557681 COPY_INSTEAD_OF_MOVE cid#1557512 COPY_INSTEAD_OF_MOVE cid#1554958 COPY_INSTEAD_OF_MOVE cid#1555758 COPY_INSTEAD_OF_MOVE cid#1555597 COPY_INSTEAD_OF_MOVE cid#1558040 COPY_INSTEAD_OF_MOVE cid#1556476 COPY_INSTEAD_OF_MOVE cid#1557646 COPY_INSTEAD_OF_MOVE cid#1557950 COPY_INSTEAD_OF_MOVE cid#1557019 COPY_INSTEAD_OF_MOVE cid#1557885 COPY_INSTEAD_OF_MOVE cid#1556402 COPY_INSTEAD_OF_MOVE cid#1557906 COPY_INSTEAD_OF_MOVE cid#1556619 COPY_INSTEAD_OF_MOVE cid#1554683 COPY_INSTEAD_OF_MOVE cid#1556549 COPY_INSTEAD_OF_MOVE cid#1554747 COPY_INSTEAD_OF_MOVE cid#1554929 COPY_INSTEAD_OF_MOVE cid#1555362 COPY_INSTEAD_OF_MOVE cid#1557053 COPY_INSTEAD_OF_MOVE cid#1557891 COPY_INSTEAD_OF_MOVE cid#1555043 COPY_INSTEAD_OF_MOVE cid#1555107 COPY_INSTEAD_OF_MOVE cid#1557203 COPY_INSTEAD_OF_MOVE cid#1556728 COPY_INSTEAD_OF_MOVE cid#1557773 COPY_INSTEAD_OF_MOVE cid#1556845 COPY_INSTEAD_OF_MOVE Change-Id: I001fb67e597b096e992fd8a0cd6f3ec577767c33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176098 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-06Fix: Make the repeat slideshow property independent of the TransitionTypeJaviya Vivekkumar Dineshbhai
Change-Id: I60b00f2935df8dc224736120b1e0d70c2821c0cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176105 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-03tdf#163486: PVS: pointer not released in destructorXisco Fauli
Since commit 7ef3b46fd5bdfb3a87e9b0a840287fdb6ff4734b Author: Gergő Mocsi <gmocsi91@gmail.com> Date: Thu Mar 7 11:57:04 2013 +0100 fdo#35546, implementing 'Create Photo Album' function V773 The 'm_pGraphicFilter' pointer was not released in destructor. A memory leak is possible. Change-Id: Iee1c4f4f3ae5232506563a219ffdec61f74fcff0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175884 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-02tdf#145161: Change pdf and image compression dialog stringAditya Sahu
Since image/pdf compression does not always reduce image or pdf resolution, change the misleading label from "reduce" to "change" wherever possible. Keep identifiers having "reduce" in their name as is as of now, only change the string values containing "reduce" to "change". Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-31tdf#163486: PVS: check GetViewXisco Fauli
V1004 The 'GetView()' pointer was used unsafely after it was verified against nullptr. Check lines: 596, 606. Change-Id: I4bf5366f49794c2956b0f704c32829c9dac6d5b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175883 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-31tdf#163486: PVS: check getViewShellBaseXisco Fauli
V522 There might be dereferencing of a potential null pointer 'getViewShellBase()'. Change-Id: I19becd2a40a7e996b6634c20df309d171ebbaf1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175882 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-31convert KernArray from sal_Int32 to doubleNoel Grandin
which allows us to eliminate a bunch of rounding at various layers, and consequently maintain a lot more precision Change-Id: I911dedd7c041c1d67396c082e5695346ea689acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 962, 979 Change-Id: Ic31a6129828a41bd3450567ca8cb8884d60691cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175220 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 944, 957 Change-Id: Ic637d4aa5e6024cc0011e8e51a0fba68c2644378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175225 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 685, 689 Change-Id: I3c35e7d89699e64693c04da554136f8747fd0dde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175347 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 718, 724 Change-Id: Id39e264626634ab4288e41bd6d72303a3820a10d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175319 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-29sd: lokit: add notes to presentation infoHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I1293a392749b6cff75be02236fb570f8faeb2446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174613 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175757 Tested-by: Jenkins
2024-10-29test: Merge SwAccessibleTestBase and AccessibleTestBaseXisco Fauli
Change-Id: Ic62bd287406326f4c3d3e0702850fe0337f17686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175762 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-25 06:42:18 +0000