summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2022-08-04lok: Dont render active text edit on slide previewsSzymon Kłos
- extend ITiledRenderable interface to pass active text edit drawing state to the SdXImpressDocument - when painting tiles - allow text edit only for current part - pass new setting also to SdrPaintView where painting happens Change-Id: Ib4ff226961a76129f4f5ff11c90694cd46a83a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137676 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
2022-07-28lok: Enable sidebar in MathMike Kaganski
Change-Id: I1554a924eef0bfcaffa893057a37ef45321a0cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137545 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-27lok: enable in-place editing of math equationsMike Kaganski
Change-Id: Ic4d187d1e2ee92eab74a6bb43e47bb4f3d47ebd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128506 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137460 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-25tdf#127236 vcl: fix missing encryption of PDF images during exportMiklos Vajna
Regression from commit 78e25558e86188314b9b72048b8ddca18697cb86 (tdf#106059 PDF export: create a reference XObject for JPG images with PDF data, 2017-02-23), once a PDF image was inserted to a document, an encrypted PDF export lost those images. The reason for this is that we started to preserve PDF images as vector data with the above commit, but this means we copied over PDF objects from PDF images to the export result as-is, so encryption was not performed for them. Fix this by separating the write of the PDF object headers, stream content and object footer and then calling checkAndEnableStreamEncryption() / disableStreamEncryption() for each object, even if it's not something our PDF export created but comes from a PDF image. Note that when existing PDF files are signed, PDF objects are also copied into a vcl::filter::PDFDocument, but such PDF images are never encrypted, so it's fine to have stub implementations in vcl::filter::PDFDocument. (cherry picked from commit 7d56dae3375dc0180aa6d20983b3f5f962302588) Conflicts: filter/qa/pdf.cxx svx/qa/unit/core.cxx vcl/qa/cppunit/pdfexport/pdfexport.cxx Change-Id: I2f74b9f51cd35b4319221532ca890e197bab9cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137358 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04tdf#149748 sd theme: fix crash on selecting none from color barMiklos Vajna
Opening Impress, going to view -> color bar to enable it and then clicking on "none" resulted in a crash. This went wrong in commit f5db3b12ae1cd3bfe6ee5d260aec9532cc65f2dc (sd theme: add UI (sidebar) for shape fill color, 2022-04-06), where I assumed that in case the slot is a SID_ATTR_FILL_COLOR, then its item set also has a SID_ATTR_FILL_COLOR key. This is usually true, but not in case of "no color" (i.e. transparent). Fix the problem by just skipping theming metadata for such a color. It seems to me that the color set of a theme is not allowed to contain such "no color" colors, so this should be safe. (cherry picked from commit c09eb0f74c0a110e4a4cfc4783b59883aad30475) Conflicts: sd/qa/unit/uiimpress.cxx Change-Id: I3fb65548dca1d78631311de56c15fdb655b9645a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136751 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04cid#1503836 silence Dereference null return valueCaolán McNamara
(cherry picked from commit 64046625553ecbfd9fe0661e5b6f48e283a909e0) Change-Id: I11dae0872d1f4add67b59ffd9696134c1dd2dbea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136750 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04sd theme: consider accent1 color when inserting shape with solid fillMiklos Vajna
Once a theme is defined for the master page of the current slide, PowerPoint inserts a shapes with their fill color & line color set based on that theme (so this color is master-page-specific), while Impress sets the fill & line color based on the default shape style. The Impress behavior has the benefit of doing the usual style-based formatting, but now a document-level style overwrites a (master-)slide-specific theme, which is inconsistent. Fix the problem by extending sd::FuConstruct::SetStyleSheet(): if we construct a shape with fill, then not only apply the style sheet, but also set the fill & line color based on the theme (if there is any). Note that this works both in case the shape is instantly created on click (LOK case) or when the user first draws a top-left -> bottom-right point pair to define the position / size of the shape. At the same time line colors don't support themes yet, so that color is just a plain value for now. (cherry picked from commit 486810603fb3f84847bb549004ed0394a2e22d0b) Conflicts: sd/qa/unit/uiimpress.cxx Change-Id: Ic6ae8f91bd719bd80f2b56f12b001d29b0961e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136749 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04sd theme: add UI (sidebar) for shape fill color effectsMiklos Vajna
Which was perhaps the last missing piece of the "sd theme: shape fill color" story. (cherry picked from commit 645413a14a91a72bc06acf0fb4703ff7b9fffec9) Change-Id: Ice75d91412aa56afe0c9995086097d491ebf7299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136748 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04tdf#149205 sd theme: fix PPTX export loosing dk1 and lt1 colorsMiklos Vajna
Document theme of Impress documents were exported to PPTX only partially: dk1 and lt1 was hardcoded to the SYS_COLOR_SCHEMES define, while the rest was written from master-slide-specific svx::Theme. The benefit of this is that our theme is just a set of colors (<a:srgbClr> markup in OOXML), while dk1 and lt1 is more dynamic by default in PowerPoint (<a:sysClr> in OOXML). The downside is that this way a custom dk1 and lt1 color was lost on export. Fix the problem by switching to <a:srgbClr> markup even for dk1 and lt1: not using the <a:sysClr> markup doesn't seem to be a problem in practice, or at least much less problematic than rendering with bad colors. If there is a need, dedicated <a:sysClr> markup support can be still added later by extending svx::ColorSet::maColors to not only store a list of colors, but also some additional properties of those colors. (cherry picked from commit 4a54a24c207f3040390e2fefec41cbbf0edd5eca) Change-Id: I26df3fd8c891c217df0d36382f6599805198f4bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136747 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-02tdf#149787 capture a copy of mpViewShell and mpViewCaolán McNamara
so the callback can outlive the FuArea Change-Id: I392ffa46b6f13795faef7284c1cae74428655b5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136694 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-02tdf#141313 only hide Impress Remote option if there is no sdremote at allChristian Lohmaier
it was incorrectly based on bluetooth support, but the remote can also be used in the local network. Regression from 4cdb960a79aff565f956f618116f3ea4b3836aa4 still worked for users who had it enabled in earlier versions, but not with new profiles. Change-Id: Ib4026c60fed0842b3bad483d78e46dd73d1d75f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136615 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 8d7c441097cc0279a9819fe0673b8cad40ae94db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136642 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02impress remote connection dialog must also work without bluetoothChristian Lohmaier
as otherwise you can never confirm the pin to approve new devices. old regression from 7c8c73dd5cf84050a8a2c51b04d7f5278b409fd7 still worked for users who had it enabled/linked in a previous version... Change-Id: Icf9fb6ae4259252da47c3709ab99fb7a2a70aeac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136616 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit c7147cd2504d1d3f91ca5b0a5e119ca9d2185b37) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136635 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02Integer division could cancel small values of wrong signMike Kaganski
... as seen at some documents where the values are like -1. There the checks in pushToPropMap may pass (the division result would be 0), but the original small negative values would fail the asserts that were introduced in commit 5772cef244dbee5834efbc693bc714d89ae6301d Author Mike Kaganski <mike.kaganski@collabora.com> Date Wed Jun 15 18:33:38 2022 +0300 tdf#134210: Reimplement cropping from srcRect and fillRect Change-Id: I114588862b5cfd2b2e4491424430cc139bdbaae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2d9f3c066a065d6aa98f1e594dcf8a091fec2bde) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136471 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136556
2022-07-02tdf#134210: Reimplement cropping from srcRect and fillRectMike Kaganski
This avoids the scaling after the crop, since scaling is performed anyway when applying BitmapMode_STRETCH. This improves resulting bitmap quality. Also consider the "crop to zero" case (when the sum of cropped parts is equal to 100%). In that case, just use an empty graphic as the fill bitmap. This makes the differences between srcRect and fillRect processing explicit, simplifies the code, avoids extra rounding inaccuracies, and takes care of the edge cases that were considered in commit 2859ec288f2c1323ea3123d82cb1684b349ff598 Author Miklos Vajna <vmiklos@collabora.com> Date Wed Jun 15 15:52:18 2022 +0200 oox: fix div by zero in lclCalculateCropPercentage() The change in SdImportTest2::testTdf134210 is because we now don't scale the cropped image. The previous value was an interpolated color, while the new value is the actual color of pixel [0, 41] of the original image. Change-Id: I24fa9928cff32bcaa6a7b3e34def14700fddd7ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135917 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5772cef244dbee5834efbc693bc714d89ae6301d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136038 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit c7a21bfed044154cac23328d37b46f34aeda0709) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136155
2022-07-01sd theme: add ODP import/export for shape fill color effectsMiklos Vajna
Map a themed color with effects to: <style:graphic-properties draw:fill-color="..." loext:fill-theme-color="..." loext:fill-color-lum-mod="..." loext:fill-color-lum-off="..."> (cherry picked from commit 0c13e4768c3c7937c2fd71675c86ff8a0ca3fe50) Change-Id: I18d8ddf8d6050ef468a8d67a9e797a576f682e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136730 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-01sd theme: add UI (sidebar) for shape fill colorMiklos Vajna
This requires extending .uno:FillColor with a new parameter, and then merging that parameter into the fill color item in sd/. The sidebar's color picker already generated these parameters. (cherry picked from commit f5db3b12ae1cd3bfe6ee5d260aec9532cc65f2dc) Conflicts: sd/qa/unit/uiimpress.cxx Change-Id: I83e3c4fc37b8d7bd34f0ef9c0cb96e164f7f0b99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136693 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-01sd theme: add ODP import/export for shape fill colorMiklos Vajna
Refer to the 12 pre-defined colors by name + don't write the attribute for the case when there is no theme. (cherry picked from commit 1868dea877b0c956ee34e92afad59920e66cad3f) Change-Id: I37c984b3371ec878a0d733977f5c937dce27c440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136676 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-30sd theme: add doc model for shape fill colorMiklos Vajna
In preparation of adding UNO API for this. (cherry picked from commit 8cc70d18c4507a746607fe5922b7c5e94b7f7579) Change-Id: Iecb2e44c43bca9e892fcb6242870ec12faa48be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136669 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-30sd theme: allow setting color effects in the sidebarMiklos Vajna
Which requires adding slot ids for the theme index / luminance modulation / luminance offset. Also merge them on the sd/ side, similar to what the character dialog does already. (cherry picked from commit 60d7796624f1c56eb036d3e73d7f8a8216cce2a4) Also squash in commit 03faef951a0dd4352a371ead89ca79040359234b (mergelibs: fix duplicate aSfxInt16Item_Impl, 2021-12-24). Change-Id: I0ae1b4d315b2bd53c17522dbccab160e6208716b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136625 Tested-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-29sd theme: add a "theme" palette to the color pickerMiklos Vajna
This implements listing the current theme colors (which depend on what is the master page of the current slide) in the color picker and also allows picking those colors. The colors are picked as-is for now, not yet setting the color theme index in the document model. (cherry picked from commit 4bbbd15fb8e8269a8bdfd188d3ca2a2a84c00922) Change-Id: I2553725c29c2a9f9de80f86b38d22a06bf9c0364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136607 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-29sd: add initial theme UI for master slidesMiklos Vajna
Click Sidebar -> properties -> slide -> master view, then launch the Slide -> Slide properties menu item, this adds a new Theme tab page there. This is just an initial UI, only the theme name can be edited as a start. (cherry picked from commit 64fcf278830a33114f0fa5884767f24edf32cb12) Change-Id: Ia2faa828c57a0e858881fb8640431f046b5739a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136529 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-27Remove not necessary container in Animation Panel in Impress SidebarSzymon Kłos
It was causing layouting issues in LOK. Change-Id: Ic7520f46efa764d2d6b50b021b44e0a5dd07d837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136343 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-06-27PPTX export: write the theme for the master pages from the doc modelMiklos Vajna
The instant benefit is that now the name of the theme and the color scheme are preserved, but this will also take changes done on the UI into account (which is not true for the grab-bag). (cherry picked from commit 5b253b2197e957fb5e42e3d0e233c10ac83afc10) Change-Id: I162eb7275d5a69d66db71fc5cd6e2e3ec94725bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136373 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-24tdf148321: convert OOXML inset values to text distance valuesTomaž Vajngerl
Inset values for top, bottom are calcualted differently in OOXML and need to be coverted on import to the text distance LO values, that place the text relative to the shape correctly. At export, the values can be converted back to the OOXML inset compatible values, but the values are not always converted back to the same values as the conversion is not bijective, however they do render the same. This also adds the test for the conversion when importing and checks that the exported values are expected. Change-Id: Ic64eec1a2a80ddad997f916da3e87dc30aaa12be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135463 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e216988657e20a1e52986f742ab60464697bcb41) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135504 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-25Resolves: tdf#149093 connect_value_change if we will query its valueCaolán McNamara
and not the text_change which is called before the value is parsed from the new text Change-Id: Ib6bd5647139f1b79f299beb42b704b465ddf535c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134368 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-13Resolves: tdf#148985 crash on searching for non-existing prefixCaolán McNamara
Change-Id: Ib89af12e75910adbd32abab5afceb9013dc51df2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134055 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-27tdf#53970 PPTX: fix import of linked media filesTünde Tóth
Linked media files were imported as images in documents created with Impress after PPTX export. Change-Id: If4920c2e40f45fff73eca4a5fa987d524177597e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132635 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 9564747d2fd5d2c859a359dd7fa6242c6859c0d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133410 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-27tdf#147586: Initialize mbBulletColorFollowText to falseXisco Fauli
Otherwise, once it's set to true, it's never reset Change-Id: Ie8a752da4162775f40c2f84f480e6a103eb55942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133422 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit a0bae88a9cd47185a71cbfd4c86bbd86ae44d30e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133404 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-27tdf#148654 stop playing sound with presentation endsCaolán McNamara
Change-Id: I74aa4cd966b6966f7826d241fcf9bb9d64955464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133394 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-25tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor propertiesXisco Fauli
Change-Id: Iebf482434cd393f55ae3e4690580b573624d78b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133219 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 1c924efe1f80207a5e104d755615b1eb9a91d418) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133282 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-25tdf#148620: sd: add UItestXisco Fauli
I tried to implement this test as a CppUnittest but '.uno:OutlineUp' and '.uno:OutlineDown' do nothing there Change-Id: Ie0d35abcc423999891d6a5dac07ec55d4ca8ee71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133176 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit e9dbbf0f184e4f742d5f0e1a6bc9adcd9d765739) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133283
2022-04-19tdf#109169 use custGeom for Octagon Bevel shapeRegina Henschel
The shapes 'Octagon Bevel', type col_60da8460, and 'Diamond Bevel', type col-502ad400, are LO specific preset shapes. They have neither a counterpart in MS binary nor in OOXML. So they need to be exported with custGeom. To force custGeom these shape types are moved from vDenylist to vAllowlist. These shapes were exported as prst='rect' before. Change-Id: I9619345812b6dba8f14ec2cc6a92ae808a56b595 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133069 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133113
2022-04-14tdf#147766 Export empty lines as line with noFillGülşah Köse
We have a case that 0 width line but has auto color. If that case exported there is no line over there, LO handles normally but MSO draws back borders as default. To prevent this we have to export them as line with noFill. testTableBorderLineStyle change reverts a workaround for 3faf005a367cbd28077403bf93810bbaf4805851 testBnc480256 Cell(1,0) still invisible. We are just checking this with another way. Change-Id: If5f6d2dbdba5c295d58307fcfe3b37629ede8a8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131532 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132886
2022-04-14Revert "Revert "tdf#135843 Implement inside horizontal vertical borders.""Gülşah Köse
This reverts commit ea5a3e0247b1230c1fe7e2cb0afc597e56d0b4c2. Change-Id: Ibd333c1e7b1530a2b6d9b8c5efbf4d9c822fa058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132885 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2022-04-06tdf#53970 PPTX: fix broken export of linked media filesTünde Tóth
Missing TargetMode="External" in the export of linked media files resulted corrupted PPTX. Change-Id: I76246db331d199810a5b413d44bec95283e88e47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132402 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit c2e8a96a8107a37901e475c65a8e61211fc3b132) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132383 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-06tdf#53970 PPTX: add unittestTünde Tóth
Change-Id: I1bcf8f79213245fdf135d6d3b2aafea6ed99f5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132296 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132320
2022-04-06tdf#53970 PPTX: fix export of embedded media filesTünde Tóth
Embedded media files lost in documents created with Impress after PPTX export. Change-Id: I453b58f9cfa6a33653e9216fb82b66970a9ec31b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132095 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132319
2022-03-30lok: use JsonWriter for annotations notificationSzymon Kłos
This will unify received objects in LOK. boost::property_tree used "string" for number values we expect them to be a "number" type. Change-Id: Ie90d7e2dd98bb371fc09878dcc6e96f4cdf73f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132054 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2022-03-30Fix btn image size inconsistencies on CustomAnimationsPanelPedro Pinto Silva
Animations btns (Add, Remove, Move Up, Move Down) - Images were being loaded from different locations - Images did not share the same size Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I33c033d50c802b7f2c9506b2c5a7b82967af7db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131551 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-03-30tdf#147978 export subpaths individually in custGeomRegina Henschel
...and implement export of all missing commands, use existing viewBox if suitable, use one EnhancedCustomShape2d move WriteCustomGeometryPoint to protected, make GetCustomGeometryPointValue local The fix solves tdf#100390 too. Without the fix the entire enhanced-path was exported as one element <a:path>. The command F was applied to the whole drawing but should affect only the subpath. The implementation is changed so that each subpath gets its own element <a:path> and command F acts only on its subpath. Support for export of handles and equations is still a long way off. Thus there is no reason to tread shapes with and without handles different. Shapes with handles had used method WritePolyPolygon, but that is not able to handle subpaths. So have desided to use method WriteCustomGeometry for all cases. To get shapes exported regardless of path commands I have added the export for the missing commands. I have removed the no longer used method WritePolyPolygon. The special treatment of shapes "moon" and "mso-spt89" (right up arrow) in export is no longer needed. Related code parts are removed. The unit test testFlipAndRotateCustomShape is adapted. In case the method WriteCustomGeometry fails, the enhanced-path is invalid. In that case an minimal custGeom is written in case of docx. Shapes whose drawing does not touch all edges of the snap rectangle were exported with wrong position and size of the drawing inside the snap rectangle. That is fixed by using an existing ViewBox for the OOXML path size. The old way of creating a path size from point coordinates is only used if the shape has no suitable ViewBox. The point values in unit test SdOOXMLExportTest2::testTdf111798 are adapted to path size 21600 x 21600 and traverse direction of the points is corrected. The resulting shape outline is still the same as before. The expected xml is updated for file tdf92001.odp in SdImportTest::testDocumentLayout. The resulting shape outline is the same, because the shape touches the edges of the snap rectangle. The case, that the shape outline does not touch a edge of the snap rectangle is tested in SdOOXMLExportTest3::testEnhancedPathViewBox. Still missing is the case, that ViewBox has other left,top than 0,0. In that case all coordinates would have to be shifted because the path size in OOXML has only width and height but not left,top. That will not be included in this patch. Change-Id: Ib1736d6a08371f4d98411d2769275f0580cd0030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132048 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-03-25tdf#96389 Use default tab stop value of MSO for pptx import.Gülşah Köse
Change-Id: Ib3dde68c672b44d8b60f121fb0e637942b5986b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131698 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132103
2022-03-09Resolves: tdf#146825 select under mouse on right clickCaolán McNamara
if something isn't already selected Change-Id: Ifa692cd71bb71ecb5c7af732deef510f2bac5fce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131130 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-03-09Revert "tdf#135843 Implement inside horizontal vertical borders."Xisco Fauli
This reverts commit 90f19b66d81b0a4958cacc40d2be0516f281d702. Reason for revert: See tdf#147766. Reverting in 7.3 branch only Change-Id: Ibda51d5cf4544383bdeb7896e1be31de759575a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131129 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-09tdf#38669 - Create the key event using a Unicode characterAndreas Heinisch
Instead of using a plain char, create a key event using a Unicode character, otherwise the key event creates texts including rectangles or wrong characters. Change-Id: I9ec0d64998927d54eb3ae90a192c3b28e235f56d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130721 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 9d25f86236885c40662bcd24517f231688361e8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131018 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-09tdf#147121 PPTX: fix regression of font size export of empty linesAttila Bakos (NISZ)
If the empty line has got direct formatted font size, don't forget to export it, unless the master setting is applied. Regression from commit b6b02e0b4c9d739836e1f61a886ea45b01e6696e "tdf#111903 tdf#137152 PPTX export: fix placeholders". Change-Id: If686e487bca9c198fd7c96860a21e4efe91381bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130005 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f29c14e8c36819296d0c66bb995201acf0a2647e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130675 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-09tdf#135843 Implement inside horizontal vertical borders.Gülşah Köse
wholeTbl as TableStylePart should be handled in different way. Before left border of the whole table was handling like all cells left border but it should be left border of the first column. insideV and and insideH properties are imported but never handled. I added the inside vertical and horizontal borders handling. Change-Id: I5aea5cbefc746db637eac6c1438fa70a7d741bc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128971 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 3faf005a367cbd28077403bf93810bbaf4805851) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130860
2022-03-09tdf#103800 PPTX shape import: fix regression of text colorTünde Tóth
defined by list styles. Properties in a:lstStyle of p:txBody should take precedence over the same properties defined in a:fontRef of style elements. Change-Id: I02cc886eb9eba94f49fe413a63bf7c46c9e3c127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130237 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130712 Tested-by: Jenkins
2022-02-21lok: Set pasted text rect pos to 0, 0Mert Tumer
Rect size change according to the length of the text however, this can make the text inserted in the negative coordinates and half of it becomes invisible. Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: Ibd4e6164c21088205efecf024c1888c55ac33f0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128603 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-14Added master slide handling in getPart* functions of SdXImpressDocumentPranam Lashkari
There was no option to get the master slide info from SdXImpressDocument Change-Id: Ic42a4c541c406a50ec26ec2113174ab25675a074 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129423 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129480 Tested-by: Jenkins
2022-02-14Set the original size in crop dialog to preferred DPI calc. sizeTomaž Vajngerl
If we have the document setting preferred image size set, then use that as the default DPI and recalcualte the logical image size using the DPI and the size in pixels. This is useful so we have the preferred DPI size as 100% in the crop dialog, so we can adjust the size in relation to that value. Change-Id: I50806f194032e228ee2cf56a39e5735a57358d46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127096 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-09 06:18:44 +0000