summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2015-07-21loplugin:unusedmethods sdNoel Grandin
Change-Id: I9b5399ace50db3259df2e619f28ae547a38e6c6d Reviewed-on: https://gerrit.libreoffice.org/17254 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20svtools: change these SvTreeListEntry functions to unique_ptrMichael Stahl
... parameters to make it clear that they take ownership. Change-Id: I572c5fa6268438a86d0a4fa1d2aef15382cb5607
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-18Convert SdTbxControl to the generic controllerMaxim Monastirsky
And remove the now unused stuff from SfxToolBoxControl. Change-Id: I8805ba96a5dc41076d9cb8d887759a578a33526d
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16Convert Alignment button to the generic controllerMaxim Monastirsky
Change-Id: I76ead43fa1cfe7ba1b62d2b13c4f4d7658a9f290
2015-07-16Convert FontWorkShapeTypeControl to the generic controllerMaxim Monastirsky
Change-Id: I7824136aa2780c4062a66f7a5284a342862f319a
2015-07-16coverity#1311945 Uncaught exceptionCaolán McNamara
Change-Id: I9c5738330a765747e749c4ec88bc6e87d8703c1c
2015-07-16loplugin:unusedmethods svx(part2)Noel Grandin
Change-Id: I161360e2f3113c4814fe1c2c095e602b2c93dcd7 Reviewed-on: https://gerrit.libreoffice.org/17120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:unusedmethods svxNoel Grandin
Change-Id: I92158457b3ffaaf7c84c6f4c87708d766c8c9f61 Reviewed-on: https://gerrit.libreoffice.org/17117 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: Id87047cb49eabe0c5ef3463f437e47f0eeeae990
2015-07-16loplugin:unusedmethods sfx2(part2)Noel Grandin
Change-Id: I82223b72ddb6a9df1ee52a300b083002234602dc Reviewed-on: https://gerrit.libreoffice.org/17075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15svx, sd, sw: GetPoolDefaultItem() can actually return nullptrMichael Stahl
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall. Change-Id: I409484c172fb5843270aee2425844076a008b4df
2015-07-15Convert filters button to the generic controllerMaxim Monastirsky
Change-Id: I6d3c76c0aafe0ad77b597a2cb8331e6f8219e2d2
2015-07-15Convert optimize table button to the generic controllerMaxim Monastirsky
Change-Id: I6b9089daaa2bb7d0dfc1072296fc51401e5fc88a
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13Introduce generic sub toolbar controllerMaxim Monastirsky
Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-13tdf#92668: Revert some implementation names, for backwards compatibilityStephan Bergmann
These implementation names of Calc, Draw, Impress, and Writer documents are the most likely to be checked by existing third-party code, so revert the corresponding parts of 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 "Fix various XServiceInfo implementations" (and instead add fixups in CppunitTest_serives). Change-Id: I1a760adbf4c89a1b4477d6e628abba8d2028ccfe
2015-07-13Fix IndentingPagesHdl type (and GetIndentingPagesHdl is unused)Stephan Bergmann
Change-Id: Ide5398040678a81e032e91e582b39d516e8c08a8
2015-07-13loplugin:implicitboolconversionStephan Bergmann
Change-Id: Id59a7c9402c59e91715f63a88eeed40d2ef9bd92
2015-07-13editeng: make Link<> usage typedNoel Grandin
Change-Id: Iec36c7e4f4fbc2ee2ee25d4d0c8488340ba7d8c4 Reviewed-on: https://gerrit.libreoffice.org/16968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13editeng, convert to typed Link<>Noel Grandin
and remove SvxBrushItem::SetDoneLink since the field it sets is unused.wq Change-Id: Ide95a295fa8004f1ddab5e560f01d36d36658a72 Reviewed-on: https://gerrit.libreoffice.org/16943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-12Missing dependency (and typo)Stephan Bergmann
Change-Id: Iecf1f652d56a129993f7ac66dce95e93d326e87b
2015-07-10vcl: remove boost/signal2/signal.hpp from headerMichael Stahl
The most relevant signal member function appears to be connect(), so let's create a wrapper function for that now, without the more esoteric ordering features for now. Move the signal member itself to a new pImpl. The benefits are worth it: preprocessor input reduced by 2.8GB, that's 9% of the total (excluding system headers which are not counted because they don't generate dependencies). Change-Id: I0aaeda51a5630a348bb12c81a83f67afbd508a14
2015-07-09SdrPaintView::AddWindowToPaintView: take a vcl::Window, tooMiklos Vajna
Change-Id: Iedb296732c0819a1d6cdc1c59b3f1718e2cd6d38
2015-07-09tdf#84909 Draw: Drawing toolbar exclusive to shapesYousuf Philips
Change-Id: I0ac457840a1d9df6d075bdd4e8205c19c5055204 Reviewed-on: https://gerrit.libreoffice.org/16875 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-07-08tdf#87702: Addition of Shadow sidebar tabRishabh Kumar
Change-Id: I75b368c0a8088926c765dbc46c6a4ce7c9d8b9f0 Reviewed-on: https://gerrit.libreoffice.org/16375 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-08test-case for crash loading a page name fieldCaolán McNamara
Change-Id: I5ef8fbf8b6711ca8950b5a0a210bc0c74ae1bd53
2015-07-08when skipping hidden pages to pdf adjust dest page indexesCaolán McNamara
when setting the page bookmarks. three slides, set second to hidden, export to pdf (without toggling on include hidden slides), in evince/acroread click on the "slide 3" title, and the viewers will not jump to that slide, seeing as the index is mis-calculated assuming 1-1 export-import pages Change-Id: I5784100c2444ca480984914e67c8b7e376a2ec47
2015-07-08fix crash on loading presentation with page name fieldCaolán McNamara
regression from commit 42b521f800a08b11432cf906ce1bdf9fcbfffdeb Date: Wed Apr 22 23:31:43 2015 +0200 tdf#88056: Implement ODF import/export of page title field Change-Id: I577a7c52836bbb13cc93910b4458aee5482ffc86
2015-07-08Fix typosAndrea Gelmini
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-08sd: test that we fixed the SdStyleSheet lifecycleMichael Stahl
Change-Id: Ia7e3c28eec02f23e4926cfb77b0afe7f8e79c711
2015-07-08sd: dispose SdStyleSheet properlyMichael Stahl
If it's disposed during document destruction it still retained pointers to SfxItemSet and SfxStyleSheetBasePool. Change-Id: I7b986b4fe5ca466f0fa86a99b744f5e2f85e08be
2015-07-08Fix MSVC buildStephan Bergmann
Change-Id: I784c0325c22708ab48217a9c06759d9fc1d7d5eb
2015-07-07tdf#91574 - fix slideshow presenter console lifecycle.Michael Meeks
Change-Id: I9748579fed8fd4dcf505bc79e48e40c1255bd22e
2015-07-08tdf#92017 Don't attempt to show commontaskbar in DrawMaxim Monastirsky
Regression from 1191ed8584f9fd63c39514dd2e3e71682913d4bc Change-Id: Ib631c7ac7d0c8688907555d0fb2e4343ce37d660
2015-07-07Added Test for tdf#80020 Impress style inheritanceVarun
Change-Id: I001dff1ba3774b811721709b0910a6fb711cca1f Reviewed-on: https://gerrit.libreoffice.org/16833 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-07Fix some misspellingsTor Lillqvist
Change-Id: Iff2303650e1dcfc56064907a28df1c4c452eac56
2015-07-06tdf79312: disable auto-close spelling dialog for sw, sdMarek Doležel
Change-Id: Ib7ea6624ac6b112779b0e64b08805538b8d6afff Reviewed-on: https://gerrit.libreoffice.org/16796 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-05SfxToolBoxControl::GetPopupWindowType seems unused, kill itMaxim Monastirsky
together with SfxPopupWindowType enum. Change-Id: Ia0b2388b34c96bb044f1bfcc7e89b33ac37d5f95 Reviewed-on: https://gerrit.libreoffice.org/16766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-07-04coverity#1309059 Uncaught exceptionCaolán McNamara
Change-Id: Id7c9b359697613547040c9694c03a427f89f35c3
2015-07-04Fix typosAndrea Gelmini
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-03fix deselect of textbox on slides with images in underlying masterCaolán McNamara
The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-29coverity#1308581 Uncaught exceptionCaolán McNamara
Change-Id: I925cc31890c8b1cd5ced0a619fbfde4be0a66dd4
2015-06-29coverity#1308553 Uncaught exceptionCaolán McNamara
Change-Id: I26d41fa888c2426ad8e77a170d9e9eb880ad32df
2015-06-29coverity#1308595 Uncaught exceptionCaolán McNamara
Change-Id: I2245925215e98077c9665803435d39e9a05de367
2015-06-29coverity#1308577 Uncaught exceptionCaolán McNamara
Change-Id: I6de407255be2bd1cc12edb5bbcaba5dd2501f60d
2015-06-29coverity#1308574 Uncaught exceptionCaolán McNamara
Change-Id: I416e3d443a43802bd8e093397945b056abe3bf85