summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2025-01-12tdf#164284 - Prevent page name change during page moveAndreas Heinisch
Change-Id: I341c5b9baf7cc39b8d543df89b4c46a59bf2a9e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180138 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2025-01-10ITEM: Refactor ItemTypeArmin Le Grand (Collabora)
ItemType is useful and faster than RTTI. Until now it was implemented by a 16-bit member in the base class, plus (potentially) all constructors having to hand a value in at item construction type (of type SfxItemType) to get that member set correctly. This works, but there is no reliable way to guarantee coverage, and there have already been cases with missing SfxItemType - these fallback to '0' and thus all Items with ItemType() == 0 are assumed equal and might be static_cast'ed to the wrong classes. Note that I identified *35* Items that had no correct ItemType set/implemented actually. It also uses 16-bit per incarnated Item at runtime. I thought and realized now a more systematic approach to do that with a pure virtual function at the Item itself. That can also be secured by a clang compiler plugin in the future to keep it working. It uses one virtual function per derived class, no longer space in incarnated Items. Also the constructors will get more simple again. But the main aspect is security - we cannot afford Items potentially being held as equal if they are not. Unfortunately C++ does not offer something like a 'strict pure virtual function' that would force to be overloaded in every derivation, but the used methotology and adding a clang test is reasonably safe. Have now done the cleanup of previous method. Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2025-01-10cool#10630 lok doc sign: allow setting the size of the Impress sign lineMiklos Vajna
Insert a signature line in LOK mode when PEM certs are configured, moving the just inserted shape works (even in the read-only PDF view), but you can't resize the shape. This is because moving goes via .uno:TransformDialog, while resizing uses .uno:MoveShapeHandle. Fix this similar to moving, by allowing the operation when the shape is a just inserted signature line. Allowing the command in read-only mode is meant to be safe, since the command implementation again checks if the resize is allowed, and there we allow this only for signature lines. Also expose the "is signature line" info on the LOK API, so it can show the graphic selection handles conditionally (only when resize will be allowed). Change-Id: Ie85aa1211564758dc24ff83b4241de78a8e69ffc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180065 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-10tdf#146947 - UI: Ability to show/reveal characters being typed intoBalazs Varga
password prompt to decrypt a document. Add toggle buttons for showing and hiding password characters in password textbox entries. Change-Id: Iba69d303431c2f9f2c987c67fcbd3f36b42dc057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179889 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2025-01-10cool#10630 lok doc sign: allow setting the pos of the Impress sign lineMiklos Vajna
Open a PDF in LOK mode, insert a signature line, try to drag the selected signature widget/shape, nothing happens. Given that the inserted shape has a default position at page center, you typically want to adjust that default position, but that requires adding a few exceptions, since PDFs are normally read-only. Desktop Impress gets around this since commit 5d296183072dc7cfe7a9985c38388b56f37d873c (sd signature line: allow move / resize of shape before signing, 2020-06-26), but LOK clients want to rather dispatch an UNO command (instead of handling this in the mouse event handler), so this requires additional work. A first problem is in isCommandAllowed() in desktop/ that explicitly rejects the UNO command for read-only documents: allow this when a signature widget is selected. A second problem is in SdrEditView::SetGeoAttrToMarked(), check for the signature widget there as well. Given that the implementation of .uno:TransformDialog already has a set of flags to prevent doing anything for read-only documents, it looks safe to allow the execution of the command itself. The size of the widget should be also possible to modify, that's not yet done here. Change-Id: I92a60717e98ac33f7a1eb9770cd0c7903f60759c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2025-01-09tdf#164183 Add hyperlink entries to context menu of tablesOliver Specht
Table objects in Draw/Impress now have Open/Edit/Copy/Remove hyperlink entries in context menu of text in table objects. Change-Id: Id3a5346eb3227871a06d2ea7fdb3ed38c07654c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177849 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2025-01-07tdf#162246 use main ViewShell when synching the annotationsTomaž Vajngerl
Current ViewShell is not always available, but we use the main ViewShell most of the time anyway in AnnotationManager, so use that when annotation synching. Use only the current ViewShell when opening the annotation pop-up window. Change-Id: Ibbc8e0859d0b91617577148e76e8293cb8015941 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179849 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-07tdf#164529 support annotation selection with edit (trigger pop-up)Tomaž Vajngerl
In some instances we want to select the annotation and edit them at the same time - trigger pop-up. This change adds back support for that. Also properly close the pop-ups when the view shell and window are destroyed. Change-Id: I17abeb39a7500001b148b8923eb9028d297a40a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179664 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-06lokit: add scale parameter to "renderNextSlideLayer"Henry Castro
When client side change the device pixel ratio. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I6356ff2a2e6513ac835b5f02a755173aafe01dc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178580 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179825 Tested-by: Jenkins
2025-01-06cool#10630 lok doc sign: fix Impress sign line when picking a certificateMiklos Vajna
Once .uno:InsertSignatureLine gets dispatched, a visual signature placeholder gets inserted, then a certificate picker shows up, but no certificates are visible in the list. The first problem is that .uno:InsertSignatureLine needs to take sign key/cert parameters in DrawViewShell::FuPermanent() (similar to .uno:Signature), so it can learn what certificate to use for signing. The second problem is that once that sign cert is attached to the view, the cert chooser for signature lines were not taking the sign cert from the view in DocumentDigitalSignatures::chooseCertificatesImpl() -- this needs routing the info about the current view from sd/ (where we still have that info) to xmlsecurity/. With this, a LOK client dispatching .uno:InsertSignatureLine with the 2 new parameters set can insert a signature line, it'll show up, but the subsequent .uno:Signature dispatch still needs fixing up. (Currently it wants to "save" the modified PDF, while it should just sign.) Change-Id: Ie536842152ef097aa6959c67916f2beb6d356e4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179819 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-06tdf#163852 ooxml: fix import of cropped vector graphic objectsBalazs Varga
We need to store the vector graphic objects size, so later we can calculate with that for the cropping. follow-up commit of: 1db193c6c744289139b1df2af0b8defcf974b238 (tdf#126084 import svg image from ooxml document that use svgBlip elem) Change-Id: Iffa98cc6a03063544bdf2b8ec3012415868e7c65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179626 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-01-03cid#1637439 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I0c0454093358d2f089a9d796aabbca8d0f0fc2a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179705 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-01-03tdf#162695 decrease the text margins to smallerTomaž Vajngerl
This decreases the text margins so the comment is overall smaller, which should make the situation better, but the main issue might be that the comments previously did not change size with zoom, but now do. This is probably nto so simple to change. Change-Id: I5c83b787f58324431e110ee095f61135b67588e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179662 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-01-03Broadcast the transition changeDarshan-upadhyay1110
- Now multiple user can see the simultaneous changes on transition sidebar Change-Id: Iae598d2cf106f3fdfb96ce409c31c69d196e8912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178298 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit ba0ec3b5f6f2154205ad72ce444a48b4dfb9af88) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179602 Tested-by: Jenkins
2025-01-03Drop unneeded forward declarations from include/Gabor Kelemen
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-03tdf#162920 make show/hide comments working againTomaž Vajngerl
use SdrObject::SetVisible to change the annotation's visibility status. Change-Id: I8002294351c64830ad294c43f6ee92425456ac0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179661 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-01-02slideshow: Render each animated paragraph in its own layerTomaž Vajngerl
We need to render each animated paragraph of a SdrTextObj in its own layer. This is not easy to do, so modify the PrimitiveContainer after rendering and turn off all the paragraphs that shouldn't be rendered. In addition also turn off rendering of the object itself (the fill and stroke). This can be done by setting the newly added setVisible method on the desired TextHierarchyParagraphPrimitive2D to false (and others to true), and turning the primitives to render the object to setVisible = false. If the primitive is not "visible" it will be skipped in the when rendering with VclPixelProcessor2D. Also changes the SlideshowLayerRenderer to take into account the rendering of paragraphs. We remember all the paragraphs for an text object that are animated, then we take this into account when we do render passes. We also need to take care of the paragraph hash, which needs to be set consistently for all animated paragraphs (so the layers can be identified correctly for animated paragraphs). Change-Id: Ice3b9e1f586c3fca81cf5da809fa88c4b9c87c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179599 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-28Resolves: tdf#164463 we need to pass a copy of the LayoutNameCaolán McNamara
a reference means it can get updated to rName during the function and the comparisons fail. a problem since: commit 235c230cd348600ce7385cc580c45a7be3572704 CommitDate: Tue Oct 22 09:17:02 2024 +0200 We don't need a virtual here Change-Id: I2f4e19ffb21b56f3554837d700977bde45140e42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179494 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-27tdf#158237: Use C++20 contains() instead of find() and end()Johann
Change-Id: I0528229042aa62d3d99e8dbaad68a86d41cf369a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178659 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-12-26no need to allocate AnnotationData for every SdrObjectNoel Grandin
SdrObject is performance sensitive, because we allocate a boatload of them when drawing charts. Avoiding an extra allocation that only a tiny handful of SdrObjects need is worthwhile. Change-Id: I4974bc1eacfe8abcce45ea659d9edaa8694135d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-26pdf: Rearrange general tab of PDF dialog, add PDF vers. selectionTomaž Vajngerl
Repurpuses PDF/A combobox to also add PDF 1.7 and PDF 2.0 as options, as those are exclusive (either you have classic PDF, or you select PDF/A which is a special version of some PDF version. No need to have a check box for PDF/A anymore, so this was removed. - Moved the version selection to top - Added "Forms" frame, which for all the form options. - Moved Tagged PDF into "Structure" frame. - Reworded some text (extended tips, tooltips) for PDF versions Change-Id: I731222ee02afea6a49e4213d18f27d1beae9da10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178270 Tested-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178768 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-24tdf#163144 Undo crash when duplicationg a page with a new annotationTomaž Vajngerl
Check if the annotation pop-up is set and only if it is, try to close it. Also added a test for this. Change-Id: Id2db041f2c0e917304377a747b1bb31bda0c6f5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174287 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-21Simplify abstract dialog impls using vcl::AbstractDialogImpl* in sdMike Kaganski
Change-Id: I93f40aef003aa52b4eef173f8f481c99fe4c0489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178985 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-21tdf#164171 Improve tooltip for Open DocumentsBogdan Buzea
Change-Id: Icee61b29fa1f233c6c28e47c57343820a1f723c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178953 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-12-20cool#10630 lok doc sign: fix Impress sign line when creating directlyMiklos Vajna
Once .uno:InsertSignatureLine gets dispatched, FuConstructRectangle gets activated, the signature line (a graphic shape) gets inserted, but then FuConstructRectangle is not deactivated in the "create directly" case, so next clicks keep inserting new signature lines, while the expectation is that "create directly" inserts one shape and selects it. The "create directly" mode is the default for LOK, but you can trigger it on the desktop with the KeyModifier=8192 (KEY_MOD1, i.e. Ctrl) UNO command parameter, too. The normal mode would send the mouse button down/up events to FuConstructRectangle and sd::FuConstructRectangle::MouseButtonUp() would select the shape after a drag to determine the position/size. The "create directly" mode will insert instantly, so sd::FuConstructRectangle::MouseButtonUp() is not called, so the shape is not selected, so the shape insert mode is not deactivated. Fix this by selecting the object for the create direct mode the same say as FuConstructRectangle would do, at the place where e.g. text editing is started for Impress textboxes. Do this for rectangle shapes for now, but later other shapes might want to do the same: e.g. curve insert doesn't have this problem, but it seems line insert has the same problem -- that's not changed here. Change-Id: I3ae85a07010f95b80a862e0cc631994113613eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178865 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-19sd: Dereference after null checkXisco Fauli
Since commit 37edf62981acf8b73a70d645755e8cdbc9bbcd3f Author: Gökay Şatır <gokaysatir@collabora.com> Date: Thu Oct 3 17:31:09 2024 +0300 cool#7406: Refactor Impress->getPartInfo & use JsonWriter. Change-Id: Ie84b0a5a04c298348368a4781c0afbd97f748f90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178845 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-19crash see on SdXImpressDocument::getPartInfo for missing pageCaolán McNamara
possibly after uno.HideSlide #0 0x00007e697b8c0b97 in SdPage::GetPageInfo (this=this@entry=0x0, jsonWriter=...) at sd/source/core/sdpage.cxx:1751 #1 0x00007e697bbda0ab in SdXImpressDocument::getPartInfo (this=<optimized out>, nPart=<optimized out>) at sd/source/ui/unoidl/unomodel.cxx:3692 #2 0x00007e698ae7e078 in doc_getPartInfo (pThis=0x121017c0, nPart=9) at desktop/source/lib/init.cxx:4176 #3 0x000000000059bcf4 in LOKitHelper::getPartData (part=9, loKitDocument=0x121017c0) at kit/KitHelper.hpp:47 #4 LOKitHelper::fetchPartsData (loKitDocument=0x121017c0, resultInfo=std::unordered_map with 6 elements = {...}, partsCount=84, mode=@0x7ffec727bd58: 1) at kit/KitHelper.hpp:91 #5 0x000000000059c6a3 in LOKitHelper::documentStatus (loKitDocument=0x121017c0) at kit/KitHelper.hpp:164 #6 0x000000000057fb7a in ChildSession::selectClientPart (this=0x556fe60, tokens=...) at kit/ChildSession.cpp:2964 #7 0x000000000058a88f in ChildSession::_handleInput (this=<optimized out>, buffer=<optimized out>, length=<optimized out>) at kit/ChildSession.cpp:495 #8 0x000000000061c63f in Session::handleMessage (this=0x556fe60, data=std::vector of length 29, capacity 29 = {...}) Change-Id: Ib4e532b31cdc6a69f9e54317699f426c12de35d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177781 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 03156b7ccb5129202978c2e636c641a2208a61aa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-19tdf#155211 - Change line style from solid to dashedAndreas Heinisch
Change line style from solid to dashed during GDI meta file import, if there exist dashed line properties. Change-Id: Ia5b88bd8513929969aed67b17494541da83b29d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178708 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-12-18tdf#135320 sd fix soft edges are not shown on text framesBalazs Varga
Allow soft edge and glow effect on text frames objects. Change-Id: If08da1cfeae515aa50ded5689b7fe3a963a98cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178656 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-12-18tdf#163620 [API CHANGE] Add UI for libreoffice themesSahil Gautam
Instead of Color, we have Light and Dark in the registry. So each theme extension will specify dark and light color values for each "customizable element" like DocColor etc. Under appearance we have three radio buttons - light/dark/system. If system is selected then light/dark colors are switched based on the system's theme. if explicitly light/dark is selected - that color is used from the registry. ColorConfigValue now has three entries nColor, nLightColor, nDarkColor. nColor is used as a cache for the color being used at the moment. This is to avoid otherwise expensive function calls + hundreds of modifications in the codebase just to change nColor. nColor is cached either when the theme is loaded or when changes are committed in `ColorConfig_Impl::ImplCommit()`. Now, if Automatic theme is selected then themes is disabled and the application uses the system colors. If some other scheme is selected like "CustomTheme" etc, then LibreOffice themes/UI color customization is enabled and the theme colors are used. Instead of a scroll window, now we have a combobox for the registry entries and a single color dropdown to select the color value. This color dropdown is for convinience in case the user wants to change some specific color that's bothering him. For themeing, theme extensions should be used. API CHANGE + remove Color in favour of Light and Dark + AppBackground has additional two - BackgroundType and Bitmap + remove officecfg::Office::Common::Misc::Appearnce in favor of officecfg::Office::Common::Appearance::ApplicationAppearance + move LibreofficeTheme under officecfg::Office::Common::Appearance UI + it looks like https://i.imgur.com/UMxjfuC.png which is a little different from how the [mockup] on the ticket describes it, and that's because of lack of time due to upcomming feature freeze. + system/light/dark allow the user to switch between light/dark modes based on either the system theme (system) or by manually specifying light/dark. + ui themeing and color customization is disabled when automatic theme is selected, and enabled otherwise. [mockup]: https://bug-attachments.documentfoundation.org/attachment.cgi?id=197469 Change-Id: I1a7f70dfe44b81f863814f87e8d46e146c0e3d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174835 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
2024-12-17sd: Dereference after null checkXisco Fauli
C: /cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sd/source/ui/view/drviewsg.cxx(247): error C2220: the following warning is treated as an error C: \cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sd\source\ui\view\drviewsg.cxx(130) : warning C6011: Dereferencing NULL pointer 'Current()'. : Lines: 106, 109, 110, 112, c:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\comphelper\configuration.hxx:51, c:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sd\source\ui\view\drviewsg.cxx:113, 116, 123, 125, 127, 129, 130 Since commit 9d9c24328cef503f999bf3a5475743e87a3aff5a Author: Gökay Şatır <gokaysatir@collabora.com> Date: Tue Sep 24 13:30:22 2024 +0300 cool#7406 Inform lokit side about the grid state. Change-Id: Ic06e765386330cf344380ddf61757298210f921e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178655 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-17cool#7406: Refactor Impress->getPartInfo & use JsonWriter.Gökay Şatır
We need to add more information to getPartInfo function for getting grid properties. While doing this, i refactored current function to use JsonWriter. We also need to inform client side when a page border, size or margin change happens. This commit also adds a shared function for these events. Change-Id: I9dad094545c7cf0e072a7831f300dd0401ebf4a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178639 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-16tdf#66791 sw: Treat weak punctuation as Asian in Asian paragraphsJonathan Clark
This change modifies script detection to treat certain weak punctuation marks, particularly left- and right- quotation marks, as Asian script in paragraphs containing Chinese and Japanese characters, but no Complex characters. This change improves our script detection compatibility with other programs. As part of this change, duplicated script detection code has been extracted from Writer and Edit Engine, and consolidated. Change-Id: Ib2880f2e832aaac4c0093971daa88223c7232d63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178608 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-12-16cool#7406 Inform lokit side about the grid state.Gökay Şatır
When grid in impress or draw is turned on, we need to inform libreofficekit. So it can show relevant UI and act accordingly. Same goes for griduse command. Also add a test for the new state callbacks. Change-Id: Ia5737ca0088e434f826eb7c40b0bec59049432af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178578 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-13tdf#150789 - FILEOPEN PPTX: fix text in SmartArt vertically offBalazs Varga
Calculate correctly the textbox area of upArrowCallout and downArrowCallout shapes in group shapes. In grouped list text area does not cover the whole shape but just a part of it at the top. In case of upArrowCallout and downArrowCallout the arrow size of the shape is not included in the textbox area of the full shape. Change-Id: If732305747c20da55bbd2896522c0b9c05cc4b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178343 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-12-13tdf#163858 sd: Support autorepeating slides in windowed modeAriel Darshan
Change-Id: I6b1d78f234699062d6b846989e4d92bfa4b3d85d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176342 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-13cid#1636690 Dereference after null checkCaolán McNamara
Change-Id: Ie32ffbe6148c2e12aa99068790fa7a1a1c0f27e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178399 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-12lok: getSlideShowInfo: return the slide namesHubert Figuière
This allow finding slides by bookmark Change-Id: Ia951aebdd04b67f4138138f7c0e1404078cc23ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178345 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-12sd: keep a non-owning pointer to the OverridingShellSarper Akdemir
... instead of keeping an owning shared_ptr To fix the ubsan build error <https://ci.libreoffice.org/job/lo_ubsan/3385/> Which appears to be caused from EventMultiplexer::CallListeners triggering a NotesPanelView to be deleted, and then notifying that just-deleted NotesPanelView, see <https://gerrit.libreoffice.org/c/core/+/177686/2#message-857c0180ae3e6572534d3bcd40f32000d434cc3d> Change-Id: I05e67dfeab093e7549e9b2ec4caf4a95dc743627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-12-11tdf#161541 sd: fix the orientation of handouts on the printed pageTibor Nagy
Change-Id: I1896674ab317fcbcfe2ebbe9ea21dcc36c203328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178274 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-12-11lok: impress: Fix variable nameHubert Figuière
Was missed in https://gerrit.libreoffice.org/c/core/+/172847 Change-Id: I8e5ece6be2253106df6b6e535afa5efaa86850a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178291 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-10[API CHANGE] remove LOKSlideRenderer implementationTomaž Vajngerl
SlideshowLayerRenderer has replaced it so it's not used anymore and we don't need it anymore to compare the output too. Change-Id: Ic1277d650324937722ec69a91218f23f147d0bde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178199 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-09tdf#164129 sd: fix resizing of the notes text contentTibor Nagy
The notes text content was not resized when we changed the paper size in the print dialog. Change-Id: I2f610579e2ac84c298c4105a5c1235fbe62ad627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178146 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-12-09Related: tdf#88226 if the paragraphs of notes contain upper and lowerTibor Nagy
paragraph spacing, add this values to the notes text size. Change-Id: I277ecad30244a418d5038e2a8668cf28302f10ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177856 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-12-09tdf#158512: PPTX import: reset useBgFill flag when it is unusedVasily Melenchuk
Even if current fill is not "use background" we should reset useBgFill explicitly, since this value could be set from master slide and was nested in current shape. It is somewhat confusing to have fillStyle as none and using slide background at the same time. So better to clean it explicitly. Change-Id: I0d817dc295785be7a6cb8f884d5023d316cd2ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165994 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-12-09lok: slideshow rework: check that requested slide is the expected oneMarco Cecchetti
Change-Id: I225dfea9981d43fb90888f5025792e9d24d9a789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178129 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-09svx: prefix members of SdrDragResizeMiklos Vajna
See tdf#94879 for motivation. Change-Id: I90f3a09e5dee630ead50954b1d8c5848b9319949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178123 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-08tdf#119745: Fix touchpad scrolling for Slides and Pages panes.Marc Mondesir
Use fractional lines scrolled to calculate distance to scroll view, instead of jumping forward or backward a full page every call based on sign. Also fixes existing bugs: horizontal pane can scroll too far to right; and snapping pane from vertical to horizontal can break scrolling if view partially scrolled. Change-Id: I0ead4710a296aac26f1cf1a0fc48e6ea403271a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177836 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-12-07cid#1636576 Dereference null return valueCaolán McNamara
since: commit 43e511e642a2ce7026b30ea5c212940ff3eb522e CommitDate: Wed Dec 4 10:17:24 2024 +0100 tdf#88226 sd: fix cutting off the overflow text on the notes print page Change-Id: I0a982a0a4213e220ec1bbd166e08bf14191eed0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178032 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-07cid#1636582 Negative loop boundCaolán McNamara
Change-Id: Ib91ee62814837765f89f65a1204021e9d9610e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-13 10:19:52 +0000