summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-07-19tdf#126334 Fix number format array in init controls.Gülşah Köse
Customization changings need only selected number format object but Position changings on bullet need all existing number format array. After merge the customization and position keeping all numbering format objects (10 item) make sense. Change-Id: Iade1e154243deaed43b9d243f2ebd0c5298b42a4 Reviewed-on: https://gerrit.libreoffice.org/75784 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-19cid#1448229 Division or modulo by zeroCaolán McNamara
Change-Id: I8d1d7415c82c7d48f8d4bdf7b86e397fce01c015 Reviewed-on: https://gerrit.libreoffice.org/75908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448319 Use after freeCaolán McNamara
Change-Id: I45a4ea5c21707606b8853bb775a7d9eec595b88c Reviewed-on: https://gerrit.libreoffice.org/75912 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19NB fix context- behaviour in draw and impressandreas kainz
Change-Id: I943466895a51463be59dacb3686926d29562a371 Reviewed-on: https://gerrit.libreoffice.org/75931 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-19cid#1448436 Unchecked return valueCaolán McNamara
Change-Id: I971587c6340afc83ac3a28b148650a8f20120164 Reviewed-on: https://gerrit.libreoffice.org/75890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448395 Uncaught exceptionCaolán McNamara
Change-Id: I7478aa8a971e834efee0effd998c68cb85368892 Reviewed-on: https://gerrit.libreoffice.org/75885 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448356 Uncaught exceptionCaolán McNamara
Change-Id: Iaa48face892514b5af769cdb3120f001940cf0ea Reviewed-on: https://gerrit.libreoffice.org/75882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448347 Unchecked return valueCaolán McNamara
Change-Id: I18a43e9a033a7326563f37caa0292a2c34752be0 Reviewed-on: https://gerrit.libreoffice.org/75880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1311945 Uncaught exceptionCaolán McNamara
Change-Id: I1f3c2d3e644c4cbb4e38740c05a623864219313e Reviewed-on: https://gerrit.libreoffice.org/75843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1424266 Uncaught exceptionCaolán McNamara
Change-Id: I5e7373dbaef52184327596d029ab63baf57764d9 Reviewed-on: https://gerrit.libreoffice.org/75844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448227 Uncaught exceptionCaolán McNamara
Change-Id: I6149b087217b9b34ecce984536aae52b8ee9d430 Reviewed-on: https://gerrit.libreoffice.org/75846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448325 Uncaught exceptionCaolán McNamara
Change-Id: I5bb61909d5d252de7465a29a3c8e49b7b1997ba3 Reviewed-on: https://gerrit.libreoffice.org/75847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448534 Use after freeCaolán McNamara
Change-Id: Ibef20405d1ecf00b71ca12e43902ccd65c873ed2 Reviewed-on: https://gerrit.libreoffice.org/75815 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448529 Use after freeCaolán McNamara
Change-Id: I5bc3a85b7319c52e3b5d1a7e7dffcbe23cdf653c Reviewed-on: https://gerrit.libreoffice.org/75814 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1451632 Dereference after null checkCaolán McNamara
Change-Id: I5ee95a9341896b8462235ece933fa70773247c92 Reviewed-on: https://gerrit.libreoffice.org/75802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17LOK: support for ordering/moving partsAshod Nakashian
Currently reordering of slides is only supported for presentations, although it is provisioned for spreadsheets as well. Change-Id: I6c35066d6a5ef7586d34a8e8b89db69a20b86572 Reviewed-on: https://gerrit.libreoffice.org/69612 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73495 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-17loplugin:unusedfieldsNoel Grandin
Change-Id: I38abc54776cc605c76faf94e9e8c0f4fa75b8788 Reviewed-on: https://gerrit.libreoffice.org/75740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16cid#1448514 Dereference null return valueCaolán McNamara
Change-Id: Idf32f7a51a57756ac620249e5a95c9e1c8d2f9d2 Reviewed-on: https://gerrit.libreoffice.org/75716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448419 Resource leakCaolán McNamara
Change-Id: I1ca12ee7097ba2f4e644d3ff91cff1a49af49cbe Reviewed-on: https://gerrit.libreoffice.org/75713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16Missing test dependencyStephan Bergmann
(a macOS build of mine happened to fail in CppunitTest_sd_uimpress with "no suitable windowing system found, exiting" when instdir/LibreOffice.app/Contents/Frameworks/libvclplug_osxlo.dylib had not been built yet) Change-Id: Ic699648f6b0dffd9ed01cf97cf624efe2ef8be30 Reviewed-on: https://gerrit.libreoffice.org/75679 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16LOK: getPartInfo now returns list of selected partsAshod Nakashian
For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73494 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-16Follow up patch tdf#126067 Correct indentation.Gülşah Köse
Change-Id: Idfe608afb8b02f8b9f56b9da76e3f2009617b183 Reviewed-on: https://gerrit.libreoffice.org/75676 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-16tdf#42949 Fix IWYU warnings in include/Gabor Kelemen
Recheck directories in include/ between vcl and svx in the module hierarchy Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: Ieab6083ee2aae33baf32d05943b07ad2de6f9d7f Reviewed-on: https://gerrit.libreoffice.org/75170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16tdf#126067 Fix slide scope feature.Gülşah Köse
Change-Id: I6e2450572b9c6a30526a8a2a91a6e0bf89103475 Reviewed-on: https://gerrit.libreoffice.org/75669 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-15cid#1448231 Explicit null dereferencedCaolán McNamara
Change-Id: I4cd6cb84b08b7979d537b9590a45ce27a8423d6c Reviewed-on: https://gerrit.libreoffice.org/75631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15Deduplicate EditHyperlink commandSamuel Mehrbrodt
Change-Id: I23f0c276c5c1229aeb4ea468c6b858e36c120bd9 Reviewed-on: https://gerrit.libreoffice.org/75480 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-15tdf#112543 Add Edit/Remove hyperlink to text boxes/shapes in WriterSamuel Mehrbrodt
Change-Id: I9052387cf39135c2324b9db03662dc0365323400 Reviewed-on: https://gerrit.libreoffice.org/75479 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-12Move remove url code to editengSamuel Mehrbrodt
so that the code can be reused by sc and sw Change-Id: I0d3c778c7bb7847fcf690d0e76994afdd0645285 Reviewed-on: https://gerrit.libreoffice.org/75477 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11Deduplicate URL tooltip creationSamuel Mehrbrodt
Change-Id: I94eb40ff4d727029ad764a381df300beee90481c Reviewed-on: https://gerrit.libreoffice.org/75409 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11tdf#98575 Go into text edit mode when clicking on a hyperlinkSamuel Mehrbrodt
without opening the hyperlink Change-Id: I210d28284c9ce283a82edf60e7d39738f4595182 Reviewed-on: https://gerrit.libreoffice.org/75364 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11tdf#126234 up relative bullet size limit to 400%nd101
The legitimate value for MS Office document bullet relative size is between 0% and 400% But for ODF the value is normally between 0% and 250%. Per ODF 1.2 spec "19.761 text:bullet-relative-size" there is no limit placed on the relative size of the bullet. This change is to make the upper limit match MS Office to address the import issue. UI also changed to reflect the raise Change-Id: Ic4bbef47e86a04b9a6f9f6188326c8b66e034807 Reviewed-on: https://gerrit.libreoffice.org/75189 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-10slide-sorter: multiple selectionAshod Nakashian
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab Reviewed-on: https://gerrit.libreoffice.org/69610 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73493 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-10SmartArt: hide connectors in org chart as they don't work correctlyGrzegorz Araminowicz
Fixing them would require a lot of effort. Changes are needed in data part (connector shapes are not created in group shapes associated with data shapes) and in layout part - routing them differently in all 4 or 5 hierBranch styles, with assistants and without. Change-Id: I48840454b0272dff9ba42db2eb5d65945642459a Reviewed-on: https://gerrit.libreoffice.org/75339 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-10tdf#42949 Fix IWYU warnings in sd/*/hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: I4b1b4fe59c572cdd969d26aac13a276d5aa6844c Reviewed-on: https://gerrit.libreoffice.org/74981 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-09SmartArt: improve organization chart layoutGrzegorz Araminowicz
layout shapes in two steps: * first calculate vertical child shapes count for every shape (taking into accout hierBranch alg variable) * then actual layout using that count to calculate size for subtrees Change-Id: I2e5ca34ed3383aa9502c52511cc1fb2bee215572 Reviewed-on: https://gerrit.libreoffice.org/75195 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-09tdf#111707 Move duplicated code into shared methodSamuel Mehrbrodt
Change-Id: I4b61ed876410662b5f85be0032b2fc8def456dd9 Reviewed-on: https://gerrit.libreoffice.org/75286 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-09tdf#111707 Only remove the selected hyperlinkSamuel Mehrbrodt
Not all hyperlinks in current text box Change-Id: Ia4ceeaeec776244e81b2c8fc401f7582a17d372f Reviewed-on: https://gerrit.libreoffice.org/75229 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-09NB tabbed_compact sd apps fix wrong DrawText commandandreas kainz
Change-Id: Icdad248e46172ba161de86bfb3f4edae4ef43139 Reviewed-on: https://gerrit.libreoffice.org/75251 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-09NB add contextual single support for impressandreas kainz
Change-Id: Ie51bfcc81843ef21d83042dbaf409e6dab99b3c2 Reviewed-on: https://gerrit.libreoffice.org/75247 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-08use BitmapEx in PreviewRenderer::ScaleBitmapNoel Grandin
Change-Id: I9f94c9cceb3c1828b9b1d21ac064dae2c12565c8 Reviewed-on: https://gerrit.libreoffice.org/75214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08Related tdf#98575 Allow editing link even when URL field is not selectedSamuel Mehrbrodt
When the cursor is directly before or behind the URL field, just extend the selection so that the link is editable. Change-Id: I80afe40a1c40e2a02ec6adb18dbdb27b6e39c7d1 Reviewed-on: https://gerrit.libreoffice.org/75190 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-05Related tdf#98575 Add "Edit Hyperlink" to context menu in sdSamuel Mehrbrodt
Change-Id: I121373fae5122e779614a53ac73b4b9d058908d2 Reviewed-on: https://gerrit.libreoffice.org/75126 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-05SmartArt: remove calculateHierChildOffsetScale() from org chart algorithmGrzegorz Araminowicz
Its purpose was to center subtree if sibling parent has no children. It was not working correctly for complex charts causing shapes to overlap. Without it chart is still readable (just sometimes not centered). Remove it for now until more universal solution is found. Change-Id: I397bd4264d6ce0fadf5c5fa1352f22e72d5d163a Reviewed-on: https://gerrit.libreoffice.org/75092 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-07-05Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233rizmut
- Add Impress transition, 3D related icons - Add many 32 px size for Calc and Draw specific icons - Fix blurred icons - Add more missing menu items Change-Id: I915e31aee51e84c88dd99e1fa3f6d5a4c7ca50d0 Reviewed-on: https://gerrit.libreoffice.org/75106 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-07-04tdf#126197: EndTextEdit on all views before delete/cut shapeXisco Fauli
Change-Id: I3da93e5c72ee6f6f99120758e870d654e01a0ec7 Reviewed-on: https://gerrit.libreoffice.org/75001 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-04remove some unneede vcl/bitmap.hxx includesNoel Grandin
Change-Id: Ibdc79538276992193e61f6dc16ddd3fd1ab80b82 Reviewed-on: https://gerrit.libreoffice.org/75069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-04NB impress groupedbar and draw contextual single context-DrawText missingandreas kainz
Change-Id: I36e686283b57342408754ae96aa39d505668de07 Reviewed-on: https://gerrit.libreoffice.org/75062 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-03tdf#126180: EndTextEdit on all views before delete/cut slideXisco Fauli
This also reworks the fixes tdf#125824 and tdf#111522 to use EndTextEdit instead of blocking the undoing Change-Id: I73c2289a9d950465f020f684e9e736148380f5c5 Reviewed-on: https://gerrit.libreoffice.org/74989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-03tdf#42949 Fix IWYU warnings in include/svx/x*Gabor Kelemen
New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5b91a82d25601041b73444f602d033ef62484ba8 Reviewed-on: https://gerrit.libreoffice.org/74563 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-02NB update UI'sandreas kainz
Change-Id: Iece18df3c1ed2e066e6820e67755d52a30d63b27 Reviewed-on: https://gerrit.libreoffice.org/74990 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>