summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-05-11sd: replace boost::mem_fn with C++11 lambdaMichael Stahl
Change-Id: I5502730d042d385033f34ae888835637376ffb44 Reviewed-on: https://gerrit.libreoffice.org/24887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-11Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I34629f1f4c77aaf12bb9b668b24f98e8d3e8eaef
2016-05-11sd: remove pointless micro-optimizationMichael Stahl
Change-Id: Ib5c9e79d21969922feeed5cd1908f238608401e4
2016-05-11Resolves: tdf#92951 make PaneDockingWindow dockable againCaolán McNamara
Change-Id: Ia7a59849777247c2beaabd3c9a4938317a7ea2d0
2016-05-11tdf#89466: SvxFillTypeBox::Selected needs to be calledKatarina Behrens
when something is selected in order to flag that its an acceptable value and should not be reset to the previous value on losing focus Have to use SvxFillTypeBox instead of base ListBox to achieve that and so SvxFillTypeBox has to then be SVX_DLLPUBLIC Change-Id: I92f6264cc9cc0a9c7c8c0b5c3c73517fe456d13e Reviewed-on: https://gerrit.libreoffice.org/24858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-10Fix typosAndrea Gelmini
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I1f147c4a0ebc6895435722d8385131917f88ecb5
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10clang-tidy modernize-loop-convert scaddins to sdextNoel Grandin
Change-Id: I63ccc56df1a1de8bc443abb95e520246c457912f Reviewed-on: https://gerrit.libreoffice.org/24798 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09tdf#89466: Handle no background and bitmap case also in sidebarKatarina Behrens
Change-Id: I9e36a7963cb3065b81c1ba25f983d722d5f30ed8 Reviewed-on: https://gerrit.libreoffice.org/24802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-09use existing functionDavid Tardon
Change-Id: I130e701902a22016cd06649e1c9ba3d932d64e1c
2016-05-08Remove useless typedef DescriptorContainerJulien Nabet
Change-Id: Ie5463de6946d1682e28ff8359c3274980af8a1da Reviewed-on: https://gerrit.libreoffice.org/24736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-08No need to cast the same thing twiceMaxim Monastirsky
Change-Id: I47e2ac07f811a2ce4bed7f732c37aedab16bc00d
2016-05-07tdf#89466: Switching between different fill types work nowKatarina Behrens
... somehow ... Change-Id: I6a9ccc60f35a2be092a60c01db04018b736a18b7 Reviewed-on: https://gerrit.libreoffice.org/24706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-06sd: replace boost::enable_shared_from_this with std::enable...Michael Stahl
Change-Id: Ia4f31a03b20bb0abe7e0ff8e423a0b046a828607
2016-05-06coverity#1359233 Unchecked dynamic_castCaolán McNamara
Change-Id: Icafdf8c187fc69866281e90bbb575e99c0f19024
2016-05-06tdf#89466: Getting/setting page background works nowKatarina Behrens
Change-Id: I60194adfdca2e4bd9d7d44cc1d43ec14f0774fc3 Reviewed-on: https://gerrit.libreoffice.org/24658 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-06coverity#1359231 Unchecked dynamic_castCaolán McNamara
and coverity#1359232 Unchecked dynamic_cast Change-Id: I416e9156c6f3b1a933d6d664a992420067b68d1b
2016-05-06tdf#89466: Don't reset page background on size/orientation changeKatarina Behrens
Change-Id: I5fbf44235784f285d42d2e83466d2f0d70fd0f5d Reviewed-on: https://gerrit.libreoffice.org/24659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-06tdf#89466: Getting/setting page orientation works nowKatarina Behrens
Change-Id: I1fd2f8cf3985079e9f8d752344646bd3a5769725 Reviewed-on: https://gerrit.libreoffice.org/24657 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-06Make this a bit sanerTor Lillqvist
Not sure about usefulness, though. Change-Id: Ia1ef46a7ab7f599e90fe91e77707b20786573182
2016-05-06tdf#91794 OSL_DEBUG_LEVEL > 1 & DBG macro removed (impress/draw)Rohan Kumar
I replaced the DGB(x) macro from the code with the SAL_INFO(...) statements wherever i found necessary. I removed the DBG function definitions also. Change-Id: I6eb21fa993fe2bfdfbc678e65d237321f12b98dc Reviewed-on: https://gerrit.libreoffice.org/22317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-05-05only set cur. page once when removing mult. pagesDavid Tardon
Change-Id: Id9da135a91d9591eed04fb25d2891169c45ecaaf
2016-05-05Don't crash when switching to slide sorterMaxim Monastirsky
... and also check dynamic_cast's. The panel still doesn't work in slide sorter mode, but at least won't crash. Change-Id: I878577b282ca5637ffeacdb804ce44c3d57a2a21
2016-05-05Fix widget nameMaxim Monastirsky
warn:vcl.layout:16932:1:vcl/source/window/builder.cxx:491: Requested top level widget "SlideBackground" not found in modules/simpress/ui/sidebarslidebackground.ui Change-Id: I614fe73006f8c148eed6c98bc1875b4303f27879
2016-05-05loplugin:nullptrNoel Grandin
Change-Id: Iacfe15cdb3c827892ef3db049a0405337faadc0d
2016-05-05loplugin:simplifyboolNoel Grandin
Change-Id: I994ff5ad74dcc68eef31c3779b5711160cc5ac5a
2016-05-05-Werror,-Winconsistent-missing-overrideNoel Grandin
Change-Id: I14a8df27dc5bf8f16f5955d45f21f5f4079d79e0
2016-05-05tdf#93124: Fix incorrect text fit in imported PPT - take twoMike Kaganski
This patch just fixes incorrect decision when the block alignment must be applied. Also, unit test is included. Change-Id: I458184778c5e9e115d1a4eac749ecb6991b227a8 Reviewed-on: https://gerrit.libreoffice.org/24648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-04tdf#89466: Getting/setting page size works nowKatarina Behrens
Change-Id: Idd421c45b0e3e82a792672849ef34189398bddb5 Reviewed-on: https://gerrit.libreoffice.org/24451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04tdf#89466: Give those slots a separate GetState methodKatarina Behrens
only SID_ATTR_PAGE_SIZE does anything so far Change-Id: I30de1b8b72702b0ddd536ed4026b433ed9295bb7 Reviewed-on: https://gerrit.libreoffice.org/24450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04tdf#89466: Access to page setup dialog, alignment of labelsKatarina Behrens
Change-Id: I687457d26cf8e6f9e8d5fb5667eddd66baf3719e Reviewed-on: https://gerrit.libreoffice.org/24449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04tdf#89466: Slide Background tabRishabh Kumar
Change-Id: Ic3ba6b47a1e5fcaeec76c4e4ff0ba6128653af86 Reviewed-on: https://gerrit.libreoffice.org/17007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04underline popup control possible to use outside sidebarSzymon Kłos
Change-Id: I48097007c7dc0439b33233939c1d73902dfeb679 Reviewed-on: https://gerrit.libreoffice.org/24491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-05-03Remove Edit -> Plug-in as no longer usedBryan Quigley
This functionality seems to only have been used with NPAPI plugins. They've been previously removed. Per the help text, if it is still used by anything, you can use the context menu instead. MN_READONLY_PLUGINOFF also appeared to be unused, so removed. More code might be removable, but would affect activate on click/visible. Change-Id: I12d5bf54edd3a2f716912179b87e798b47b3cc3d Reviewed-on: https://gerrit.libreoffice.org/24500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-02drop cruftDavid Tardon
Change-Id: Ib3364e97407061ee7710cb87f1f33a2736ed9c0e
2016-05-02use unique_ptrDavid Tardon
Change-Id: I55ff9ae568a0d44c8ee8be922adf40e12038e436
2016-05-02fix typoDavid Tardon
Change-Id: I841a9c12664950b2f1fe8cdf43e3d815f292eb3d
2016-05-02rbhz#1326602 avoid exp. bg bitmaps from deleted slidesDavid Tardon
ODF export uses SvxUnoBitmapTable (impl. of com.sun.star.drawing.BitmapTable) to create fill bitmap styles. That returns all XATTR_FILLBITMAP items that are in the document's pool. So we ensure that bitmaps that are only used on deleted (either explicitly or by undoing their insertion) slides are not in the pool. Change-Id: I54c594a94989158f22b156fe660c1e716b988b3e
2016-05-02add member prefixDavid Tardon
Change-Id: Ic53e0c564176649b6cba84ea898c3c2f69fcad8c
2016-05-02use unique_ptrDavid Tardon
Change-Id: I38d5c436985b0a68530be01c7482a68cf4e99018
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ideafa411b53fe4a5f2e6559be10c4cb82b58a256 Reviewed-on: https://gerrit.libreoffice.org/24543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30removed defaulted argument from function callArmin Le Grand
Change-Id: I09a48b1223e7a339b4760a8b719a927db2b418a3
generated by cgit (git 2.34.1) at 2025-01-15 19:50:06 +0000