summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2024-05-09Use less SdOptionsLayout->IsHandlesBezier in favor of officecfgGabor Kelemen
Change-Id: Id2f005413f255b4a0f0e0cd240cb8700c27ee204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166598 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-05-09Use less SdOptionsLayout->GetMetric/SetMetric in favor of officecfgGabor Kelemen
Change-Id: I12c9f69e0db1bf3e726b7d642e9a6855b031d3b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166597 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-05-08tdf#69192: add StartingSlide to SID_PRESENTATION and cmdline show=Justin Luth
Allow the user to start the presentation at a specific slide using command-line parameters. This patch depends on the previous variable renaming patch. Change-Id: I87797cbccb463904e5d2fe9b078e3921be27c91a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167066 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-05-07Impress: transmit document's property StartWithPresentationMéven Car
This is transmitted as stateChanged event. This property is set for ppsx/pps files. Change-Id: Ic2f495cb9923b385bce7d93a2d8121d2945221ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163652 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit b951c57d4b723621d211b552f2cd238ae0dc246a) Change-Id: I7eedc855255a30abdfdf61c8315b4f8238c07ca9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165094 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167277 Tested-by: Jenkins
2024-05-07WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I3f13b457025280486d6cb4d2935c1ef5a52b0637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-06tdf#99528 Use vertical tabs in 'Edit Style' dialogSamuel Mehrbrodt
Change-Id: Ia581c92952d16d71ace8511b502304cdb9014479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166760 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2024-05-03tdf#152906: use correct Y offsetMike Kaganski
GetEditCursor now returns the position relative to the line, not to the whole text. In ImpEditEngine::CreateLines, its use wasn't fixed, and so the Y position of all lines in the calculation was the same, thus adjusting to the same contour's horizontal stripe. Change-Id: I16362bab47f3064281eefb45a12834d836a8ada3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167042 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-05-03tdf#160349: add .uno:ChangeTheme to notebookbar to toggle dark modeJustin Luth
A temporary (ugly, but appropriate) icon has been assigned. The toggle can be customize-assigned to keyboard, menu, and toolbar, and can be found by searching for "Dark Mode". In the menu, it is checked when in Dark mode, and in the toolbar it is "depressed" or highlighted as active. Dark mode has been added to the view tab of notebookbar.ui. I added it as NOT VISIBLE, for several reasons. - dark mode is rather new and not so stable, so don't over-promote it. - notebookbars cannot be infinitely customized by the end user, so developers have to add all items. Users only enable or disable. - toggling dark mode really ought to be done at the OS level, and typically should be a one-time setting, therefore not appropriate to waste precious toolbar space. The primary benefit of making it available in the menu is for QA testers who want to easily switch back and forth. WARNING: by customizing the notebookbar, you prevent seeing any future NBB changes made to the program (until you reset to defaults or blow away the user profile). Dark Mode can easily be added to a menu, toolbar or keyboard shortcut by the end user, so I didn't bother adding it anywhere else. To avoid completely cluttering up this commit, I only added Dark mode to the main notebookbar. Once this commit has been finalized, the other writer-apps and notebookbars can also gain this command. Change-Id: Ia7594ad81e305ead922abd0ad7b41d6fc0413053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166781 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-05-03sd, svx: Return new annotation instead of using out paramMichael Weghorn
Let `SdrPage::createAnnotation` et al. return the newly created annotation rather than using an out parameter, which makes this more straightforward. Change-Id: Iee0561859756522ef33680c2cc9b492541a31d5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167019 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-02Save with newer Glade versionSamuel Mehrbrodt
Change-Id: I1bd6864230b26e9e32c7c509a91666e8f679cd76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166759 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-02cid#1596707 Unchecked dynamic_castCaolán McNamara
Change-Id: I2067f335dfacf2dfb4b5b18b54c738f3fba4c375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166981 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-01annot: make TextApi use SdrModel instead of SdDrawDocumentTomaž Vajngerl
Also it uses SdrOutliner instead of SdOutliner. This change is important for moving the implementation to svx, where we don't have sd specifics available and it seems in this case they are not even needed. Change-Id: I6c63ba4953bb5281aa951a0048a08fdd2813c530 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166495 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-30Drop some uses of css::uno::Sequence::getConstArray ...Mike Kaganski
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code 2021-11-05). Change-Id: I4ccc647bb794515c8c11f8dfd9a26563f4aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166819 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-04-28Use less ConfigurationAccess in favor of officecfgGabor Kelemen
Change-Id: I9bb0165aabb0d5ff2caac33ec948a04d96eb3316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166756 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-28Drop CacheConfiguration in favor of officecfgGabor Kelemen
Also the key path was wrong in SlsCacheConfiguration.cxx: MultiPaneGUI/SlideSorter/PreviewCache but in Impress.xcs we have MultiPaneGUI/SlideSorterBar/PreviewCache hierarchy so this may actually now start to work :) Change-Id: I4b552be713e6e157edb45692ba78101429aa1c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166755 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-27Drop now unused option-stream identifiersGabor Kelemen
Change-Id: Id08e41e11b8027339e58ab182739087030e66eef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166754 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-04-27reduce symbol visibility in sdNoel Grandin
Change-Id: I3d4de2b8854278b8713992660268e764815fe738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166761 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-04-26Use less SdOptionsLayout->IsDragStripes/SetDragStripes in favor of officecfgGabor Kelemen
Change-Id: I0c0e2dd57d1f1408f85bca4b6ee3bfcebae1cf22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166596 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-04-26Use less SdOptionsLayout->IsMoveOutline in favor of officecfgGabor Kelemen
Change-Id: I848e11a64a42b670254c88b791d0b2a2534d112f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166595 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-04-26Drop now unused GetOptionStream classGabor Kelemen
Change-Id: Iddb1fbb437f0f66c551e9231d79511caf1edafb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166635 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-26Drop now unused sdiocmpt.cxxGabor Kelemen
Change-Id: Ibba331a536bbd6f228df005c3488a722a3631d4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166634 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-26annot: moved more of Annotation and dependencies into svxTomaž Vajngerl
Moved the holder of annotations from SdPage to SvxPage, so that the vector holding the annotations and accessors are on SvxPage and adapted the code. This also changes the type od most parameters on most methods from sd::Annotation to sdr::annotation::Annotation and adapted the code. Moved AnnotationEnumeration into svx, as it was needed in svx already. Change-Id: Iab17aa881443f58adfb9158959db00ed24076279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166494 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-26annot: move UndoAnnotation and deps. to svx, adapt svx AnnotationTomaž Vajngerl
This moves UndoAnnotation and dependent classes to svx, refactor the code to in sdr::annotaion::Annotation so annotations in sd module still work as they have before. Change-Id: I3769069a636c30c55bc1fcf2406d990f1b44baa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166493 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-26tdf#158305 Store Convert to Polygon dialog settings correctlyGabor Kelemen
Change-Id: I4d732adb8365cd4ecddf372b5646c14c7ffe828c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166631 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-04-26tdf#158304 Store Cross-Fading dialog settings correctlyGabor Kelemen
Change-Id: I3b8de3590a83def6fd6c77a504c69085dc2f0361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166633 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-04-26Drop stale pubdlg.cxx fileGabor Kelemen
Seems to be unused since commit 28b6480c6bdd179f3943f768926b7f196226c768 tdf#105303: Drop html export wizard Change-Id: I9d7aa80d64df6f68af51cd026ef49d6a61cf9cfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166632 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-26Use less SdOptionsLayout->IsRulerVisible/SetRulerVisible in favor of officecfgGabor Kelemen
Change-Id: I0f6b38d364fb880e8dcd3cae08f2c5298cb7a5bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166594 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-26Use less SdOptionsLayoutItem in Options - Impress - ViewGabor Kelemen
in favor of officecfg Change-Id: I3aea51bf0c1a2184163c07bf42b26164311843de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166593 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2024-04-25Related tdf#87676 Enable text formatting toolbar when in a text boxSamuel Mehrbrodt
Use the second row (hiding the shapes toolbar) to show the text formatting toolbar when the user is inside a text box. This helps users to do basic text formatting at the place where they expect the controls from Writer, Calc, etc. Otherwise, when the Sidebar is switched to another Deck, finding the text formatting functions can be hard in the classic toolbar layout. Change-Id: I8d6f54e6f3f44917b0c89ae699c2798e4f6b86a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166621 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2024-04-25annot: added Annotation impl. to svx, moved some thing from sdTomaž Vajngerl
This is an attempt to move the sd::Annotation to the common code in the svx module. This will need to be done in multiple steps so the first one is to introduce sdr::annotation::Annotation class in svx module, which is derived by sd::Annotation. Non-problematic functionality and members are also moved to the svx Annotation. Change-Id: Id20466b3780514ab63a9df8923b879098870ebb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-04-24[API CHANGE] a11y: Use XAccessible for relation targetsMichael Weghorn
Use a Sequence of XAccessible rather than its base interface XInterface for AccessibleRelation's TargetSet. As the targets are accessible objects as well, anything other than XAccessible doesn't make much sense. Using XAccessible right away makes that clearer and avoids the need to query the XAccessible interface. (The winaccessibility bridge was already using `static_cast`, relying on the fact that the objects are XAccessibles.) The a11y UNO API is not published, so an API change should be unproblematic. Change-Id: I7f08e98d1ec303d5343d9a7954187cdd71495ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166586 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-04-24tdf#38164: sd: allow panning across pages when zoomed inSarper Akdemir
Change-Id: I513b2b8cbdc91733e551da71a1e6782fecc981a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166542 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper@libreoffice.org>
2024-04-22Revert "IASS: Correct Buffering of last Slide"Armin Le Grand
This reverts commit 77eb3f1a76892b6070e77324e260204408383ef4. Reason for revert: Better solution in https://gerrit.libreoffice.org/c/core/+/166177 which is 052c668da38b70943d24770895abc8119aace2a6 Change-Id: I42248771c993bcd04c2fe368795db4e1fe7a2586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166212 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-04-20related tdf#33603: sd: do not assume there's always a viewshellSarper Akdemir
Change-Id: I171639150a84372e7e25b5246d4882c467edd58b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166271 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2024-04-20loplugin:constantparam in sdNoel Grandin
Change-Id: I4943244d8c08d1d86e4c1ff9177b00cfa451e453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166315 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-20Return double from OutputDevice::GetTextArrayMike Kaganski
And introduce GetTextWidth / GetTextHeight variants returning double. It allows to avoid premature rounding. At least in one case - testTdf145111_anchor_in_Fontwork - it allowed to make the test DPI-independent (at least in my testing on Windows, using 125, 150, and 175% UI scaling). Change-Id: I973d2c729ec6bb7114b4f99b9027f1ead7c1d061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166237 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-20tdf#160601 add expert option for default slides per row in slide sorterCor Nouws
Change-Id: Ib122ad0fce8159c1ceb092bcc65a59ba1ad23bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166174 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-04-18tdf#33603: make the notes pane handle placeholder text on focusSarper Akdemir
Change-Id: Id2bca2b8a8bafa9da44a5f97a8e763b512078ef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166152 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2024-04-18tdf#160669 IASS: flush Prefetch for SLideShow as neededArmin Le Grand (allotropia)
Change-Id: I3c0e2be658358ab5b412ab18cce197eb28e5c0db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166177 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-04-17add Spell state to impress RenderState like we do for calc/writerCaolán McNamara
Change-Id: I1adfef0fa7220d93b096fbe4b86d0c04b2e5547e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-17Drop FRound, and use generalized basegfx::froundMike Kaganski
Change-Id: I7447e649dc3ef4e51242f69c7486a3e84e103d2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166159 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-15Case rotation in Impress: skip sentence caseOliver Specht
Sentence case does not make sense if a selection contains less than two words. Rotation then skkips to the next case mode. Change-Id: I79d6560c494b716a53bfed654027f6f37dc6c362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166115 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-15tdf#33603 Allow adding Notes Panel to toolbar/menubar/keyboard shortcutsSamuel Mehrbrodt
Change-Id: Ic3e8f6b5a0cc8697c62e8f10f69ff53859f33d3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166004 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2024-04-15tdf#33603 Make notes panel available in readonly modeSamuel Mehrbrodt
Change-Id: I2dd10802f3798b2e87833d3cd8ebd21366e0f546 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166003 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2024-04-15tdf#33603 Fix Close button not working in Notes PaneSamuel Mehrbrodt
Remove duplicate command and now unused NotesChildWindow Change-Id: Idef94086ca91dd1474070c426c37ef921ad4fa03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166002 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2024-04-15Generalize basegfx::fround for templated return typeMike Kaganski
And use it when assigning to tools::Long Change-Id: I0814d7bac9cdd48191ba69c64e3b12a4973b3417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-14Use more o3tl::convertMike Kaganski
Change-Id: I56d6909dc3b1a7d45e4e3f45583321b1338838cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166063 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-13Drop unused SdOptionsContents classGabor Kelemen
seems to be practically out of use since 2007 commit 56ca5814a1843a31d23b249f1960a31532c6b5bd part of patch series '#i80528# Removal of draft paint modes' Change-Id: I770bab8b1973bec099ffdaa3243f1c0d2995ee52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165858 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-12Remove duplicated includeAndrea Gelmini
Change-Id: I423fed50156a225d14c0afeebd7b72936c052b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166008 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-04-12Resolves tdf#157403 sidebar SdNavigator does not show new slide/pageJim Raykowski
after file reload Change-Id: I8ba7ffac3c098cf388a67e3454c5986b5a8b1f3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165767 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-06 10:02:11 +0000