summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-08-31sd/pptx export: refactor WriteAnimationNode.Mark Hung
to get rid of function pointers. Change-Id: Iaea4782274c655484559118183397a3340d1d7cb Reviewed-on: https://gerrit.libreoffice.org/59734 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: remove unnecessary using caluses.Mark Hung
Change-Id: I836766e308fb198f4f081837731ba1854c770f06 Reviewed-on: https://gerrit.libreoffice.org/59733 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: move animation related static member functionsMark Hung
of PowerPointExport to anonymous namespace. This allows cleaning up PowerPointExport and later moving other non-static member functions caller outside PowerPointExport to become a new class. Change-Id: I174337896db68307d7859dc9cf8bb9a9648f90eb Reviewed-on: https://gerrit.libreoffice.org/59732 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-30sd/pptx export: move animation export code to a single file.Mark Hung
Move animation export functions in PowerPointExport to a single file for further refactor work. Change-Id: I957599bb293fcdda3d51db48334ef5825b1cba64 Reviewed-on: https://gerrit.libreoffice.org/59731 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-30Remove redundant asserts after newMike Kaganski
Also remove SlideSorter::CreateController which only calls new; fix a memory leak in osl_Security's MyTestPlugInImpl::initialize Change-Id: I70b6e888984f8543adbf879162e752556d2b3f0e Reviewed-on: https://gerrit.libreoffice.org/59805 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-30rename GetMarkedObjModel to CreateMarkedObjModelNoel Grandin
and return std::unique_ptr Not that it helps much, the ownership quickly becomes complex once it hits the TransferableHelper. Change-Id: I3c6bd72072e092b71b32e4105fe859fdcea956af Reviewed-on: https://gerrit.libreoffice.org/59777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30don't declare allocation operators for internal codeNoel Grandin
since they just call into malloc/free now, we can ignore them. Should have some nice side-effects like letting the compiler allocate temporaries on the stack. Change-Id: I2500abe19acf9b5bcc676604393c498d4e0dce58 Reviewed-on: https://gerrit.libreoffice.org/59658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29Removed execution flag on pptx fileAndrea Gelmini
Change-Id: I7beaea418a995670d26f1542ef09416410fdb722 Reviewed-on: https://gerrit.libreoffice.org/59466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#117058: Simplify calls to Menu::CheckItemArnold Dumas
Change-Id: Ib4cba3af376d8d031d5282a5459eaecc18e3ed9a Reviewed-on: https://gerrit.libreoffice.org/58811 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-08-29fix sd_export_ooxml2 fail on Linux-rpm_deb-x86@71-TDF, MASTERJustin Luth
due to rounding differences, it was failing on 32bit linux only. Test name: SdOOXMLExportTest2::testTdf91999_rotateShape equality assertion failed - Expected: 1449000 - Actual : 1448640 Test name: SdOOXMLExportTest2::testTdf114845_rotateShape equality assertion failed - Expected: 3287520 - Actual : 3287160 I also re-added the extra test that had previously failed for a similar reason under Linux64 even. Change-Id: I6c8be5ef1545d48f1e59319c3b3df1d2580e1f95 Reviewed-on: https://gerrit.libreoffice.org/59754 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29new loplugin:oustringbufferNoel Grandin
look for places where we are appending the temporary result of adding strings together, to an OUStringBuffer, where we could rather call append repeatedly and avoid the temporary creation Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82 Reviewed-on: https://gerrit.libreoffice.org/59708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28fix glib/bluetooth linking errorsLuboš Luňák
Since nobody else seems to have this problems, this may be possibly only specific to KDE builds or to using gold linker. Change-Id: I29359e298178b934a6232b78da684e55db590863 Reviewed-on: https://gerrit.libreoffice.org/59655 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-08-27tdf#101242 Support draw:display and draw:protect attributes of ODFRegina Henschel
LibreOffice writes the properties visible, printable and locked of layers into items in the subfile settings.xml and handles them as properties of the view. ODF handles them as property of the layer. To become more ODF conform as a first step these properties are now read and written. They are used to initialize the view in case they are missing in settings.xml, which is the case for foreign documents. The ODF properties are written in addition to the items in settings.xml, so that older versions will notice no difference with such documents. SdModelTestBase is changed to handle odg as Draw document. Change-Id: I190ecc51fc6ee91ec4b96d06bb216ce517bdfcfe Reviewed-on: https://gerrit.libreoffice.org/59269 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-27tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[n-s]*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also a bit of fallout management overreaching into include/ Change-Id: I99bd4527ecf34e5193602f0e9dcb33b504e8c9e1 Reviewed-on: https://gerrit.libreoffice.org/58808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-27rename ENABLE_HEADLESS option to DISABLE_GUINoel Grandin
since it has nothing to do with the headless command line option, so use the name it has in the configure.ac file Change-Id: Ibf0615ed02695d6e48a797f5632e4f417c010c70 Reviewed-on: https://gerrit.libreoffice.org/59611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24loplugin:useuniqueptr in sd dialogsNoel Grandin
Change-Id: Ie4b665b565812f8ba4ca454387a6ad0e38433bbd Reviewed-on: https://gerrit.libreoffice.org/59544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24loplugin:useuniqueptr in sd::CommunicatorNoel Grandin
Change-Id: Iedfe9aa982b64e8ba7d07c74d60cabd101538357 Reviewed-on: https://gerrit.libreoffice.org/59491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24tdf#118993 - Missing new Insert Special Character in Calcheiko tietze
Added also to Impress and Draw for consistency Fix for tdf#116355 included and SID_CHARMAP_CONTROL disabled in Impress like SID_CHARMAP Change-Id: I8b9925f6124527dfc27c7a27f6c8832c7e9c88e2 Reviewed-on: https://gerrit.libreoffice.org/58323 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-24tdf#119236 Dimension dialog for Writer and CalcMaxim Monastirsky
Change-Id: Ifbc6c8959afcedac0fd9ec7a3f5e2cca63c11eda Reviewed-on: https://gerrit.libreoffice.org/59484 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-22Resolves: tdf#118799 use spelling/search dialog as message dialog parentCaolán McNamara
when visible Change-Id: Id4d6df2a85aebd6887949f285e1a5ec1046dbf64 Reviewed-on: https://gerrit.libreoffice.org/59456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22Resolves: tdf#119259 reused in-use SdStyleSheet removed by undoCaolán McNamara
since... commit a4cd841541a729d7b8126d27d91fa28e30b01403 Date: Thu Feb 13 16:10:47 2014 +0530 n#757432: Styles (rename &) copy to different decks. While copying slides to different slide decks, styles were not being copied if there is already one with the same name. This patch renames and copies those to keep the formatting intact. if a SdStyleSheet is not freshly created, but reused, it ends up in the rCreatedSheets list, and so when the copy is undone (via SdMoveStyleSheetsUndoAction), the SdStyleSheet is unconditionally remove from the StylePool and so its ref count hits 0 and is removed, even though there are still objects depending on it. the problem becames more common since... bash-4.4$ git show 57db6e24b5ad43d447c30e44a112c74c7e75b46b commit 57db6e24b5ad43d447c30e44a112c74c7e75b46b Date: Tue Aug 15 02:51:07 2017 +0530 Removing old SfxItemSet::getHash usage improves the SfxItemSet comparison. Assuming that its correct to leave SdStyleSheetPool::CopySheets with those reused SdStyleSheets in the list, change things so that a flag is passed around to indicate if the SdStyleSheet should be removed or not by undo Change-Id: I82b5bd93183fd1ff9e67957ccfb5babef81fd36d Reviewed-on: https://gerrit.libreoffice.org/59432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22loplugin:useuniqueptr in sd::Outline::IteratorNoel Grandin
Change-Id: I5f8281efb09c1da7c12e80d2522b89bbd400c3f7 Reviewed-on: https://gerrit.libreoffice.org/59435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22new loplugin:conststringfieldNoel Grandin
Look for const string fields which can be static, and mostly convert them to OUStringLiteral And add a getLength() method to OUStringLiteral to make the transition easier. Remove dead code in XclExpRoot::GenerateDefaultEncryptionData, default password is never empty. Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091 Reviewed-on: https://gerrit.libreoffice.org/59204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22tdf#119118 convert tmAbs value to second.Mark Hung
setInterval() of IterateContainer actually need second instead of percentage of the duration, we just need to convert tmAbs in millisecond to second to make iterate interval correct. Change-Id: I1dfc3c64187eb5b7fd8f0b6a91f41dc55466b58b Reviewed-on: https://gerrit.libreoffice.org/59412 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-22lokdialog: Convert the SideBar->Animation->Effect Options to async exec.Noel Grandin
and move the ownership of the propertyset, so it lives as long as the dialog (which appears to fix a double delete here as a bonus) Change-Id: Iaff931a048211ae8453cc8955344453abdd3f4ab Reviewed-on: https://gerrit.libreoffice.org/59399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-21loplugin:useuniqueptr in TextApiObjectNoel Grandin
Change-Id: I57c6f91ff034f06f947dd8498aa10a2e61a5ff9e Reviewed-on: https://gerrit.libreoffice.org/59366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20Simplify containers iterations, tdf#96099 follow-upArkadiy Illarionov
Use range-based loop or replace with std::any_of, std::find and std::find_if where applicable. Change-Id: I2f80788c49d56094c29b102eb96a7a7c079567c6 Reviewed-on: https://gerrit.libreoffice.org/59143 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-18coverity#1438403 Unchecked return valueCaolán McNamara
Change-Id: I7debe5eb1c366264cb94a52f63677f392cda647e Reviewed-on: https://gerrit.libreoffice.org/59291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-18uitest Impress-rename,new slide ; tdf#85360Zdeněk Crhonek
Change-Id: Id080fdeb3d47f27f9a8b83b7720e96eb46eb716b Reviewed-on: https://gerrit.libreoffice.org/59267 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-08-17Consolidate: basegfx::clamp -> o3tl::clampStephan Bergmann
Change-Id: Iffd8b0a19d4479b6c70dc834c6f64499e87e01b1 Reviewed-on: https://gerrit.libreoffice.org/59265 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16SvxNumberFormat::nFirstLineOffset should have a larger typeStephan Bergmann
...similar to 0d227c96e11d7d03829144183bc66d229e059a4b "SvxNumberFormat::nAbsLSpace should have a larger type", this time due to: > Testing file:///home/sbergman/lo/core/sd/qa/unit/data/ppt/pass/hang-10.ppt: [...] > filter/source/msfilter/svdfppt.cxx:3793:39: runtime error: implicit conversion from type 'sal_Int32' (aka 'int') of value -142240 (32-bit, signed) to type 'short' changed the value to -11168 (16-bit, signed) > #0 in PPTNumberFormatCreator::ImplGetNumberFormat(SdrPowerPointImport const&, SvxNumberFormat&) at filter/source/msfilter/svdfppt.cxx:3793:39 (instdir/program/libmsfilterlo.so +0x79930d) > #1 in PPTNumberFormatCreator::GetNumberFormat(SdrPowerPointImport const&, SvxNumberFormat&, unsigned int, PPTParaLevel const&, PPTCharLevel const&, TSS_Type) at filter/source/msfilter/svdfppt.cxx:3674:5 (instdir/program/libmsfilterlo.so +0x797bad) > #2 in PPTStyleSheet::PPTStyleSheet(DffRecordHeader const&, SvStream&, SdrPowerPointImport&, PPTTextParagraphStyleAtomInterpreter const&, PPTTextSpecInfo const&) at filter/source/msfilter/svdfppt.cxx:4395:13 (instdir/program/libmsfilterlo.so +0x7ac27d) > #3 in SdrPowerPointImport::SdrPowerPointImport(PowerPointImportParam&, rtl::OUString const&) at filter/source/msfilter/svdfppt.cxx:1618:59 (instdir/program/libmsfilterlo.so +0x74759f) > #4 in ImplSdPPTImport::ImplSdPPTImport(SdDrawDocument*, SotStorage&, SfxMedium&, PowerPointImportParam&) at sd/source/filter/ppt/pptin.cxx:175:7 (instdir/program/libsdfiltlo.so +0x5f2be8) > #5 in SdPPTImport::SdPPTImport(SdDrawDocument*, SvStream&, SotStorage&, SfxMedium&) at sd/source/filter/ppt/pptin.cxx:162:23 (instdir/program/libsdfiltlo.so +0x5ce2bb) > #6 in ImportPPT at sd/source/filter/ppt/pptin.cxx:2760:47 (instdir/program/libsdfiltlo.so +0x617c79) > #7 in SdPPTFilter::Import() at sd/source/filter/sdpptwrp.cxx:106:32 (instdir/program/libsdlo.so +0x2878233) > #8 in sd::DrawDocShell::ConvertFrom(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:474:46 (instdir/program/libsdlo.so +0x2e163dc) > #9 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:786:23 (instdir/program/libsfxlo.so +0x2c8c492) > #10 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:75:31 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19771) > #11 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5724c) > #12 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x57ec9) > #13 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19d6d) Change-Id: Icd83120e99ac8e7181d75e2cf9d13f49064e65e1 Reviewed-on: https://gerrit.libreoffice.org/59212 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16tdf#99213 handle iterate container.Mark Hung
Export iterate container as p:par with iterate element, which has 'type' attribute and p:tmAbs element. Note that child animation node would not have target so it has to use the target of the iterate container. Testcase of testTdf113822 is used, PowerPointExport:: WriteAnimationAttributeName is tuned to prevent data loss there. Deciding an Any is a RGB color by converting to sal_Int32 doesn't work and has been done AnimationExporter::convertAnimateValue, so we can remove them securely and make the roundtrip test case work. Change-Id: I04a66f004df291c04c1f6e4a8fb7da34b924d922 Reviewed-on: https://gerrit.libreoffice.org/58998 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-16tdf#119284 bg for automatic not set while editingCaolán McNamara
refactor and reuse fdo#35779 solution for this case Change-Id: I0631cd2560aa2acc2310f95b5c4dea36a2845a58 Reviewed-on: https://gerrit.libreoffice.org/59165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16these only get used if pOL is non-nullCaolán McNamara
Change-Id: I70d38727027d15b0bf3ea2904655f15d9503b681 Reviewed-on: https://gerrit.libreoffice.org/59162 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-15ofz#9821 Indirect-leakCaolán McNamara
Change-Id: I7b4f1a487c49048b7796dba982c5c1d2163cce46 Reviewed-on: https://gerrit.libreoffice.org/59068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-15SvxNumberFormat::nAbsLSpace should have a larger typeStephan Bergmann
...as is seen when executing CppunitTest_sd_filters_test with Clang's new -fsanitize=implicit-conversion (see below). The next larger natural choice after short is sal_Int32, and some of the code calling GetAbsLSpace actually already supported the value to be as wide (but not wider than) sal_Int32; code calling GetAbsLSpace that expected the value to be no wider than short has either been adapted or at least been marked with a TODO. (Other choices could have been sal_Int64 or long.) Some dependent function's parameter types have also been changed accordingly. > Testing file:///home/sbergman/lo/core/sd/qa/unit/data/ppt/pass/hang-10.ppt: [...] > filter/source/msfilter/svdfppt.cxx:3792:33: runtime error: implicit conversion from type 'sal_uInt32' (aka 'unsigned int') of value 144780 (32-bit, unsigned) to type 'short' changed the value to 13708 (16-bit, signed) > #0 in PPTNumberFormatCreator::ImplGetNumberFormat(SdrPowerPointImport const&, SvxNumberFormat&) at filter/source/msfilter/svdfppt.cxx:3792:33 (instdir/program/libmsfilterlo.so +0x7992cc) > #1 in PPTNumberFormatCreator::GetNumberFormat(SdrPowerPointImport const&, SvxNumberFormat&, unsigned int, PPTParaLevel const&, PPTCharLevel const&, TSS_Type) at filter/source/msfilter/svdfppt.cxx:3674:5 (instdir/program/libmsfilterlo.so +0x797c6d) > #2 in PPTStyleSheet::PPTStyleSheet(DffRecordHeader const&, SvStream&, SdrPowerPointImport&, PPTTextParagraphStyleAtomInterpreter const&, PPTTextSpecInfo const&) at filter/source/msfilter/svdfppt.cxx:4395:13 (instdir/program/libmsfilterlo.so +0x7ac38d) > #3 in SdrPowerPointImport::SdrPowerPointImport(PowerPointImportParam&, rtl::OUString const&) at filter/source/msfilter/svdfppt.cxx:1618:59 (instdir/program/libmsfilterlo.so +0x74762f) > #4 in ImplSdPPTImport::ImplSdPPTImport(SdDrawDocument*, SotStorage&, SfxMedium&, PowerPointImportParam&) at sd/source/filter/ppt/pptin.cxx:175:7 (instdir/program/libsdfiltlo.so +0x5f2be8) > #5 in SdPPTImport::SdPPTImport(SdDrawDocument*, SvStream&, SotStorage&, SfxMedium&) at sd/source/filter/ppt/pptin.cxx:162:23 (instdir/program/libsdfiltlo.so +0x5ce2bb) > #6 in ImportPPT at sd/source/filter/ppt/pptin.cxx:2760:47 (instdir/program/libsdfiltlo.so +0x617c79) > #7 in SdPPTFilter::Import() at sd/source/filter/sdpptwrp.cxx:106:32 (instdir/program/libsdlo.so +0x2878413) > #8 in sd::DrawDocShell::ConvertFrom(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:474:46 (instdir/program/libsdlo.so +0x2e165bc) > #9 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:786:23 (instdir/program/libsfxlo.so +0x2c8cb12) > #10 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:75:31 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19771) > #11 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5724c) > #12 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x57ec9) > #13 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19d6d) Change-Id: Ifa298a51bb62b7cbee9249b8289963f3427721f5 Reviewed-on: https://gerrit.libreoffice.org/59116 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-15loplugin:useuniqueptr in OverlayObjectListNoel Grandin
Change-Id: I641d93e54504c27bcc49bae8edf6286c0a9a471f Reviewed-on: https://gerrit.libreoffice.org/59024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-14tdf#118825 use exportToSvgD for motion path in pptx filter.Mark Hung
Change-Id: Ie3c023b0efc4a6c5a92ffc8ba43259ff2bb7da8f Reviewed-on: https://gerrit.libreoffice.org/58849 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-13loplugin:returnconstant in sdNoel Grandin
Change-Id: Ie48caf16bae9f85b61dd9614199f1b2d75783e6e Reviewed-on: https://gerrit.libreoffice.org/58878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-12Resolves: tdf#112343 remove last dbus-glib mentionsArkadiy Illarionov
Remove dbus-glib bundle from flatpak since LibreOffice doesn't depend on dbus-glib as of commit 02addb3618f026acd72ece76fc726b9473cc5940. Fix dbus reference in comment. Change-Id: I1f4bc41bcd0ea091fc199f2271b27079ce3c2c74 Reviewed-on: https://gerrit.libreoffice.org/58795 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-11set copy_paste_error to false rather than intentionalCaolán McNamara
Change-Id: I152482ef594c286d3c2a94cab62feff49bbf79fa Reviewed-on: https://gerrit.libreoffice.org/58884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-10OUString: avoid getTokenCount to only get last tokenMatteo Casalin
Change-Id: I68529076a6a6c2b23842c41d3e9099083a78d3c6
2018-08-10OUString: avoid getTokenCountMatteo Casalin
Change-Id: Icceff0aeb5c6fb70513786366416c2d86b60602a
2018-08-10CopyDlg: avoid getTokenCountMatteo Casalin
OUString managed inside this class either is empty or has 8 tokens, simplify check. Change-Id: If576187c6e4800e85f1cebb1ed3e1ae87a4315d1
2018-08-10OUString: use optimized concatenationMatteo Casalin
Change-Id: Ibaaa29568fe46148baa47422853ef2e627f4045b
2018-08-10OUString: use indexed getToken and convert to proper integer typesMatteo Casalin
Change-Id: I39210971a65e62cc22b384ebf090a987747c57af
2018-08-10Avoid getTokenCountMatteo Casalin
Change-Id: Ib1b6c354184b9379ebafb15ac4a1c789e1c3c1a2
2018-08-10tdf#91999 export/drawingml: shape rotate 180 is not specialJustin Luth
This commit reverts the first (LO 4.3ish) regression commit 6063555744ed89d8a757b667cddcdd4357839466 and most of the two commits that tried to fix that: commit 9ae1e094d5a8a5b4432c88ebea0ca9fc1c79f602 and commit ee45d881efab230e7682f964d6ad4d00f85b0006 in LO6.0/6.2. The ooxmlexport6 unit test shows that there is nothing special about 180degrees. So, all transformations need to be avoided in docx format - not just 180 degree ones. I removed IsInGroupShape() since it is no longer being used - as per standard procedures. Change-Id: Id2bba5bc542875a10ac21fbb67f29b2d59705493 Reviewed-on: https://gerrit.libreoffice.org/58434 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-10tdf#111856 Playing video in impress is considered a modificationNickson
Change-Id: If7a2db2d37dc6230a76b79c79e6163a1b33be7d2 Reviewed-on: https://gerrit.libreoffice.org/58713 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
generated by cgit (git 2.34.1) at 2025-01-30 13:17:18 +0000