summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2017-03-23remove unused helpid in SfxShellNoel Grandin
Unused since commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae "update unusedmethods plugin to deal with constructors" where I removed a unused SfxDockingWindow constructor. And in that case, the helpid was only being used to assign the window a UniqueId. Change-Id: I148e424424fcf08449440b83a8600071b39d7a07 Reviewed-on: https://gerrit.libreoffice.org/35554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23“Hyperlink” is NOT a dated word, it’s just a precise oneAdolfo Jayme Barrientos
We should always be clear and precise, given that LibreOffice handles various kinds of links. Nobody at L10n wanted this change, but they were ignored. This should fix tdf#103093, which was a consequence of the introduced ambiguity. This reverts commit a1297fc2df243d765ffb14f18bbdde158459b9f4. Change-Id: I29232c7a8384c3fa501c61aab26e061ebcb1a0d8
2017-03-22catch structured storage exceptions during testingCaolán McNamara
Change-Id: Ibce297f85ebcf5ebde1a9e81afef9b0c41ebeb1a
2017-03-22lok sd: Fix crash when searching.Jan Holesovsky
This is a follow-up of ed5450f2a5ed8e72b48b4d976217746cea04a5c9 where the check for the HasView has been removed. Turns out that there are conditions when this really can happen, leading to crashes in the LOK searching. Unfortunately I did not manage to find a reliable reproducer to create a unit test :-( - so I suspect this commit might be more a workaround than a root cause fix. Would be great to find out the exact conditions leading to the situation when the EditEngine does not contain the EditView, and evaluate this fix against that - but that's hard without a reliable reproducer. A unit test for this fix is missing from the same reason. The unit test from ed5450f2a5ed8e72b48b4d976217746cea04a5c9 still passes. Change-Id: I1cca7219817119d27a224b35efb660a84d35b8fa
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22create SfxDisableFlags enumNoel Grandin
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f Reviewed-on: https://gerrit.libreoffice.org/35514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-21ofz: leaks in animation nodesCaolán McNamara
there's no dispose option to deal with circular references Change-Id: I11ad081ab7c98648b7ab87e138f54add04ab07fe Reviewed-on: https://gerrit.libreoffice.org/35488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-20Resolves: tdf#106612 fix double click in draw/impress navigatorCaolán McNamara
Change-Id: Ic4b08c6e5cd430b5278bdc2cb7f1205bba160740
2017-03-19Fix typos + some German translationsAndrea Gelmini
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: https://gerrit.libreoffice.org/35406 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19fix typo/grammar: "the the" --> thedennisroczek
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: https://gerrit.libreoffice.org/35151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-18Typo: sucess->success + "adminsitrator" fixJulien Nabet
Change-Id: I42fdb0a60b987af92e0433e7ff0e5754bc1da748 Reviewed-on: https://gerrit.libreoffice.org/35412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18valgrind: uninitialized valueCaolán McNamara
and can use a simple vector here Change-Id: If27e881c4ae7a1a068fdbb1c0a689ecc78804095
2017-03-18Revert "Revert "Implement export and import of author field in fixed format""Rosemary Sebastian
This reverts commit cae16645e17df6a1f87443c00b6abfd26dabd27f. Change-Id: If5b85beb53a0925909d537023879a7d86fa011cf Reviewed-on: https://gerrit.libreoffice.org/35391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com> Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-17tweak libjpeg to honor JPEGMEM and set it in file format testersCaolán McNamara
Change-Id: I6660ccc68d3c82bf6118c2106a9293fd37e801ae Reviewed-on: https://gerrit.libreoffice.org/35283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-17cleanup double includes and declarationsJochen Nitschke
Change-Id: I770e09f48b1a3e8299f59a8e475ba3c18d436d7b Reviewed-on: https://gerrit.libreoffice.org/35312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17convert SvxBorderStyle to scoped enumNoel Grandin
and rename to SvxBorderLineStyle Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc Reviewed-on: https://gerrit.libreoffice.org/35265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16Revert "Implement export and import of author field in fixed format"Rosemary Sebastian
This reverts commit 5de40734af30a8b897c6c5b7f681759e36a25557. Change-Id: Ib09fb1dc54066cadcd9503c92140d78e7482ae6c Reviewed-on: https://gerrit.libreoffice.org/35281 Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com> Tested-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-16ofz#877 reference to stack alloced obj outlives objCaolán McNamara
Change-Id: I8c854e2f651f8bf0018e8249827aae0fe23057e7
2017-03-16Resolves: tdf#106557 don't crash on missing line spacing argumentCaolán McNamara
this is all a bit addled, but at least don't crash Change-Id: I19c35205446cebc83b8299839bcab8e02ff7c07d
2017-03-16remove unused defines from HRC files in sdNoel Grandin
Change-Id: I2cbb6257aa65e45f3e46b64a8f00e36aecd95564 Reviewed-on: https://gerrit.libreoffice.org/35219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15tdf#105040 Notebookbar: added shortcuts toolboxSzymon Kłos
In the tabbed notebookbar the shortcuts toolbox is introduced. It is placed before tab labels, after the menu button. Customization is possible, buttons are loaded from the newly created toolbar "Notebookbar shortcuts". NotebookbarTabControl was moved to the sfx module. Change-Id: Ifa4a1688c6e92c2f03bd386608e3e9d1c28069d4 Reviewed-on: https://gerrit.libreoffice.org/35194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-15add ppt fuzzerCaolán McNamara
Change-Id: I283d24fc2d7420273c3769fcd4ea3938da85afb4
2017-03-15pesky hidden leak causing pptfuzzing oomCaolán McNamara
Change-Id: I08af0f9e62ffaa6d8e0021d4e95c4e945030403a
2017-03-15convert SvxFrameDirection to scoped enumNoel Grandin
Based on the casts in chart2/source/view/main/ChartView.cxx and the similarity of naming of values, I conclude that this enum was intended to abstract over css::text::WritingMode2. Added a comment to that effect. Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57 Reviewed-on: https://gerrit.libreoffice.org/35164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15remove unused HRC defines in sd/Noel Grandin
improve the existing 'find unused RID constants' script Change-Id: I6facbf9ef929bd31dc59eba4a1807c72b87cdb2f Reviewed-on: https://gerrit.libreoffice.org/35186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14No need for --disable-activex and --disable-atl any longerTor Lillqvist
Change-Id: I7ac4f32cb01bfcc3a2c06e69280c2150d408ec6b Reviewed-on: https://gerrit.libreoffice.org/35174 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-14uitest: add the impress zoom level to the state informationMarkus Mohrhard
Change-Id: I8c064788159b3cdd83f9ef0f4609e615db789cc3 Reviewed-on: https://gerrit.libreoffice.org/35147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-14sd lok: Don't search on master pages & notes in Impress.Jan Holesovsky
Change-Id: I43ed9f53618dca09e0289bffadc2c05056e0eebb Reviewed-on: https://gerrit.libreoffice.org/35149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-14sd: fix comparison between different enum typesJochen Nitschke
found while changing base of SvxFrameDirectionItem to SfxEnumItem > warning: comparison between ‘enum SvxFrameDirection’ > and ‘enum com::sun::star::text::WritingMode’ [-Wenum-compare] Change-Id: Ide7c8193fd700f2503b05322f0d4d38f465b12c5 Reviewed-on: https://gerrit.libreoffice.org/35148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-11Fix typosAndrea Gelmini
Change-Id: Ia79bc8d35cf19438d177f31a8e0c8603102b4ef1 Reviewed-on: https://gerrit.libreoffice.org/35061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-11Fix (German?) spelling mistakes in comments: s/save/safe (the adjective)Tor Lillqvist
Might be more of them left, I found these by looking for "is save" or "it save". Many more potential misspellings of "Safe" as "Save" in identifiers are left. Need to check individually which of them actually mean "Safe", which mean "Saved" perhaps. Change-Id: I5d3791ea2df2e1d485f65400404972b72af45aec
2017-03-10Implement export and import of author field in fixed formatRosemary Sebastian
Change-Id: I1975bfcdc8436f2b05e2fab2a4c9c09838330b30 Reviewed-on: https://gerrit.libreoffice.org/33520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rosemary Sebastian <rosemaryseb8@gmail.com>
2017-03-09valgrind: fix leakCaolán McNamara
==2184== 1,396 (24 direct, 1,372 indirect) bytes in 1 blocks are definitely lost in loss record 11,080 of 11,791 ... ==2184== by 0x31D4F774: sd::framework::BasicPaneFactory::createResource(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> const&) (BasicPaneFactory.cxx:258) ... ==2184== by 0x31D3F550: sd::framework::ConfigurationControllerResourceManager::ActivateResources(std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId>, std::allocator<com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> > > const&, com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&) (ConfigurationControllerResourceManager.cxx:74) ... ==2184== by 0x31D426A3: sd::framework::ConfigurationUpdater::UpdateCore(sd::framework::ConfigurationClassifier const&) (ConfigurationUpdater.cxx:247) ==2184== by 0x31D42B76: sd::framework::ConfigurationUpdater::UpdateConfiguration() (ConfigurationUpdater.cxx:156) ==2184== by 0x31D42F3E: sd::framework::ConfigurationUpdater::RequestUpdate(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&) (ConfigurationUpdater.cxx:103) Change-Id: I257ae26bc0e61696b1c8e27a1b3a75a993fac1a5 Reviewed-on: https://gerrit.libreoffice.org/34982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-08loplugin:loopvartoosmallStephan Bergmann
Change-Id: I4804a25046a35c24d19d578c014d8e52f62b70e8
2017-03-08convert SvxCaseMap to scoped enumNoel Grandin
Change-Id: Iea77ddc21e9b2d5a021c08e323da9ccabf9d46bd Reviewed-on: https://gerrit.libreoffice.org/34963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxAdjust to scoped enumNoel Grandin
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639 Reviewed-on: https://gerrit.libreoffice.org/34941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06make use of the SfxItemSet::GetItem<T> methodNoel Grandin
Change-Id: I8201429993129b019a6dd51c203a9f8dcbb2253e Reviewed-on: https://gerrit.libreoffice.org/34867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06remove some unnecessary use of OUString constructorNoel Grandin
found with git grep -nP '<<= OUString\(\w*[A-Za-z]+' Change-Id: I43354842f1e0418fb292f2e8e0cb30f1229d1c67 Reviewed-on: https://gerrit.libreoffice.org/34864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06Dia*Item classes are unusedNoel Grandin
Change-Id: I0546a15300312c19feaf701057ab0191547b9202 Reviewed-on: https://gerrit.libreoffice.org/34858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06cppcheck: knownConditionTrueFalseJochen Nitschke
> Condition '!bError' is always true Change-Id: I8dc7293ab57f765cc532565cac3d009742152387 Reviewed-on: https://gerrit.libreoffice.org/34911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-05cppcheck: knownConditionTrueFalseJochen Nitschke
> Condition 'nLevel==1' is always true Change-Id: If35c47af9bea87dbc93a011f0fb53cf966bf579f Reviewed-on: https://gerrit.libreoffice.org/34901 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-04tdf#106304: Output <a:br> instead of &#10; for hard newlinesTor Lillqvist
This fixes the problem that the line before the hard newline in the .pptx export is not centred. The fix for the sd_export_ooxml1 test is a bit hacky, but then so is the code in question. Change-Id: I4f89e9d0177ab3b16e8ec624a99fce9e2f8ef730
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03avoid config for ppt loader testingCaolán McNamara
Change-Id: I6508ea7da815290f3bd15ac1d012ebb745090b11
2017-03-03drop SvxNumType and rename SvxExtNumType->SvxNumTypeNoel Grandin
Both of them are abstractions over the css::style::NumberingType constants. SvxNumType serves no useful purpose, since it's just a typedef to sal_Int16. At least SvxExtNumType wraps up the css::style::NumberingType constants in a nice enum. Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e Reviewed-on: https://gerrit.libreoffice.org/34816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03use SvxExtNumType in SvxNumberTypeNoel Grandin
and follow the rabbit trail, fixing various other types in the process Change-Id: I8fc7df3b585df21578ffb28fdd7e5e427b3bfd9d Reviewed-on: https://gerrit.libreoffice.org/34814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03convert SfxEnumItem to type-safe template classNoel Grandin
and drop the SvxChartTextOrientItem class, unused. Change-Id: I99100837d1beb953450f57b2cda47d165df1620c Reviewed-on: https://gerrit.libreoffice.org/34747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02do item namespace dance for linking sd and merged into a single executableCaolán McNamara
Change-Id: Iad4549f3fdde53b8d654442b3a848ea1be6f245a
2017-03-02Fix typosAndrea Gelmini
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-01 18:34:30 +0000