summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 962, 979 Change-Id: Ic31a6129828a41bd3450567ca8cb8884d60691cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175220 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 944, 957 Change-Id: Ic637d4aa5e6024cc0011e8e51a0fba68c2644378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175225 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 685, 689 Change-Id: I3c35e7d89699e64693c04da554136f8747fd0dde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175347 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 718, 724 Change-Id: Id39e264626634ab4288e41bd6d72303a3820a10d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175319 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-29sd: lokit: add notes to presentation infoHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I1293a392749b6cff75be02236fb570f8faeb2446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174613 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175757 Tested-by: Jenkins
2024-10-29test: Merge SwAccessibleTestBase and AccessibleTestBaseXisco Fauli
Change-Id: Ic62bd287406326f4c3d3e0702850fe0337f17686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175762 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-29UnoApiTest: rename load to loadFromURL and use it everywhereXisco Fauli
Change-Id: Ie67eebec74f783fa0c29acfb23bb83bc582812b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175724 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-29Simplify a bitMike Kaganski
Change-Id: Ia0225e6053112a88db3641ba653e2af7cc702f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175749 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-28don't use iterateItemSurrogates for EE_FEATURE_FIELDNoel Grandin
Change-Id: I96cd1728e2358d4ea49275952726aae85e6f52a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175726 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-28cid#1607729 Overflowed constantNoel Grandin
Change-Id: Iebfcb18a764a432f3bd56b98225e27fb5081737f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175721 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-27cid#1555789 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556865 COPY_INSTEAD_OF_MOVE cid#1556871 COPY_INSTEAD_OF_MOVE cid#1556939 COPY_INSTEAD_OF_MOVE cid#1556951 COPY_INSTEAD_OF_MOVE cid#1556964 COPY_INSTEAD_OF_MOVE cid#1556966 COPY_INSTEAD_OF_MOVE cid#1556968 COPY_INSTEAD_OF_MOVE cid#1556971 COPY_INSTEAD_OF_MOVE cid#1556989 COPY_INSTEAD_OF_MOVE cid#1557001 COPY_INSTEAD_OF_MOVE cid#1557011 COPY_INSTEAD_OF_MOVE cid#1557032 COPY_INSTEAD_OF_MOVE cid#1557038 COPY_INSTEAD_OF_MOVE cid#1557041 COPY_INSTEAD_OF_MOVE cid#1557055 COPY_INSTEAD_OF_MOVE cid#1557056 COPY_INSTEAD_OF_MOVE cid#1557057 COPY_INSTEAD_OF_MOVE cid#1557065 COPY_INSTEAD_OF_MOVE cid#1557068 COPY_INSTEAD_OF_MOVE cid#1557087 COPY_INSTEAD_OF_MOVE cid#1557090 COPY_INSTEAD_OF_MOVE cid#1557093 COPY_INSTEAD_OF_MOVE cid#1557113 COPY_INSTEAD_OF_MOVE cid#1557122 COPY_INSTEAD_OF_MOVE cid#1557126 COPY_INSTEAD_OF_MOVE cid#1557145 COPY_INSTEAD_OF_MOVE cid#1557151 COPY_INSTEAD_OF_MOVE cid#1557152 COPY_INSTEAD_OF_MOVE cid#1557197 COPY_INSTEAD_OF_MOVE cid#1557216 COPY_INSTEAD_OF_MOVE cid#1557245 COPY_INSTEAD_OF_MOVE cid#1557272 COPY_INSTEAD_OF_MOVE cid#1557310 COPY_INSTEAD_OF_MOVE cid#1557314 COPY_INSTEAD_OF_MOVE cid#1557318 COPY_INSTEAD_OF_MOVE cid#1557333 COPY_INSTEAD_OF_MOVE cid#1557340 COPY_INSTEAD_OF_MOVE cid#1557358 COPY_INSTEAD_OF_MOVE cid#1557359 COPY_INSTEAD_OF_MOVE cid#1557365 COPY_INSTEAD_OF_MOVE cid#1557367 COPY_INSTEAD_OF_MOVE cid#1557395 COPY_INSTEAD_OF_MOVE cid#1557418 COPY_INSTEAD_OF_MOVE cid#1557488 COPY_INSTEAD_OF_MOVE cid#1557493 COPY_INSTEAD_OF_MOVE cid#1557506 COPY_INSTEAD_OF_MOVE cid#1557514 COPY_INSTEAD_OF_MOVE cid#1557528 COPY_INSTEAD_OF_MOVE cid#1557534 COPY_INSTEAD_OF_MOVE cid#1557537 COPY_INSTEAD_OF_MOVE cid#1557562 COPY_INSTEAD_OF_MOVE cid#1557563 COPY_INSTEAD_OF_MOVE cid#1557592 COPY_INSTEAD_OF_MOVE cid#1557608 COPY_INSTEAD_OF_MOVE cid#1557615 COPY_INSTEAD_OF_MOVE cid#1557619 COPY_INSTEAD_OF_MOVE cid#1557637 COPY_INSTEAD_OF_MOVE cid#1557648 COPY_INSTEAD_OF_MOVE cid#1557712 COPY_INSTEAD_OF_MOVE cid#1557750 COPY_INSTEAD_OF_MOVE cid#1557762 COPY_INSTEAD_OF_MOVE cid#1557765 COPY_INSTEAD_OF_MOVE Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-27tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 681, 686 Change-Id: Ifbd5935a3bc2693d7d63c0791d7960f1a69e8d5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175348 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-27cid#1608184 silence Overflowed constantCaolán McNamara
Change-Id: Ifb16694334fa0f0aa58cbe99075712046473404d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-27tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 235, 249 Change-Id: If20872264edda30a8854e40787b73060990d2224 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175392 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-26cid#1556875 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556891 COPY_INSTEAD_OF_MOVE cid#1556903 COPY_INSTEAD_OF_MOVE cid#1556917 COPY_INSTEAD_OF_MOVE cid#1556925 COPY_INSTEAD_OF_MOVE cid#1557021 COPY_INSTEAD_OF_MOVE cid#1557092 COPY_INSTEAD_OF_MOVE cid#1557119 COPY_INSTEAD_OF_MOVE cid#1557218 COPY_INSTEAD_OF_MOVE cid#1557342 COPY_INSTEAD_OF_MOVE cid#1557727 COPY_INSTEAD_OF_MOVE cid#1557800 COPY_INSTEAD_OF_MOVE cid#1557821 COPY_INSTEAD_OF_MOVE cid#1557830 COPY_INSTEAD_OF_MOVE cid#1557677 COPY_INSTEAD_OF_MOVE cid#1557674 COPY_INSTEAD_OF_MOVE Change-Id: I20dab0c49a17c28b4feaf97440a36d4962310b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-26cid#1608133 Overflowed constantCaolán McNamara
Change-Id: I38651265938cf076078c34f359b7f3f9ea3728c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-26cid#1555767 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555770 COPY_INSTEAD_OF_MOVE cid#1555788 COPY_INSTEAD_OF_MOVE cid#1555789 COPY_INSTEAD_OF_MOVE cid#1555798 COPY_INSTEAD_OF_MOVE cid#1555816 COPY_INSTEAD_OF_MOVE cid#1555822 COPY_INSTEAD_OF_MOVE cid#1555835 COPY_INSTEAD_OF_MOVE cid#1555845 COPY_INSTEAD_OF_MOVE cid#1555859 COPY_INSTEAD_OF_MOVE cid#1555864 COPY_INSTEAD_OF_MOVE cid#1555868 COPY_INSTEAD_OF_MOVE cid#1555892 COPY_INSTEAD_OF_MOVE cid#1555896 COPY_INSTEAD_OF_MOVE cid#1555921 COPY_INSTEAD_OF_MOVE cid#1555932 COPY_INSTEAD_OF_MOVE cid#1555935 COPY_INSTEAD_OF_MOVE cid#1555944 COPY_INSTEAD_OF_MOVE cid#1555952 COPY_INSTEAD_OF_MOVE cid#1555985 COPY_INSTEAD_OF_MOVE cid#1556024 COPY_INSTEAD_OF_MOVE cid#1556038 COPY_INSTEAD_OF_MOVE cid#1556042 COPY_INSTEAD_OF_MOVE cid#1556044 COPY_INSTEAD_OF_MOVE cid#1556060 COPY_INSTEAD_OF_MOVE cid#1556083 COPY_INSTEAD_OF_MOVE cid#1556085 COPY_INSTEAD_OF_MOVE cid#1556090 COPY_INSTEAD_OF_MOVE cid#1556136 COPY_INSTEAD_OF_MOVE cid#1556157 COPY_INSTEAD_OF_MOVE cid#1556159 COPY_INSTEAD_OF_MOVE cid#1556172 COPY_INSTEAD_OF_MOVE cid#1556179 COPY_INSTEAD_OF_MOVE cid#1556187 COPY_INSTEAD_OF_MOVE cid#1556255 COPY_INSTEAD_OF_MOVE cid#1556256 COPY_INSTEAD_OF_MOVE cid#1556266 COPY_INSTEAD_OF_MOVE cid#1556275 COPY_INSTEAD_OF_MOVE cid#1556290 COPY_INSTEAD_OF_MOVE cid#1556294 COPY_INSTEAD_OF_MOVE cid#1556301 COPY_INSTEAD_OF_MOVE cid#1556311 COPY_INSTEAD_OF_MOVE cid#1556318 COPY_INSTEAD_OF_MOVE cid#1556326 COPY_INSTEAD_OF_MOVE cid#1556369 COPY_INSTEAD_OF_MOVE cid#1556374 COPY_INSTEAD_OF_MOVE cid#1556387 COPY_INSTEAD_OF_MOVE cid#1556388 COPY_INSTEAD_OF_MOVE cid#1556417 COPY_INSTEAD_OF_MOVE cid#1556425 COPY_INSTEAD_OF_MOVE cid#1556435 COPY_INSTEAD_OF_MOVE cid#1556495 COPY_INSTEAD_OF_MOVE cid#1556497 COPY_INSTEAD_OF_MOVE cid#1556501 COPY_INSTEAD_OF_MOVE cid#1556503 COPY_INSTEAD_OF_MOVE cid#1556520 COPY_INSTEAD_OF_MOVE cid#1556523 COPY_INSTEAD_OF_MOVE cid#1556562 COPY_INSTEAD_OF_MOVE cid#1556573 COPY_INSTEAD_OF_MOVE cid#1556576 COPY_INSTEAD_OF_MOVE cid#1556598 COPY_INSTEAD_OF_MOVE cid#1556615 COPY_INSTEAD_OF_MOVE cid#1556626 COPY_INSTEAD_OF_MOVE cid#1556671 COPY_INSTEAD_OF_MOVE cid#1556689 COPY_INSTEAD_OF_MOVE cid#1556701 COPY_INSTEAD_OF_MOVE cid#1556713 COPY_INSTEAD_OF_MOVE cid#1556758 COPY_INSTEAD_OF_MOVE cid#1556759 COPY_INSTEAD_OF_MOVE cid#1556788 COPY_INSTEAD_OF_MOVE cid#1556811 COPY_INSTEAD_OF_MOVE cid#1556821 COPY_INSTEAD_OF_MOVE cid#1556824 COPY_INSTEAD_OF_MOVE cid#1556825 COPY_INSTEAD_OF_MOVE cid#1556862 COPY_INSTEAD_OF_MOVE Change-Id: I4925a79688a983bb07252600430039ec0bcb75b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175678 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-25tdf#95680 Convert - Metafile - Save Image... No function.Noel Grandin
The obvious fix seems to work Change-Id: Iabbde43f18b49f19149a9a7ee44efd0b6b445736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-25fix: repeat slideshow duration display issueJaviya Vivekkumar Dineshbhai
Change-Id: Id762a2f0ca9ad1603dff42fbd1ad992282933007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175629 Tested-by: Jenkins Reviewed-by: vivek javiya <vivek.javiya@collabora.com>
2024-10-25tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 282, 296 Change-Id: Ie74d4b31246ba279ad7e1e585036b1b06ad3fabe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175424 Reviewed-by: Jack Honour <JaxkDev@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-10-25cid#1633347 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1633346 COPY_INSTEAD_OF_MOVE cid#1633344 COPY_INSTEAD_OF_MOVE cid#1633343 COPY_INSTEAD_OF_MOVE cid#1633340 COPY_INSTEAD_OF_MOVE cid#1608137 COPY_INSTEAD_OF_MOVE cid#1608131 COPY_INSTEAD_OF_MOVE cid#1607860 COPY_INSTEAD_OF_MOVE cid#1607432 COPY_INSTEAD_OF_MOVE cid#1607394 COPY_INSTEAD_OF_MOVE cid#1607310 COPY_INSTEAD_OF_MOVE cid#1607156 COPY_INSTEAD_OF_MOVE cid#1607093 COPY_INSTEAD_OF_MOVE cid#1607090 COPY_INSTEAD_OF_MOVE cid#1607039 COPY_INSTEAD_OF_MOVE cid#1606709 COPY_INSTEAD_OF_MOVE cid#1558053 COPY_INSTEAD_OF_MOVE cid#1558052 COPY_INSTEAD_OF_MOVE cid#1558042 COPY_INSTEAD_OF_MOVE cid#1558038 COPY_INSTEAD_OF_MOVE cid#1558037 COPY_INSTEAD_OF_MOVE cid#1558034 COPY_INSTEAD_OF_MOVE cid#1558031 COPY_INSTEAD_OF_MOVE cid#1558027 COPY_INSTEAD_OF_MOVE cid#1557994 COPY_INSTEAD_OF_MOVE cid#1557977 COPY_INSTEAD_OF_MOVE cid#1557970 COPY_INSTEAD_OF_MOVE cid#1557966 COPY_INSTEAD_OF_MOVE cid#1557957 COPY_INSTEAD_OF_MOVE cid#1557954 COPY_INSTEAD_OF_MOVE cid#1557941 COPY_INSTEAD_OF_MOVE cid#1557933 COPY_INSTEAD_OF_MOVE cid#1557918 COPY_INSTEAD_OF_MOVE cid#1557907 COPY_INSTEAD_OF_MOVE cid#1557890 COPY_INSTEAD_OF_MOVE cid#1557883 COPY_INSTEAD_OF_MOVE cid#1557881 COPY_INSTEAD_OF_MOVE cid#1557861 COPY_INSTEAD_OF_MOVE cid#1557842 COPY_INSTEAD_OF_MOVE cid#1557840 COPY_INSTEAD_OF_MOVE cid#1557830 COPY_INSTEAD_OF_MOVE cid#1557830 COPY_INSTEAD_OF_MOVE Change-Id: If5ee3396eafdb8b338d9e6cf0705be6e2b431fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-25cid#1633779 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1633350 COPY_INSTEAD_OF_MOVE cid#1633349 COPY_INSTEAD_OF_MOVE cid#1633348 COPY_INSTEAD_OF_MOVE Change-Id: I58d82029647a6661983465efa2c2abc17a5744c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-25Related: tdf#159860 inform if there is > 100 master slidesCaolán McNamara
which is atypical and easy to not notice when it happens Change-Id: I16546b0e841771c746cd33fefd7ec15e2877b08d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-24slideshow: improve grammar for repeat slideshow in sidebarJaviya Vivekkumar Dineshbhai
Change-Id: Ibe3ca1c11a9dcbb82cadc0ab531e9a69fe275769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175535 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-23tdf#163486: PVS: check mpViewShXisco Fauli
V595 The 'mpView' pointer was utilized before it was verified against nullptr. Check lines: 719, 720. Change-Id: Ie1bda82df979fd5f293fb6eb9623917371e9da34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-23tdf#162245 Insert->Comment in Draw/Impress not incrementally numberedNoel Grandin
fix numbering. regression from commit e17c56bfc7930d3c14c3ff4cfd59828e8dcc0229 Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Thu Jun 6 10:52:35 2024 +0900 annot: new Annotation sdr object, replacing annotation tags Change-Id: I7f649346422886ab2e27a06b03b359ab395ec4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175411 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-22cid#1555259 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555264 COPY_INSTEAD_OF_MOVE cid#1555280 COPY_INSTEAD_OF_MOVE cid#1555303 COPY_INSTEAD_OF_MOVE cid#1555313 COPY_INSTEAD_OF_MOVE cid#1555314 COPY_INSTEAD_OF_MOVE cid#1555323 COPY_INSTEAD_OF_MOVE cid#1555333 COPY_INSTEAD_OF_MOVE cid#1555338 COPY_INSTEAD_OF_MOVE cid#1555349 COPY_INSTEAD_OF_MOVE cid#1555364 COPY_INSTEAD_OF_MOVE cid#1555379 COPY_INSTEAD_OF_MOVE cid#1555398 COPY_INSTEAD_OF_MOVE cid#1555410 COPY_INSTEAD_OF_MOVE cid#1555411 COPY_INSTEAD_OF_MOVE cid#1555416 COPY_INSTEAD_OF_MOVE cid#1555429 COPY_INSTEAD_OF_MOVE cid#1555434 COPY_INSTEAD_OF_MOVE cid#1555441 COPY_INSTEAD_OF_MOVE cid#1555446 COPY_INSTEAD_OF_MOVE cid#1555480 COPY_INSTEAD_OF_MOVE cid#1555490 COPY_INSTEAD_OF_MOVE cid#1555524 COPY_INSTEAD_OF_MOVE cid#1555527 COPY_INSTEAD_OF_MOVE cid#1555531 COPY_INSTEAD_OF_MOVE cid#1555578 COPY_INSTEAD_OF_MOVE cid#1555581 COPY_INSTEAD_OF_MOVE cid#1555591 COPY_INSTEAD_OF_MOVE cid#1555614 COPY_INSTEAD_OF_MOVE cid#1555619 COPY_INSTEAD_OF_MOVE cid#1555633 COPY_INSTEAD_OF_MOVE cid#1555654 COPY_INSTEAD_OF_MOVE cid#1555707 COPY_INSTEAD_OF_MOVE cid#1555712 COPY_INSTEAD_OF_MOVE cid#1555746 COPY_INSTEAD_OF_MOVE cid#1555763 COPY_INSTEAD_OF_MOVE Change-Id: Ibcc1a3649c5663328e60474c06e51902aa74db52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175407 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-22lok: fix repeat slideshow after duration issueJaviya Vivekkumar Dineshbhai
Change-Id: I0b84d003ab3345bc89482e9940a4f0d11f33e427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-22cid#1545605 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545841 COPY_INSTEAD_OF_MOVE cid#1554682 COPY_INSTEAD_OF_MOVE cid#1554686 COPY_INSTEAD_OF_MOVE cid#1554715 COPY_INSTEAD_OF_MOVE cid#1554750 COPY_INSTEAD_OF_MOVE cid#1554759 COPY_INSTEAD_OF_MOVE cid#1554770 COPY_INSTEAD_OF_MOVE cid#1554779 COPY_INSTEAD_OF_MOVE cid#1554794 COPY_INSTEAD_OF_MOVE cid#1554800 COPY_INSTEAD_OF_MOVE cid#1554826 COPY_INSTEAD_OF_MOVE cid#1554836 COPY_INSTEAD_OF_MOVE cid#1554862 COPY_INSTEAD_OF_MOVE cid#1554865 COPY_INSTEAD_OF_MOVE cid#1554872 COPY_INSTEAD_OF_MOVE cid#1554883 COPY_INSTEAD_OF_MOVE cid#1554906 COPY_INSTEAD_OF_MOVE cid#1554921 COPY_INSTEAD_OF_MOVE cid#1554926 COPY_INSTEAD_OF_MOVE cid#1554946 COPY_INSTEAD_OF_MOVE cid#1554956 COPY_INSTEAD_OF_MOVE cid#1554970 COPY_INSTEAD_OF_MOVE cid#1554986 COPY_INSTEAD_OF_MOVE cid#1554991 COPY_INSTEAD_OF_MOVE cid#1555013 COPY_INSTEAD_OF_MOVE cid#1555037 COPY_INSTEAD_OF_MOVE cid#1555050 COPY_INSTEAD_OF_MOVE cid#1555057 COPY_INSTEAD_OF_MOVE cid#1555066 COPY_INSTEAD_OF_MOVE cid#1555067 COPY_INSTEAD_OF_MOVE cid#1555083 COPY_INSTEAD_OF_MOVE cid#1555097 COPY_INSTEAD_OF_MOVE cid#1555135 COPY_INSTEAD_OF_MOVE cid#1555140 COPY_INSTEAD_OF_MOVE cid#1555146 COPY_INSTEAD_OF_MOVE cid#1555148 COPY_INSTEAD_OF_MOVE cid#1555149 COPY_INSTEAD_OF_MOVE cid#1555155 COPY_INSTEAD_OF_MOVE cid#1555157 COPY_INSTEAD_OF_MOVE cid#1555168 COPY_INSTEAD_OF_MOVE cid#1555195 COPY_INSTEAD_OF_MOVE cid#1555196 COPY_INSTEAD_OF_MOVE cid#1555237 COPY_INSTEAD_OF_MOVE Change-Id: I90531c19c28dca77fe99c72efdfc0972c311da98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-22We don't need a virtual hereCaolán McNamara
Only known SdPages need this Change-Id: Id504cd1ec318fa8cce43d11f03c628e7457f7634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175369 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-22move vcl::DeleteOnDeinit to toolsNoel Grandin
so we can fix a shutdown use-after-free in sot. Change-Id: I32f83bd94627d72d7bee7ea2ebd6ab77a7f78435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-22set stylesheet parent at creation timeNoel Grandin
avoids a bunch of broadcasting. a similar mega-master-page scenario as reported in tdf#158773 9.1 - 7.0s Some re-ordering of SVG output occurs, which means tweaking some unit tests. Change-Id: I447a4639a96c12c627a074f7e0f1ede8b3cbaf72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21don't need to const_cast away constness for SdPageCaolán McNamara
Change-Id: I44fd36841319eeb3deda7becaf04ec3188586788 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21improve style searching in SvXMLStylesContextNoel Grandin
We can searching without needing a std::map by sorting the style list. Which also allows to do prefix searching. Which we can use to dramatically reduce the number of styles we need to loop through in SdXMLStylesContext::ImpSetGraphicStyles. a similar mega-master-page scenario as reported in tdf#158773 13.5 - 9.1s Needed to adjust some unit tests because the order of iteration through styles is now different, which affects some file output. Change-Id: Ia7240fe520b70839d2519eba1fb70819a3c3bf81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175281 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-21set master slide name at creation timeNoel Grandin
which avoids some expensive broadcasting when the name is changed a similar mega-master-page scenario as reported in tdf#158773 48s -> 20s Change-Id: Ifcfd96077a9e83868ac96671ce9f208ae3ca418f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175126 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21lok: enable additional transition uno commandsJaviya Vivekkumar Dineshbhai
Change-Id: I424f08cf6b7ffba54ff3e20b9a8a49c20c7dcd40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175295 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-21Make tools::Time ctor taking sal_Int64 privateMike Kaganski
This ctor is meant to set the value of nTime directly; and that value is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK. But in some places, this ctor was misused for setting of nanoseconds, which would only accidentally work for values less than one second. All places that initialized tools::Time with 0, now use EMPTY. This makes the ctor private; and for the very few cases where really the encoded value of nTime is stored / restored, fromEncodedTime is introduced. Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-21vcl: move bitmap filter headers into vcl/bitmap global header directoryChris Sherlock
Use #pragma once instead of header guards Change-Id: Iba43f2103628ed184933cf2611991e7aef9f0173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173369 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-10-19Fix typo in codeAndrea Gelmini
Change-Id: I8f825d42024edc874e1f5aaff1de4eef2b3b1e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175170 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-10-19cid#1608219 silence Overflowed constantCaolán McNamara
and cid#1608307 Overflowed constant cid#1606687 Overflowed integer argument Change-Id: I043f3e49810ca441453af88866a1156f47e6cd87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175177 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-18lok: enable transition repeat after x propertyJaviya Vivekkumar Dineshbhai
Change-Id: I61bd2ebaebfb19350aa3b3634f5877c0bfa05880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171773 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-18change misleading var prefixCaolán McNamara
Change-Id: I0e59d51cbbb7b9d7481d028fb0c682e108b0e7d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175118 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-18tdf#163486: PVS: recurring checkXisco Fauli
V571: Recurring check. The 'xObj' condition was already verified in line 809. Change-Id: I4b782c9601893ad91598382ea2f999cbd46df75b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175104 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-18tdf#163486: PVS: check GetView()Xisco Fauli
V595 The 'GetView()' pointer was utilized before it was verified against nullptr. Check lines: 518, 531. Change-Id: I9c6ebccabece0923702e6a8fb4ee6beb9b6dc198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175114 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-18tdf#163486: PVS: check mpViewShXisco Fauli
V595 The 'mpViewSh' pointer was utilized before it was verified against nullptr. Check lines: 704, 713. Change-Id: I5c1902d9aa9a33e62cf2aa559bab9c0b3f45f688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175112 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-18tdf#163486: PVS: condition is always trueXisco Fauli
V654 The condition '!bFound' of loop is always true. Change-Id: Ib37444255641f902a6833e222dfe1ee001376ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175110 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17tdf#34804 sd: enable keyboard shortcut for CharColor and CharBackColorJustin Luth
A followup patch that adds keyboard shortcut support to Draw/Impress for .uno:Color and .uno:CharBackColor to use recentColor. Change-Id: I1eea3b8330ca3c10e20b13e0fa83c15418eee6a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174828 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-10-17lok: sd: transition information: export fade colorMarco Cecchetti
Change-Id: I955c18cc5d131cfa5a246bb4506a81b8cf40b7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175071 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-17we don't need to copy the Name here, a reference is sufficientCaolán McNamara
48s -> 47.8s Change-Id: Ib95b701d424b0b92aa3848b75f81c41eff0af2ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175029 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-16tdf#162571 - sd: Text box expands or shrinks on left or right orBalazs Varga
both sides, depending on the text alignment. Set the text anchor position based on the first paragraph alignment. WIP: testing... Change-Id: Ie1588c3eab5dd24eddb20baf342aca57c0dd39fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174885 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-03 16:39:07 +0000