summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2023-08-11lok: a11y: get focused paragraph notified on document loadMarco Cecchetti
Usually, when the document is loaded, a CARET_CHANGED accessibility event is automatically emitted for the first paragraph. That allows to notify the paragraph content to the client, even if no input event occurred yet. However, in Cypress tests no accessibility event is automatically emitted until some input event occurs. So we use the workaround in this patch to notify the content of the focused paragraph, without waiting for an input event. (cherry picked from commit d6f929c03ca08a0c1134937a1ff1a42f75221e93) Change-Id: I8696c5f9ea069824614e9b541f4959b315dbda5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155575 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I09285716b6d17d8de95af91d822966520af35605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-05cid#1539501 Unchecked dynamic_castCaolán McNamara
Change-Id: I5b369c51259036e02609e5ad66b882063aa9e309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155369 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-04oox: default first line indent is 0Szymon Kłos
When First Line Indent was defined in paragraph properties Impress remembered that value and applied for the next paragraph. Let's set it to default value (0) if property is not set explicitly. Change-Id: I3b075fab594fce64d953553634a49b9769c9341c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155336 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-08-04pptx: import shape text from master pageSzymon Kłos
If shape has custom text defined in master page but no text itself - don't prefer placeholder text but text from master page. Change-Id: Id4f7aeca0e74ecd8565905cd656a182c1195fa30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154980 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155335 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-08-03UITest_validity: use oneprocess modeMiklos Vajna
Before: 0m44,958s After: 0m29,853s Also UITest_chapterNumbering: 0m27,926s -> 0m20,910s Change-Id: I0172e3d96a4e6d19e3cf1e98fb9145b9bae1096e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155267 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-01Allow getViewRenderState to get from a specific viewParis Oplopoios
getViewRenderState would get its output from the current view, make it so that it's possible to specify a specific view Change-Id: I279b215f8311b079c220c79b8b41c76bc0210154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154943 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit eff5643dbc5bb9dfede530e8e07261bb9bdc98f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155046 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-07-28SfxMedium::GetItemSet never returns nullptrMike Kaganski
Change-Id: Ibfc98a49022aa09ebf5315e5d3328308c1e51d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154997 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-27tdf#112594: Group NNBSP with the Mongolian characters after itKhaled Hosny
Narrow No Break Space has special uses in Mongolian, so we want to make sure it is in the same portion as the Mongolian text, even when it comes after text from another script group. We limit this to Mongolian to minimize potential side effects. Change-Id: Idb4c64cec8581e56acfe9bbb8adf4ddc213aaf19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155000 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-25keep gtk3->gtk4 automigration rulesCaolán McNamara
Change-Id: Ie66f1343dffce441836beaf5a779b32b92e3bbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-25fix .ui indentCaolán McNamara
Change-Id: Ib6ebed36b857d5ffa449f66319ef67f2f84722dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-25Convert internal vcl bitmap formats transparency->alpha (II)Noel Grandin
(Second attempt at landing this) Image formats and graphics APIs use alpha, not transparency, so change our internal formats and data structures to work directly with alpha, so we don't need to modify data before we push it to graphics APIs. Add a couple of new Color constants to make the intention of the vcl code clearer. Notes (*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask to more accurately reflect the requirements of the CGImageCreateWithMask function seems to fix some tests. (*) The vcl code does not properly support gradients with transparency. So the previous code was wrong, and this change is going to result in slightly different wrongness. Change-Id: I9e21c2e98d88ecfdc5f75db13bd1ffff7c38db98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114168 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-23remove some unused #definesNoel Grandin
Change-Id: I2c8168cd804ae8d1e4effa61be1d9dc902ecf9b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-23cid#1539070 Dereference before null checkCaolán McNamara
Change-Id: I32bb7a7e6689b5b9cf9847726cc813ddb2404e56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154792 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-23cid#1538306 Uncaught exceptionCaolán McNamara
and cid#1538308 Uncaught exception Change-Id: Ifd274b71e9fc1d744799451f460fdcb0ee1ca91d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-23vcl: Drop now unneeded DevicePoint typedefKhaled Hosny
It has been always typedef'd to basegfx::B2DPoint since: commit 5e218b5c51f7d9cd10bd9db832879efca41b9c75 Date: Wed Jan 12 21:19:32 2022 +0000 always use B2DPoint for DevicePoint Change-Id: I9f5202d5a71c77dd79f1759923917c26bf68a9af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154632 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-23tdf#156234: Don’t round glyph coordinates when doing subpixel positioningKhaled Hosny
When doing subpixel positioning (i.e. OutputDevice is in map mode), delay the rounding of the glyph coordinates after converting from pixel to logical units to minimize the loss of precision as much as possible. Some test expectations, expectedly, changes due to the improved positioning precision. Change-Id: I2591e3c7d4923ba7886a35bf53db759273354e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-21loplugin:unusedmethodsNoel Grandin
Change-Id: Id2bbe63ca8d4255fd883798581ac7fa1fda7dba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-21tdf#50725: sd: add new configuration option DragThresholdPixelsSarper Akdemir
Adds new expert configuration option DragThresholdPixels for Impress and Draw under Misc/DragThresholdPixels. Also bumps up the previous hardcoded default value from 2 to 6. Assuming this value was set when 640x480 resolution was the most common resolution, currently scaling the hardcoded default by 3 makes sense. (eg. GTK uses 8 pixels as the default) Change-Id: I35c0eed3ce477685c759f517471ce0bdc8315864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154379 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-07-21loplugin:redundantcast small improvementNoel Grandin
Change-Id: I2c96b367138b94d6178a3c4a0f83049f13a04f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-21Assume that all modern X servers have a unified display areaNoel Grandin
Change-Id: I704e6147085b2eca7fc6fd93261aced3e04b2fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154667 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-21tdf#152992: for Impress/Draw add horizontal hit tolerance for quick text editSarper Akdemir
Implements horizontal hit tolerance for quick text edit in Impress & Draw making it more forgiving. Previously it was required to click exactly on the glyph to get a direct text cursor. Refactors hittestprocessor2d so that it now supports pseudo per axis hit tolerance. i.e. underlying isInEpsilonRange hit check is still the same utilizing the larger tolerance of the two per axis tolerance, but the preliminary check that uses aPolygonRange.grow() and later aPolygonRange.isInside() now filters hit misses out with respect to the per axis hit tolerance. Utilizes hittestprocessor2d's new per axis tolerance to introduce hit tolerance for quick text edit, making it similar to TextEdit mode hit tolerance which only has horizontal tolerance. Fixes wrong use of BoundRect hit to determine text frame border hits. Which previously only made sense for TextFrame borders, and was mostly useless for shapes with text inside. Change-Id: I749e63752da05b01270bfcab2632c41879a848ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154640 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-07-20split GetWindowExtentsRelative asunderNoel Grandin
sometimes it returns a relative position, sometimes an absolute position. Rather have two different methods with names that match what they return. Change-Id: Ie1e73c6be1c797fd59934c96866d1fef1f972b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-19tdf#130581 - Improve unit test of undo command for hide/show slidesAndreas Heinisch
The test has the following structure: 1. The first slide will be selected and set to hidden 2. Then, the test checks if the slide is hidden and if there is the undo command for hiding the slide 3. Second, hiding the slide will be undone 4. Again, the test checks if the slide is visible and if there is the redo command for hiding the slide Finally, the same actions will be tested using the show slide command where the tests checks for two undo actions, i.e., show and hide slide. Change-Id: I8e9c4905f4ebbb45d872f5e6ca76179dbfae3a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154464 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-07-18tdf#126095 sd notebookbar: don't force table/media toolbarJustin Luth
Perhaps the entire function could return early in case the notebookbar is active, but only if all of them have a context notebookbar tab. Some of them I can't check since I don't know how to trigger them. Images, media, and tables all do have a context bar. (Media's bar is missing useful things like location, mute, and even file-location path. (Those will come separately in another commit.) Change-Id: Ic4623a1cab3abc1ac1f83622cbd11e549d2b0b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154559 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-18related tdf#126095 sd notebookbar: give room to .uno:AVMediaToolBoxJustin Luth
There are lots of controls on the media player (like mute, position etc) that are obviously not accessible if the control is squished to a small size. Giving full access is especially important if we do not show the extra toolbar, but depend on this notebookbar context switch. Change-Id: Ie766c426182469015a3431b83c852ce16d7436f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154560 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-17tdf#156308: Restore use of /org.openoffice.Office.Recovery/AutoSaveMike Kaganski
... instead of respective values from /org.openoffice.Office.Common/Save/Document The history of the problem: d0f9685d2cfc3927add412b276c804dcc20cb6a5 (2004-11-26) made SvtSaveOptions use org.openoffice.Office.Recovery/AutoSave, *in addition* to org.openoffice.Office.Common/Save/Document/*, as "forward AutoSave/AutoSaveTime to new config location" part of i#27726; at this point, org.openoffice.Office.Recovery/AutoSave/* took precedence (they were read last). 8e6031e126782ced6d7527b19cf817395e9b63e4 (2004-11-26) implemented autorecovery.cxx, already reading org.openoffice.Office.Recovery/AutoSave/* d5b9283985633fdb423269cab961bba2acc3539e (2021-07-25) made SvxSaveTabPage and SfxApplication::SetOptions_Impl use officecfg::Office::Common::Save::Document::* instead of SvtSaveOptions. 134f40136a9bea265d8f2fedfdb41a1e65d81b49 (2021-07-25) dropped SvtSaveOptions_Impl::ImplCommit, and its saving of officecfg::Office::Recovery::AutoSave::* (which likely detached officecfg::Office::Recovery::AutoSave from officecfg::Office::Common::Save::Document, making UI edits not stored to the former). aeb8a0076cd5ec2836b3dfc1adffcced432f995f (2022-05-23) made AutoRecovery::implts_readAutoSaveConfig read officecfg::Office::Common::Save::Document::* instead of proper officecfg::Office::Recovery::AutoSave::*. This change restores the intended use, and deprecates corresponding values in /org.openoffice.Office.Common/Save/Document. Change-Id: I33d48e3945326c80d356bfc930ed8a7f042c982b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154500 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-17tdf#130581 - Add undo command for hide/show slidesAndreas Heinisch
Change-Id: I7305e222df65fda6523940ca63f5759857c94bea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153375 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-07-15Resolves tdf#156182 - Automatic text color unreadable with darker cellsHeiko Tietze
Change-Id: Ia5e405fc05613726b5011174c8d00ca204eb31b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154352 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-07-13tdf#153446 sd FuText: handle mouse-up without mouse-downJustin Luth
This is a follow-up to the previous commit which did the same thing to all of the other FuConstruct elements. It isn't essential to have for FuText, just nice for consistency. FuText is much more complex than the other FuConstructs, and has been this complex since initial import. In patchset1, I removed a large chunk of code that I assume is now obsolete with my change, but now I just left it in. Without any documentation or unit tests, it is hard to know for sure why this function creates a textbox on mouse-up. So I chickened out and did the smart thing of just leaving stuff I don't know anything at all about alone. Change-Id: I105178e6af343eed505a803c6c3642eec073f6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154083 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-12tdf#153446 sd fuconstruct: handle mouse-up without mouse-downJustin Luth
The situation where this was happening occurred when the notebookbar had a pop-out of additional functions available. This pop-out removed the focus from the draw window, so the mouse-down was used to regain focus in Draw. The mouse-up just needed to be absorbed or else the "drag the shape to create" would be changed into a select. I checked as many "situations" as I could possibly have conceived of after reviewing the code in this area. The ones I know I need are !bMBDown and !IsAction(). The rest are just to try to avoid getting me into trouble. [FuText also could benefit from this, but that function is much more complex, and so I don't dare to interfere. It already does BegCreateObj on a mouse-up, but the textbox it creates is hard to notice.] Change-Id: I4ed2564e81d8a7ce82e7edec43e4e9acc6e97760 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154069 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-12tdf#105362 better support for transparency in PNG & GIF exportArmin Le Grand (allotropia)
The granularity to decide at the SdrView what to paint was not fine enough, so I added code to get what we need: Do avoid page decorations (including PageBackgrund aka 'wiese'), but do include/process MasterPage content. Change-Id: I49df05abc89b4bcebc973c37d30be0a0c72e59ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154301 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-07-12Categories for link targets in ImpressSzymon Kłos
Writer and Calc presented possible link targets inside documents as a Tree, with items under their categories. This patch makes the same for Impress so we don't mix master pages with regular pages. Change-Id: Ifd98300b0d609c28d6c1880332fff7e750b5e1b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152389 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153985 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-12tdf#141135 notebookbar: use radio buttons instead of checkboxesJustin Luth
I mean of course in the places where mutually exclusive options are side by side. I mainly searched in menu.xml where menu:style="radio", and then changed the notebookbar menu items to do the same thing. It was all done by hand, unfortunately. Before testing, ensure you have no customized notebookbars: rm instdir/user/config/soffice.cfg/modules/*/ui/* git grep -B10 '.uno:NormalView\|.uno:BrowseView' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:PageMode\|.uno:MasterPage' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:.uno:PagebreakMode\|.uno:NormalViewMode' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:DefaultCellStyles' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:CommonAlign' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:StyleApply' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:TextBodyParaStyle' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:NumberListStyle' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:OutputQuality' *.ui | grep -A10 GtkMenuItem git grep -B10 '.uno:ParaRightToLeft\|.uno:ParaLeftToRight' *.ui | grep -A10 GtkMenuItem git grep -B10 .uno:SpacePara *.ui | grep -A10 GtkMenuItem git log -p -1 | grep '^+' | grep -v GtkRadioMenuItem Change-Id: Ia2e29a6541fed66f4bcb0936d715969994671e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154337 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-10svx: prefix members of GeoStatMiklos Vajna
See tdf#94879 for motivation. Change-Id: Id8d116bfa375f7dd30ca8dcdec0ee02df8105030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154234 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-07-06tdf#141058 oox,sw: OOXML import/export of decorative on shapesMichael Stahl
Also add a test for PPTX (using the oox filters), and add a SdrObject to the testTdf143311 for DOCX (using the writerfilter/docxsdrexport). Change-Id: Iccee46c0d30316c33c0947b117e2604c96fa0182 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154137 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-05simplify sd: already asked if mxTextObj.get().is()Justin Luth
Change-Id: Ibb303cf53722684b0f98f0195ec6d55376bcfd1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154073 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-07-05simplify SvxUnoDrawPool initialisationNoel Grandin
Change-Id: Iaca5eec19935c50cc7cade4f3dab139a5232473a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154058 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-05tdf#138504 svx,etc.: decorative flag on SdrObject shapesMichael Stahl
* SdrObject new member m_IsDecorative * new Undo SdrUndoObjDecorative * surprising amount of changes in sw including additional SwUndoFlyDecorative * svx API SvxShape property "Decorative" * UI checkbox "Decorative" * ODF import/export as loext:decorative on style:graphic-properties * PDF/UA export: ViewObjectContcat tag shapes with this flag as Artifact Change-Id: I37f7a0597eab92c6c6aff94fad6c16c59b231c80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154063 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-05Make sure views get new themes on .uno:ChangeThemeParis Oplopoios
It would be that sometimes .uno:ChangeTheme would not load the new scheme because it was using EditableConfig::GetCurrentSchemeName which uses a static name - normally great except for when you need different views to have different color schemes in tiled rendering Change-Id: I5b149bd1a4776337f76753c6de98d5386a899d34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153939 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 77f5b9259864798b6efc213f6dfa685cd440f71a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154001 Tested-by: Jenkins
2023-07-04loplugin:unusedvarsglobalNoel Grandin
Change-Id: Ia86c8bd0bdc85c375eb3837ba97f9e171d9dac6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-03tdf#155630 Use common getPolygon for sdDr. David Alan Gilbert
Unfortunately the SetLineEnds in sw is different enough from sw and sc to make sharing it a pain. However we can share the GetPolygon function we already moved into svx. Expose the svx function into the header and use it in sd. Change-Id: I05b0f820286c8ce848fa0d6c69603d3625c2b4d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-03Delete DrawViewShell copy constructorsParis Oplopoios
DrawViewShell does not get copied so best to set these to deleted to highlight this. Change-Id: I3d35d3a47137b15346d54a08d3d7af480b0872bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153864 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-07-02pAttr is always dereferenced, use a reference instead of a pointerCaolán McNamara
Change-Id: I76ebce9085b9e47a6c571ddbcafa44d0d3a0f97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-30loplugin:unusedmethodsNoel Grandin
Change-Id: I8d3402a69237b665462e04440ad73fe29e2133db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-30tdf#156091: handle OWN_ATTR_TEXTCOLUMNS in SdStyleSheet::getPropertyValue_ImplMike Kaganski
Somehow I failed to implement this from start. In commit 95ebd24a629b4c8cd62cc20c0701683512cc8fa0 (editengine-columns: ODF support [API CHANGE], 2021-06-08), I implemented its support in SdStyleSheet::getPropertyState; then, in commit f2ea39c70da3f82bb39f8b51b5484172360b1fc2 (Avoid crash getting default item for OWN_ATTR_TEXTCOLUMNS, 2021-06-22), I added its support in SdStyleSheet::setPropertyValue; and finally, the time has come to support getting its value. Better late than never. Change-Id: Ifa1f933f00336bf6d01a5c71d0c92baf846ccabb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-29loplugin:unusedmethodsNoel Grandin
Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29mbIsUIReadOnly is deadNoel Grandin
after I removed SetUIReadOnly in commit e2c7a6bd572644b928704f6cb3696b568ac0aba1 loplugin::unusedmethods and that was dead because of commit cb32938d572777c9a5d75007cc76ba50c5a698eb [API CHANGE] remove unused SlideSorterService Change-Id: Ib0e170794e0f448b094b3d1ca5d309deab4c1bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-29loplugin:unusedfields make it a little smarterNoel Grandin
around dealing with operator[] on map data-types Change-Id: Idd6654948ae2d03d634fcf30a8d98530a78ab4ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-28xmloff: ODF import: adapt generator parsing to 2-digit major versionsMichael Stahl
DocumentInfo currently assumes that a LO version encoded in "BuildId" property has only 1 digit major version, which is now wrong and would start to give incorrect results when major version "30" will be detected as LO_3x. Add the dots as separators into the BuildId because it's not going to work without. Change-Id: I8918afe3642cbefa8488c57658f1505c9a20eddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153649 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-03-21 03:50:12 +0000