summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-08-09menubar draw: add choosemodebar commandsandreas kainz
Change-Id: I1baee1ec55e310aec2ec1010234d739eec5020c8 Reviewed-on: https://gerrit.libreoffice.org/58749 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-08-08tdf#83659 Enable outline commands for text boxes and tablesMaxim Monastirsky
Change-Id: I2fff7354556769104e9ffaafc504d3159f63e4e8 Reviewed-on: https://gerrit.libreoffice.org/58748 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-08tdf#116350 Fix export of fontworkSzymon Kłos
Change-Id: Icf3a07c6b79296feb233bbe08a6d69ab21a41414 Reviewed-on: https://gerrit.libreoffice.org/58746 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-08tdf#116350 Correctly display text on arcSzymon Kłos
Change-Id: Ice8c141db20d43ccc8d6e2b56004a4a28d2b257a Reviewed-on: https://gerrit.libreoffice.org/58729 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-08tdf#112343 Change dependency from dbus-glib to dbusArkadiy Illarionov
Add check for GLib support for modules which depends on dbus and glib separately. Also fix copy-paste typo. Change-Id: Ibd33573b2f8dff9e0a7f2e0fc983d93878bb5357 Reviewed-on: https://gerrit.libreoffice.org/57157 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-08loplugin:useuniqueptr in SfxApplication::LoadTemplate and SfxMediumNoel Grandin
pass SfxItemSet around by std::unique_ptr Change-Id: I54da96d8df224f7c4f2fb9ebf06ed32d479298e7 Reviewed-on: https://gerrit.libreoffice.org/58649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3fe82f6e3aad299fe42d6256c0deaba1339df0c1 Reviewed-on: https://gerrit.libreoffice.org/58708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08Fix typosAndrea Gelmini
Change-Id: I65836b437bbc27d4f6a5862fe436397d858564a2 Reviewed-on: https://gerrit.libreoffice.org/58701 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-06Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') in files formerly omitted for oversight or non-cxx extension Change-Id: I327c573f44076c6ccfecf737eafccba2da72e1bd Reviewed-on: https://gerrit.libreoffice.org/58600 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-06tdf#113822 handle letter-by-letter animations in pptx documents.Mark Hung
Unlike odp that has anim:iterate (IterateContainer) node, both parallel time container and interate container appear as p:par in ooxml so that we have to alter the node type in the end. We also have to set the target of the iterate container to make animation work. Change-Id: Ic50b5f1d85716a67712ed1e812bcb0e7f25fb5a8 Reviewed-on: https://gerrit.libreoffice.org/58576 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-06NB Draw: add tabbedbar initial releaseandreas kainz
Change-Id: I23b8d7147cf540bb1ac264e9b113aaec658f8598 Reviewed-on: https://gerrit.libreoffice.org/58638 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-08-06loplugin:useuniqueptr in DeleteOnDeinitNoel Grandin
Change-Id: If7428654a2577ba67aea57904d2a2b5099c4d602 Reviewed-on: https://gerrit.libreoffice.org/58568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-03Move angle normalization code from various places to toolsMike Kaganski
Also rename svx angle normalization functions in include/svx/svdtrans.hxx, that deal with 100ths of degree, to avoid confusion: NormAngle180 -> NormAngle18000; NormAngle360 -> NormAngle36000. Some places were fixed that previously returned inclusive ranges (i.e., both 0 and 360), see changes in these files: chart2/source/view/main/PlottingPositionHelper.cxx chart2/source/view/main/PolarLabelPositionHelper.cxx chart2/source/view/main/ShapeFactory.cxx filter/source/graphicfilter/idxf/dxf2mtf.cxx sw/source/core/graphic/grfatr.cxx (the latter now matches the comment in the function). Change-Id: I9f274bbb4168360d60dceff02aeba6332c519a59 Reviewed-on: https://gerrit.libreoffice.org/58556 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-03forcepoint#70 give all escher client data objects a common parent classCaolán McNamara
and make NotifyFreeObj a virtual method of SvxMSDffClientData, finding the sc case where the client data was neither SvxMSDffImportData nor ProcessData. make the sc case a XclImpDrawObjClientData whose NotifyFreeObj is a noop Change-Id: I07422e7a3415114674bb1e3c1ef120299adf2dc8 Reviewed-on: https://gerrit.libreoffice.org/58551 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-03tdf#116350 Export preset text geometry (text effects)Szymon Kłos
Change-Id: Ifb921b56387ca183b5a57126f6e88e2f9a4ecb3d Reviewed-on: https://gerrit.libreoffice.org/58430 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-03uitest Impress Document propertiesZdeněk Crhonek
Change-Id: Ida877ab6e65d4bcbd42d37fd2567db63f84ed8ad Reviewed-on: https://gerrit.libreoffice.org/58456 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-08-02tdf#116350 Import preset text geometry (text effects)Szymon Kłos
"Font effect" implementation, instead of normal text, content is converted to "fontwork". Change-Id: I5d02c7faedb66a4b919e64ae1b830bffb69984c1 Reviewed-on: https://gerrit.libreoffice.org/58358 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-02Notebookbar: Added shortcuts toolbox in drawKshitij Pathania
Change-Id: Icb1dbc5539c1fe64c2ee4906602578460860e9c8 Reviewed-on: https://gerrit.libreoffice.org/58464 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-01Fix typosAndrea Gelmini
Change-Id: Id59caa7da8fdfd613eb3b97196c52131aeb7378c Reviewed-on: https://gerrit.libreoffice.org/58375 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-31tdf#119015: don't call TableModel::optimize in CellCursor::merge()Mike Kaganski
Better do that explicitly in the SvxTableController::MergeRange, so that the UI-driven operation still optimizes the table, but import code gets the initial column count, and not throw trying to access the deleted column. Change-Id: Ib4b4d716935ec2036ccb839c36f1be5b0cb878d5 Reviewed-on: https://gerrit.libreoffice.org/58359 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-31tdf#118080 fix formula importing of ppt animation.Mark Hung
Change-Id: I5f56e0d70a13418b0bde45c2fc65f56fdb365263 Reviewed-on: https://gerrit.libreoffice.org/58209 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-31sd/qa: fix saveAndReload with PPT format.Mark Hung
UIName instead of Type were used as TypeName to initialize SfxFilter, and caused problems in DrawDocShell::ConvertTo() when saving PPT format. Change-Id: Iaffe7025a163c7520442c96921e8540903284ebf Reviewed-on: https://gerrit.libreoffice.org/58208 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-31loplugin:returnconstant in svxNoel Grandin
Change-Id: I0cc0c32afa0d735738c6744873f3518a2763821e Reviewed-on: https://gerrit.libreoffice.org/58334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31loplugin:useuniqueptr in sd::TestNoel Grandin
Change-Id: I77b938a6269612d6282fcef4f17a5a8486f93fc2 Reviewed-on: https://gerrit.libreoffice.org/58355 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31Fix typosAndrea Gelmini
Change-Id: Iaa00d65b518b3e638c2d31912e247cb91bdd0950 Reviewed-on: https://gerrit.libreoffice.org/58347 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-31crashtesting: failure on exporting tdf112587-1.odp to pptxCaolán McNamara
since... commit 7ff086c9141429e32c733f38d288cf67d6e9e3c9 Date: Tue Jul 17 18:58:27 2018 +0800 tdf#118836: fix grow-shrink animation in saved pptx. Convert AnimeTransform with transform type SCALE to animScale. Change-Id: I098db215b2970f321e2f8b715b1037140f2268be Reviewed-on: https://gerrit.libreoffice.org/58345 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-31uitest logger: log more eventsSaurav Chirania
Logging for the following: 1) Object Selection 2) Sidebar / Deck opening 3) Parameters of UNO commands 4) Element Selection (Math) 5) Set Zoom (Impress) 6) Calc - a) Autofilter Launch b) Select Cell / Range of cells c) Switch table 7) Writer - a) Goto page b) Set Zoom Change-Id: Ifc7f603f62d10cfd1062923ded68203e574aebb6 Reviewed-on: https://gerrit.libreoffice.org/57368 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories scripting, sd, sdext Change-Id: I47889cd889cf1d68353184229bfd4712f1528fbf Reviewed-on: https://gerrit.libreoffice.org/58220 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-29loplugin:stringloop in sdNoel Grandin
Change-Id: I5b0cd65b6e69490c79e0ac37c137283d19711787 Reviewed-on: https://gerrit.libreoffice.org/58252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-28tdf#118948 - Date format in Impress header/footer is lost when savingNoel Grandin
regression from commit 7d14555ef7e867c5b1a0e195e3ef056885697c59 convert SvxDateFormat to scoped enum Change-Id: I9d365c710a20054e249433f54635068f713afa72 Reviewed-on: https://gerrit.libreoffice.org/58202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27tdf#111306: Hide background widget in sidebar in master and notes viewXisco Fauli
Background is lost if it's changed from the sidebar in master or notes view, thus hide the widget for now, until the real issue is fixed. Keep the insert image button visible as it works. The background can be changed from the page properties dialog Change-Id: Ic3f6116cb0997024096343cb20ec40ac07307918 Reviewed-on: https://gerrit.libreoffice.org/57440 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-07-27loplugin:returnconstant in vclNoel Grandin
Change-Id: I597ef6d75d1c21cdc15a91bf7f549bc14c851506 Reviewed-on: https://gerrit.libreoffice.org/58086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27Related: rhbz#1602589 fix leaked_storageCaolán McNamara
no logic change intended Change-Id: Ic4d54965033e518195ef8e76ddec7feca14970c2 Reviewed-on: https://gerrit.libreoffice.org/58125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27Related: rhbz#1602589 silence coverity copy_paste_errorCaolán McNamara
Change-Id: Idca4bfaaa9f127eae87ae879e2131aed747ce4b3 Reviewed-on: https://gerrit.libreoffice.org/58089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26sd: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. Change-Id: Ib791cc511acfce457f7ffb2cd2c1a834e4e28734 Reviewed-on: https://gerrit.libreoffice.org/58078 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-26Removed execution flag on pptx fileAndrea Gelmini
Change-Id: Ia73b1d9cf740e8fc086885951d48cd2d4bf2d786 Reviewed-on: https://gerrit.libreoffice.org/57994 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-26sd: remove incorrect comments in testTdf118783 and testTdf118768.Mark Hung
Remove comments that are copied from other tests by mistake. Change-Id: I2dde9a7fc0c1e2f693947ff3bf9d83cf644a03cc Reviewed-on: https://gerrit.libreoffice.org/57979 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-26Removed executable permission on pptx fileAndrea Gelmini
Change-Id: Ic1c9e854229a80f82c7ce6187816cc63f85c1f41 Reviewed-on: https://gerrit.libreoffice.org/57992 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-25tdf#50499 convert by, from, and to of AnimContext.Mark Hung
Also change testTdf104788 because the expected value is taken as a double and decimal places are omitted if there isn't any. Change-Id: I16cb363b1ce0ff09da2df361849d47819bf9ced4 Reviewed-on: https://gerrit.libreoffice.org/57413 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-25tdf#118836: fix grow-shrink animation in saved pptx.Mark Hung
Convert AnimeTransform with transform type SCALE to animScale. Change-Id: I39dfbdb814afa78ca981238bb1876f4af0995791 Reviewed-on: https://gerrit.libreoffice.org/57790 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24ofz#9261 catch all exceptionsCaolán McNamara
Change-Id: I535c9608bbd554a55edf9ccd58ac71032ba756fc Reviewed-on: https://gerrit.libreoffice.org/57902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24tdf#118835 export animClr element. ( handle AnimateColor ).Mark Hung
Implement PowerPointExport::WriteAnimateColorColor to export to, from, by elements of the animClr element. Change-Id: I0fb81f8838656c127610a9a10654e3e51106bea8 Reviewed-on: https://gerrit.libreoffice.org/57820 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24tdf#113818 convert formula of AnimContext.Mark Hung
Change-Id: I0f6f08247eaf8099d84c0e8201d22fc507b1cac4 Reviewed-on: https://gerrit.libreoffice.org/57414 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24tdf#118835 fix missing attribute name conversion.Mark Hung
LineColor and LineStyle are missing from the switch-case. Just reuse the conversion list from oox::ppt::getAttributeConversionList(), also reoder the list so that fillcolor is prior than fillColor. Change-Id: Ia78553ad2fc908923da56bc58baf96dbb7d40863 Reviewed-on: https://gerrit.libreoffice.org/57819 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24tdf#118890 subtract 100% from by values of animScale.Mark Hung
Despite that by values should be offset values instead of ending values, what we got from pptx seems to be the later, that we have to subtract 100% from the by values to get offset values for slideshow. Change-Id: I7eb9981210ea9998dae0de8f22c155b394e5abeb Reviewed-on: https://gerrit.libreoffice.org/57860 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-23Fix typosAndrea Gelmini
Change-Id: If0d8f4033d9bc20f521d33d732fb349f0df5eeef Reviewed-on: https://gerrit.libreoffice.org/57822 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2 Reviewed-on: https://gerrit.libreoffice.org/57810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-23tdf#118764 Add missing tab stops in sidebar panelsJim Raykowski
Change-Id: I09d5df8d7f07eb4b6c4341d9cd281131fc2df23b Reviewed-on: https://gerrit.libreoffice.org/57535 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-21Removed executable permission on (odp|pptx) filesAndrea Gelmini
Change-Id: I6180c01c45c3336192d4e95cc943ad9f4bc38f4e Reviewed-on: https://gerrit.libreoffice.org/57730 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-21sd: fix closing document twice in testTdf118768.Mark Hung
Change-Id: I07def80070d8109b9d54ef19a841e3091f743b9c Reviewed-on: https://gerrit.libreoffice.org/57791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>