summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-01-18basebmp now only used from vcl/headless codeCaolán McNamara
Change-Id: I068d404431d3565f6ad5741edbd3693225824a4d
2016-01-18tdf#97119 Make TabBarVisible configuration persistantPhilippe Jung
Now the TabBarVisible status persist between LO quit/relaunch. It is also taking into accoutn when opening a (existing/new) presentation. Fixes the incorrect toolbar button status Moves the two buttons on Standard bar, in the PageSetup/SlideMasterPage group. ShowTabBar button is also enabled but not selected by default. Change-Id: Idd9ab15efebc2bf43bc827afaa1eb1457b39deec Reviewed-on: https://gerrit.libreoffice.org/21541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-01-18drawmodes header goneCaolán McNamara
Change-Id: Ia1b9ad96dbe41bebc5c2819385950a6d2980608b
2016-01-18cppcheck: doubleFreeCaolán McNamara
Change-Id: I371db988044264b6b1ff95bd7c683d1485430fe8
2016-01-18cppcheck: copyCtorPointerCopyingCaolán McNamara
replace custom ref counted thing with a shared_ptr Change-Id: I9d61235e38cc4c708826cf76d9edc2880b4b5ec7
2016-01-18vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5 Reviewed-on: https://gerrit.libreoffice.org/21560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc Reviewed-on: https://gerrit.libreoffice.org/21510 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16Fix ODR Violations under LTOPeter Foley
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: warning: type ‘struct SlideshowImpl’ violates one definition rule [-Wodr] class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: a different type is defined in another translation unit class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:334:28: note: the first difference of corresponding definitions is field ‘mpShowWindow’ VclPtr<ShowWindow> mpShowWindow; ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:334:28: note: a field of same name but different type is defined in another translation unit VclPtr<ShowWindow> mpShowWindow; ^ /home/peter/libreoffice/include/vcl/vclptr.hxx:75:7: note: type name ‘VclPtr<sd::ShowWindow>’ should match type name ‘VclPtr<ShowWindow>’ class VclPtr ^ /home/peter/libreoffice/include/vcl/vclptr.hxx:75:7: note: the incompatible type is defined here class VclPtr ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:166:7: warning: type ‘struct SlideShowView’ violates one definition rule [-Wodr] class SlideShowView : public ::comphelper::OBaseMutex, ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:166:7: note: a different type is defined in another translation unit class SlideShowView : public ::comphelper::OBaseMutex, ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:232:45: note: the first difference of corresponding definitions is field ‘mpSlideShow’ SlideshowImpl* mpSlideShow; ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:232:45: note: a field of same name but different type is defined in another translation unit SlideshowImpl* mpSlideShow; ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: type ‘struct SlideshowImpl’ should match type ‘struct SlideshowImpl’ that itself violate one definition rule class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: the incompatible type is defined here class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ Change-Id: Ibbb7fb6f35f7e2771aef78a38fc4b6adef131845 Reviewed-on: https://gerrit.libreoffice.org/21503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-01-16Fix ODR violations when compiling with LTOPeter Foley
/home/peter/libreoffice/sd/source/ui/controller/slidelayoutcontroller.cxx:84:8: warning: type ‘struct snewfoil_value_info’ violates one definition rule [-Wodr] struct snewfoil_value_info ^ /home/peter/libreoffice/sd/source/ui/controller/displaymodecontroller.cxx:71:8: note: a different type is defined in another translation unit struct snewfoil_value_info ^ /home/peter/libreoffice/sd/source/ui/controller/slidelayoutcontroller.cxx:86:16: note: the first difference of corresponding definitions is field ‘mnBmpResId’ sal_uInt16 mnBmpResId; ^ /home/peter/libreoffice/sd/source/ui/controller/displaymodecontroller.cxx:73:17: note: a field with different name is defined in another translation unit sal_uInt16 mnId; ^ Change-Id: Ic5f5354424188a0889e842e80cb70dd90ecaeff3 Reviewed-on: https://gerrit.libreoffice.org/21504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-01-15ugh, forgot to git add the test documentMichael Stahl
Change-Id: Ia10730e07de3bd86f54c7fc0ba5ae55f350ce149
2016-01-15oox: export Math objects to PPTX filesMichael Stahl
These hit the assert in lcl_StoreOwnAsOOXML now so better implement some export. Change-Id: I10c005a547e8a85f2a82198a49f9a03fc46a61d7
2016-01-14sd lok: More places where we need to force the transparent color for bg.Jan Holesovsky
Change-Id: Ic6e0ed45b118b27a86f8657671ae877ce494c5d4
2016-01-14sd: use ScopeGuard in Outliner::SearchAndReplaceAll()Miklos Vajna
So the flag will be reset on early return as well. Change-Id: Ib086ec4a02dda291a0291a8ac40660c16de0fbf6
2016-01-14-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: I892dc449bc2e9840ec8dac9c4a1b43961b6c1b07
2016-01-14editeng: handle SdrModel::isTiledSearching()Miklos Vajna
Given that the edit/outliner views can come and go, avoid the lifecycle problems with just passing a pointer to the sdr model to editeng, and then it'll always have the up to date "are we searching" information. editeng can't depend on svx, so provide an interface class SdrModel can implement. Change-Id: I3b98011593b00ac0fab05b6b9c591dd20d94c579
2016-01-14sd tiled rendering: it's pointless to send selection changes during search allMiklos Vajna
But they do cause annoying flashing. Change-Id: Ic313a15429c5db98c5660a5274aa49e95dd217e5
2016-01-14loplugin:unusedmethods unused return value in sdNoel Grandin
Change-Id: I9bf87cad19b7371076fd0b2333c83697021fe0e1
2016-01-14tdf#96522 reset CustomShapeEngine at importArmin Le Grand
Do not reset UNO API xShape at import time as described in tdf#93994, better reset the involved XCustomShapeEngine which allocates and holds the EditEngine and VirtualDevice. Resetting the UNO API object leads to problems when e.g. an animation effect is set for the shape. This happens since the animation effect remembers the xShape using a weak reference, thus being no real on-demand constructable object. Change-Id: I7b421f578ebf003af2745e449cd02ba368b455dd Reviewed-on: https://gerrit.libreoffice.org/21401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-01-14sd: clean up remaining non-static isTiledRendering() usageMiklos Vajna
Change-Id: I36b0edc55b9c275bef5cf82af2bdf0ccb3ebe621
2016-01-13resolve TODO, remove SVVERB_SHOWMichael Stahl
Change-Id: I10148330f1a356dbd423af98267c25d7128c3a86
2016-01-13Fix memory leakStephan Bergmann
Change-Id: Icf46bc3c086a8221e08a4bb18e1f64355043cdbb
2016-01-11lool - search all - unit test failure - solvedMarco Cecchetti
Change-Id: I5a74dd60f61fc0fdb88f08383d579b14222aa55d Reviewed-on: https://gerrit.libreoffice.org/21365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-01-11loplugin:privatebase: Make various derivations publicStephan Bergmann
...assuming they were implicitly made private by accident rather than by design. (And private derivation can cause unexpected failure of dynamic_cast, cf. 63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove then-unnecessary downcasts.") Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
2016-01-11loplugin:privatebase: Make derivation from Timer explicitly privateStephan Bergmann
Change-Id: I5c3bcd19bb63f78c8d06961d39b0932220cb3762
2016-01-11loplugin:privatebase: Make derivation from noncopyable explicitly privateStephan Bergmann
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
2016-01-11sd: with any luck the OLE test should run on WNT now tooMichael Stahl
... with the new implementation in oox. Change-Id: I65aca6e4151ad7383d45c60430132a45ae3a001e
2016-01-11sd: enhance the OLE object test to also test the exported XMLMichael Stahl
Needs adding various helpers to be able to use XPath. Change-Id: Ifa7b1e5434fb253430da2bfcc5d38ea347d437af
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08lool - page border shadow can be disabledMarco Cecchetti
Support for text documents and presentations. Added a command line option for gtktiledviewer: --hide-page-shadow. Reviewed on: https://gerrit.libreoffice.org/21210 Change-Id: I1e427693d7af40cb5731d1730ac5b7c486d45c29
2016-01-07svx: fix windows build, rename SvxEscapementItem::GetProp()Michael Stahl
90e07dd6f5d64a0d0041361c1592a6cd93ff2ac0 introduced a new unit test which calls SvxEscapementItem::GetProp(), and apparently the unit test also #includes windows.h somehow, so GetProp macro is defined to GetPropA and that fails to link since SvxEscapementItem doesn't have this member function. Thank you, C preprocessor, you barbarous relic. Change-Id: I6fd8e9d832ed5e1ce1a4fa7f1516c55d51a3283b
2016-01-07Avoid loplugin:unreffunStephan Bergmann
...with be343661b076f3f57e7eb9ca1a5a4d3529752b58 "Disabled the test for a moment." Change-Id: Ic1b60f5590431f2edea4a65c62fdeb8eda256987
2016-01-07Disabled the test for a moment.Jan Holesovsky
Change-Id: I251d079d6362cf09d014623663cf9355a9c79a2e
2016-01-07sd: lool search all - 2nd search did not work - fixedMarco Cecchetti
TODO: now table are skipped because current implementation is not able to iterate through table cells and when a match occurs on the first cell the text object iterator stops working; Change-Id: I36ca4dabe88b0eb8fd89d3fe3dcc6951e5c03d0e Reviewed-on: https://gerrit.libreoffice.org/21166 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-01-07set reasonable default size for new draw/impress tablesJustin Luth
The width was decent, except that on small paper (A6) it was wider than the paper size. The height was terrible - the minimum size possible. It was too small for even a single line of text. That made it hard to grab the table edge (instead grabbing a row edge) when trying to resize. Now the height and width are limited to the page/view size, and based on the number of rows created. One possible enhancement would be to use the border width instead of the page width. Change-Id: I4e106a7bc34f65886e3c80d308499242c0fdd7d8 Reviewed-on: https://gerrit.libreoffice.org/21171 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-06Make E3dScene3D::GetCamera return non-referenceStephan Bergmann
I stumbled over this when Valgrind'ing CppunitTest_sd_filters_test somewhat erroneously reported Source and destination overlap in memcpy(0x2fde4af8, 0x2fde4af8, 96) for aCamera = rNewCamera; in E3dScene::SetCamera (svx/source/engine3d/scene3d.cxx), where the compiler chose to use memcpy in the implicit definition of the Viewport3D (being a base class of Camera3D) copy assignment operator, and the call pattern of Get/SetCamera in EnhancedCustomShape3d::Create3DObject (svx/source/customshapes/EnhancedCustomShape3d.cxx) causes that assignment to be a self-assignment. Upon closer inspection, some calls of GetCamera already create a copy from the returned reference, while others modified the returned reference, but then would also always call SetCamera on it. An alternative to the given change would have been to instead change SetCamera(Camera3D&) to UpdateCamera() and require all call sites of GetCamera/UpdateCamera to modify the reference returned from GetCamera, but it looks safer overall to go this way. Change-Id: I578e72db57630dca1b09124a3b11d177005b797d
2016-01-05Make SotFactory private to sot/ and clean a bitMatúš Kukan
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05new loplugin rangedforcopy - use reference in range based forAndrzej Hunt
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2 Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01 Reviewed-on: https://gerrit.libreoffice.org/20190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05tdf#96708: don't modify document while copying to clipboardMike Kaganski
I.e., don't try to create auto-layout for clipboard pages which don't contain one; don't resize objects to text. Also, don't invalidate items that are equal to defaults, because explicitly set items are not the same as absent items: pasting an object without an item makes the property to inherit new target's default, while when the item is present, the default doesn't apply. Also, don't consider selected state of the page while stringifying - this makes selected page string to differ from not-selected clipboard page. Change-Id: I172e03e1a8c428e5fcae3a116cc9ad8de79f1a87 Reviewed-on: https://gerrit.libreoffice.org/20871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-12-30Related: tdf#89540 We don't use PseudoSlots in sdMaxim Monastirsky
This unbreaks various draw buttons after the addition of SID_INSERT_DRAW to sd. Also silences the warning "master slot with non-enum-type found". Change-Id: I250a1a4b5d24f052d303c24138654f7e41cc4fb6
2015-12-30tdf#89540 Completed show draw functions button for impress and draw.Gulsah Kose
v2: failed commit. v3: Solved slot defination and dimmed button problem. v4: Tried to find slot execution method. v5: Added a control for draw toolbar name in impress and draw v6: Toolbar name control is changed for checking request only impress and draw. v7: Overrided initialize method of base class. v8: Control provided with module name. v9: Cleaned unnecessary included headers v10: Removed m_sModuleName defination and reused base class' m_sModuleName variable. Added white space before header files. Moved control into the initialize method. Control is changed as only controls impress or draw. Change-Id: I781783a72954af1f16212b981356db472ed48739 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2015-12-30Kill remaining plugin bitsMaxim Monastirsky
Change-Id: Icd99757b48626ef43313e8de42c4e5462f85a958 Reviewed-on: https://gerrit.libreoffice.org/21008 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-12-29cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-27Bail out early (so to avoid unuseful dynamic_casts)Matteo Casalin
Change-Id: Ie1940e2178585c56cecdbbcff9c9e57aa8b05459
2015-12-24tdf#84846 Merge identical GotoTreeBookmark into GetObjectIsMarkedFernando Pirani
Removed some duplicate code. All current behavior should stay the same. Merged GotoTreeBookmark into the almost identical GetObjectIsMarked: > Added a bool parameter to control the behavior of GetObjectIsMarked > There was only 1 call to GotoTreeBookmark in the whole code. Replaced it with a call to GetObjectIsMarked Change-Id: I3594512d0ff425ab2bd5636845d0e703dee85d52 Reviewed-on: https://gerrit.libreoffice.org/17505 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2015-12-23sd: fix not necessary to pass default argumentHenry Castro
Change-Id: I4f4277bdf6b513bfce58d96000c485fbdc82a1b1
2015-12-23sd tiled rendering: enable map mode to center imagesHenry Castro
In the tiled rendering case the map mode is disabled, and conversion pixel to logical is not computed. Change-Id: I0d54aaa897f0fe0df6e8b55334053dc66b6ea925 Reviewed-on: https://gerrit.libreoffice.org/20912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-29 05:02:47 +0000