summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2015-05-04Use typed TabControl::SetDeactivatePageHdl LinkStephan Bergmann
Change-Id: I487aad5217cb685ece971717445a68b4fb3d2b3a
2015-05-02tdf#34555 Moving SID_OBJECT_CROP out of sdPhilippe Jung
The crop action in impress is defined in impress but uses code shared in svx. This patch move the declaration of the Crop action in svx so that it can be shared with sc & writer. This is part of a serie of 4 patches that adds Save graphic, Change Picture, Edit with external tool, Crop (by handles) in all products (scalc, sdraw, simpress, swriter). Main menus, toolbars and contextual menus are updated accordingly. Change-Id: Idb6907aa09c0efd456c2ad51232cf37edb28d977 Reviewed-on: https://gerrit.libreoffice.org/15587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-04-30Use typed Link for MenuButton::SetSelectHdlStephan Bergmann
(and MenuButton::GetSelectHdl was unused) Change-Id: I94df06bcda9e041fde65553e30247874b20ff74b
2015-04-30tdf#90673:FILESAVE:PPTX Paragraph text direction right-to-left is not exportedPriyankaGaikwad
Problem Description: After RT 'rtl' tag of <a:pPr> are not exported XML Diff: Original : <a:pPr marL="457200" indent="-457200" algn="r" rtl="1"> RT : <a:pPr algn="r"> Change-Id: I307bc748c73127c311cabd127bb98e43bd298271 Reviewed-on: https://gerrit.libreoffice.org/15428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of initial :: for the sdr namespaceTor Lillqvist
Change-Id: Ibbeb069b6fcb2aa0581429ac5cb6db519548fd00
2015-04-30Get rid of initial :: for the svx namespaceTor Lillqvist
Change-Id: I03e428a749bca409ebac9c142acaddafcbfeca23
2015-04-30Get rid of the initial :: for the vcl namespaceTor Lillqvist
We used it all over the place without leading :: already anyway, even in many files in include. So let's be consistent. In the majority of cases, prefer the easier-on-the-eyes choice, not the "safe" one. In those files in include where *all* existing uses of ::vcl:: indeed used the :: prefix, there let's keep it for consistency. Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-29coverity#1078827 Dereference before null checkCaolán McNamara
Change-Id: I3d8850900e25606c23e2209abe828e2b1e98b38e
2015-04-29coverity#1296210 Explicit null dereferencedCaolán McNamara
Change-Id: Ia5aaa3deba695f9b9aec68477f8b34f1602a8045
2015-04-29Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann
...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29bogus Werror=maybe-uninitializedCaolán McNamara
Change-Id: I01eeeeff399961e59194c592139386355515d44c
2015-04-29redundant castCaolán McNamara
Change-Id: Ib812a7cafabc4820946da67fb3f8896b6aad1461
2015-04-29convert CT_ constants to scoped enumNoel Grandin
Change-Id: Icd1f009e879965feb936c6268688cdcd1edbd231
2015-04-29convert SDRMOUSE constants to scoped enumNoel Grandin
Change-Id: Ia5389095683a1c012a988ed71bf769a1f25d80fb
2015-04-29convert SDRSEARCH_ constants to scoped enumNoel Grandin
Change-Id: I1495dbaf05b642d98f41639d41f831f007601df3
2015-04-29convert SDR_SWAPGRAPHICS constants to scoped enumNoel Grandin
and drop unused DOC constant Change-Id: Id35d18241642742500cc007c575a8a54b5b8dd97
2015-04-29convert SDR*ALIGN constants to scoped enumNoel Grandin
Change-Id: I29b7b4fe1181133cbbb0bb43a1835941cf12210d
2015-04-29convert SDRESC_ constants to scoped enumNoel Grandin
Change-Id: I9488088d006ceae15368fae775aeebebfa7ce229
2015-04-29convert SDRINSERT constants to scoped enumNoel Grandin
Change-Id: I6335e00cae161cea7ece922ecfa845c205626cd9
2015-04-29convert SVXRULER_SUPPORT constants to scoped enumNoel Grandin
Change-Id: Id6c2571b5a060530437509a8dc203dc1a346f773
2015-04-29convert LANG_LIST constants to scoped enumNoel Grandin
Change-Id: Ibd699cfdfd3266c2965a5b6368cfe2f4431b7fb4
2015-04-29fix compile: delegate RenderContext parameter to superTomaž Vajngerl
Change-Id: I1c08e29c45d8334db52b129a957098481f3e57a4
2015-04-29replace Paint calls to Invalidate + fix compilationTomaž Vajngerl
Change-Id: Id716c47d56922ab6ce0c3adb3d426ea814980674
2015-04-29mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)Tomaž Vajngerl
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-28default initialization of object of const type w/o user-provided default ctorStephan Bergmann
...same as aef1826d9ca318a1359a2116e7f146e993413234, actually fallout from diverging behavior regarding DR 253 betwween GCC/libstdc++ and Clang, cf. thread starting at <https://gcc.gnu.org/ml/libstdc++/2015-04/msg00165.html> "std::__debug::vector default ctor must not be defaulted" Change-Id: I9189d472b57249857d64f7d807a0e08fc1758759
2015-04-28Fix --disable-pdfimport buildTor Lillqvist
Change-Id: I932f584ef3c054abe738d59e9957c3a40be1d2c9
2015-04-28Check ENABLE_PDFIMPORTTor Lillqvist
Change-Id: I1c0e7e5ecfcd62315e367d537cd3e0466b66e48f
2015-04-28sd: fix GCC-4.7 buildMiklos Vajna
Change-Id: Ie86c66fe643b6a8cbf2436c3f5a05388ae6a6119
2015-04-28Merge remote-tracking branch 'origin/feature/vclptrmerge2'Michael Meeks
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28Fix tdf#90911 wrong parameter size on getsocknameJuergen Funk
This was crashing on selected versions for Windows. Change-Id: I7e9dd39db06f6ed93d2ae0d49275387e53983a89 Reviewed-on: https://gerrit.libreoffice.org/15559 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-04-28SfxRequest generically uses an SfxUInt16Item hereStephan Bergmann
Change-Id: I872d666bee073ef570971ec36e678cc7354fc498
2015-04-28nOK var wants to be of type boolStephan Bergmann
Change-Id: I9e4129270a3d0bb744d8fbaf1641fcbdf1e2b0a7
2015-04-28Dialog::EndDialog nResult param is of type long/VclResponseTypeStephan Bergmann
Change-Id: I31f1941daf158676518fcf259ef8a9e84863473e
2015-04-28SfxTabPage::DeactivatePage wants to return SfxTabPage::sfxpgStephan Bergmann
Change-Id: Iba538bb51635e6cae1e033d14e8da3dabfb36634
2015-04-28Rephrase comparisons between bool and sal_BoolStephan Bergmann
...to cater for forthcoming loplugin:implicitboolconversion improvements Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
2015-04-27More loplugin:simplifyboolStephan Bergmann
Change-Id: I3bb156856ec6538168764c64dc768ba70c9bca88
2015-04-26Help button on the left in simpress photoalbumOlivier Hallot
Change-Id: Ie31c16c332ad05bc5c41d20403dc905587addfac Reviewed-on: https://gerrit.libreoffice.org/15504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2015-04-24tdf#89758 Interactive crop preview shouldn't scale proportionallyTrent MacAlpine
Add extra check to keep images proportionally scaling by default from affecting interactive crop preview rectangle. Change-Id: I2b15bbc8628934e3d3cf17927885ede890505cd3 Reviewed-on: https://gerrit.libreoffice.org/15505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-04-24Simplify SVG_DISABLE_FONT_EMBEDDING checkStephan Bergmann
Environment variables are used as a source for bootstrap variables anyway. Consistently consider SVG_DISABLE_FONT_EMBEDDING to be enabled if the bootstrap variable is present, regardless of its value. No need to tset it in CppunitTest_sd_import_tests, as it only affects SvgExport. (However, there is currently no test of svg export in CppunitTests_sd_export_tests, either; it was last disabled with 925907767cc63c1e5d6414e215f671a0b9f8a28a "disable sd's regression test again" and subsequently removed with f5dbe0eaba923f5de84745a04f531b36c979cafa "Usage of XShapeDumper in Impress added.") Change-Id: I3bc8e26953bd4b5a59f8230ee93fe99e0488d5cc
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: Ie214d859cb47c64cb6fab6f451a53ef188400026
2015-04-24CppunitTest_sd_tiledrendering: add search testcaseMiklos Vajna
This fails without ef9722558a33a6e88ed5ab76198f2698ddd1e003 (ImpEditView::SetEditSelection: fix missing tiled rendering selection callbacks, 2015-04-23). Change-Id: I5bf6bf6373e43e8551dd61d72d1f0012f92d2619
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...manual fix inside a macro call Change-Id: Ic14d5186aae08a1e868e98ed370b0142db1a1329
2015-04-23Use comphelper::SequenceAsHashMap::getUnpackedValueOrDefault<bool>Stephan Bergmann
...instead of ...<sal_Bool>; plus ensuing loplugin:implicitboolconversion Change-Id: I5400e9d3175b9fe9b6088d37fe6bf3275314d7d0
2015-04-23loplugin:staticmethodsNoel Grandin
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-23loplugin:staticmethodsNoel Grandin
Change-Id: Ib0c0841e48814d1a6e13bcd4575725d86ffa5e5e
2015-04-22tdf#90090 - customizing and positioning additional toolbarsYousuf Philips
Restoring the line & filling and image toolbars to how they were and reorganized the standard and drawing toolbar buttons and used OOo stats to reogranize the buttons in the split buttons Change-Id: I63117f5a7b1243bd6f359bcd965d240d4237c8ef Reviewed-on: https://gerrit.libreoffice.org/15483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>