Age | Commit message (Collapse) | Author |
|
(*) rename the enum to make it's purpose more obvious
(*) remove the enum header - it belongs to this class, no need to have
it somewhere else
(*) return property name by const&, no need to copy here
(*) use a o3tl::enumarray instead of a std::unordered_map - there are
only 3 entries here, and two of them are ALWAYS used, so just flatten
the data structure.
Change-Id: Ic496bd5220d55be1209a3243c095d461df0a02ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129788
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
so we can avoid constantly generating new TextForwarders which
are the same as the one they replace.
The underlying problem is that of tdf#123470 but this solution should
be safe to backport
Change-Id: I742f2a9ce0024adf9bd0acc5bb8edb9372fc0af5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129775
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
because they are not slots, they are only being used as parameters
Change-Id: I539f4832b884d1ea7dc14ce4ef6c79feec6681cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129732
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I6401dcf2507ac53a71dbe4de4ba774aed905961e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129731
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I36cdd81fcb70d5383519c22b92a3d6366b719b8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129380
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
REPLACE is really a replaceAndFind instead of a findAndReplace.
Thus, when you changed your search parameter and did a replace,
it replaced the previously searched for item, and then found the
first instance of the new search parameter.
That of course is just wrong.
So make sure to verify that the previous search
matches the current search competely.
However, that doesn't mean that the entire searchItem matches,
since we don't want to restart the search just
because the replace parameter changed.
In my testing, this wasn't an issue for REPLACE_ALL.
So the only time we need to worry about the last search
result is in a replace once situation.
P.S. This commit exposed that mpSearchItem can point
to a destructed SvxSearchItem, so this patches unit test
will crash if the other 7.4 commit is missing.
Change-Id: I7be14d64534018718145c6ac5f8629ff5f2e5611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129385
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
this is presumably what was intended
Change-Id: I0c436c1440207140158ae902b17b43549a94d8c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129536
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib3d42ab54ec855af5a922f4dd47cedd96bdf10c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129529
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
When the user switches between slides and then re-starts a search,
they expect that the search will begin on the current slide.
This fixes a somewhat 5.2 regression. Before that time, the first
search attempt failed, but the second attempt started
at the current slide. After 5.2 fixed the first-attempt-failure,
the starting position was "the slide after the last find".
This patch resets the starting position to the current slide,
which I saw was done in every case by DetectChange().
I thought about moving all this logic into DetectChange,
but it doesn't make much sense to affect a spell-checking
dialog run by moving around in the slides,
so just keep the logic here.
I submitted the unit test in a PRIOR patch.
The basic search was failing on WIN/MAC platforms
and so I wanted to confirm that this was NOT my fault.
Indeed, on those OSes the testing fails,
so I just run it under Linux where it works fine.
Change-Id: I4d1af3049bb2c0a59ec46f005c4b1773aefffb6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129204
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: I8fa978a5b58faa79c9c07b2c832a56b4d5230dd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129504
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
I tested "if (mpSearchItem)" which passed, but then it
crashed when trying to access (*mpSearchItem) == (*pSearchItem)
because the mpSearchItem's DTOR had already been called
prior to the if(mpSearchItem).
Since mpSearchItem is never compared to another
memory pointer, it is safe to assign it to a Clone.
Steps to reproduce:
1.) open Impress and search for something
2.) change the search string to something else
3.) search again.
Note that there isn't currently any code that hits this.
I discovered it trying to craft a fix for bug 145868.
Change-Id: Idc5f5a3e812ed3e49631347c35c3f4b2d8bb4127
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129347
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
There was no option to get the master slide info from SdXImpressDocument
Change-Id: Ic42a4c541c406a50ec26ec2113174ab25675a074
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129423
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129480
Tested-by: Jenkins
|
|
nY goes first. See include/vcl/BitmapReadAccess.hxx
Change-Id: I1af00102d2267017b98e6b6e286f2eda74f9ca24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129374
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
... SwScannerEventListener and SwView_Impl
See tdf#94879 for motivation.
Change-Id: I19958bc70e7dd80ea3f1c75e06b9ac192d40f254
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129472
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ie78797eaa774ba94b7b57fad025c811707d2db04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129448
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I69504a65926e3611e0d954d3ed317d45741b341b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129354
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
When inserting a PDF file as an image or pasting PDF data from the
clipboard on a Retina iMac the resulting rendered image did not look
sharp.
Using a surprisingly large extra scaling factor helps. The exact
reasons for this are unknown. It isn't enough to use a scaling factor
of just 2 (which is the HiDI ("Retina") scale factor on my iMac).
Possibly the fuzziness is related to what Pdfium uses to render text.
Also, look at CountDPIScaleFactor() in vcl/source/window/window.cxx.
The GetDPIScaleFactor() function lies on macOS even more than it does
on other platforms. It claims that the DPI scale percentage is always
100. But in fact most Macs nowadays have a Retina display so it would
make more sense, in theory, to at least always return 200 instead.
That wouldn't be any more wrong. But that causes regressions in the UI
rendering, like needlessly large icons in the toolbars.
Change-Id: Idc694f742c4ac32a5a134f8d206cf4eee467c39a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129369
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This reverts commit 87866def6bfe2ee91be34a5ce37b79d6da881617.
This also reverts commit 98d6ed2aeb22b27fddf716a372f483b89ecea841
< tdf#123973: sd_png_export_tests: Add unittest >
Change-Id: Ic3c8c70ef789b83cec0614e766a3c067cbf078fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129351
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Some image filled shapes with grayscale effect in PPTX documents
created with PowerPoint were not grayscale in Impress.
Change-Id: I0a89f283f525eb47c21c5d5fa788484d8074a7e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128616
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Yesterday I pushed 5d05abcc7cb53fd7f7d7ed700e3c65e9da3e5dea
< tdf#105998: sd_png_export_tests: Add unittest >
Meanwhile, Armin pushed 4d535c4f867d86d40786788e5e5c9fd061a65673
< tdf#126319 Corrected bitmap creation from metafile >
making the size of the export shape to be 193x193 instead of
192x192
Change-Id: I366b7fc7d53db46a0beb1c5b588ac33ecabc343b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129348
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Follow-up to commit 9310e47e2ce71348a16e5412131946348833f4b2
"tdf#101122 DOCX custom shape export: remove bad fill".
Change-Id: I2acdae3964c31ee366387d9938fe366405dcace9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127944
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: Ifac9aedb4972323da8b70d0a8f6f663513d2fbdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129310
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
only instantiated with one type, so just turn it into a normal class
Change-Id: If3ae908f3e226ae9f4d3b81a7a7d9ba492ccda4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129283
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I312844466157a4029f6744a4b13306903229c51b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129276
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I4a32d815b085f10ab9be1b861bdfdeb128ec242e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129275
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I28cf3bf29905f66f458b9dfbb8ad31742f866d73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129280
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
- enable subcontrol .ui for jsdialogs in annimation panel
- optimize to not recreate widget on every sidebar refresh
- don't sent close message for whole sidebar when called from
subcontrol
This fixes widgets in annimation panel like: Direction listbox,
or other replacements for selecting color, font etc. for font effect
Change-Id: I5683ca9cefe384ed0d2a34d46936ddf4a9b45bce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125757
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129170
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
in the slide selection
Change-Id: Ibdd9c827fea3ef33f0ae385147b3fa633d5dff83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129244
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I723bbd82fc01f644de3bfb2a80b4640cec0cfbca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129243
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This reverts commit ba535d8cbda1026823ce9796c20f97b7367d581f.
Change-Id: I277e640c0f8ed0038e8ea867ddeef999a00b7b87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129242
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4e3f97aef0865a00a771d8fa959422203a8f08f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129228
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
in preparation for a follow-up test for tdf#123973
Change-Id: Iadedff75c42fa24390602a6eb914027157b53029
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128979
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
sigh, not even draw manages to get invalidation right
regression from
commit 9a850dd9f3c221660b6259bdfd64a77343f2256c
Date: Wed Jan 12 10:27:38 2022 +0200
used cache value in ViewObjectContact::getPrimitive2DSequence (2nd
attempt)
Change-Id: I2692ac6933a3956eb98f48ff0875cdc0c933bd8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129221
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... sw::sidebar::PageStylesPanel and sw::sidebar::WrapPropertyPanel
See tdf#94879 for motivation.
Change-Id: I8eb8be59b9fad087fadb2735c46133aca4810415
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129199
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Follow-up to commit 4574a1ea408c2ac30042dca32d02207ec7add4da
"tdf#146223 PPTX import: fix master objects visible property".
Change-Id: I34e6132837d6c84974f8446978c59226a9a7d2d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127908
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Windows and Mac OS are failing this unit test
at an early stage, before the code change should
even hit. So I am decoupling the unit test and
running it prior to my patch to ensure that it
really is some pre-existing issue and not
related to my code.
[Because lcl_search() was is not used in MAC/WIN,
I was getting errors about an unused function,
so I also used it in another test (where I
got the code from in the first place).
I verified that test still failed when
the associated commit was reverted.
I also made it bBackwards just to make sure
the variable is used, even though irrelevant here.]
Change-Id: I2413fa54b881d8e8eb8c6c8907fbc0d13c352e10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128729
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: I4df3b153750be8d650f2c3b0ea5bd840b4397c27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129134
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This file is relatively new, convert it to use CPPUNIT_TEST_FIXTURE
before it grows more. it's clearer and faster when writting
new tests
Change-Id: I15485642d64e5e3ed628155ffac4cfc70e8c3451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129132
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
to act as an extra check that we have the association of Item and
TypedWhichId annotations correct.
(*) requires that I add an upcasting constructor to TypedWhichId
(*) Make the field dialog stuff in writer use a new item id
FN_FIELD_DIALOG_DOC_PROPS instead of abusing the
existing SID_DOCINFO
Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
none of them are remapped (via the SfxItemfo stuff in the pool)
Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2811e151a9643f589e251e176d9c717472a5dd4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129099
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I5592b1cb244b220fac40db1680e3b9f726ba57e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129096
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Just like when doing Insert>Image... of a PDF file, you get a bitmap
of the rendering of the first page of the PDF, not separately editable
shapes or text. The pasted PDF document is included when exporting to
.odp at least, just like for Insert>Image...
I don't know how common or easy it is on Windows or various Linux
desktops to have PDF format data on the clipboard, but at least on
macOS, if you select a rectangle of a PDF document viewed in the
Preview app, and do Edit>Copy, a PDF document is put on the
pasteboard. (Preview also puts a TIFF rendering of the selection on
the pasteboard, but for some reason that is of ridiculously low
resolution. That is what used to get pasted into Impress previously.)
Change-Id: Ic4b29deb12609dd839d8578779600156ff1ec48b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129049
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
none of them are remapped (via the SfxItemEntryInfo stuff in the pool)
Change-Id: Ic7b5f2c3cc75a65bdf9c45f9522cc53954b4ba38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129040
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and update the idl compiler to cope with namespaced class names
Change-Id: I7b5242f872e358bc3c5584f543767719172aac83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129026
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5cd2d05913f5c90499e3454e108d43ad75eee09c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128888
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: Ic4d187d1e2ee92eab74a6bb43e47bb4f3d47ebd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128506
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I83ff18c8b5e95fa172de950eb351cbfd855c9d5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128919
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia9a1e0f687de3f916d59f28112b7b00c0d4a6610
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128872
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|