summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2017-11-07loplugin:constparams in sdNoel Grandin
Change-Id: Id4b68ca0509111396ed354f4cda43d663083cad0 Reviewed-on: https://gerrit.libreoffice.org/44388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06tdf#112547 sd: add unit testMichael Stahl
Change-Id: If63f004c95208d49743f389746ca430ad91e1231
2017-11-06TSCP: need to enumerate the marker and IPPart properties tooTomaž Vajngerl
Change-Id: Ibc8643667c3ae352107a93dcce2be02b1a9af06f Reviewed-on: https://gerrit.libreoffice.org/44344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-06TSCP: Insert objects to all master slides, improve object placingTomaž Vajngerl
Change-Id: Ic8b122748157bf63b5c934a4745bcdc011594153 Reviewed-on: https://gerrit.libreoffice.org/44342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-06TSCP: put more duplicated methods to commonTomaž Vajngerl
Change-Id: Ic49e0dad1351684db3372214604d12b48d0be907 Reviewed-on: https://gerrit.libreoffice.org/44337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-04Replace lists by vectors in animation parts (sd/animations)Julien Nabet
Change-Id: Ie5306041e5cde5617e460ae4d98861e8d26e389d Reviewed-on: https://gerrit.libreoffice.org/44297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-04TSCP: add a full text. value of the header/footer as doc. propertyTomaž Vajngerl
Change-Id: I4742066c34802017790c1c21ec04a7760d4fe1f7 Reviewed-on: https://gerrit.libreoffice.org/44279 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-04Resolves: rtl: tdf#60315 slide pane context menu misplacedCaolán McNamara
so use same (slighty crazed) logic as DrawViewShell::Command to get the right place when rtl is enabled Change-Id: Icb4a39310ab98bd186cbafd516ca5f323da8cce1 Reviewed-on: https://gerrit.libreoffice.org/44274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-03Revert "A first step to refactor ShapeList (sd)"Julien Nabet
This reverts commit c5857a0371dcc7977e68d48f08f2a3ecefb67b89. Change-Id: I59326867bdf71dcf20a86e03499884452675c557 Reviewed-on: https://gerrit.libreoffice.org/44284 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03TSCP: Paragraph signature RDF namespace now urn:bailsAshod Nakashian
And remove PARAGRAPH entries from ClassificationResults to restore adding the parens correctly. Change-Id: Id0f07758e4daad8d0736800e211e35e9c7e026cf Reviewed-on: https://gerrit.libreoffice.org/44145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-03TSCP: flesh out ClassificationResultAshod Nakashian
Change-Id: Ie6ee33cc21f6f27ae1d58a0e47f367b0539e4378 Reviewed-on: https://gerrit.libreoffice.org/44117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-03TSCP: use the BAC identifier as the RDF keyAshod Nakashian
DOCX RDF -> SmartTag logic expects urn:bails namespace to dump the RDF, and it also needs to have the rdf file in tscp/bails.rdf, hence the move. Change-Id: I9ae496c97abe97d3596de46ffccd5f7c80e37d34 Reviewed-on: https://gerrit.libreoffice.org/44116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-03A first step to refactor ShapeList (sd)Julien Nabet
Change-Id: I5b036a9e2ba2b4c5eb784d7264adaa525fd4c08d Reviewed-on: https://gerrit.libreoffice.org/44156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-02coverity#1420536 Unchecked dynamic_castCaolán McNamara
Change-Id: I289f61fe7e9d6b8c37b70a8fce56090c72af9abf
2017-11-01TSCP: Support DocInfo.Custom field for ODP file formatTomaž Vajngerl
Impress has a limited support for fields - this includes support for DocInfo.Custom field, which shows the user defined custom fields that are used in TSCP. This commit adds minimal support (only what is needed for TSCP) for DocInfo.Custom field but only supports string fields for now. It is not possible to add the field manually, at least not until the full support is added. Change-Id: Ib3b73ab22fd4fe65ab6fb5173fe035a3359deea5 Reviewed-on: https://gerrit.libreoffice.org/44041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-01TSCP: simplify key creation and detectionTomaž Vajngerl
Change-Id: I5f87e77cf529d1c4d37ea55b8858c374a66ea9e4 Reviewed-on: https://gerrit.libreoffice.org/44018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-01TSCP: extract some functions, simplify codeTomaž Vajngerl
Change-Id: I993b272b0976e857506041794f5c00183e5854a9 Reviewed-on: https://gerrit.libreoffice.org/44017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-01impress: notebookbar_grouped full and compactYousuf Philips
Change-Id: Ic128be38d25937bfda5599602a201892d0d3a8bb Reviewed-on: https://gerrit.libreoffice.org/44139 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-01TSCP: don't modify the class. object, delete and create a new oneTomaž Vajngerl
In Impress advanced classification, a new text object is created the first time and added to a master page, and then later, if changed, the object ismodified. The modification however didn't work, so instead of modifiying, try to delete all text objects (identified for classification) from the master page and then create a new one from scratch. Change-Id: I2263949a1c08e98ce066883648d866175f42c91d Reviewed-on: https://gerrit.libreoffice.org/44016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-31loplugin:constantparam in editengNoel Grandin
Change-Id: I0a07326d5b63e82ef16e02f75fd8523e3b73e1f4 Reviewed-on: https://gerrit.libreoffice.org/44096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in sdNoel Grandin
Change-Id: I1c5e5a26d343ac3aa244d7b053f2ec6922edbb21 Reviewed-on: https://gerrit.libreoffice.org/44085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31TSCP: proper collecting and applying of paragraph and text weightTomaž Vajngerl
Change-Id: I22edc4adb87706a176c3afa3500963c4a5b46ee7 Reviewed-on: https://gerrit.libreoffice.org/44015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-30related: tdf#103884 remove gltf/collada featureThorsten Behrens
Change-Id: Icd26ad96c0337844ef1463dabfbe791caa00dd2d Reviewed-on: https://gerrit.libreoffice.org/43972 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-29tdf#110357: Impress table looses selection when clicking on ...Tamás Zolnai
... Increase \ decrease font button Change-Id: I52cf853de01b06c6c9db9779f15174f895789da8 Reviewed-on: https://gerrit.libreoffice.org/43962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-28TSCP: bump the doc classification if lower than paragraphAshod Nakashian
The document classification should not be lower than the highest-classificed paragraph. This insures that the document classification is as high as the highest classified paragraph upon saving. Change-Id: Ic838b886ecf97da2eca56870f68aa3e51c7291f6 Reviewed-on: https://gerrit.libreoffice.org/43772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-10-27tdf#110002: Sidebar shows 2 as font height for some specific...Tamás Zolnai
... Impress tables cells While clicking inside a table we can avoid to unmark and remark the corresponding table. This unneccessary unmark\remark operations trigger a lot of useless updating stuff. For example it regenerate the whole sidebar while we still in the table so the sidebar's context did not actually change. Change-Id: I4c56b87b032e3cced3f09801147784dd2baaf9ef Reviewed-on: https://gerrit.libreoffice.org/43961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-27loplugin:constantparam in sd,sdextNoel Grandin
Change-Id: Idc3507b80da046aca00283e99fdca35cb624c3da Reviewed-on: https://gerrit.libreoffice.org/43952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27ODP: export TextPreRotateAngleSzymon Kłos
Change-Id: I13eb005195ebbdee5016bf279cba423e388723a0 Reviewed-on: https://gerrit.libreoffice.org/43910 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-27ofz#3830 Integer-overflowCaolán McNamara
Change-Id: Ia58552034aba32e9ecf00745d0cadc1e323c3c41 Reviewed-on: https://gerrit.libreoffice.org/43933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27coverity#1420317 Unchecked dynamic_castCaolán McNamara
Change-Id: I33d065780ece2aab5f5a07d0dfd5493005a22b33 Reviewed-on: https://gerrit.libreoffice.org/43917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26More loplugin:unnecessaryparenStephan Bergmann
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in loplugin:unnecessaryparen. However, that would still not look through implicit CXXConstructExpr, so would still not have found the occurrences in 81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode. Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not entirely sure in which situations non-implicit CXXConstructExpr---that should thus not be ignored---would occur, but assume they would be underneath something like a CXXFunctionalCastExpr, which is not ignored.) Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
2017-10-26loplugin:finalclasses in sdNoel Grandin
Change-Id: I0947aa295ba1859ebc1e7ce9ce2e621f02d399ce Reviewed-on: https://gerrit.libreoffice.org/43846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26PPTX export: correct position of rotated groupsSzymon Kłos
* added testcase for tdf#113263 Change-Id: I7abf68d8fb4ffd8b883cfbf4d69916912add8182 Reviewed-on: https://gerrit.libreoffice.org/43794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-24ofz#3760 Divide-by-zeroCaolán McNamara
Change-Id: I951d5f167effe8cb856e28afec890218df698fde Reviewed-on: https://gerrit.libreoffice.org/43760 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-24tdf#113227 FILESAVE: PPT: bullets disappear after RTNoel Grandin
regression from commit afa675469cd9894f41a6b9eeb2e7acc8245d256c use SvxExtNumType in SvxNumberType where I managed to put a "default: break" statement in the wrong place Change-Id: Ic821a03208a75363c538c4641077b084f1e2d242 Reviewed-on: https://gerrit.libreoffice.org/43737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: sdStephan Bergmann
Change-Id: I4b75316c8644a591e6d1cfab4945ef123f945b53
2017-10-23chmod 0755 -> 0644 for some source filesStephan Bergmann
Change-Id: Ibe5b5e03374419c2c23cd6559ab213d2dc2fcc66
2017-10-23tdf#113263 Revert "PPTX export: correct position for shape in group"Szymon Kłos
This reverts commit fd3383556881d6a9d73e1a3027c079cf9bfddecb. Change-Id: Ia9befead3b45975d91215cea584b32afadb5bd52 Reviewed-on: https://gerrit.libreoffice.org/43711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-23Simplify some includesStephan Bergmann
...where the relevant path is already found via -I settings Change-Id: I9cb13b7b648ff2b1983a8b80d5047c4d9da9f515
2017-10-23tscp: advanced classification dialog for impressTomaž Vajngerl
Change-Id: I76c81e6f84de8160c20f1614d7676f2f2c3fb155 Reviewed-on: https://gerrit.libreoffice.org/43361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21check ppt property size against max available lenCaolán McNamara
Change-Id: Ie99a68ea34edfb480d41cf832d3044f4bf686585 Reviewed-on: https://gerrit.libreoffice.org/43661 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-21check seeks earlierCaolán McNamara
Change-Id: Id392f2299b6bdacb9a71e94959d24d02417d571e Reviewed-on: https://gerrit.libreoffice.org/43657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-21check seekCaolán McNamara
Change-Id: I610a650caaffe6510c1a13831b810f1dd0eab8ae Reviewed-on: https://gerrit.libreoffice.org/43656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-21loplugin:redundantcast handle dynamic_castNoel Grandin
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb Reviewed-on: https://gerrit.libreoffice.org/43621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-21coverity#1401307 document checked 'Uncaught exception'Caolán McNamara
markup std::unique_ptr where coverity warns a dtor might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: Icc99cdecf8d8b011e599574f0a05b59efd1c65c2 Reviewed-on: https://gerrit.libreoffice.org/41561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20tdf#97630 xmloff: ODF extended draw:fit-to-size messMichael Stahl
The plan: 1. As Regina points out, there is already (in ODF 1.2, but not ODF 1.1) a style:shrink-to-fit attribute for shapes, so use this to represent the AUTOFIT value. The fallback from AUTOFIT to draw:fit-to-size="true" was a stupid idea anyway, probably "false" is less annoying in practice. There are 2 different shapes that implement TextFitToSize property: a) text shapes already interpret ALLLINES and PROPORTIONAL exactly the same b) fontwork custom shapes interpret ALLLINES but do nothing for PROPORTIONAL As Regina points out, there is no shape that needs to distinguish between ALLLINES and PROPORTIONAL, so we do a minor behavioral API CHANGE and from now on interpret PROPORTIONAL as ALLLINES on fontwork custom shapes. This obviates the need to distinguish the values in ODF and so we don't need a new attribute, just use draw:fit-to-size="true" for both. On import, use MID_FLAG_MERGE_PROPERTY to combine the 2 attributes into one value. 2. Restrict the export of draw:fit-to-size to only the standard values "true"/"false". This implements step 1, the step 2 will be done in the future when most users have the import of the style:shrink-to-fit. Change-Id: I4a378aa110fdb82db7a99a839d7ff207248a73e7 Reviewed-on: https://gerrit.libreoffice.org/43521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-19Make Library_sdfilt find Library_sd include files via -IStephan Bergmann
...instead of through ../../... paths. Change done in preparation of loplugin:includeform. Change-Id: I1b4476f32573c2ef19d2a145e6e617b63006d40b Reviewed-on: https://gerrit.libreoffice.org/43562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Make include file found through -Isd/source/ui/incStephan Bergmann
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: I954b6f7132db103c6b89a4ca1577b16f94e800c2 Reviewed-on: https://gerrit.libreoffice.org/43561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>