summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-06-30schema,sd: enable ODF validation in sd testsMichael Stahl
There are actually 2 bugs here that affect the export, and just 1 new attribute. Change-Id: Id2d9eeeb62c97011712a376a844dec7c8a744116 Reviewed-on: https://gerrit.libreoffice.org/56606 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-29Improved loplugin:redundantcast (const-qualified typedefs): sdStephan Bergmann
Change-Id: I043576ca1fa83180b326f65b05f6bc5c21814e82 Reviewed-on: https://gerrit.libreoffice.org/56701 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-29tdf#104199 sd: export non-borders as noFillJustin Luth
...followup to commit 76505bbd862b17b9b02a2d6e68bac308890dec70 which made the border invisible by setting the color to COL_AUTO. But being invisible isn't good enough because on a round-trip we are now losing the "noFill" attribute and saving a defined border. However, COL_AUTO is turned into white during import, in both LO and in MSO, so round-tripping displayed a white border instead of an invisible one. Change-Id: If6cb513ca6e4336e49bc56a9509aede2e1937063 Reviewed-on: https://gerrit.libreoffice.org/55658 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-06-29tdf#115233 Don't reset crop when replacing a graphicPaul Trojahn
When passing DND_ACTION_MOVE to View::InsertGraphic, the whole object gets replaced. DND_ACTION_LINK should be used, because it just replaces the graphic and keeps crop information. Marking the object is not needed, because InsertObjectAtView and ReplaceObjectAtView already take care of that. Change-Id: I0d829ec39a9d484a7c8946252e90eddb12ea9756 Reviewed-on: https://gerrit.libreoffice.org/56401 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-29menubar draw update zoom subgroup in viewandreas kainz
in every app there is in view as last subgroup zoom ordinary you have fullscreen and zoom with the submenu as in draw there fuulscreen isn't available panning was shown and the submenu was updated to show also the draw specific zoom items Change-Id: I390ac40815aa28c7df883cf63dcd214b181785ed Reviewed-on: https://gerrit.libreoffice.org/56586 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-06-28tdf#53993 broadcast the change when dragging ends.Mark Hung
Eventually MotionPathTag::Notify() and CustomAnimationPane:: updatePathFromMotionPathTag will be called to update the motion path of the effect. Change-Id: I1cd0756ea24d9b56ad3c44c99ef015c584c74dc7 Reviewed-on: https://gerrit.libreoffice.org/56353 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-28tdf#107690 DOCX, XLSX and PPTX unit tests for "Open as read-only"László Németh
ie. OOXML export/import of "_MarkAsFinal" MSO document property. Change-Id: I01f0702d5467e78eb93ce8dce8ba25874839c3e3 Reviewed-on: https://gerrit.libreoffice.org/56475 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28tdf#107690 OOXML import/export of setting "Open as read-only"László Németh
Import custom document property _MarkAsFinal as LoadReadonly setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX and PPTX documents. Before this fix, LibreOffice opened read-only OOXML documents as editable, also saved and exported _MarkAsFinal=true silently, resulting unintented read-only warning info bar in MSO. This commit improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. Note: LoadReadonly (on File->Properties...->Security, property "Open file read-only") doesn't show "Edit read-only" info bar from commit 630186ff4e0eba7317e542f8c3eca39ebd068721, but it's still possible to switch on editing by Edit->Edit Mode. MSO shows info bar for _MarkAsFinal. (There is an advantage to hide the info bar in LibreOffice in a mixed environment, to avoid overwriting of press-ready MSO files by LibreOffice.) Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal in MSO: (1) Switching on editing doesn't remove the LoadReadonly property automatically in LO. (2) Saving with LoadReadonly doesn't switch off editing of the actual (still opened) document in LO. Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216 Reviewed-on: https://gerrit.libreoffice.org/56180 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk
new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: https://gerrit.libreoffice.org/56443 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-28tdf#42949 Fix IWYU warnings in include/osl/*hGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7 Reviewed-on: https://gerrit.libreoffice.org/56491 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-27loplugin:useuniqueptr in OutlineBulletDlg and SdPresLayoutTemplateDlgNoel Grandin
Change-Id: I4bd0a9dd7be5b6ad7c1307f73c89ab0ee915ce9f Reviewed-on: https://gerrit.libreoffice.org/56495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-27tdf#114845 sd: only shift rotated group itemsJustin Luth
fixes 6.0 commit 9ae1e094d5a8a5b4432c88ebea0ca9fc1c79f602 > PPTX export: correct position of rotated groups However, there was nothing excluding the re-positioning to only group items. Change-Id: I62e36b46c0d2ac3e41f8d7d4ed82df11e6eb1ee5 Reviewed-on: https://gerrit.libreoffice.org/56386 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-06-27loplugin:useuniqueptr in sd::CommunicatorNoel Grandin
Change-Id: If4725a7c170a4f10b1ffd0cfc769fcdca70e2eaf Reviewed-on: https://gerrit.libreoffice.org/56493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-27loplugin:useuniqueptr in PortionObjNoel Grandin
Change-Id: I79fcbaa12def04aa36bdf1928638b70ad490448c Reviewed-on: https://gerrit.libreoffice.org/56494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25smartart : test documentsekuiitr
Change-Id: I163a080cfae988db38fbd7b3d9de1531f6ba4089 Reviewed-on: https://gerrit.libreoffice.org/54112 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-25loplugin:useuniqueptr in sd::ViewNoel Grandin
Change-Id: I8902a792d9dc1ba2bc50a53c10a387f34af50307 Reviewed-on: https://gerrit.libreoffice.org/56339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in sd::RulerNoel Grandin
Change-Id: Ic1f213b039b9c3e1cedc041d3e136eb09496570d Reviewed-on: https://gerrit.libreoffice.org/56338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in FuDisplayOrderNoel Grandin
Change-Id: I53241b4cd45ffd6cdbf81c2984a7e95e67a00b93 Reviewed-on: https://gerrit.libreoffice.org/56335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in ViewIteratorImplNoel Grandin
Change-Id: Ia17fbfbbb76d035c669e797c98a095667187ee80 Reviewed-on: https://gerrit.libreoffice.org/56337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in SdLayerManagerNoel Grandin
Change-Id: I95c17965e7de1daf0b548220326e05371b71b1ae Reviewed-on: https://gerrit.libreoffice.org/56336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in SdNavigatorWinNoel Grandin
Change-Id: Ib1005ab0a0a007d2bad956c8ca0c23c475736d5f Reviewed-on: https://gerrit.libreoffice.org/56332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in CustomAnimationDialogNoel Grandin
Change-Id: Ic2e93c1493159c9602bd68b409052117766dcc02 Reviewed-on: https://gerrit.libreoffice.org/56328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25tdf#114845: unit test to prevent a bad fixJustin Luth
The fix I was about to suggest broke this file on round-trip. It is not enough to just exclude if not a group-shape, or else the group-shape detection is not good enough. Change-Id: I0048bb9221262afdd373b18b5d73ec9468b7d670 Reviewed-on: https://gerrit.libreoffice.org/56340 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-06-24sd: Reduce the number of possible intermediate allocationsTakeshi Abe
... by reserving enough space at once. As the length of these vectors depends/grows on user's input, this change can be a micro optimization. Change-Id: I1baa7d1433875491e86403d727f11f676d29a833 Reviewed-on: https://gerrit.libreoffice.org/56346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-24tdf#33022 Dispose the deprecated motion path.Mark Hung
Change-Id: I8b31b0feedd84893327b2a4acc436d46c2306450 Reviewed-on: https://gerrit.libreoffice.org/56240 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-24tdf#67611 re-add the effect if nothing is left in the textgroup.Mark Hung
Unlike regular shape object whose shape effect were kept after change text grouping to "as object", the effects of all the outline objects were removed. Re-add the effect if nothing is left there. Change-Id: I6d06fad709639f2d2976f6027b8d193f66893c90 Reviewed-on: https://gerrit.libreoffice.org/55973 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-24tdf#47795 set mnTextGrouping to last non WITH_PREVIOUS level.Mark Hung
Change-Id: I8ca3b421dbfa83c19234f5cbde0a2ae340d3d268 Reviewed-on: https://gerrit.libreoffice.org/55979 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-24sd effects: keep configurations that is not changed.Mark Hung
Change-Id: Ia2c670c708caaf8ab50a13e0635c13a759fd5941 Reviewed-on: https://gerrit.libreoffice.org/55974 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-24tdf#45178 notify object rename and update effect description.Mark Hung
Change-Id: Ib63147a9f4dceb35e21bcf0ca5c1afebf5263721 Reviewed-on: https://gerrit.libreoffice.org/56048 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-23tdf#96099 Remove trivial std::vector typedefs in sd, sfx2, shellArkadiy Illarionov
Change-Id: Ib3708c9650f273de4a2f549d2ce9f2465bd37d6c Reviewed-on: https://gerrit.libreoffice.org/56206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-22tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[f-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie93b7695e4c67fc55089b21a5df37a3468ad4bee Reviewed-on: https://gerrit.libreoffice.org/55565 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-21NFC sd misc cleanup: earlier exit, commentsJustin Luth
The exception in the case of a running slideshow has been around since the function was introduced, but more and more code has been building up in front of that if clause. Since no changes will be made, include that exception in the initial exit clause to avoid unnecessary computations. This cleanup is prep work for a bug fix. Change-Id: Ief0b07d8108e1576459486ef61f038443f64705f Reviewed-on: https://gerrit.libreoffice.org/54678 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-06-21simpress: Fix duplicate ID in notebookbar.uiSamuel Thibault
and enable the corresponding gla11y warning Change-Id: Iabf850f6831cb7d269aa74c9ab50461d35871a16 Reviewed-on: https://gerrit.libreoffice.org/55750 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-21loplugin:useuniqueptr in AnnotationWindowNoel Grandin
Change-Id: I3ea0b0ed28e85e7f8cf00e73b6698a5773c886ba Reviewed-on: https://gerrit.libreoffice.org/56197 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in AnimationWindowNoel Grandin
BitmapEx and tools::Time are both value objects, no need to use std::unique_ptr for them Change-Id: Ibeed7da46ccc8fd3cd3301d364ae33c33c0114bb Reviewed-on: https://gerrit.libreoffice.org/56198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in EasyFileNoel Grandin
Change-Id: Ic18811145db90a7f9eff61e94069e68b3c80c298 Reviewed-on: https://gerrit.libreoffice.org/56196 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in SdDrawDocumentNoel Grandin
Change-Id: Id67b08d8d8a08d7e19ef8534b7bb9d689a571e06 Reviewed-on: https://gerrit.libreoffice.org/56105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in HtmlExportNoel Grandin
Change-Id: Ib146bdfd04f428d922e23ec6b5054d53326ca5f3 Reviewed-on: https://gerrit.libreoffice.org/56106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in PropertyControlNoel Grandin
Change-Id: I6b648f26f3946da27585a70f18406e92d9de80c2 Reviewed-on: https://gerrit.libreoffice.org/56107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-19tdf#90243 don't append index if shape already has a name.Mark Hung
Change-Id: I518ad83bf3782af7cb3144982ec8844a573f0de4 Reviewed-on: https://gerrit.libreoffice.org/56051 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-06-18vcl: share GfxLinkAshod Nakashian
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-17tdf#42949 Add a class declaration to include/sfx2/shell.hxxGabor Kelemen
This is necessary to not get IWYU warnings or build errors where SFX_DECL_INTERFACE is used Also remove an earlier workaround in sd Change-Id: I4cc86f7ad0c83aeaae225ee05af34fa49ba67e73 Reviewed-on: https://gerrit.libreoffice.org/55955 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-16AW080: Continued cleanups/remaps/correctionsArmin Le Grand
Change-Id: I953f29e6a8d398e00884a600d6f4ceba880489a5 Reviewed-on: https://gerrit.libreoffice.org/55913 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-16tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[dDE]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here and a bit of fallout management. Change-Id: Ie86a34f7f091525f21369f989165a56eace70513 Reviewed-on: https://gerrit.libreoffice.org/55558 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-16AW080: Cleanup of 3D Object methodsArmin Le Grand
Change-Id: I3a8247aabd2fd24b53faf9e1e8da29856dde70bf Reviewed-on: https://gerrit.libreoffice.org/55897 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-15tdf#96099 Remove some trivial std::vector iterator typedefsArkadiy Illarionov
Change-Id: Iced10ed59c475dff4d33ff06151b2015a27a860b Reviewed-on: https://gerrit.libreoffice.org/55715 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-14tdf#100894 freeze when editing calc file with bazillions of cond formattingNoel Grandin
This does not fix the root cause of this problem, which is simply that the document has a bazillion style sheets. Either the program which exported this document is broken, or our importer is not correctly de- duplicating the imported stylesheets. Anyhow, I made performance improvements until I realised that it was simply going to be impossible to display that many stylesheets in our UI. But still, this bug was useful in flushing out some performance issues. The improvements, in order of decreasing importance are: (*) Use SfxStyleSheetIterator in SvxStyleToolBoxControl::FillStyleBox to avoid an O(n^2) situation where the pool repeatedly marks all the stylesheets as not-used, and then walks the document finding out if a stylesheet is used. Which is a waste of time because we're searching the documents pool, so of course they are all used. (*) Add a virtual method to avoid dynamic_cast (*) return raw pointers instead of returning rtl::Reference by value to avoid unnecessary reference counting. SfxStyleSheetIterator Change-Id: I15ff9c1846d3ed3e6f5655fa44c762f7619d547a Reviewed-on: https://gerrit.libreoffice.org/55751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14tdf#104199 sd: nofill borders shouldn't be visible.Justin Luth
regression from export bugfix tdf#90190. rLineProperties.maLineFill was set, but that value was never used, leaving aBorderLine with the default value. Setting borderline to COL_AUTO lets it merge in with background colors while still taking up the space defined by the border width. The existing unit test says "it is likely you will break this if fixing background issues, so feel free to adjust the test values." Indeed, this patch removes an unwanted black border, so utilizing that test as a proof. Change-Id: I0725a3d5874a509a4464c586d60c77cde2b49fcb Reviewed-on: https://gerrit.libreoffice.org/55205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-06-12tdf#118063 Impress: Deselected spacing remained checkedIlhan Yesil
The state of the attributes for spacing are now read and set correctly. Change-Id: I661c00e247b55c64ea39c03db77dab9fa0775852 Reviewed-on: https://gerrit.libreoffice.org/55455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-01-14 14:47:33 +0000