Age | Commit message (Collapse) | Author |
|
...so forbid anything else, to avoid issues like the one described in
766cdd869d7d983e9e171a3eae0629cb9a0206ff "This code wants to add the numeric
SvxRotateMode value". Some remaining places that apparently do want to convert
some numeric value to sal_Unicode have been augmented with an explicit cast.
Change-Id: I6200a84e250e697bc88694bd71142ca1d9a13651
Reviewed-on: https://gerrit.libreoffice.org/81132
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I763f9a3f57efcd47643ca4651e2454e95c6921c9
Reviewed-on: https://gerrit.libreoffice.org/81127
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I51aceb8a1f908cf89a0b8b6d0e58755fc4374862
Reviewed-on: https://gerrit.libreoffice.org/81075
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iad1a4dbd603e9258e8835e7ab534cd74f4882968
Reviewed-on: https://gerrit.libreoffice.org/81074
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1ac98096d117e3ae7c2f0be2690acef32b85fbdb
Reviewed-on: https://gerrit.libreoffice.org/81073
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds
with our PCHs.
Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5
Reviewed-on: https://gerrit.libreoffice.org/80961
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I9bd29b7377fdf0e1ba36cc021e7e78f83bb1c12c
Reviewed-on: https://gerrit.libreoffice.org/80960
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Since that variable holds the relevant includes, using
'gb_LinkTarget_set_include' makes sure that those
flags end up in the correct section, e.g. when generating
IDE integration using 'gbuild-to-ide'.
E.g. for the 'qtcreator-ide-integraton' make target, this
makes sure that they end up in the 'INCLUDES' section in
'sd/sd.pro' and not the 'DEFINES' section, which previously
led to an "error: macro name must be an identifier" being
shown when editing files underneath 'sd/' in Qt Creator with
the Clang Code Model plugin enabled, s.a. commit
4aa60490622cc10f8d3a31489c62a5622d240c83
("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines").
Corresponding entry in my config_host.mk.in on Debian
bullseye/testing:
export DBUS_GLIB_CFLAGS=$(gb_SPACE)-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
Change-Id: I9af9a58fdc05ce6648221c00a20859be777843f9
Reviewed-on: https://gerrit.libreoffice.org/80944
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Commit 5926b22b5dc33490d23d594b129eb8a70b94ffb0
("The SystemEnvData passed into the canvas factories appears to
be unused") removed previous arg at index 1, so adapt here, too.
This makes the presenter console shown again (tdf#128166).
A visible result of FullScreenPane::CreateCanvas passing wrong
args was that an Impress presentation shown in presentation mode
in dual screen using the qt5/kf5 VCL plugin wouldn't terminate
properly and crash Impress on close.
Change-Id: I3933864d4bb007cfdefb0a20378ff3d75ea6cd85
Reviewed-on: https://gerrit.libreoffice.org/80933
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Replace them with default initialization or calloc
Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1
Reviewed-on: https://gerrit.libreoffice.org/80805
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Icc19b6e3493f1d9e49584c3e2ac99509fae4e02e
Reviewed-on: https://gerrit.libreoffice.org/80923
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
It started out as a wrapper around character literals, but has by now become a
wrapper around arbitrary single characters. Besides updating the documentation,
this change is a mechanical
for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done
Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f
Reviewed-on: https://gerrit.libreoffice.org/80892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
and extend O*StringView to have a constructor that takes a pointer and a
length
Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8
Reviewed-on: https://gerrit.libreoffice.org/80872
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifa4589fb50affc4c5ffb52288db8533c98ec6dd9
Reviewed-on: https://gerrit.libreoffice.org/80587
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
|
|
by hand, because I don't feel like teaching this specific idiom to the
plugin
Change-Id: If400677dac842ca740c4532ed79f6f18f752b730
Reviewed-on: https://gerrit.libreoffice.org/80842
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifbdb3e41eae665f7dcaf5301aaba2b6e4662cf48
Reviewed-on: https://gerrit.libreoffice.org/80855
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
look for OUStringBuffer append sequences that can be turned
into creating an OUString with + operations
Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6
Reviewed-on: https://gerrit.libreoffice.org/80809
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Regression from commit 943a534ac7cb3df513583e226c986dafd8ba246b
(tdf#123684 PPTX import: fix wrong background color for <p:sp
useBgFill="1">, 2019-04-23), the problem was that we didn't handle the
case when a shape had an XML fragment like this:
<p:sp useBgFill="1">
<p:style>
<a:fillRef idx="1">
<a:schemeClr val="accent1"/>
</a:fillRef>
</p:style>
</p:sp>
i.e. the shape both wants to use background fill and it has a style
declaring how to fill it as well. We gave the style a priority, while
PowerPoint gives the background fill a priority.
Fix the problem by not setting the fill from the style in case the
background fill is already set.
Change-Id: Ie1b56e5615219138a5b7ddd7a2b25295b991bc05
Reviewed-on: https://gerrit.libreoffice.org/80804
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I631ee8b101bacc4dec075100aa25158b71fbae40
Reviewed-on: https://gerrit.libreoffice.org/80681
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
which defeat the *StringConcat optimisation.
Also make StringConcat conversions treat a nullptr as an empty string,
to match the O*String(char*) constructors.
Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b
Reviewed-on: https://gerrit.libreoffice.org/80724
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Setting this option will prevent copying/dragging any content from LO
to another program or even another LO window.
Change-Id: Ifbc032a4fa69ac1a17d4b500f5a30f5399d84ed7
Reviewed-on: https://gerrit.libreoffice.org/80586
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: If3084f7ffaceb774dba1b1f195229313a8f1d04a
Reviewed-on: https://gerrit.libreoffice.org/80670
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Adds arrangement actions to position & size sidebar so it is
possible to move the object up/down in the stack.
As Draw/Impress uses it's own action names for the same UNO action
(Forward/Back in Draw and ObjectForwardOne and ObjectBackOne in
Writer/Calc) also add the global ones to Draw/Impress and connect
them to the same function as Forward/Back. This commit does not
unify them however (Forward/Back are still used in menus/toolbars)
but this could be done in the future.
Change-Id: Ibb152f29dbe11dfb1b6a057e6ea60b21029912e2
Reviewed-on: https://gerrit.libreoffice.org/80729
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Wont work because it will disable undo during any scripts that luck/unlock documents for their duration
This reverts commit fae4f1506fc481b8dc2977d3bf9363dd8eaf4945.
Change-Id: I447560c9200d381ea93e2275abd57f91c5acc819
Reviewed-on: https://gerrit.libreoffice.org/80725
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I1a5e17dc056311caba3dbabfb70d21e87344eda0
Reviewed-on: https://gerrit.libreoffice.org/80429
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I033c15db6848e96ba6b6bd7a2852c9e4d1524a8e
Reviewed-on: https://gerrit.libreoffice.org/80630
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
(cherry picked from commit f107161bbd0eb4ee5766f5f983d18b32b929b15c)
Change-Id: If717db82fe6ab14bbf32225c1f1c95f44954f011
Reviewed-on: https://gerrit.libreoffice.org/80667
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I31c0d004d717564063c36862f9eef661d18768a9
Reviewed-on: https://gerrit.libreoffice.org/80648
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
mostly so that my stringadd loplugin can point out places to improve
Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5
Reviewed-on: https://gerrit.libreoffice.org/80618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and improve the WriteOString method, we can avoid the strlen here, we
already have the length
One change in behaviour to be noted - if the string contains
trailing zero bytes, which ARE INCLUDED IN THE STRING LENGTH,
i.e. I'm not talking about the normal terminating zero, then this
patch changes behaviour because we will now write those zeros to
the stream.
Change-Id: I4668b9b9eb877f820b1dc70d6cd10ba2623bc0a2
Reviewed-on: https://gerrit.libreoffice.org/80597
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Obtain lang attribute of rPr element from CharLocale,
CharLocaleAsian, or CharLocaleComplex based on the script
type of exported text.
There are several other call sites of WriteRunProperties,
like those in chartexport, and those for text fields,
Here I leave the default to CharLocale so it fallback
to western locale as it did before.
Change-Id: I33679517dd88f9e415933decc02f10afc807ad3b
Reviewed-on: https://gerrit.libreoffice.org/79973
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
...same as 7d361e96c9ea822790db21806e9fc05279423833
"loplugin:redundantpointerops" (that were presumably missed by that commit
because I only pulled 682fdbf1312cf6ca70fe209bf4d7051dad8f5008
"loplugin:redundantpointerops check other pointer types" halfway through my
local build)
Change-Id: I1497e4fca2046cbcd107bb2ac5ed6f41bd68de98
Reviewed-on: https://gerrit.libreoffice.org/80569
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I06d47b69d65c2ab2dbb5bcef19c0ac66eba4c128
Reviewed-on: https://gerrit.libreoffice.org/80571
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I5159ed77c2b3ba2f06e381a738a49dbe17a6a4dd
Reviewed-on: https://gerrit.libreoffice.org/80542
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
and add in two special cases for the mentioned cui dialogs
Change-Id: Ibd2bf8e9e5bff131f2c009c784652f4500842326
Reviewed-on: https://gerrit.libreoffice.org/80488
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
add org_openoffice_comp_Draw_framework_PanelFactory_get_implementation
make it build
Change-Id: I522f3d684c52caf15a78d5eff29e78e645588481
Reviewed-on: https://gerrit.libreoffice.org/80515
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=154847
Regression introduced by:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3c86ffd8ded628e6f2b4187948a1b1056f6a0f56
Change-Id: Id9355958b0c4a56215ff98f0e5be13a3074ce45f
Reviewed-on: https://gerrit.libreoffice.org/80500
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I12517651fb3f777fd08e384992bb3e84b340ad85
Reviewed-on: https://gerrit.libreoffice.org/80382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
See https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-ppt/6be79dde-33c1-4c1b-8ccc-4b2301c08662
"
2.6.1:
A - fAutoAdvance (1 bit): A bit that specifies whether to automatically advance to the next slide
during a slide show based on timing information on the slide.
B - fWillSkipBuilds (1 bit): A bit that specifies whether to display animations during a slide show.
C - fUseSlideRange (1 bit): A bit that specifies whether to display only the slide range specified by
the startSlide and endSlide fields during a slide show.
D - fDocUseNamedShow (1 bit): A bit that specifies whether the slides shown during a slide show
are from the named show identified by namedShow. It MUST be ignored if fUseSlideRange is
TRUE.
E - fBrowseMode (1 bit): A bit that specifies whether the slide show is presented in a way optimized
for browsing. If fBrowseMode is TRUE, fKioskMode MUST be FALSE.
F - fKioskMode (1 bit): A bit that specifies whether the slide show is presented in a way optimized
to run at a kiosk. If fKioskMode is TRUE, fBrowseMode MUST be FALSE.
G - fWillSkipNarration (1 bit): A bit that specifies whether to play slide audio narrations during a
slide show.
H - fLoopContinuously (1 bit): A bit that specifies whether to restart the slide show at the
beginning after advancing from the last slide.
I - fHideScrollBar (1 bit): A bit that specifies whether to display the navigational scroll bar during a
slide show.
"
So yes, "IsEndless" corresponds to "fLoopContinuously"
Document "Skip narration"
+ "show scrollbar" corresponds to Bit 8 (the contrary of "fHideScrollBar")
so since this the Bit 8 of nFlags isn't set, it's always to 0, so we always show scrollbar
Change-Id: Ifb4f62a9f52cdafac9f788f4d6d1deb0cf1b8efa
Reviewed-on: https://gerrit.libreoffice.org/80415
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Idc94a2a912d94a8208348a8d6151c6d7dfe3ccb9
Reviewed-on: https://gerrit.libreoffice.org/80352
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id36265c5bd50d95105e3abf37e999aba80b4712c
|
|
Change-Id: Ie7c2f75ec66ae4c1f8dc49075624617c294cbc25
Reviewed-on: https://gerrit.libreoffice.org/62945
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/79131
|
|
Some, like SID_NAVIGATOR_PAGE were incorrectly using
SfxAllEnumItem, and others did not need to use SfxAllEnumItem.
Change-Id: I0f61dcdda8bbc021667db3cf78141778f7b85087
Reviewed-on: https://gerrit.libreoffice.org/80252
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I62067075853b1d5c893c14d72a247b07a3cc5585
Reviewed-on: https://gerrit.libreoffice.org/80248
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5cffa31b45b7752ba3ff18c8a92da9766fcf8de6
Reviewed-on: https://gerrit.libreoffice.org/80241
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
because we aren't using the array of values in SfxAllEnumItem
Change-Id: I67ccb7737c52f9949495c53881e052d5005882aa
Reviewed-on: https://gerrit.libreoffice.org/80165
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
When IWYU is used to check cxx files it also checks associated
hxx (but for .hxx -> .h too) files too and gives addition/removal recommendations
There is no documented way of disabling this.
Currently f-u-i does not differentiate between recommendations for the
checked file and its header and prints everything.
Which means sometimes I need to update .hxx files or blacklist warnings
that interestingly are not shown when the same .hxx is checked with IWYU.
The worst example is ucb/source/ucp/ftp/curl.hxx where IWYU gives recommendations
for /usr/include/x86_64-linux-gnu/curl/curl.h
Remedy this with considering the full
filename + should add these lines: / should remove these lines:
string as beginning of interesting recommendations
Also remove some now obsolete blacklist entries from yaml files
Change-Id: I1d139536992e4b56c699c31a4cc6491d373c2002
Reviewed-on: https://gerrit.libreoffice.org/80172
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I6dd2f7d54a2dd1d28a2b180887a97750ae8bce36
Reviewed-on: https://gerrit.libreoffice.org/79817
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I557767fe8e148eabddd9ccdaf3fbe6caba2ac05d
Reviewed-on: https://gerrit.libreoffice.org/80083
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id4adbe484f88be74f45dab8e7ef426c66e5cbc8b
Reviewed-on: https://gerrit.libreoffice.org/80002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|