summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20Rename functions to avoid name collisions more generally.Matúš Kukan
Luckily, in this case it's easy to find the only place where we load the symbol. Change-Id: I224fd1e08f268095f8be58b089a643d434bc7a98
2014-02-20cid#1078827 Dereference before null checkNoel Grandin
Change-Id: Id35992113a8e8f2d06bda7f2287227afeec62313
2014-02-20cid#1078825 Dereference before null checkNoel Grandin
Change-Id: I9daa1e3a294db0b205fe5b2ec247bbf550d2dca1
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-19coverity#738820 bAutoSave is unusedCaolán McNamara
Change-Id: I98fca5611e47a4368e4947d29e703e661bfeebaa
2014-02-19coverity#738822 mnTemplate is unusedCaolán McNamara
Change-Id: Ic9c4a520a5a3a849a16f68e033bae9ba83088f6e
2014-02-19coverity#738826 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib76b31ffb4c9708dc5f5d219c7a861a32f8851ff
2014-02-19coverity#738827 mbIsDeselectionPending unusedCaolán McNamara
Change-Id: Icfe7a8f49853ec7250de1c4c578038787eb8f241
2014-02-19unotools: sal_Bool -> boolStephan Bergmann
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-19Avoid app specific CreateDialogFactory code for non-DESKTOP.Matúš Kukan
As happened in 7e9ac5952711400ad856b3328c5cc00c05cec6f2 for cui library. Change-Id: If51201eb452d4b84729b37949fb9b949020b47b8
2014-02-19cid#736800 dereference before null checkNoel Grandin
Change-Id: I51eb6331d74c1484cf12a2a1810485dd8b927a32
2014-02-19cid#736797 dereference before null checkNoel Grandin
Change-Id: Ib279f66fcc349c75d7b3d26ba80356eea1697295
2014-02-18Remove from option-dialog the CurrentPage-option (fdo#71601)Rob Snelders
Change-Id: I28a75468b1f43e0219fa0f03fe89601a77d3cd4d Reviewed-on: https://gerrit.libreoffice.org/7842 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-18Typo (a/A)dditionaly -> (a/A)dditionallyJulien Nabet
Change-Id: Ic4451b45b86f14bb2fab507503a6fa1e8f515b66
2014-02-18Resolves: #i123468# Added SdrEndTextEdit before replacing EmptyPresObj...Armin Le Grand
also secured ReplaceObjectAtView to check for active TextEdit, assert this and make an emergency correction (cherry picked from commit 623cd778689bd0851652b2db00b24c308dfb657a) Conflicts: svx/source/svdraw/svdedtv.cxx Change-Id: I0e9ae1b1cd84e04c37c4de38aca7752804782384
2014-02-18Stick to a single O[U]String hash functionStephan Bergmann
8f8bc0dcf3bc253ae49159d52db049767f476ced "Move string hash function into String class" had introduced a new getHash64 that, besides returning sal_uInt64 instead of just sal_Int32, didn't do sampling of only a handful of characters, but always computed the hash over all characters (as the usage in SfxItemSet and SdPage appears to require for either performance or approximated correctness). However, it would be advantageous to keep the stable URE interface as small as possible. Now, O(1) sampling was apparently considered state of the art when the rtl string classes were first created, closely copying java.lang.String, which at that time demanded sampling for hashCode(), too---but never sampling more than 15 characters, with the obvious (in hindsight, at least) performance catastrophes, so they changed it to O(n) somewhere along the way. Based on that, this commit changes the existing hash functions to not do sampling any more, and removes the newly introduced -64 variants again. (Where the extended value range of sal_uInt64 compared to sal_Int32 was hopefully not vital to the existing uses.) The old implementation used sampling only for strings of length >= 256, so I did a "make check" build with an instrumented hash function that flagged all uses with inputs of length >= 256, and grepped workdir/{Cppunit,Junit,Python}Test for hits. Of the 2849 hits encountered, 2845 where in the range from 256 to 295 characters, and only the remaining four where of 2472 characters. Those four were from CppunitTest_sc_subsequent_filters_test, importing long text into a cell, causing ScDocumentImport::setStringCell to call svl::SharedStringPool::intern, which internally uses an unordered_set. These results appear to justify the change. Change-Id: I78fcc3b0f07389bdf36a21701b95a1ff0a0d970f
2014-02-18callcatcher: update unused code listsCaolán McNamara
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-17comphelper: sal_Bool -> boolStephan Bergmann
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17cid#705877 dereference before null checkNoel Grandin
Change-Id: I78d51802fa5709d1aaccb3a73929b39bf75b4219
2014-02-17Resolves: #i42894# added support for <presentation:animations>...Armin Le Grand
at import and creation (cherry picked from commit 0f11a9d487744af6c50e9f1d547c22cd4bdeab48) Conflicts: sd/source/core/EffectMigration.cxx sd/source/ui/dlg/animobjs.cxx sd/source/ui/unoidl/unoobj.cxx Change-Id: Ib498bf718d40501cbab71a700342343df68a6ee9
2014-02-15fdo#63154 Remove unused solar.h reference in sd.Alexandre Vicenzi
Change-Id: I3dca2ffe3f94bedfea954bd83e84c724fb564ec9 Reviewed-on: https://gerrit.libreoffice.org/8063 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-14inserting a picture in a blank placeholder is setting its bgCaolán McNamara
which isn't probably what we want here, we want to replace it fully like we always did. The old behaviour that if the frame is non-empty then we fill its bg with the color is still the case after this change. regression since 5c75cd95178e3d57e53fee64a9d64023c6d18acf Change-Id: Ib670a7f0dae5809d6936910b6ba4886a99fb7e64
2014-02-14sal_Bool->boolNoel Grandin
Change-Id: Ib0f6699e994f5a71603779b8227bf081b71a5dd6
2014-02-14warning C4018: '<' : signed/unsigned mismatchStephan Bergmann
...at for(sal_uInt32 p = nInsertPos; p < (nInsertPos + nBMSdPageCount); p++) Change-Id: I7c81bc4e51f394c3f4d77bab4ed8a4ae9a35c83e
2014-02-14cid#704734 reference after null checkNoel Grandin
Change-Id: I54a51427347bdd363fc980db4c1ef1a1feb99177
2014-02-14Drop unnecessary #includeTakeshi Abe
Change-Id: I7518b1014676fda6cfc052e110859cfbf7ca30ad
2014-02-13coverity#737846 Uncaught exceptionCaolán McNamara
Change-Id: I9257ec4d9ccb7c602a9537230b61be944371d3ad
2014-02-13coverity#737840 Uncaught exceptionCaolán McNamara
Change-Id: I3e11ac315adbe2f64bfc391234c517472950aeff
2014-02-13coverity#737837 Uncaught exceptionCaolán McNamara
Change-Id: Ia71f03515ae209619b73aa617c4649cc4de4dfa6
2014-02-13coverity#737836 Uncaught exceptionCaolán McNamara
Change-Id: I533cccc1dab5e8d722209c37f0c05331d5c206a8
2014-02-13coverity#737835 Uncaught exceptionCaolán McNamara
Change-Id: If5452880070876a4dfc2526b08928fb219a60529
2014-02-13coverity#737833 Uncaught exceptionCaolán McNamara
Change-Id: I71b3022c84a861959ec1c70a7d2f9e94766df250
2014-02-13coverity#737831 Uncaught exceptionCaolán McNamara
Change-Id: Ie528eb19db50abc475ebc1e9b575e8dfbc5e87c6
2014-02-13coverity#737828 Uncaught exceptionCaolán McNamara
Change-Id: I60920fe65102185139438f5bec663480310b96c6
2014-02-13coverity#737827 Uncaught exceptionCaolán McNamara
Change-Id: Iab21baa94bb2fa3d0de6155e670f198d35de72e9
2014-02-13coverity#737824 Uncaught exceptionCaolán McNamara
Change-Id: Ie8ba13265b436eb3ca548d5ccd2ca28d1e65e035
2014-02-13Update a hatching import test according to the new valuesZolnai Tamás
Change-Id: I2f3504e12be63a326da189e7f69ce87ad2bdb674
2014-02-13fdo#74468 fix timing of slide transitionsDavid Tardon
Regression since commit 16428c9600964a4945cf6fd0d938dea047d1248b. Change-Id: Id274c21e08d10d2e727f3b5a3fd852cd297e4637
2014-02-13-Werror,-Wdeprecated-declarationsStephan Bergmann
Change-Id: I6b10ab0b3f11559f515084b45dc3771627223418
2014-02-13n#757432: Styles (rename &) copy to different decks.Muthu Subramanian
While copying slides to different slide decks, styles were not being copied if there is already one with the same name. This patch renames and copies those to keep the formatting intact. Change-Id: I66f71493f1fd658eed43e39aa7ae7ee7b5463b34
2014-02-13Move string hash function into String class.Muthu Subramanian
hashCode() seems to do sampling while creating the hash. hashCode64() will not. Change-Id: Id30f5a2a774cf5244dbc00da9649e95a532484be
2014-02-12Typo: "omited"/"ommitted"/"ommited" -> "omitted"Julien Nabet
Change-Id: Icc690b0ae1fc8f7165082774720d265798815faa
2014-02-12more SvStream:operator>> conversionNoel Grandin
Convert the template based read_lenPrefixed methods to regular methods. Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019 Reviewed-on: https://gerrit.libreoffice.org/7895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12coverity#705850 Dereference before null checkCaolán McNamara
Change-Id: Icb7dc092c1511006ab6592425d443dadcaeb1784
2014-02-12sal_Bool->boolNoel Grandin
Change-Id: Ie477a46fae2b8c4deb55435f3769ba74037dd259
2014-02-11coverity#735822 Unchecked dynamic_castCaolán McNamara
Change-Id: I88911159659f765e6f2c2f49d3d3e8313b2c9e8f
2014-02-11sd: add some missing locks in new codeMichael Stahl
Change-Id: Id0efc9a0e108886c261e75bc109e090a16fba960
2014-02-11sal_Bool->boolNoel Grandin
Change-Id: I31fb9d5b49260fd1a8fc1312b01fd5632c97ab2e
generated by cgit (git 2.34.1) at 2025-01-07 23:05:35 +0000