summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-19Resolves: tdf#102293 triple click results in visually unselected wordCaolán McNamara
in previously unselected textboxes in impress started happening after... commit 16c7f8916661df24f4681ec82f6bd4d7ad85d141 Date: Tue Jan 12 16:36:49 2016 +0000 tdf#97075 - don't render sdr overlays before we paint in impress instead flush the overlay after activating the edit object if we go on to put the cursor in there. Seems to work. Change-Id: Ib746c36d1074aee09771a3dc1d69834ce80a9c08
2016-09-19Related: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if...Caolán McNamara
This is similar to de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1 where the master page is not the sole owner. Which happens when copying and pasting slides which bring along a duplicate master page to an already existing one, and the attempt to remove the duplicate strips the fill properties from the shared stylesheet in use by the other regression from... commit b876bbe2cacce8af379b10d82da6c7e7d229b361 Author: David Tardon <dtardon@redhat.com> Date: Tue Apr 26 09:17:11 2016 +0200 rbhz#1326602 avoid exp. bg bitmaps from deleted slides Change-Id: I0a3a34ade2ad8464b1edb67a6e28dab45c761a2c
2016-09-18loplugin:unusedenumvaluesNoel Grandin
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b Reviewed-on: https://gerrit.libreoffice.org/28942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16sd draw text: emit LOK_CALLBACK_VIEW_LOCK from registerCallback()Miklos Vajna
This is similar to commit 7b784e4e3927d91a96cd0b54fc43c9b488822e47 (sw draw text: emit LOK_CALLBACK_VIEW_LOCK from registerCallback(), 2016-09-14), but this fix is for Impress. Change-Id: I995d2ed223aa6ce7845c440039d176b6beada84e
2016-09-16loplogin:singlevalfields in include/Noel Grandin
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc Reviewed-on: https://gerrit.libreoffice.org/28931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15sd draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback()Miklos Vajna
This is basically the Impress equivalent of commit 2ea385a54b53797ab3960869012f3ce3268eab2c (sw draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback(), 2016-09-13). Change-Id: Ib138845de6db2a8ad49dc8596af3e05ec5278610
2016-09-15disable generation of ole previews in ODF format until after loadCaolán McNamara
so the user update links dialog can control their generation SdrEmbedObjectLink becomes exposed to calc so it can detect if the link dialog needs to be used to update ole links. Change-Id: Id1dd7ea17342140eab9307d546528747e3a98090 Reviewed-on: https://gerrit.libreoffice.org/28879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-15sd: loplugin:staticmethodsMichael Stahl
Change-Id: I86dabc6e1fdd6fc9fd2fc35a6272061484af154d
2016-09-15loplugin:singlevalfields in sc..vclNoel Grandin
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
2016-09-14sd lok draw text: make sure watching views have no cursorsMiklos Vajna
These additional views are only created to follow the updates done in the editing view, not to contribute additional cursors. With this, if the first view edits a shape text and the second view is created, then no unwanted text view cursor is created in the first view for the shape text from the second view. Be precise in the unit test and make sure that cursors from all views are hidden, because even without a fix the cursor of view #2 is hidden, but not from view #3, so the test wouldn't fail without the fix. (But hardcoding the 0-1 and 2-3 view IDs exposed by Impress before/after initializeForRendering() would be ugly.) Change-Id: Idf64f7bfcc35c98a5eada9a0a523a9b45b65a211
2016-09-14loplugin:constantparamNoel Grandin
clean up the plugin a little, and try to catch params which are default constructed, which doesn't seem to be working yet Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12 Reviewed-on: https://gerrit.libreoffice.org/28861 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:dllprivateStephan Bergmann
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13Adjust controls in animation deck and make it a11y accessibleYousuf Philips
Change-Id: I0a9bbfdc88f3432a80900aeee04c2de71c1c54fb Reviewed-on: https://gerrit.libreoffice.org/28796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13chmod 644 some source filesStephan Bergmann
Change-Id: Icd8821278635c1bd27b5185cddf5dc25dfba7eb4
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12Bin a few unused forward declarationsTor Lillqvist
Change-Id: Ic10de79427d3a353451c9b603495f55459a5936d
2016-09-10loplugin:constantparam in sdNoel Grandin
Change-Id: I2bc989802c12b379a1ba4202f54ecfef1f339c8c Reviewed-on: https://gerrit.libreoffice.org/28774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-10Typo: (un)kown->(un)knownJulien Nabet
Change-Id: I7455c928293cd8d2d2ff16aa85fe02c9a54959d2 Reviewed-on: https://gerrit.libreoffice.org/28801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-09-09loplugin:constantparam in sfx2Noel Grandin
Change-Id: If5d401001abb7bf3fc642d47f537b57836e6d9c5 Reviewed-on: https://gerrit.libreoffice.org/28772 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09loplugin:constantparam in sot..svlNoel Grandin
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882 Reviewed-on: https://gerrit.libreoffice.org/28769 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09tdf#62717 FILESAVE : Names Master pages are not saved properlysll
Change-Id: If58a72fca0f9cbdeb6fc11cc36dbf13e22cdd99a Reviewed-on: https://gerrit.libreoffice.org/28750 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-08tdf#92218 Implement Impress single toolbar mode toolbarYousuf Philips
Change-Id: I38c5b6a85c63da55be1382dc4e6ad42a22d33f26 Reviewed-on: https://gerrit.libreoffice.org/28741 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-09-08Related tdf#64575 Only allow "Fill Slide" for 1 Image/SlideSamuel Mehrbrodt
Change-Id: I4887a5dd727eecacf7c80a581428f6440218bf86
2016-09-07Adjust labels in the bullets and numbering dialogYousuf Philips
Change-Id: If8892446dcabd8dc51d1193fe1fcccd64fa07bac Reviewed-on: https://gerrit.libreoffice.org/28706 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07Photo Album Dialog: Don't add caption by defaultSamuel Mehrbrodt
Change-Id: I025a42b765200cfa6ac9664c03051a9f523700a0
2016-09-07tdf#101390 Add Arrows toolbox functions on writer drawingbar.Gulsah Kose
Writer arrows toolbox includes following commands .uno:LineArrowEnd .uno:LineCircleArrow .uno:LineSquareArrow .uno:LineArrows .uno:LineArrowStart .uno:LineArrowCircle .uno:LineArrowSquare .uno:Line Change-Id: I91af27826ea411eabfa61c11962cfb85d2d2aab2 Reviewed-on: https://gerrit.libreoffice.org/28363 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2016-09-07tdf#64575 Photo Album: Better Image LayoutAbhilash
Change-Id: I021c5fa921eb80edd996e0224e69e3b3d54b76d3 Reviewed-on: https://gerrit.libreoffice.org/27654 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07loplugin:constantparam in vclNoel Grandin
Change-Id: I0cae8e5de1170dec4c82df7f1f5377143a079876 Reviewed-on: https://gerrit.libreoffice.org/28686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-05convert Orientation to scoped enumNoel Grandin
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05convert ToolBoxButtonSize to scoped enumNoel Grandin
Change-Id: I365b0e34361eb339b04e5f4792f54eff5bf582a5
2016-09-05convert GradientStyle to scoped enumNoel Grandin
Change-Id: Ib740da708612df7a5f4b8c82262b9b1bd436604d
2016-09-04coverity#1371177 default assign is good enoughCaolán McNamara
and coverity#1371311 coverity#1371240 Change-Id: I1f792b9a8e3e386633d4026d8b073ab615d243f3
2016-09-02sd lok: implement SfxViewShell::NotifyCursor() APIMiklos Vajna
The same API is already implemented in sw and sc already, the sd implementation allows selecting a shape in one view, then creating a second view, and seeing the selection of the first view in the second view, without de-selecting and re-selecting the shape in question in the first view. Change-Id: Ia36e4772584d132f1ff6a7eb07ca4cadaa384ee9 Reviewed-on: https://gerrit.libreoffice.org/28623 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-02svx: move GetSfxViewShell() to SdrMarkViewMiklos Vajna
... from SdrObjEditView. This way SdrMarkView can avoid SfxViewShell::Current() calls, and it can avoid clearing the LOK graphic selection of the old view when constructing a new view. With this, an existing graphic selection in an Impress LOK view is no longer cleared when creating a new view, thanks to the sd::View::GetSfxViewShell() override. Change-Id: I70a287aa9c2265bf59a9fb18e0c3839b8f119bbc Reviewed-on: https://gerrit.libreoffice.org/28618 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-01loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: Ifc9cdbda77048791203e89350c2efa9a6c34c4a5 Reviewed-on: https://gerrit.libreoffice.org/28555 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01std::list<sal_Int16> to vectorNoel Grandin
Change-Id: I3b8b902108d632ea992018ca023984bf1366e804
2016-09-01std::list<sal_Int16> to dequeNoel Grandin
Change-Id: I5e841fd7a9de74bba359c7e39d23d9a9b3fbc1f2
2016-09-01convert RefDevMode to scoped enumNoel Grandin
and fix the bForceZeroExtleadBug TODO Change-Id: Iac9295c6ce31112d69a870e3a229823eb1e9a4f2
2016-08-31let's make Impress crash less - SfxStyleFamily editionMichael Stahl
Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to introducing the enum SfxStyleFamily - inconsistently converted one call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily instead of a mysterious "5", but did not adapt all of the code that extracts the SfxUInt16Item that subsequently extracts this value and expects a number 0-5. Since it's clearly inexcusably stupid to have 2 different public sets of integers identifying styles, make the usage of the second "array index" integers private to templdlg.cxx; the SfxUInt16 item now always contains enum SfxStyleFamily. (regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e) Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201
2016-08-31sd: fix un-sorted SidArray in FuChar::DoExecute()Michael Stahl
Triggers an assert in SfxBindings::Invalidate(). (regression from ecc7308efa973fd1f1985ff9a0a0f01414b73f2b) Change-Id: Ida5b6c006ef6b8a839962c4f09c8341eee980270
2016-08-30tdf#56403: Text is right aligned in RTL localesKhaled Hosny
Draw/Impress is setting writing mode to RTL (which in turn sets text alignment to right) if the current locale is RTL one. This does not make sense at all since it means document prepared on a LTR locale and contains LTR text will appear right aligned on RTL locales. It would have slightly more sense if SetDefaultWritingMode() actually just set a default (for e.g. new documents), but that is not the case here as it affects all documents. This was introduced in 2c32696a04bc195c8ce61a0df6dcafb8c0c49fe0 with a branch merge and no further explanation. Change-Id: Idee0f58e153498a6676a22242d2edd5054b908c6 Reviewed-on: https://gerrit.libreoffice.org/28411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (sd)Stephan Bergmann
Change-Id: Ib044294174c665407dd2c1e8fd083e9f34733ec6
2016-08-30convert DescriptionGenerator::PropertyType to scoped enumNoel Grandin
Change-Id: Id55ccb4bf0109f1bb6f870b38792e3454b567877
2016-08-30drop extraneous acquireDavid Tardon
Change-Id: I1f26d0994f5895f8bb8ccd6c2ddce7fc1ec24ecc
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-12-28 08:05:33 +0000