summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-03-19silence coverity unchecked return value from library on xmlText* functionsCaolán McNamara
Change-Id: I651abb00d8ae1bdbf758a6a0176fd8912531a585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112753 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-19tdf#131905 PPTX table export: fix vertical alignmentTibor Nagy
Table cells lost their vertical alignment. Change-Id: Id5ca22550b5613566d7ea2a93e8a36fdca31860d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112171 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-18weld the sidebar deckCaolán McNamara
Change-Id: Idc6710df7e59bcb5f61fca783e0cc0666cb13a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-18Resolves tdf#66470 - Scaling value in statusbarHeiko Tietze
Changes also the sort order at the options Change-Id: I61c231fb94d4b4c66358a17e7585609e31eb6a70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-17throw exception for errors in uitest actionsNoel Grandin
so we abort early when a uitest goes wrong, instead of letting tests become fragile because it looks like its passing, but the code is just accidentally working Remove code in python uitests that was not actually doing anything (and now crashes because we throw an exception for actions that don't mean anything) Change-Id: I9c52f9fdc06f1c01e9b93b58a5200f9c3684db1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-16tdf#136956 reorder undo actions in removeColumnsMark Hung
and removeRows. Inside the removeColumns and removeRows, undo actions are added first, and then cell spans are updated to reflect the removed columns or rows. Once undo the cell spans they become immediately invalid because the rows or columns are already removed, hence cause Impress to crash. Change-Id: I9d8641bdad43026eca03cbeaaa3a5907b516304f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112355 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-03-16devtools: move "Development Tools" menu from "Help" to "Tools"Tomaž Vajngerl
Change-Id: I82f3315321ecb3ef2796234968ff22392be828eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112551 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-15tdf#139804 Focus form controls inside document with Alt-<Mnemonic>Samuel Mehrbrodt
Change-Id: I710a23a53ca0eb256a477a78ce1b7ae01129f717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-03-14loplugin:unusedmethodsNoel
Change-Id: I851eba4ca80eac9ee5896df53fbcd0f5ad125763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-13add PixelFormat enum that replaces bit count in Bitmap/BitmapExTomaž Vajngerl
Bit count for the image is a numeric value (sal_uInt16) but only a handful of values make sense - namely 1,4,8,24 and 32. This replaces the numeric value with an enum, which only accepts those values and checks the correct values are used at compile time. Change-Id: I0fc137c62bce3b0d021f05019a1648da628521bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112408 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-13update pchesJulien Nabet
Change-Id: Id6dfae9fb97fbe3fc89b9f2e083d7a3d5c1d36d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112411 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-12can call XWindow::setVisible instead of extracting its vcl::WindowCaolán McNamara
Change-Id: Ia3b4c95b37f5da7ae1c8e04ae1181d00d7567cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112387 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12drop PNGReader and use only PngImageReaderLuboš Luňák
PNGReader is a home-made PNG reader that does not use libpng, so it's more code, presumably less optimized and it apparently also doesn't always map colors properly. The only two features it has that PngImageReader doesn't are explicit chunk reading (used only for reading Microsoft's GIF in PNG, I implemented that for PngImageReader in a previous commit), and it loads paletted images as BitmapEx with a palette instead of converting to direct-color 24/32bpp or 8bpp-gray. The latter is even questional if nowadays that's feature or a misfeature, as it saves memory at the expense of speed. I can implement that if somebody misses it. I had to adjust some tests: - CVE-2016-0952-1.png - invalid CRC of the PNG header, neither Gimp nor Gwenview can display that, it should fail - afl-sample-Z_NEED_DICT.png - failure while decompressing data, but the loader considers that only a partially broken image since the header is correct, so it "passes" (like in Gimp or Gwenview) - SdImportTest::testTdf134210() and testPictureWithSchemeColor::Load_Verify_Reload_Verify() need the colors tested changed, because apparently gamma correction or something is now applied correctly, and it wasn't before (again checked the loaded images with Gimp) Change-Id: Id46f8d8a01256daf48ca64264b47c4e609183837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112042 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-12Fix wrong position on move when page has marginmert
Change-Id: I9ac2d9914b86210ca2148b44488c2c70cc5870d4 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111949 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111929 Tested-by: Jenkins
2021-03-11TransferableDataHelper::CreateFromSelection doesn't use its argumentCaolán McNamara
Change-Id: Id43995411d850ae051d1d803bcea2745e1dc17a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11remove intermediate containers in sidebarsCaolán McNamara
tested extension sidebars of: a) Wollmux extension sidebars b) Analog Clock Extension demo https://wiki.openoffice.org/wiki/Sidebar_for_Developers#Example:_Analog_Clock_Extension Change-Id: If9729e20526681928137989f01a8ae733a9b0cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use strong_int for item ids in vcl::ToolBoxNoel
(*) fix bug in SfxToolBoxControl::StateChanged where it was using the slot id instead of the toolbox item id (*) I left the logic in SbaTableQueryBrowser alone, but it looks suspicious, casting slot ids to toolbox ids Change-Id: Ied229164c27fb4456b0515c6fdcbd1682766a1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-11tdf#114441: Convert use of sal_uLong to better integer typesBayram Çiçek
Change-Id: Ibb432c3db6d99343514c412c4c1b968808b733c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110886 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-11register navigator individually in each module that it exists inCaolán McNamara
instead of globally. This makes the navigators the same as everything else and easier to deal with. Change-Id: I882612e73d36485b84161a2d3fbc1188f734c0fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112244 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11schedule redraw to draw without focusCaolán McNamara
Change-Id: I9a33811d0d806b686f0b226a81e53d2181f8c822 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-10tdf#140865 roundtrip pptx wordart 3D, add sp3dRegina Henschel
Change-Id: I446ae4e8c9dd5f2fbf3efe289681339f967c515a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112185 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-03-10Draw: Fix crash on multiple page selection on slidesortermert
Change-Id: Id7461b811d3445df895cf751153bd0dd81f09efc Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111864 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 505965dd5d05e4711bf5b433b8af06e88e030962) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111917 Tested-by: Jenkins
2021-03-09fetch/set/clear primary selection without intermediate vcl::WindowCaolán McNamara
the intermediate layer doesn't do anything useful Change-Id: I00564f43db8914445ea4013c6f387c7d7c783427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09filter: svg: unit test for placeholder localeMarco Cecchetti
We set the language to it-IT and check that the exported placeholder text is still <number> instead of <numero> Change-Id: I7ec7e25e53075da38cb87d81e9f8268b37121bfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111115 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111847 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2021-03-09filter: svg: export: renaming class attributes related to TextShapeMarco Cecchetti
TextShape => SVGTextShape com.sun.star.drawing.TextShape => TextShape Change-Id: I4bbb465e0f65aa328527ac3022c0b68546fb5db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111224 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111846 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2021-03-09filter: svg: export tiled background by exploiting svg:pattern elementMarco Cecchetti
By exporting a tiled bitmap background by exploiting the <pattern> element we get performance improvement when the background is made of a big number of tiles. The unit test for the tiled background case has been updated. Change-Id: I80a4eebd081d2c59ec7d9906fc9c616692f7e0fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110319 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111844 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2021-03-09add some Timer debug namesLuboš Luňák
Change-Id: I7a0037ffd7d45ab18efa76dce805274090527525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112182 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-09drop sd::LayoutMenu set_id overwriteCaolán McNamara
this was added with commit d2b5ab3498a78c6d164a15b3bf2b947553ea2743 Date: Sun Oct 20 09:50:48 2019 -0400 sd: sidebar: force to set the id of the LayoutMenu control Otherwise, the function std::unique_ptr<UIObject> WindowUIObject::get_child(const OUString& rID) will not find the control with the rID. Change-Id: Ie571eb351bb0c59654f577cef1961247273d7608 Reviewed-on: https://gerrit.libreoffice.org/81345 but there doesn't appear to be a current use of 'sd::LayoutMenu' in LibreOffice or Online Change-Id: I07ebd872f0dd203057c96386730acd5f6aa7a168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09defer getting toplevel for color picker until we need itCaolán McNamara
Change-Id: I60f4ded47f7d80b397647ea3344e83a5dfd1b11e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09fontwork: insert in the center of LOK viewSzymon Kłos
Change-Id: Iabde4ee927546b0e396c4fbd6d0099fa82240166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109968 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112163 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-09Make sal/config.h the first in pchMike Kaganski
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09tdf#139944 Disable navigator in impress and draw master modeJim Raykowski
Change-Id: I48ed310f7903502085da2469f546d371960935f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111986 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-08move GetDPIScaleFactor check to ValueSet canvasCaolán McNamara
Change-Id: I586b3d1167300d914da18af7f32dd8e434bb49c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-08filter: svg: js engine: unit test: slide background: exporting bitmapsMarco Cecchetti
Two unit tests: 1 - a slide background with a single bitmap 2 - a slide background with bitmap tiles Change-Id: Iffdb9ea958ba07391dfbdcfd6e925a9461e2af84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109932 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111843 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-03-08tdf#140796: Wrong English string for U+2060 characterJulien Nabet
Rename "No-width No ~Break" to "Word ~Joiner" + replace pattern "ZWNBSP" variable names by "WJ" Change-Id: I95a874a9d2d20a30d2c4c3add6041adbe72d872c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-08clean up some more dynamic/static castingNoel
using a hacked version of the staticdynamic plugin and some judgement Change-Id: I5e6668b19320025e419f84bebceade4239577729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-08loplugin:refcounting check for one more caseNoel
where we might be holding something newly created by pointer instead of by *::Reference Change-Id: Ife6f7acae4252bf56dcdeb95d72e43c523444f97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-07ref-count SdrPageNoel
which simplifies ownership handling, particularly with regard to undo/redo Change-Id: Ie8f300ebfdae6db3c06f78a87e35a07497d6b825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06update pchesJulien Nabet
I just used ./bin/update_pch.sh Change-Id: I06a7f36eb4c511b8d6c6477fd87e57f0d9702457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-06loplugin:staticdynamic look for static after dynamicNoel
Change-Id: Ic3066d9a9441e369370cc6aa0fbffb9a321bc928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111985 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06drop check for visibility before calling updateMotionPathTagsCaolán McNamara
presumably this is effectively always the case Change-Id: I05ac9075ea340f800cdb9b8fda6e01c8ba1fa186 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112034 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move MouseButtonDown logic to LayoutValueSet childCaolán McNamara
Change-Id: I8d70321856219988618d99ba5884b89950441b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112012 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move valueset resize into LayoutValueSet classCaolán McNamara
Change-Id: If1a5dbcdac95a167779b30c26f4aa61bbe104cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05with widget layout we don't need to explicitly track the parent resizeCaolán McNamara
Change-Id: I17e153ecc8b1b79bbbfbbccfe88a46f5905611fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112010 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05drop unneeded DEBUG SetTextCaolán McNamara
Change-Id: I3844494d87992d1a23fee78aaa3b3912cb9fc5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move handler for ESC to close slideshow from navigator down to contentsCaolán McNamara
Change-Id: Ie021bcf86043cf2ae02eb39911c748135452853c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05parent panel doesn't need an explicit KeyInput handlerCaolán McNamara
the treeview child one is sufficient Change-Id: I3a5e7a262055e5f03cf5323eeaa8c169eaab2693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05updateMotionPathTags is already called from the ctorCaolán McNamara
#3 0x00007fffd0fe1939 in sd::CustomAnimationList::Select() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:981 #4 0x00007fffd0fe4f62 in sd::CustomAnimationList::update() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:864 #5 0x00007fffd0fe353b in sd::CustomAnimationList::update() (this=0x3622310) at sd/source/ui/animations/CustomAnimationList.cxx:639 #6 0x00007fffd0ff5f4b in sd::CustomAnimationPane::onChangeCurrentPage() (this=0x391e9c0) at sd/source/ui/animations/CustomAnimationPane.cxx:1664 #7 0x00007fffd0ff4321 in sd::CustomAnimationPane::initialize() (this=0x391e9c0) at sd/source/ui/animations/CustomAnimationPane.cxx:208 #8 0x00007fffd0ff527b in sd::CustomAnimationPane::CustomAnimationPane(vcl::Window*, sd::ViewShellBase&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (this=0x391e9c0, pParent=0x391a3e0, rBase=..., rxFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x166a030) at sd/source/ui/animations/CustomAnimationPane.cxx:156 so don't recall it on StateChangedType::Visible StateChange Change-Id: I311d97ad69b295669e7c31e18f669ae6b123b7d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05move properties from container vcl::Window to window-filling childCaolán McNamara
Change-Id: I5ddd17220ff8b45678716c406297d305aa2229e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05don't use the vcl::Window parent to derive a treeview sizeCaolán McNamara
Change-Id: Ic366a90fbdcd735d377c8a00766cdfa0add31c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111998 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-04 09:16:33 +0000