summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-04-09Recheck include/ with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-09remove need for an intermediate vcl::WindowCaolán McNamara
Change-Id: I59f24888e47ec17e46bf651d8530fc9468f16f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-08update PCHsLuboš Luňák
Change-Id: Ia9d04447f927e270a55500e7f35723a729bc01dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113801 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-08impress: avoid crash when user edits text and other deletes slideSzymon Kłos
We need to end text edit when page is deleted by other user. Change-Id: I89824c91f5652421a443feb9412acbae65db8800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112917 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113784 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-08lok: remove event listener when disposingHenry Castro
In order to prevent that the event listener holds the object reference count when removed, ensure they are removed when disposing the object. Change-Id: I7cb4cb7d87acfc9610c2498760ade531456fe22e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113493 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-08impress: delete correct page when has multiple usersSzymon Kłos
When multiple users are editing the presentation few pages could be selected. Then the first selected page was removed instead of currently selected by user who executed the delete action. SlideSorterViewShell has better knowledge about selected slides by current view. Change-Id: Icb3157c8426027a7edc225249f8dd99270e9b2da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112883 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113728 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-08tdf#141511 fix null pointer use crashJim Raykowski
Change-Id: I196216d10829df99629e4e97aad7db622c3378e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113779 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07tdf#141297: sd: Add UItestXisco Fauli
Change-Id: I0e0a7869b77719d5080e6f4df83159251bed2f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113708 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07tdf#141267 PPTX export: fix handling of audio nodes with non-media sourceMiklos Vajna
Regression from commit cf5fa358a6bf6e7c0aae2dca1e8fa3334d95ebdb (PPTX export: fix missing audio anim node for slide narrations, 2021-01-25), the problem was that the audio source can be any kind of shape, not only a media shape. Fix the problem by explicitly checking of the shape has a media URL. Change-Id: I2bdde0f9ed3576f307aabff5e39d441f295c203f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113715 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-07rtl::Static -> function local staticNoel Grandin
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06ExecuteSpellPopup never called with a null spelling callbackCaolán McNamara
Change-Id: Id03001541ccfd8503a7b8181598bad9811542b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06update pchesCaolán McNamara
Change-Id: I835c8fcc237ece5cf9d7a3b261645139d022e9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06forward declare vcl::window in vcl/event.hxxCaolán McNamara
Change-Id: Ib3fc1b72d3d45377e2d4ccd0ff3e6835d2c29930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-05VCL drop Scheduler::ProcessTaskSchedulingJan-Marek Glogowski
Just process tasks (and system events) via DoYield and actually wake up the system timer on OSX. This drops the testFocus unit test. There is some comment about it in README.lifecycle, but the test's CPPUNIT_ASSERT was already commented and mmeeks suggested to simply drop it. Even worse: just replacing - Scheduler::ProcessTaskScheduling(); + Scheduler::ProcessEventsToIdle(); results in a SIGSEGV in my local Linux build, which is a totally unrelated crash. Change-Id: Ie3e2a8668b8501f081706dde0ba3684801c30cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112761 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-03-31LOK: getPartInfo now returns master page countPranam Lashkari
master page count will be used when switching to master view to know how many slide previews to be shown Change-Id: I11735797d16538a9f667a85b90a86b1e6cf9b5aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113358 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-03-31sd: clean up not needed HAVE_FEATURE_PDFIUM ifdefsMiklos Vajna
Towards completely avoiding the HAVE_FEATURE_PDFIUM ifdef forest. Change-Id: I490c64a724729086d6156dc815f89d4e0d1ec709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113390 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-29tdf#125560 PPTX import: fix WordArt effect textDeflate and textInflateTopGabor Kelemen
These effects were mapped incorrectly, resulting missing display and after ODP round-trip, changed effects. Code pointers and test documents by Regina Henschel. Change-Id: I8a05702b1c48492b9542dd827b1ac1daf2423bfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112786 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-29tdf#137367 PPTX import: fix lost direct hyperlink colorsTibor Nagy
Regression from commit 92f74f6ccb5a55807724db85815f7ea0c49370e0 (bnc#887230: always use theme color for hyperlinks in Impress) Testing: direct color of the first text line is theme based (a:rPr/a:solidFill/a:schemeClr), the second line contains a direct color (a:rPr/a:solidFill/a:srgbClr), the third one contains a theme based direct color darkened by 25.000% (val=75000 of a:rPr/a:solidFill/a:schemeClr/a:lumMod). Note: overwriting default theme based hyperlink colors is also supported by Google Docs, Office 365 and MS Office 2019. Change-Id: I1e3e78fac729a97f42c8dddcffd877a16383adbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112377 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-29Fix duplicate object IDStephan Bergmann
...introduced with 1bad47097694de957857c9c891bf79a4873a97c4 "tdf#67614 - Added the FHD image resolution", causing CppunitTest_sd_dialogs_test to SIGABRT with > warn:vcl.gtk:800970:800970:vcl/unx/gtk3/gtk3gtkinst.cxx:17012: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: instdir/share/config/soffice.cfg/modules/simpress/ui/publishingdialog.ui:1197:1 Duplicate object ID 'resolution3Radiobutton-atkobject' (previously on line 1174) > cppunittester: vcl/unx/gtk3/gtk3gtkinst.cxx:17015: (anonymous namespace)::GtkInstanceBuilder::GtkInstanceBuilder(GtkWidget *, std::u16string_view, const rtl::OUString &, SystemChildWindow *, bool): Assertion `rc && "could not load UI file"' failed. Change-Id: I7bee0b5f2a675ffe27c9920f6a31d6f906abb90f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113298 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-03-29tdf#131269: sd_import: Add unittestXisco Fauli
Change-Id: I81ced436c4b4484ec58af35a559412ea1f97aaf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113294 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-28cid#1474092 Untrusted loop boundCaolán McNamara
Change-Id: I0a068e98a1d8d8523f188310025808143a5dbcf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-28drop operator bool and operator! from Bitmap and BitmapExNoel
IRC chat: <quikee[m]> noelgrandin: doesn't adding operator bool to Bitmap has the same problem as Graphic and the reason why you dropped that commit 7334034ae93b49fc93b5859a3c047a319d138282 "drop Graphic::operator bool" <noelgrandin> quikee[m], hmmm, good point <noelgrandin> maybe I should just drop both operator bool and operator! in favor of IsEmpty <quikee[m]> noelgrandin: I don't remember what the problem is I just remembered we dropped it Graphic :) sure, dropping everything for IsEmpty is probably the best Change-Id: Ieae289cda64f0b8d8fdecd5ea9e6f2bb874ff4cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113163 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-26loplugin:flattenNoel
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-26create operator bool for BitmapNoel
so we can use a more natural syntax than "!!" Change-Id: I8152a0d3ce37115fc83d332a26725ca1d28d959a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113147 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-25tdf#67614 - Added the FHD image resolutionAndreas Heinisch
Added the possibility to chose full hd image resolution when exporting slides via html. Change-Id: I38c721c98093fbd21d9761708edf68e26d0c97ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-25loplugin:unusedvarsglobalNoel
Change-Id: Ie73c8bec0196c680311b0959f3a17c3af900ce88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-25tdf#134734 sd,sw: add UITestsMichael Stahl
Change-Id: I674066b1c998f35e1d21a575669a131721e41113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113004 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-25tdf#134734 svx,sd: BackgroundFullSizeMichael Stahl
There is already a boolean SdPage::mbBackgroundFullSize, UNO property and ODF import/export, but curiously no trace of it ever doing anything. There is some mystery handling of SID_ATTR_PAGE_EXT2 there but in the dialog that is only handled for SVX_PAGE_MODE_CENTER from Calc for a completely different purpose. Move mbBackgroundFullSize to base class SdrPage so that ViewContactOfMasterPageDescriptor can access it to paint. There's an oddity in the handling of the property where the dialog works on the master page and not on the current slide, not sure why it was implemented this way. Change-Id: If6e1329e3f77e0a1a7226d5e51ceb221ea86c401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112783 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-25const OUString -> const OUStringLiteralMike Kaganski
Mostly automated rewrite Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-24Related: tdf#135363 don't keep a reference to the vcl::WindowCaolán McNamara
in fact, why keep a VclPtr reference to that window at all Change-Id: I3f0511b41434cba744a63d4a9e185c97a6cef5e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112992 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-24Resolves: tdf#135364 ensure the window is released by a11y disposeCaolán McNamara
the window dtor wasn't called with a11y enabled, with the side effect that the pen color wasn't stored by the dtor Change-Id: I5f482f53d4d93f1e2632cacf7c0a7407f0df1450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-24sd_import_tests: simplify testXisco Fauli
Change-Id: Idf1bae6bfb8a41d2bea65c4e1848368d2a2abd14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112984 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-24tdf#124176 Use pragma once in sdVincent LE GARREC
Change-Id: Ic439140d9ecdcdee9272185bd3c2d11e11288f07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112051 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-23Revert "lok: switch to the correct view before any UI update is doneTamás Zolnai
via SfxBindings." This reverts commit 35b81a05c7c58d0db2276627a9387a738c409974. Change-Id: I29adf767d2bf3fa0f19b13f8eae3d2464cd90601 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112997 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-03-23Revert "Remove this unreliable check."Tamás Zolnai
This reverts commit cb0dfff9a49530f348223e1df54762a3da61aa51. Change-Id: I10434f0cab65825532b2adff9a0961067d3dba7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112996 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-03-23tdf#140714 Import graphics cropped into custom geometry as custom shapes.Gülşah Köse
Change-Id: I2054d24ce41c9f0d6cc1675f461274067c3b2898 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112943 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-03-22Remove this unreliable check.Tamás Zolnai
This check was added to an existing test, instead of adding a new test focusing this functionality. In this context, this lock thing is not really reliable. Change-Id: Iad64edba277e714fa7f6b68fdfa8db0bf74851a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112892 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112893 Tested-by: Jenkins
2021-03-22lok: switch to the correct view before any UI update is done via SfxBindings.Tamás Zolnai
Change-Id: I541e53b4219340233ed5a4bec407ded5adf6a841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112538 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112730 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-03-22failure seen in UITest backtraceCaolán McNamara
Thread 1 (Thread 0x2ba41b2ef700 (LWP 27523)): #0 0x00002ba4249a0464 in SdTransferable::ObjectReleased() (this=0x2501da0) at sd/source/ui/app/sdxfer.cxx:650 #1 0x00002ba4249a00db in SdTransferable::~SdTransferable() (this=0x2501da0) at sd/source/ui/app/sdxfer.cxx:113 g = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x14c1ee0}, <No data fields>} #2 0x00002ba4249f1d36 in SdPageObjsTLV::SdPageObjsTransferable::~SdPageObjsTransferable() (this=0x2501da0) at sd/source/ui/dlg/sdtreelb.cxx:79 #3 0x00002ba4249f1d79 in SdPageObjsTLV::SdPageObjsTransferable::~SdPageObjsTransferable() (this=0x2501da0) at sd/source/ui/dlg/sdtreelb.cxx:78 #4 0x00002ba40446ccc3 in cppu::OWeakObject::release() (this=0x2501da0) at cppuhelper/source/weak.cxx:242 #5 0x00002ba4249a6015 in cppu::WeakImplHelper<com::sun::star::datatransfer::XTransferable2, com::sun::star::datatransfer::clipboard::XClipboardOwner, com::sun::star::datatransfer::dnd::XDragSourceListener, com::sun::star::lang::XUnoTunnel>::release() (this=0x2501da0) at include/cppuhelper/implbase.hxx:115 #6 0x00002ba40a291791 in rtl::Reference<TransferDataContainer>::~Reference() (this=0x2ea9780) at include/rtl/ref.hxx:129 ... #21 0x00002ba40af10699 in UIObjectUnoObj::~UIObjectUnoObj() (this=0x2501680) at vcl/source/uitest/uno/uiobject_uno.cxx:27 Change-Id: Idcd388cbe1ec78ff36f14fd39f9eb5134da873e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112881 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-22tdf#124176 Use pragma oncepekka-dev
Change-Id: I8ab895a7b8e430d13e4db39a270af8d20949815c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112826 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-03-22change SfxApplication::GetTopWindow to weld::WindowCaolán McNamara
Change-Id: I19906f2a9d820c99375e2e5677a484d4e2e25fdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112857 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21cid#1473853 Unchecked return valueCaolán McNamara
Change-Id: I869e42e1c1651c9c435449a295e41a5f8889f4dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21cid#1473798 silence Unchecked return value from libraryCaolán McNamara
Change-Id: I00174b5444749f3345f5691e24eb5219d1b47059 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21update pchesCaolán McNamara
Change-Id: I60e61133c305673bb305e41957f5414820c7c358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-20cid#1474258 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic28d5cc86d77320a8e18dbc6cc2275687c26a1d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112778 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-20cid#1459022 Uninitialized pointer fieldCaolán McNamara
Change-Id: I0828d25eac66928acd6dfd7d09989cabf7bf573b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112775 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-19cid#1474113 Out-of-bounds readCaolán McNamara
order of Precedence is % before - Change-Id: Ief011bb145be8246451ae3785bff7325ae28c222 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112759 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>